yahalimu 41 Posted December 26, 2019 Yep that fixed it Jack. Thanks. I remember changing to mysqli from mysql many years ago to get bit to work on PHP5, I assumed that would be OK for PHP7 but I take it 7 is more fussy. The last error I am getting is: 'PHP Warning: count(): Parameter must be an array or an object that implements Countable.' This is on the following code. (top line) and also on a similar bit of codebelow using (count($statsArray['qty']) > 0) { if (count($statsArray['price']) > 0) { $warning = true; echo '<p style="margin:auto; text-align:left; padding:10px; 0px">'; printf( "***Warning:*** There are %d products with a price of $0.<br>", $statsArray['price'] ); for ($i = 0; $i < count($statsArrayPrice); ++$i) { echo ' ' . $i . ' - ' . $statsArrayPrice[$i] .'<br>'; } echo '</p>'; } I changed $statsArray['price'] to $statsArrayPrice and it seems to work OK and report all zero quantity items and not error out. I hope this is correct. Otherwise all the code can be ported to Phoenix with minimal changes. Only had to hard code includes directory etc.. Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted December 27, 2019 (edited) @yahalimuThe following changes should be made. Please try it and let me know if there are any other issues. Find if (count($statsArray['price']) > 0) { and replace it with if (is_array($statsArray['price']) && count($statsArray['price']) > 0) { Find if (count($statsArray['qty']) > 0) { and replace it with if (is_array($statsArray['qty']) && count($statsArray['qty']) > 0) { edited: corrected typo for first change. Edited December 27, 2019 by Jack_mcs Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
yahalimu 41 Posted December 27, 2019 Hi Jack, That latest code adjustment did not error but also did not list zero quantitiy or zero price products in my installation. Iain Share this post Link to post Share on other sites
yahalimu 41 Posted December 27, 2019 Using $statsArrayPrice did seem to work ok though. Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted December 27, 2019 From my previous post, the lines should be changed to if ($statsArray['price'] > 0) { and if ($statsArray['qty'] > 0) { There will be warning notices if error reporting is enabled. I will upload a new version soon that should fix all of the known issues. Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
Peper 13 Posted February 5, 2020 Google warnings not going away Error is Mismatched [price] (page crawl) This comes in pricing showing excl Tax on site, the googlefeeder.txt is calculated including Tax Google bot is crawling site excluding Tax Google reports Mismatched [price] Web is setup to show pricing excluding tax in admin with tax rates 0% and 15% What needs to be done? Getting the Phoenix off the ground Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted February 5, 2020 Regarding the warnings, I will try to get an updated version uploaded soon. Regarding the tax, I have clients that have shops that use tax and others that don't. But they are using the later version, which has not been released, so that might be the reason. 1 Peper reacted to this Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted February 7, 2020 A new version has been uploaded with these changes: Added gtin as an identifier. Added code for Phoenix compatibility. Installation just requires the files to be uploaded for Phoenix. Changed count code to pass php 7.3. Found by member @yahalimu. Changed default http to https in the googlefeeder file. Removed the code to check if mysql is being used. Mysqli is now required. 3 2 valquiria23, Peper, zeeshop and 2 others reacted to this Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
valquiria23 234 Posted February 7, 2020 Thank you very much Jack @Jack_mcsfor supporting oscommerce !! Community Oscommerce fan You'll find the latest osC community version here. Share this post Link to post Share on other sites
zeeshop 5 Posted January 7 @Jack_mcs, I am looking to install module which can comply with Google Merchant Centre (GMC) Requirement for Google Free Products Listings. I noticed from your comments in another forum that this may be the best module to achieve this or is there any other? Please advise if This module can work with GMC and if it is compatible to work with Phoenix 1.07.12. It seems like Google can fetch feeds automatically and there is no mention of Google FTP User name/ password as required in googlefeeder.php I tried installing it for testing and received following errors: No warning comes if I stop errors reporting in admin/config.php. Notice: Undefined variable: currentVersion in /homepages/31/dxxxxxxxxx/htdocs/xxxxxxxxx/admin/feeders.php on line 52 Any suggestion pls.Thanks Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted January 8 @zeeshopYes, it works with google. I don't know if it will work with the latest Phoenix version but I think it should. The error is because you didn't upload the Version Checker files (see the installation instructions). Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
zeeshop 5 Posted January 8 Thanks, I uploaded the feed on GMC but feed was rejected due to following reason: GMC requires price in this format: I changed the lines as advised in 2019 post on 17/07/19 shown below, but it is showing currency as USD in feed file, but my store default currency is GBP, is there any way to change currency to GBP. Since GMC requires the price field to have the curency specified (i.e. '19.99 USD'), near line 465 I replaced $row->price . "\t" . with $row->price . ' ' . OPTIONS_CURRENCY . "\t" . Thanks Share this post Link to post Share on other sites
Jack_mcs 1,022 Posted January 9 5 hours ago, zeeshop said: currency as USD in feed file, but my store default currency is GBP, Please try changing the currency setting in the googlefeeder.php file. 1 zeeshop reacted to this Support Links: Need Help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC version (the community-supported responsive version) here. How to Upgrade to the latest version Recommended SEO Addons Share this post Link to post Share on other sites
zeeshop 5 Posted January 9 Thanks, I had to change line 20 & line 63 references from USD to GBP, all working fine now. Share this post Link to post Share on other sites