Jump to content
Sign in to follow this  
adrian##

fixes to PhpBB contribution

Recommended Posts

HI All,

 

I appreciate this contribution isn't really supported much anymore but i have a couple of questions....

 

Firstly, i have downloaded the updated files (only the changed files for phpbb 2.019) has anyone implemented this upgrade over the mod files successfully?

 

I'm concerned about the hacking issues raised by earlier versions, so would like to upgrade if possible?

 

Secondly, the contribution seems to be working fine now, however, the links in my breadcrumb navigation are the same colour as the link colour defined in the phpbb stylesheet not the oscommerce stylesheet. Is there a fix for this, as it will not fit in with the colour scheme of my site to have all the links the same colour?

 

Best Regards

 

Donna

Share this post


Link to post
Share on other sites

I have read all 9 pages of this thread and various other threads. None of the old links work any more and it is really too bad no one has pulled together all the needed changes in one place. As my forum is private, I don't mind it being an old version, but it would be nice to get it working.

 

I found this in another thread which nicely describes the problem I am seeing. I also saw the multiple scalar value errors on some 2003 posts in this thread but no answers ...

 

it was giving me multiple $template errors nonstop along the lines of:

Warning: Cannot use a scalar value as an array in .....

 

I did a little research and learned that was because both STS and PHPBB use $template as a variable.

I changed all the PHPBB contribution files from "$template" to "$template_" and BINGO! all the errors went away and the Admin side of the forums works like a charm.

However when I try to view the forums:

http://www.sitename.com/modules.php?op=mod...&file=index.php

 

All I see is the header and footer. No side menus. No forum. No other content.

 

Has anyone solved this?

 

Kitty

Open Sky Web Design

Share this post


Link to post
Share on other sites

Kittycooper,

 

Look through the catalog\includes and the 7 sts_.php files and replace the $template with something like $template2.

 

For example the coding will look like $template2['templatedir'] instead of $template['templatedir']. I have not had any adverse effects from osCommerce and STS doing this.

 

Warning: This is a beast of a Contrib to try and get working. The given instructions and files are just a start.

Share this post


Link to post
Share on other sites

I've followed all the patch/fix metioned (including the Javascript addition, comment out the cookie, and fixed tep_zone thingee ... and still have the following warnings:

 

 

When I click on the View Newest Post arrow (stops there):

Warning: Cannot modify header information - headers already sent by (output started at ..../catalog/modules.php:28) in 
..../catalog/includes/modules/phpbb2/includes/functions.php on line 768

 

After Send Reply, but msg got posted successfully:

..../catalog/modules.php:28) in 
..../catalog/includes/modules/phpbb2/posting.php on line 601

Share this post


Link to post
Share on other sites
I've followed all the patch/fix metioned (including the Javascript addition, comment out the cookie, and fixed tep_zone thingee ... and still have the following warnings:

When I click on the View Newest Post arrow (stops there):

Warning: Cannot modify header information - headers already sent by (output started at ..../catalog/modules.php:28) in 
..../catalog/includes/modules/phpbb2/includes/functions.php on line 768

 

After Send Reply, but msg got posted successfully:

..../catalog/modules.php:28) in 
..../catalog/includes/modules/phpbb2/posting.php on line 601

 

Hi there, I'm having the same problem...i have been told that the problem is most likely caused by the 'echo' being premature to the setcookie on line 28 of modules.php. I am looking into this now and will let you now how and when i resolve it.

 

Regards

 

Donna

Share this post


Link to post
Share on other sites

hi there all

thkx for the solution..i was goin all over to search for an intergrated e-commerce withfourm

 

but its too complicated, the contrib..

is there any way i can get the whole pre-moded files..as in osc+phpbb mod 2getah..n just install it??

 

sorry , n thkx in advance

Share this post


Link to post
Share on other sites

Hi All,

 

I've been trying to implement this for a long time now, and i'm finding that the file modules.php is causing lots of problems, mainly the:

 

Warning: Cannot modify header information - headers already sent by (output started at /home/dtotrans/public_html/ladyloving/modules.php:28) in /home/dtotrans/public_html/ladyloving/includes/functions/general.php on line 33

 

Now i'm not a coder personally, but people have been trying to help me fix this (and this isnt a problem due to white spaces at the top and bottom), its concerned with some output being sent prior to the headers or something, and quite frankly i just can't fix this on my own. If any one out there has got a fully working forum can they please let me have a copy of modules.php or make the changes to the version supplied with the contribution below?

 

<?php
/*
 $Id: privacy.php,v 1.19 2002/07/21 23:38:57 hpdl Exp $

 osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2002 osCommerceReleased under the GNU General Public License

 Integrate PHPBB206 INTO OSC 2.2 oscphpbb2 Copyright (c) 2003/09/10  
 version:		1.0	
 author:		Oldpa
 web site: http://oscphpbb2.ecart.com.tw http://oldpa.adsldns.org  http://www.oldpa.com.tw  */		

 require('includes/application_top.php');
 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_BB_INDEX);

 $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_BBMODULES, 'op=modload&name=phpbb2&file=index.php', 'NONSSL'));

switch($op){

case"modload":

if (( $mode != 'smilies' ) & ( $mode != 'topicreview' ) & ( $mode != 'searchuser' )) {
define('SHOW_HEAD_FOOT', true);
?>
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">
<title><?php echo TITLE; ?></title>
<base href="<?php echo (getenv('HTTPS') == 'on' ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">
<link rel="stylesheet" type="text/css" href="stylesheet.css">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
<!-- header //-->
<?php require(DIR_WS_INCLUDES . 'header.php'); ?>
<!-- header_eof //-->

<!-- body //-->
<table border="0" width="100%" cellspacing="3" cellpadding="3">
 <tr>
<? /*
<td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- left_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>
<!-- left_navigation_eof //-->
</table></td>
*/ ?>
<!-- body_text //-->
<td width="100%" valign="top"><table border="0" width="100%" cellspacing="0" cellpadding="0">
  <tr>
	<td><table border="0" width="100%" cellspacing="3" cellpadding="3">
	 <tr>
<?php
}
  include(DIR_WS_MODULES."$name/$file"); 

//Footer data em page_tail

  break; 

default:
die("Sorry file does't exist.");
break;
exit;
}
?>

 

I would be most appreciative for the help, as this is has been driving me crazy for almost a week?

 

Best Regards

 

Donna

Share this post


Link to post
Share on other sites

Donna -

As I recall the problem is actually with the file \includes\modules\phpbb2\templates\subSilver\overall_header.tpl

 

it repeats the html and body tags already in modules.php which confuses everything. I had to pull all the CSS code out and put it into a separate css file called by modules.php then remove the head and body tags so the new overall_header.tpl code is like this:

 

<!-- BEGIN switch_enable_pm_popup -->
<script language="Javascript" type="text/javascript">
<!--
if ( {PRIVATE_MESSAGE_NEW_FLAG} )
{
	window.open('{U_PRIVATEMSGS_POPUP}', '_phpbbprivmsg', 'HEIGHT=225,resizable=yes,WIDTH=400');;
}
//-->
</script>
<!-- END switch_enable_pm_popup -->


<a name="top"></a>

<table width="100%" cellspacing="0" cellpadding="10" border="0" align="center"> 
<tr> 
	<td class="bodyline"><table width="100%" cellspacing="0" cellpadding="0" border="0">
		<tr> 
			<td>   </td>
			<td align="center" width="100%" valign="middle"><span class="maintitle">{SITENAME}</span><br /><span class="gen">{SITE_DESCRIPTION}<br />  </span> 
			<table cellspacing="0" cellpadding="2" border="0">
				<tr> 
					<td align="center" valign="top" nowrap="nowrap"><span class="mainmenu"> <a href="{U_FAQ}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_faq.gif" width="12" height="13" border="0" alt="{L_FAQ}" hspace="3" />{L_FAQ}</a></span><span class="mainmenu">   <a href="{U_SEARCH}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_search.gif" width="12" height="13" border="0" alt="{L_SEARCH}" hspace="3" />{L_SEARCH}</a>   <a href="{U_MEMBERLIST}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_members.gif" width="12" height="13" border="0" alt="{L_MEMBERLIST}" hspace="3" />{L_MEMBERLIST}</a>   <a href="{U_GROUP_CP}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_groups.gif" width="12" height="13" border="0" alt="{L_USERGROUPS}" hspace="3" />{L_USERGROUPS}</a>  
					<!-- BEGIN switch_user_logged_out -->
					 <a href="{U_REGISTER}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_register.gif" width="12" height="13" border="0" alt="{L_REGISTER}" hspace="3" />{L_REGISTER}</a></span> 
					<!-- END switch_user_logged_out -->
					</td>
				</tr>
				<tr>
					<td height="25" align="center" valign="top" nowrap="nowrap"><span class="mainmenu"> <a href="{U_PROFILE}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_profile.gif" width="12" height="13" border="0" alt="{L_PROFILE}" hspace="3" />{L_PROFILE}</a>   <a href="{U_PRIVATEMSGS}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_message.gif" width="12" height="13" border="0" alt="{PRIVATE_MESSAGE_INFO}" hspace="3" />{PRIVATE_MESSAGE_INFO}</a>   <a href="{U_LOGIN_LOGOUT}" class="mainmenu"><img src="templates/subSilver/images/icon_mini_login.gif" width="12" height="13" border="0" alt="{L_LOGIN_LOGOUT}" hspace="3" />{L_LOGIN_LOGOUT}</a> </span></td>
				</tr>
			</table></td>
		</tr>
	</table>

	<br />

 

As I recently got this all working I will try and post my working version as an addition to this contrib over the weekend. Mind you most of my problems came from the need to accomodate the STS template contrib as well, so may not be of use to all.

 

Kitty

OpenSkyWebDesign.com

Share this post


Link to post
Share on other sites

One more thing I had to do was remove the cookie usage from the following modules (since output has already started ...) :

 

\includes\modules\phpbb2\templates\subSilver\

 

index.php

posting.php

viewforum.php

 

I have created 2 new versions of the contrib (one with STS and one without) - anyone who wants to try them please do and contact me directly with any problems. I would like contribute these once they are OK. These are not exactly what my client has, although close, so I cannot test them myself.

 

Warning - this contrib uses an old version of PHPBB which is not fully secure from hackers - someone needs to take the latest port of PHPBB2 in PHPnuke and redo this contrib, however if you want to use this anyway, here is my complete fixed version of this contrib 2116.

 

Contrib 2116 redone

 

Kitty

OpenSkyWebDesign

Share this post


Link to post
Share on other sites
hi there all

thkx for the solution..i was goin all over to search for an intergrated e-commerce withfourm

 

but its too complicated, the contrib..

is there any way i can get the whole pre-moded files..as in osc+phpbb mod 2getah..n just install it??

 

sorry , n thkx in advance

 

Agreed. My brain is spinning after reading less than half of this thread. :wacko:

 

Guess I'm not ready for integration yet.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×