Jump to content
Golden Boy

RMA Returns error for 2.2 MS2

Recommended Posts

Hi northessex,

 

I've changed the code for the returns_track.php, and then tried the form...

 

Error 404 - Not Found page with this address in the browser address bar:

 

https://www.mydomain.com/catalog/returns_tr...p&error=yes

 

As someone stated before, this is an important mod, but if it doesn't work it's worthless to us. I cannot let this mod hold my site back from opening sometime this year :blink: , so I'm really close to uninstalling this mod! :(

 

Thanks!


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

Hello Mark

 

I've been messing around with this mod for some time now, and I have to thank you for the changes to returns track - I tried something similar to your changes and kept getting errors, but it's now working! So big thanks!

 

However, there are still several issues. The most important is in admin. When looking under returned products, the status shows as the return reason! What I mean is that rather than telling you the status of the return (i.e. pending, completed or rejected) it tells you the return reason (i.e. faulty, warranty etc)! This is clearly wrong! I have changed this so it calls the status... but it is not giving the correct status (i.e. instead of complleted, it shows rejected!)

 

Any ideas? Also should the status (i.e. accepted rejected etc) not show on the customer side so they know what is happening with the return?

 

GD - did you change "post" to "get" ? If not try that!

 

Regards,

 

Jiten

Share this post


Link to post
Share on other sites

Hi Unified,

 

GD - did you change "post" to "get" ? If not try that!

 

Yes I did, but no go. :(

 

If you have your returns_track.php working, can you post the full source code here, so I can do a diff between yours' and my own, maybe then I could get that part of the mod to work. :rolleyes:

 

Thanks!


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

Hello Greg

 

Sorry been away a couple of days... but here's my returns_track.php:

 

<?php
/*
$id author Puddled Internet - http://www.puddled.co.uk
 email support@puddled.co.uk
  osCommerce, Open Source E-Commerce Solutions
 http://www.oscommerce.com

 Copyright (c) 2002 osCommerce

 Released under the GNU General Public License
*/

 require('includes/application_top.php');

/*  
 if (!tep_session_is_registered('customer_id')) {
   $navigation->set_snapshot();
   tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL'));
 }
*/

 if (!$HTTP_GET_VARS['action']){
     $HTTP_GET_VARS['action'] = 'returns_track';
 }
 if ($HTTP_GET_VARS['action']) {
   switch ($HTTP_GET_VARS['action']) {
   case 'returns_show':

      // first carry out a query on the database to see if there are any matching tickets
      $database_returns_query = tep_db_query("SELECT returns_id FROM " . TABLE_RETURNS . " where customers_id = '" . $customer_id . "' and rma_value = '" . $HTTP_POST_VARS['rma'] . "' or rma_value = '" . $HTTP_GET_VARS['rma'] . "'");
      if (!tep_db_num_rows($database_returns_query)) {
//           tep_redirect(tep_href_link('returns_track.php?error=yes'));
	 tep_redirect(tep_href_link('returns_track.php', '', 'SSL').'&error=yes');
      } else {
         $returns_query = tep_db_fetch_array($database_returns_query);
         $returns_id = $returns_query['returns_id'];
         $returned_products_query = tep_db_query("SELECT * FROM " . TABLE_RETURNS_PRODUCTS_DATA . " op, " . TABLE_RETURNS . " o where o.returns_id = op.returns_id and op.returns_id = '" . $returns_id . "'");
         $returned_products = tep_db_fetch_array($returned_products_query);

             require(DIR_WS_CLASSES . 'order.php');
          $order = new order($returned_products['order_id']);

      }

   break;

}
}

 require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_RETURN);
 $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_RETURN, '', 'NONSSL'));
?>
<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">
<html <?php echo HTML_PARAMS; ?>>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>">
<title><?php echo TITLE; ?></title>   
<base href="<?php echo (getenv('HTTPS') == 'on' ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">
<link rel="stylesheet" type="text/css" href="stylesheet.css">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">
<!-- header //-->
<?php require(DIR_WS_INCLUDES . 'header.php'); ?>
<!-- header_eof //-->

<!-- body //-->
<table border="0" width="100%" cellspacing="3" cellpadding="3">
 <tr>
   <td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- left_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_left.php'); ?>
<!-- left_navigation_eof //-->
   </table></td>
<!-- body_text //-->
   <td width="100%" valign="top"><table border="0" width="100%" cellspacing="0" cellpadding="0">
     <tr>
       <td width="100%"><table border="0" width="100%" cellspacing="0" cellpadding="0">
         <tr>
           <td class="pageHeading"><?php echo HEADING_TITLE; ?></td>
           <td align="right">
<?php // echo tep_image(DIR_WS_IMAGES . 'table_background_specials.gif', HEADING_TITLE, HEADING_IMAGE_WIDTH, HEADING_IMAGE_HEIGHT); ?>
</td>
         </tr>
       </table></td>
     </tr>
     <tr>
       <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
     </tr>
     <tr>
       <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
         <tr>

 <td width="100%" valign="top">
	 <table border="0" width="100%" cellspacing="0" cellpadding="0">

         <?
     if ($HTTP_GET_VARS['action'] == 'returns_show') {
         include(DIR_WS_MODULES . 'returns_track.php');
    // }

     ?>
<?php
//
?>
 <tr>
	 <td><?php echo tep_draw_separator('pixel_trans.gif', '20', '20'); ?><br</td>
 </tr>

<?php
//}
?>

   <table></td>
     <!-- end new insert here --//-->
   <?
} else {
?>
     <tr>
       <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
         <tr>
      	 <td width="100%" valign="top">
    <table border="0" width="100%" cellspacing="0" cellpadding="0">
                <?
                 if (isset($error)=='yes') {
                  $error_message = '<tr>
                                    <td colspan=3 class=main>The details you entered do not match any of our records, please try again, or contact us for further assistance</td>
                                    </tr>
                                    <tr>';
                   new infoBox(array(array('text' => $error_message)));
                 // }
                   echo '<br><BR>';
             }
                   $returns  = tep_draw_form('rma_find', tep_href_link('returns_track.php', '', 'NONSSL'), 'get');
       $returns .= tep_draw_hidden_field('action', 'returns_show');
       $returns .= tep_hide_session_id();
                   $returns .= '<tr>
                            <td colspan=3 class=main>Please enter the RMA number you recieved when you placed you item for return.</td>
                            </tr>
                            <tr>
                            <td width=100& colspan=3 class=main> </td>
                            </tr>
                            <tr>
                            <td width="25%" height="30" align="left" class="main">Your <b><i>RMA</i></b> Number</td>
                            <td width="5%" height="30" align="center" class="main"> </td>
                            <td width="75%" height="30" align="left" class="main"><font color=red><input type=text name="rma" value="" size=20></font></td>
                            </tr>
                            <tr>
                            <td width=100& colspan=3 class=main> </td>
                            </tr>
                            <tr>
                            <td width=100% colspan=3 align=right><input type=submit name="submit" value="Find Return ->">   </td>
                            </tr>
                            </form>


                            ';



                new infoBox(array(array('text' => $returns)));



                ?>

            <!--  </table></td></tr>-->
           </table></td></tr>
          </table></td></tr>
<?
}

?>


           </td>
         </tr>
       </table></td>
     </tr>

   </table></td>
<!-- body_text_eof //-->
   <td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">
<!-- right_navigation //-->
<?php require(DIR_WS_INCLUDES . 'column_right.php'); ?>
<!-- right_navigation_eof //-->
   </table></td>
 </tr>
</table>
<!-- body_eof //-->

<!-- footer //-->
<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>
<!-- footer_eof //-->
<br>
</body>
</html>
<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?>

 

I hope that helps!

 

Regards

 

Jiten

Share this post


Link to post
Share on other sites

Hi Unified,

 

I hope that helps!

 

Thanks, but no change. :(

 

PLEASE,

 

Anyone that has the mod working, PLEASE post a .zip file of their working version of the mod B) , so everyone who has tried and failed to get this important mod working, like myself, can get on to running their store!

 

Thank you! :D


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

Nevermind,

 

This mod, just does not want to work for me :rolleyes:, so I'll be uninstalling it.


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

question on step 4:

 

 

 

 

4, Open catalog/includes/functions/general.php

at the end of the file just before the closing ?> add the following line

include('includes/functions/refund_functions.php');

 

 

should this be admin/include/functions/general.php

 

I have 2.2ms2 and I don't have this folder catalog/includes/functions/

Share this post


Link to post
Share on other sites

A happy update, well at least for myself! ;)

 

I've benn trying to get the mod to work sense 04/09/2003, so I had to try the mod, just one more time before I gave up on it, so I installed this version:

 

02/07/2004 - RMA_return2.1b Author: andrew

 

http://www.oscommerce.com/community/contri...ons,1136/page,7

 

Oh happy day! :D

 

With some very minor tweaks, it is working 100% on my 2.2MS2 install.

 

Thanks andrew, and a big thank you to ALL the coders on this mod. B)


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

OK what did I do? I installed the update and when a click on "Track a Return" I get the Return A Product box with a text box and a button with no writing (returns_track.php). Did I miss something?

 

Don

Share this post


Link to post
Share on other sites

Hi donbaker,

 

I get the Return A Product box with a text box and a button with no writing (returns_track.php). Did I miss something?

 

It sounds like you may have forgot to add the language file for:

 

catalog/includes/languages/english/returns_track.php

 

Or

 

If you are talking about the forms submit button not having any text on it, the code should look like this:

 

<td width="100%" colspan="3" align="right"><input type="submit" name="submit" value="Find Return ->">   </td>

 

Good luck.


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

GD, i tried to install the latest 2.2 version of RMA_returns contibution on a milestone 2.2 shop.

 

it seems like the installation instructions are not good or incomplete.

for now i'can't see my orders anymore, they are in the DB though but i can't see them in my admin.

 

maybe you have a full and working installation guide for this new RMA_returns 2.2 version.

 

thank you :P

 

can you also say if this newer version (RMA_returns 2.2) is made for MS2.2 ?

Share this post


Link to post
Share on other sites

Hi verstege,

 

GD, i tried to install the latest 2.2 version of RMA_returns contibution on a milestone 2.2 shop.

 

Is your milestone 2.2 shop, MS1 or MS2? The latest RMA_returns 2.2 is made for MS2. ;)

 

--------------------------------

 

it seems like the installation instructions are not good or incomplete.

for now i'can't see my orders anymore, they are in the DB though but i can't see them in my admin.

 

The full installation instructions were included in the new .zip file. What file is not showing your orders?

 

--------------------------------

 

can you also say if this newer version (RMA_returns 2.2) is made for MS2.2?

 

Yes, I installed this version of the mod on my 2.2 MS2 shop.

 

02/07/2004 - RMA_return2.1b Author: andrew<- Made for 2.2 MS2.

 

http://www.oscommerce.com/community/contributions,1136


Running osC - 2.2MS2. P.S. Please don't ask for a link to my site, it is on a production server and not available for the general public, yet!

Share this post


Link to post
Share on other sites

Hello @ all,

 

the last days i installed this really great and usefull contribution RMA Returns System v2.2a to my osc v 2.2 ms2. there where a few bugs i fixed and made it compatible with this osc version. while i was installing and testing it i decided to spend a new download for all when it is working in multilanguage english and german. RMA is a very important topic if you do not only want to sell however even give your customers support after they placed an order. so i am almost at the end and it really works good, taxrate calculation is correct, displayed currency in catalog/retrun_track.php and catalog/retrun_products.php when placed a return is not even changeable by selecting country or currency dropdown. I fixed a few little things more ....

 

BUT:

 

Maybe somebody can help me to resolve one (i think) really big problem ->

 

when i sold an item with attributes and options the RMA Retruns System v2.2a is not adding this to the products price.

At my account_history_info.php i can see the total with all attributes and options included but when i click "return this product" on the next page there will be only shown the products price without the attributes and options....

The same problem in admin/....

 

 

Maybe someone can help to fix this last little big problem...

 

 

Thanx for ur help Joachim

Share this post


Link to post
Share on other sites

Hello all!

 

I am running osc2.2 MS2 and am working on installing RMA_return_2.2a. I seem to be having the same problem as many others where the customer hits the "Request" button to get his rma and is sent to the login page. I noticed that the osCsid is changed at this point... even though it is correctly held in a hidden field generated immidiately following the <form> field. Has anyone corrected this problem as of yet?

 

I noticed after dropping in "breaks" that the error occurs as soon as the return_product.php page is called. I originaly thought they may have redirected to themselves without the osCsid but that seems to not be the problem.

 

I am only using this RMA contrib as a stop gap measure until I can complete my own RMA system. BTW my system will allow for returning multiple items from an invoice at one time (not the present get 1 rma per line item on the invoice) and will include the ability for the customer to get a UPS or FEDex return shipping lable so my company can pick up their return shipping cost. This should all be done in about a month (read as by May 1st 2004).

 

Anyway any help on this small bug would be greatly appreciated.

 

Cheers!

Share this post


Link to post
Share on other sites

Jsut noticed this for the first time...... here is the url as it appears in the url box on my browser!

 

 

return_product.php?action=sent&rma_value=04185610388&return_id=10?osCsid=9a4978fc3be886e611af4810ca2d2238

 

anyone else get that ? between thier return_id and ocCsid instead of the needed &?

Share this post


Link to post
Share on other sites

Sorry to post so many times in one day but I have te fix for RMA_return_2.2a in regards to the bug where users hit the "Request" button and are redirected back to the login page without getting their rma number displayed on the screen.

 

In /catalog/return_product.php chnage the following lines:

 

if ($HTTP_GET_VARS['action']) {

switch ($HTTP_GET_VARS['action']) {

case 'insert':

case 'update':

 

to look like this:

 

if ($HTTP_GET_VARS['action']) {

switch ($HTTP_GET_VARS['action']) {

case 'sent':

break;

case 'insert':

case 'update':

 

Now farther down in the same file find:

 

tep_redirect(tep_href_link(FILENAME_RETURN . '?action=sent&rma_value='. $rma_value . '&return_id=' . $ticket_id));

 

and change it to:

 

tep_redirect(tep_href_link(FILENAME_RETURN, 'action=sent&rma_value='. $rma_value . '&return_id=' . $ticket_id));

 

 

This last edit ensures that the url is sent properly otherwise the urls would have a format of:

return_product.php?action=sent&rma_value=54288470329&return_id=26?osCsid=sessionid

 

which would cause oscommerce to think that there is not a valid seesion id, therby sending the customer to the login screen and creating a new session id in the process.

 

Hope this is useful for anyone out there using this contribution.

Share this post


Link to post
Share on other sites

So does your fix make this system usable? I am looking for just such a package and was hoping this one would work. If not, pleases be sure to post when your package is available.

 

I look forward to your contribution.


If at first you don't succeed! Erase all evidence that you tried!

The higher... the fewer...

Share this post


Link to post
Share on other sites

Also, GD. You state that you have this working, but then in the contributions area you post that it is NOT working and do not use it... So which is correct?


If at first you don't succeed! Erase all evidence that you tried!

The higher... the fewer...

Share this post


Link to post
Share on other sites

Is there a way to get the status that the return is set in the admin side, reflected on the customers side?

 

Return a Product

 

 

 

Retruns status <---- Shouldnt there be a status here????????

 

 

Product to return

 

Product name

1 x Mouse Pad $0.69

 

 

 

Also, does anyone know where I can correct the spelling of Retruns above to Returns?

 

Thanks again community,

David

Share this post


Link to post
Share on other sites

Hi everybody,

I intend to add this great contrib to osC 2.2 MS2, but the RMA returns contrib advises otherwise??? Can anyone care to share your experience regarding this contrib with the rest of us? Any problems with this contrib?

 

Thanks in advance for your time. :D :D

Share this post


Link to post
Share on other sites

Hello!

 

Yes, I got the contribution to work full force! Had a lot of clean-up work to do but I got it done on 2 sites, and getting ready to clean-up the 3rd site.

 

I first followed all the instructions and as I ran a test, found error by error and fixed them. I didn't get some of the same errors others had, basically the install went rather well.

 

One problem was I noticed when you click on Track A Return, the button showed <? inside of it. So it was finding the spot to fix that. After trial and error I finally found it. Basically, all my errors were minor and easy to find.

 

If you need help, hollar! Now that I've got this contribution running I will try to help out as much as I can.

 

HTH

 

p.s. Its the Returns Sort Admin Version 1.0 either one! that isn't working yet. Download this one 8 Feb 2004 - RMA-Return 2.2a

Edited by only2empires

Share this post


Link to post
Share on other sites
Hello!

 

Yes, I got the contribution to work full force! Had a lot of clean-up work to do but I got it done on 2 sites, and getting ready to clean-up the 3rd site.

 

I first followed all the instructions and as I ran a test, found error by error and fixed them. I didn't get some of the same errors others had, basically the install went rather well.

 

One problem was I noticed when you click on Track A Return, the button showed <? inside of it. So it was finding the spot to fix that. After trial and error I finally found it. Basically, all my errors were minor and easy to find.

 

If you need help, hollar! Now that I've got this contribution running I will try to help out as much as I can.

 

HTH

 

p.s. Its the Returns Sort Admin Version 1.0 either one! that isn't working yet. Download this one 8 Feb 2004 - RMA-Return 2.2a

Hi Cathy,

 

Is it possible that you update the contribution with the known problems fixed so as to benefit the rest of us... If this is not too much to ask.

 

Thank you. :D

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×