NEW! Complete Order Editing Tool!

[vmn 14]

@SCH_001This was discussed in April 2018 in this topic. I uploaded my version then. As I pointed out my version is heavily mofified.

 

[♥BrockleyJohn 305]

Long overdue - I have uploaded a new version of the addon to

https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0

which includes all the fixes posted to the thread through this year. It installs on Phoenix 1.0.7.10 offering full functionality without core modifications. Many of the php notices and warnings have been fixed.

A little adaptation for customer data modules has been applied so that it doesn't throw warnings or offer the fields if you don't have modules like suburb installed but not all are handled (eg. state) - you can extend along the same lines if required.

A future version could use the new modules properly, along with the rationalisation and autoloading of classes but that will involve an extensive redesign that might end up being a different addon altogether.

[vmn 14]

This was an obsolete comment regarding the version 1.2.8. I was writing a comment to  when a note of a new version was posted

 

Edited November 24, 2020 by vmn

[vmn 14]

23 hours ago, BrockleyJohn said:

There are no core code changes required on any Phoenix version since 1.0.4.0

Sorry, I must have missed something.

As to 1.2.9 I think that there is no infoBoxContent style any more in 1.0.7.9.

I think I stick to my version with one core change. Hopefully the core in the future will contain this extra hook.
I also modify the style of the order list and add order language to the edit link.

BTW, I moved the extra hook to the end of this if statement in orders.php before the last break stmt.

if (($oInfo ?? null) instanceof objectInfo) {
    ...
   echo $OSCOM_Hooks->call('orders', 'orderList');
}
        

 

[♥BrockleyJohn 305]

2 minutes ago, vmn said:

Sorry, I must have missed something.    

yeah, probably v1.2.8 which is when core changes were no longer required

[f.figue 2]

2 hours ago, BrockleyJohn said:

Long overdue - I have uploaded a new version of the addon to

https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0

which includes all the fixes posted to the thread through this year. It installs on Phoenix 1.0.7.10 offering full functionality without core modifications. Many of the php notices and warnings have been fixed.

A little adaptation for customer data modules has been applied so that it doesn't throw warnings or offer the fields if you don't have modules like suburb installed but not all are handled (eg. state) - you can extend along the same lines if required.

A future version could use the new modules properly, along with the rationalisation and autoloading of classes but that will involve an extensive redesign that might end up being a different addon altogether.

Hi,

Thanks for keeping updates to this addon.
I have the previous version installed and the calculation does not work well if you use discount codes.
I wonder if the new version includes the changes so that the discount code addon works well: https://apps.oscommerce.com/xkyCQ&discount-codes-phoenix

Thank you!

[♥BrockleyJohn 305]

7 hours ago, f.figue said:

Hi,

Thanks for keeping updates to this addon.
I have the previous version installed and the calculation does not work well if you use discount codes.
I wonder if the new version includes the changes so that the discount code addon works well: https://apps.oscommerce.com/xkyCQ&discount-codes-phoenix

Thank you!

I am afraid that I don't know! We did do some bug fixing around shipping calculations and their tax in the spring. This may have had some impact on other order total modules such as discounts, but I didn't investigate the behaviour. If you can try the latest version and report back specifically what doesn't work if it's still wrong, I can have a look for the cause.

[artfulweb 23]

On 11/24/2020 at 9:12 AM, BrockleyJohn said:

Long overdue - I have uploaded a new version of the addon to

https://apps.oscommerce.com/Apps&wwEZ9&order-editor-for2-3-v1-0

which includes all the fixes posted to the thread through this year. It installs on Phoenix 1.0.7.10 offering full functionality without core modifications. Many of the php notices and warnings have been fixed.

A little adaptation for customer data modules has been applied so that it doesn't throw warnings or offer the fields if you don't have modules like suburb installed but not all are handled (eg. state) - you can extend along the same lines if required.

A future version could use the new modules properly, along with the rationalisation and autoloading of classes but that will involve an extensive redesign that might end up being a different addon altogether.

Hi John,

Thanks for the update.

Just installed and corrected in admin/order_editor/functions.php, line 284 :

    $product_options_query = tep_db_query("select products_options_id from " . TABLE_PRODUCTS_OPTIONS . " where products_options_name = '" . $options_name . "' and language_id = '" . (int)$language_id . "'");

 TO:

    $product_options_query = tep_db_query("select products_options_id from products_options where products_options_name = '" . $options_name . "' and language_id = '" . (int)$language_id . "'");
 

And 298-300:

          $product_options_values_query = tep_db_query("select pov.products_options_values_id from " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov, " . TABLE_PRODUCTS_ATTRIBUTES . " pa where pa.options_id = '" . $options_id . "' and pov.products_options_values_name = '" . $options_value . "' and pov.language_id = '" . (int)$language_id . "' and pov.products_options_values_id = pa.options_values_id and pa.products_id = '" . (int)$products_id . "'");
    } else {
        $product_options_values_query = tep_db_query("select pov.products_options_values_id from " . TABLE_PRODUCTS_OPTIONS_VALUES . " pov, " . TABLE_PRODUCTS_ATTRIBUTES . " pa where pa.options_id = '" . $options_id . "' and pov.products_options_values_name = '" . $options_value . "' and pov.language_id = '" . (int)$language_id . "' and pov.products_options_values_id = pa.options_values_id");
 

TO:

          $product_options_values_query = tep_db_query("select pov.products_options_values_id from products_options_values pov, products_attributes pa where pa.options_id = '" . $options_id . "' and pov.products_options_values_name = '" . $options_value . "' and pov.language_id = '" . (int)$language_id . "' and pov.products_options_values_id = pa.options_values_id and pa.products_id = '" . (int)$products_id . "'");
    } else {
        $product_options_values_query = tep_db_query("select pov.products_options_values_id from products_options_valuespov, products_attributes pa where pa.options_id = '" . $options_id . "' and pov.products_options_values_name = '" . $options_value . "' and pov.language_id = '" . (int)$language_id . "' and pov.products_options_values_id = pa.options_values_id");

[dculley 15]

@BrockleyJohn

In November I did a fresh install to 7.10 and to moved to 7.12.  I'm also under PHP 7.4

I have used the app under Osc 2.3.4 and in joyed it.  I see that this group is trying to get it to run under Phoenix.  I went to the app page and down loaded the latest app on it.  But then was confused on what part to install.  I down loaded the Order Editor v1.2.9 Phoenix 1.0.7.10 under this app.  But there are several sections. That confused me. 

Not sure what to do. 

This will be a new install.  Is this ready for 7.12?  If it is any help on what I need to do? 

I see in the installation (new) there is 2 1.0.4 v.  and than I see new files.  Just got my self confused. 

Thanks for the help.

Dean

 

[dculley 15]

@artfulweb @BrockleyJohn

 

Installation (NEW) is unclear to me.  I see that CE Phoenix 1.0.4.0 v is for the most part empty.  And that 1.0.5.0v is empty.  So that leaves me with CE Phoenix before 1.0.4.0v and Catalog new files.  Which one do I use?  I'm thanking the 'Catalog new files'.

After uploading the correct file, which edits do I need to do to order.php

Will I still need to apply the changes to admin/order_editor/functions.php,  that B mentioned above? 

Thanks for any help.

Dean

[yahalimu 41]

On 11/24/2020 at 5:27 PM, BrockleyJohn said:

I am afraid that I don't know! We did do some bug fixing around shipping calculations and their tax in the spring

Hi, I don't think the discount issue has been reported previously so I doubt its been addressed but I'm in a similar situation. It doesn't handle discounts and the totals go out when any changes are made.

If a product, for example, is changed it recalculates the order totals. BUT

1) The new TAX is calculated ignoring the discount.

2) The new order total uses this Tax amount but also ignores the discount line.

Where in the code  does it re-calculate the totals? Couldn't find it.