Jump to content

Recommended Posts

30 minutes ago, edfaught said:

Does the hotfix also take care of this?

Answered: Yes it does. However now I see this:

Warning
: Use of undefined constant MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH - assumed 'MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH' (this will throw an Error in a future version of PHP) in
includes/modules/pi/product_info/pi_gallery_kissit.php on line 84

Because previously and by mistake I didn't have the module installed.

Edited by edfaught

Share this post


Link to post
Share on other sites
14 minutes ago, edfaught said:

Answered: Yes it does. However now I see this:


Warning
: Use of undefined constant MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH - assumed 'MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH' (this will throw an Error in a future version of PHP) in
includes/modules/pi/product_info/pi_gallery_kissit.php on line 84

Because previously and by mistake I didn't have the module installed.

Seems I missed to add these constants during the last update to abstract module.

Here the fixed module (needs uninstall/reinstall):

pi_gallery_kissit.php

 

Quote

(Also, the support link in the download documentation is outdated.) 

Thanks, I'll also update it.

 

Please confirm and I'll upload the update with these fixes tomorrow.

Edited by raiwa

Share this post


Link to post
Share on other sites
On 1/12/2021 at 3:27 PM, Denzel said:

Found the list messed up again after searching a product, which is linked to a 2nd folder. Decided to add classes to the <th> tags, so we can exclude the choosen classes:


$('table tbody td:has([href*="pID={$products_id}&"])').parent().find('th').not('.pmodel').not('.pname').addClass('pname').before('<th class="pmodel">{$products_model}</th>');

  this works for me even with three links 😉 

Hi Dennis,

Your solution includes other customizations like the product model and I believe you posted the wrong line which adds {$products_model}. It should be {$products_thumb}.

Please post generic solutions for a unmodified installation, not custom solutions.

What works for me is this:

$('table tbody td:has([href*="pID={$products_id}&"])').parent().find('th').not('.pname').addClass('pname').before('<th class="pname">{$products_thumb}</th>');

Thank you 😉

Edited by raiwa

Share this post


Link to post
Share on other sites

Uploaded update with the above fixes for Phoenix 1.0.7.13:

KissIT image thumbnailer 3.5.0r1

Requires Phoenix 1.0.7.4+
Tested with Phoenix 1.0.7.13

Change log 3.5.0r1:

- updated gallery modules for Phoenix 1.0.7.13.
- fixed error in admin thumbs category hook. Thanks to @Denzel
- updated pi gallery module to abstract_module

Change log 3.5.0:

- moved and cleaned up thumbs subdirectory creation and removed unnecessary .htaccess. Thanks to @vmn
- fixed error in admin thumbs showing duplicated images in product and category listing. Thanks to @Denzel
- added support for webp image format
- updated pi gallery module to abstract_module
- Added optional convert jpeg, png and gif images to webp thumbs (Pro Version)

 

Share this post


Link to post
Share on other sites
vor 3 Stunden schrieb raiwa:

I believe you posted the wrong line

That's true, I'm sorry 🙂

Share this post


Link to post
Share on other sites

Running with 1.0.7.13: 

just a question: is it intended, that the main-image is not thumbnailed? Because neither an image width or height is specified in pi_gallery_kissit.php Line 68. By adding some numbers there, the main image is cached as well. 

Share this post


Link to post
Share on other sites
38 minutes ago, cupidare said:

Running with 1.0.7.13: 

just a question: is it intended, that the main-image is not thumbnailed? Because neither an image width or height is specified in pi_gallery_kissit.php Line 68. By adding some numbers there, the main image is cached as well. 

Yes, it is intended. It's supposed you wish to show the full original image size in the pop up. Only if watermark is used, KissIt will produce a new "thumb", but also in the original image size. There is no "cache" effect, the original image is there and does not need to be "cached" in the thumbs folder.

Share this post


Link to post
Share on other sites

Thank you for the answer. I personally store images in full resulution (>4mb) because maybe I will need it in the future ...  but for the pi-site it is sufficient to show a much smaller image. So am I right putting the "sufficient"-file-size in this position?

Edited by cupidare

Share this post


Link to post
Share on other sites
48 minutes ago, cupidare said:

Thank you for the answer. I personally store images in full resulution (>4mb) because maybe I will need it in the future ...  but for the pi-site it is sufficient to show a much smaller image. So am I right putting the "sufficient"-file-size in this position?

Yes, if it's ok for your needs.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×