Jump to content

Recommended Posts

Hi Ed,

I suppose you are using the latest KissIT image thumbnailer 3.4.1. :

I checked in my develp store and can't see this error.

These constants are defined in the KissIt Gallery module.

Please try to uninstall and reinstall the module.

Share this post


Link to post
Share on other sites

I uninstalled and reinstalled with no change. Here's the list of scalars etc. from an Xdebug breakpoint at pi_gallery_kissit.php line 84. I noticed it shows KISSIT_IMAGE_MODULE at 3.4.0 but I'm pretty sure I installed 3.4.1. Since I had a little trouble getting the upload files in the right places I wouldn't be surprised to find something out of place. I'll double check that.

KISSIT_1.jpg.6d21b829560a8230dfae49bc5210ce95.jpgKISSIT_2.jpg.8fa41fe35281abd1ee2c2941601ccb3c.jpg

Edited by edfaught
I always edit the first draft.

Share this post


Link to post
Share on other sites
On 9/16/2020 at 1:59 AM, raiwa said:

These constants are defined in the KissIt Gallery module.

I have found my problem I think: I have overridden class pi_options_attributes and I know that I have to define the constants myself (Though I don't know why).

As my learning curve is somewhat hampered I ask you if this make sense?

Share this post


Link to post
Share on other sites

Hi Ed,

The attributes module is not related.

However I found now the confusion. It was created by using the wrong content module constant in the pi module.

That's why I checked the content module, but you are using the pi module.

The pi module has the constants missing, apart of using the wrong one in the output.

I fixed it now. Please try this one:

includes/modules/pi/product_info/pi_gallery_kissit.php

pi_gallery_kissit.php

You need to uninstall yours, replace it and install again.

Please confirm and I'll update the package.

Thanks
Rainer

 

Edited by raiwa

Share this post


Link to post
Share on other sites
Quote

Warning
: Use of undefined constant MODULE_CONTENT_PI_GALLERY_KISSIT_MAIN_IMAGE_WIDTH - assumed 'MODULE_CONTENT_PI_GALLERY_KISSIT_MAIN_IMAGE_WIDTH' (this will throw an Error in a future version of PHP) in
C:\Users\Ed_2\My Websites\nationalvnwarmuseumfriends.org\giftshop\includes\modules\pi\product_info\pi_gallery_kissit.php on line 73

At least the error on line 88 went away...

Share this post


Link to post
Share on other sites

Seems this is whitched.

This should be ok now:

pi_gallery_kissit.php

Share this post


Link to post
Share on other sites

Uploaded update with the above fix:

KissIT image thumbnailer 3.4.2.

Requires Phoenix 1.0.7.4+
Tested with Phoenix 1.0.7.7

Change log 3.4.2:

- fixed wrong and missing constant in pi gallery kissit module. Thanks to @edfaught
- added missing alt tag

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×