edfaught Posted January 13, 2021 Share Posted January 13, 2021 (edited) 30 minutes ago, edfaught said: Does the hotfix also take care of this? Answered: Yes it does. However now I see this: Warning : Use of undefined constant MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH - assumed 'MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH' (this will throw an Error in a future version of PHP) in includes/modules/pi/product_info/pi_gallery_kissit.php on line 84 Because previously and by mistake I didn't have the module installed. Edited January 13, 2021 by edfaught Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted January 13, 2021 Author Share Posted January 13, 2021 (edited) 14 minutes ago, edfaught said: Answered: Yes it does. However now I see this: Warning : Use of undefined constant MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH - assumed 'MODULE_PI_GALLERY_KISSIT_SMALL_IMAGE_WIDTH' (this will throw an Error in a future version of PHP) in includes/modules/pi/product_info/pi_gallery_kissit.php on line 84 Because previously and by mistake I didn't have the module installed. Seems I missed to add these constants during the last update to abstract module. Here the fixed module (needs uninstall/reinstall): pi_gallery_kissit.php Quote (Also, the support link in the download documentation is outdated.) Thanks, I'll also update it. Please confirm and I'll upload the update with these fixes tomorrow. Edited January 13, 2021 by raiwa Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted January 14, 2021 Author Share Posted January 14, 2021 (edited) On 1/12/2021 at 3:27 PM, Denzel said: Found the list messed up again after searching a product, which is linked to a 2nd folder. Decided to add classes to the <th> tags, so we can exclude the choosen classes: $('table tbody td:has([href*="pID={$products_id}&"])').parent().find('th').not('.pmodel').not('.pname').addClass('pname').before('<th class="pmodel">{$products_model}</th>'); this works for me even with three links 😉 Hi Dennis, Your solution includes other customizations like the product model and I believe you posted the wrong line which adds {$products_model}. It should be {$products_thumb}. Please post generic solutions for a unmodified installation, not custom solutions. What works for me is this: $('table tbody td:has([href*="pID={$products_id}&"])').parent().find('th').not('.pname').addClass('pname').before('<th class="pname">{$products_thumb}</th>'); Thank you 😉 Edited January 14, 2021 by raiwa Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted January 14, 2021 Author Share Posted January 14, 2021 Uploaded update with the above fixes for Phoenix 1.0.7.13: KissIT image thumbnailer 3.5.0r1 Requires Phoenix 1.0.7.4+ Tested with Phoenix 1.0.7.13 Change log 3.5.0r1: - updated gallery modules for Phoenix 1.0.7.13. - fixed error in admin thumbs category hook. Thanks to @Denzel - updated pi gallery module to abstract_module Change log 3.5.0: - moved and cleaned up thumbs subdirectory creation and removed unnecessary .htaccess. Thanks to @vmn - fixed error in admin thumbs showing duplicated images in product and category listing. Thanks to @Denzel - added support for webp image format - updated pi gallery module to abstract_module - Added optional convert jpeg, png and gif images to webp thumbs (Pro Version) Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
Denzel Posted January 14, 2021 Share Posted January 14, 2021 vor 3 Stunden schrieb raiwa: I believe you posted the wrong line That's true, I'm sorry 🙂 Quote Link to comment Share on other sites More sharing options...
cupidare Posted January 18, 2021 Share Posted January 18, 2021 Running with 1.0.7.13: just a question: is it intended, that the main-image is not thumbnailed? Because neither an image width or height is specified in pi_gallery_kissit.php Line 68. By adding some numbers there, the main image is cached as well. Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted January 18, 2021 Author Share Posted January 18, 2021 38 minutes ago, cupidare said: Running with 1.0.7.13: just a question: is it intended, that the main-image is not thumbnailed? Because neither an image width or height is specified in pi_gallery_kissit.php Line 68. By adding some numbers there, the main image is cached as well. Yes, it is intended. It's supposed you wish to show the full original image size in the pop up. Only if watermark is used, KissIt will produce a new "thumb", but also in the original image size. There is no "cache" effect, the original image is there and does not need to be "cached" in the thumbs folder. cupidare 1 Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
cupidare Posted January 18, 2021 Share Posted January 18, 2021 (edited) Thank you for the answer. I personally store images in full resulution (>4mb) because maybe I will need it in the future ... but for the pi-site it is sufficient to show a much smaller image. So am I right putting the "sufficient"-file-size in this position? Edited January 18, 2021 by cupidare Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted January 18, 2021 Author Share Posted January 18, 2021 48 minutes ago, cupidare said: Thank you for the answer. I personally store images in full resulution (>4mb) because maybe I will need it in the future ... but for the pi-site it is sufficient to show a much smaller image. So am I right putting the "sufficient"-file-size in this position? Yes, if it's ok for your needs. cupidare 1 Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted January 22, 2021 Author Share Posted January 22, 2021 (edited) Uploaded update with the above fixes for Phoenix 1.0.7.13: KissIT image thumbnailer 3.5.1 Requires Phoenix 1.0.7.4+ Tested with Phoenix 1.0.7.13 Change log 3.5.1: - cast to int image width and height Change log 3.5.0r1: - updated gallery modules for Phoenix 1.0.7.13. - fixed error in admin thumbs category hook. Thanks to @Denzel - updated pi gallery module to abstract_module Change log 3.5.0: - moved and cleaned up thumbs subdirectory creation and removed unnecessary .htaccess. Thanks to @vmn - fixed error in admin thumbs showing duplicated images in product and category listing. Thanks to @Denzel - added support for webp image format - updated pi gallery module to abstract_module - Added optional convert jpeg, png and gif images to webp thumbs (Pro Version) Edited January 22, 2021 by raiwa Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
vmn Posted January 26, 2021 Share Posted January 26, 2021 Hello @raiwa and thanks again for your great addon. I wanted to have language specific default images. To achieve this I made the following change to kiss_it_image.php: if (defined('DEFAULT_IMAGE') && tep_not_null(DEFAULT_IMAGE) && !is_file(DIR_FS_CATALOG . $src)) { //VMN$src = DEFAULT_IMAGE; $src = 'includes/languages/' . $_SESSION['language'] . '/images/' . DEFAULT_IMAGE; } elseif ( (empty($src) || ($src == 'images/')) && (IMAGE_REQUIRED == 'false') ) { return false; } I wonder whether you would like to include this change into a future version of the addon:). raiwa 1 Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted January 26, 2021 Author Share Posted January 26, 2021 Nice, I'll test and consider it for the next update. Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
vmn Posted January 30, 2021 Share Posted January 30, 2021 And, in the modern world: $src = Text::ltrim_once(language::map_to_translation('images/' . DEFAULT_IMAGE), DIR_FS_CATALOG); Quote Link to comment Share on other sites More sharing options...
micheleangle Posted February 12, 2021 Share Posted February 12, 2021 dculley - How did you get rid of the watermark? Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted February 13, 2021 Author Share Posted February 13, 2021 15 hours ago, micheleangle said: dculley - How did you get rid of the watermark? If you do not wants to use Watermark at all, switch it off in the settings: Admin : Images If you only wish to remove it from some image(s), read the instructions, example store logo. Don't forget to reset the thumbs and browsers cahe after changing the settings. micheleangle 1 Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
dculley Posted February 13, 2021 Share Posted February 13, 2021 3 hours ago, raiwa said: If you do not wants to use Watermark at all, switch it off in the settings: Admin : Images If you only wish to remove it from some image(s), read the instructions, example store logo. Don't forget to reset the thumbs and browsers cahe after changing the settings. @micheleangle Sorry I did not get back to you earlier. I have been away. @raiwa is correct that is what I did. Under the section: Check and adjust the Confiuration Setting in Admin for your need: section C - "0=no watermark. Hope this helps some. micheleangle 1 Quote Link to comment Share on other sites More sharing options...
zeeshop Posted February 20, 2021 Share Posted February 20, 2021 @raiwa I am facing this issue after installing KissIT image thumbnailer 3.5.1 that I am not able to see many images on products at front end. In Admin side, there is no issue and all product images are displaying without issue. This issue is with the products I uploaded few hours ago using easypopulate, All images were tested and working without any problem before. But when I installed KissIt Moudule it only effected these new products. weirdly it is still showing 3 items images from this bulkuploaded products but not showing for 99 % of them. All previously listed products are still displaying images correctly. Kindly advise what could be the reason? Thanks Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted February 20, 2021 Author Share Posted February 20, 2021 Caché? Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
zeeshop Posted February 20, 2021 Share Posted February 20, 2021 Thanks @raiwa if you referring to Image cache, yes I reset it, with no effect on my images issue. I am using Phoenix v1.0.7.15 on Php: 7.4.15 One thing I noticed, may not be relevant and hence your comments will be important, when looking on your "Uninstall" instructions catalog/includes/functions/html_output.php -- I do not have these lines in this file. delete the folder “kiss_image_thumbnailer” in: catalog/includes/modules/ - I do not have this folder catalog/ADMIN/includes/functions/general.php - I do not have these lines in this file. I believe I followed the installation instructions carefully, but not sure why above lines are not there & why some images are not displayed. Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted February 20, 2021 Author Share Posted February 20, 2021 The uninstall instructions seems are not updated. You would just remove all kissit files. For your not showing images issue: Can you show a sceenshot. If it's that the thumbs are not created, it can be due to memory limit if you are using very big images. Try to use smaller images or increase your server's memory. Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted February 20, 2021 Author Share Posted February 20, 2021 18 minutes ago, raiwa said: The uninstall instructions seems are not updated. You would just remove all kissit files. And run the db uninstall file. Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
zeeshop Posted February 20, 2021 Share Posted February 20, 2021 Thanks, Screen shots: Product info, shop front: (no image) Admin side: Product info summary: Admin Side Product detail (with Image) Images seems to be normal sizes, and as I mentioned earlier, products which were uploaded yesterday are affected, on all older products images are displaying with no issue. How to increase server memory? is this to be do with hosting provider? Shall I re-Install? Thanks Quote Link to comment Share on other sites More sharing options...
♥raiwa Posted February 20, 2021 Author Share Posted February 20, 2021 (edited) How big is “normal size” for you? Just try with one smaller image for testing, if it then works, it’s this. For memory increasing ask your hosting. EDIT: Make also sure to use only standard characters in the image names. Try to find out any characteristic difference between the working and non working images. In admin it says: IMAGE DOES NOT EXIST Edited February 20, 2021 by raiwa Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥Smoky Barnable Posted September 26, 2021 Share Posted September 26, 2021 I have this mostly working with PHP8 except for this warning: Deprecated: Required parameter $quality follows optional parameter $save_in in /home/includes/modules/kiss_image_thumbnailer/classes/Image.php on line 137 protected function _output( $save_in = null, $quality, $filters = null ) { switch ($this->_mime_type) { case self::IMAGETYPE_GIF : return imagegif ( $this->_image, $save_in ); break; case self::IMAGETYPE_JPEG : case self::IMAGETYPE_JPG : $quality = is_null ( $quality ) ? 75 : $quality; return imagejpeg ( $this->_image, $save_in, $quality ); break; case self::IMAGETYPE_PNG : $quality = 9; $filters = is_null ( $filters ) ? null : $filters; return imagepng ( $this->_image, $save_in, $quality, $filters ); break; default : trigger_error ( 'Image cannot be created.', E_USER_NOTICE ); break; } // end switch } // end method I see this warning in the "what's new?" box. Quote The water in a vessel is sparkling; the water in the sea is dark. The small truth has words which are clear; the great truth has great silence. - Rabindranath Tagore Link to comment Share on other sites More sharing options...
♥Smoky Barnable Posted September 26, 2021 Share Posted September 26, 2021 protected function _output( $save_in = '', $quality = '', $filters = null ) { This seems to clear the warning. Quote The water in a vessel is sparkling; the water in the sea is dark. The small truth has words which are clear; the great truth has great silence. - Rabindranath Tagore Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.