Jump to content
burt

Phoenix, constructive feedback + bug hunting

Recommended Posts

Posted (edited)

Now that it's been out in the wild a few days, bugs may have been found (or any other constructive feedback etc). Here's the Demo Site:  https://template.me.uk/phoenix/

If you have not yet installed Phoenix for yourself, please do have a look around and point out any bugs etc.  We're hoping to squash as many bugs as possible and then make a new release 1.0.1.0

Demo site is v1.0.0.2 + interim fixes slated for 1.0.0.3

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
Posted (edited)

Hi

From the front end if you go to buy apples and click on the down arrow next to the red star is does nothing?
Same when going to select country during create an account.

When in admin orders > orders and then edit it says Orders : at the top as you are now working on an order this should be just Order not Orders

Not a bug but a should have / need - in Australia and not sure where else we have to put our ABN on the invoice and also the invoice need to be called a Tax Invoice, we should be able to enter our business number / tax number in admin - configuration - store and the invoice needs this number on it along with the word Tax Invoice (or also make this a name which can be entered in admin configuration) this would make the included invoice usable for many

On a fresh install /phoenix/admin/modules_content.php won't load for me just give a empty screen :(

There is a heap of other add_on's which I feel should be included in the base package but as these would be only my opinion I will leave it out of this topic

 

 

Edited by supercheaphobb

Share this post


Link to post
Share on other sites
1 minute ago, supercheaphobb said:

From the front end if you go to buy apples and click on the down arrow next to the red star is does nothing?
Same when going to select country during create an account.

Great, thanks for pointing that out.  Fixed in next push.

1 minute ago, supercheaphobb said:

When in admin orders > orders and then edit it says Orders : at the top as you are now working on an order this should be just Order not Orders

Not sure this really, truly, matters ?  That's quite nitpicky I'd say.

2 minutes ago, supercheaphobb said:

On a fresh install /phoenix/admin/modules_content.php won't load for me just give a empty screen :(

Update to 1.0.0.2 - zip file is attached in main Phoenix thread.

--

For the things below, yes - I'm not really looking for feature requests, more for things that are bust.  But thanks though.

3 minutes ago, supercheaphobb said:

Not a bug but a should have / need - in Australia and not sure where else we have to put our ABN on the invoice and also the invoice need to be called a Tax Invoice, we should be able to enter our business number / tax number in admin - configuration - store and the invoice needs this number on it along with the word Tax Invoice (or also make this a name which can be entered in admin configuration) this would make the included invoice usable for many

There is a heap of other add_on's which I feel should be included in the base package but as these would be only my opinion I will leave it out of this topic


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

@raiwa (thank you) found a missing <p> tag in the "no js" script hook.  This will also be pushed into 1.0.0.3

Any more bust stuff?  Any more BS4 users point out my mistakes etc in implementing BS4 (I am certain there are many!).

Any constructive advice/feedback will be welcomed.

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
23 hours ago, supercheaphobb said:

Not a bug but a should have / need - in Australia and not sure where else we have to put our ABN on the invoice and also the invoice need to be called a Tax Invoice, we should be able to enter our business number / tax number in admin - configuration - store and the invoice needs this number on it along with the word Tax Invoice (or also make this a name which can be entered in admin configuration) this would make the included invoice usable for many.

Totally off topic I know but there is nothing stopping you, or anyone else,  creating a package that makes changes to the core code to comply with country specific legal requirements. If everything was kept country specific it would make loading them and updating them easy as each countries requirements changed. A package that would alter things like address layouts, tax values, date and time formats, and all sorts of other changes would be a start to making the code international.


REMEMBER BACKUP, BACKUP AND BACKUP

Get the latest Responsive osCommerce CE (community edition) here

It's very easy to over complicate what are simple things in life

Share this post


Link to post
Share on other sites

product_info.php with product options : label gives a validating error. (for="input1")

<label for="input1" class="col-form-label col-sm-3 text-left text-sm-right">

(The value of the for attribute of the label element must be the ID of a non-hidden form control.)


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites
11 minutes ago, Rwe said:

product_info.php with product options : label gives a validating error. (for="input1")

<label for="input1" class="col-form-label col-sm-3 text-left text-sm-right">

(The value of the for attribute of the label element must be the ID of a non-hidden form control.)

Thank You!  This fix will be in the 1.0.0.3 push.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Information Sidebox does not match the display of the other sideboxes for tap-targetting.

This is fixed and will go into 1.0.0.3 push.

Before:  only thing clickable is the text.
After:  can click anywhere in the box (and it highlights grey).  Same as the categories box.

info.jpg.087ebee0b39978bb85322f55c7cc8340.jpg


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

product_reviews.php?products_id=4

validating errors:

<img src="images/apple-1.jpg" alt="Apples" title="Apples" width="100" height="80" class="img-fluid" hspace="5" vspace="5" />

The hspace attribute on the img element is obsolete


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites
2 minutes ago, Rwe said:

product_reviews.php?products_id=4

validating errors:

<img src="images/apple-1.jpg" alt="Apples" title="Apples" width="100" height="80" class="img-fluid" hspace="5" vspace="5" />

The hspace attribute on the img element is obsolete

Same error found in products_review_write as well.  Thank You.

Will be pushed in 1.0.0.3


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

 index.php?cPath=1

Duplicate attribute class.

line 103

<select name="filter_id" onchange="this.form.submit()" class="form-control input-sm" class="form-control">

 


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites
4 minutes ago, Rwe said:

 index.php?cPath=1

Duplicate attribute class.

line 103

<select name="filter_id" onchange="this.form.submit()" class="form-control input-sm" class="form-control">

 

Thank You.  Will be pushed in 1.0.0.3


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

On the checkout  and  'my account' pages there are also a few validating errors.


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites

Are you using a particular validation tool?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

https://validator.w3.org/

Validate the page by URL or the pages that the validator cannot access ( checkout and account) you can use validate by direct input: source to textfield

 

 


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites

the modal on the advanced  search, the close X is before search help, i have only ever seen it on the right

Share this post


Link to post
Share on other sites
7 minutes ago, puddlec said:

the modal on the advanced  search, the close X is before search help, i have only ever seen it on the right

Thank You.  Will be pushed in 1.0.0.3


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

In the create account page the order for address is

Street Address - City - Post Code - Country

I think many people (like me) changed this into:

Street Address - Post Code - City - Country


  • Gold is EOL
  • Frozen is Sunset
  • Edge is defunct and no longer exists
  • Phoenix is the default recommended download

Share this post


Link to post
Share on other sites
Posted (edited)

@René H4

45 minutes ago, René H4 said:

In the create account page the order for address is

Street Address - City - Post Code - Country

I think many people (like me) changed this into:

Street Address - Post Code - City - Country

In the United States, the correct format is:

Name

Street Address

City

State

Postal Code

Country

 

PS: I do see that the Post Office will put the Postal Code after Country

Edited by ArtcoInc

Get the latest Responsive osCommerce CE (community edition) here .

Share this post


Link to post
Share on other sites

Yes, this is very much a localization thing @René H4

1.0.0.3 is out, please see main Phoenix thread for how to update.

Please do continue to point out bugs/enhancements etc


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
33 minutes ago, freakystreak said:

Is this live shop ready? 

In my opinion, yes.  It already has less bugs in it than Frozen ;) 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

cool, thanks... good to know. I was just upgrading to Frozen so I guess it's best to switch now before I develop too much


Ah, the world wide web. What a wonderful place.

Share this post


Link to post
Share on other sites

Hi problem during install of 1.0.0.3

Can't click on the drop down arrow to select time zone

Share this post


Link to post
Share on other sites

So after your comment

On 7/9/2019 at 9:06 PM, burt said:

Not sure this really, truly, matters ?  That's quite nitpicky I'd say.

Do you want to know about spelling mistakes / grammar or not?

Either way while I am typing... On the store front after install you have "Welcome on Store Name" I think this is meant to be Welcome to

But if you feel this is nitpicky I won't bother contributing as a shop owner about small error's...

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×