Jump to content
burt

Phoenix, constructive feedback + bug hunting

Recommended Posts

Posted (edited)

Now that it's been out in the wild a few days, bugs may have been found (or any other constructive feedback etc). Here's the Demo Site:  https://template.me.uk/phoenix/

If you have not yet installed Phoenix for yourself, please do have a look around and point out any bugs etc.  We're hoping to squash as many bugs as possible, introduce new featues and make regular new releases.

Demo site is latest version + interim fixes slated for next version.

Edited by burt
updated v

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
Posted (edited)

Phoenix 1.0.1.4 test site PHP 7.3

Warning: Use of undefined constant OSCOM_APP_PAYPAL_LOGIN_SORT_ORDER - assumed 'OSCOM_APP_PAYPAL_LOGIN_SORT_ORDER' (this will throw an Error in a future version of PHP) in D:\*********\htdocs\includes\modules\content\login\cm_paypal_login.php on line 41

I get this when I call the content modules list but not the payments modules list.

admin/modules_content.php

I do not use PayPal login.

Edited by mhsuffolk

OsC 2.3.4.1 CE Frozen   PHP 7.2   MySQL 10.1.36-MariaDB-cll-lve. Phoenix in development

Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix 1.0.2.0) here.

Share this post


Link to post
Share on other sites
Posted (edited)
On ‎7‎/‎25‎/‎2019 at 10:01 PM, burt said:

I've never seen it happen (unless the shopowner has done something a bit out of the ordinary to make it happen) and I've seen many hundreds (perhaps 1000s) of oscommerce shops over the years.

After fresh installing the latest Phoenix (1.0.1.4) to my local wamp server also i do have the following warning message after placing an order and then go to: admin -> orders -> edit order.

It seems that this warning is not new see this treat:

 

They also provide a fix but i dont know if this is okay to use on Phoenix

The warning appears on my installation on php 7.2 and 7.3

I dont know how i can have made a mistake  on  installing, while i just follow the smooth installation instructions.

What go's wrong and how to solve this?

Screenshot_1.jpg

Edited by Rwe

:heart: osCommerce

I am using osCommerce CE Phoenix.

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites

Hi @burt,

Back buttons in account probably need some spacing. This is easy to fix of course but just pointing it out. Photo taken from the phoenix demo site.1195674161_ScreenShot2019-09-03at11_08_25pm.png.91ad816e87828caf5abaa5c8af82641e.png

Regards,

Peter


Full-time I am a C-suite executive of a large retail company in Australia.

I am enjoying learning about web-design.

CE Phoenix is the best and only version of osCommerce worth considering. Download it here: https://github.com/gburton/CE-Phoenix

Share this post


Link to post
Share on other sites
55 minutes ago, peterpil19 said:

Hi @burt,

Back buttons in account probably need some spacing. This is easy to fix of course but just pointing it out. Photo taken from the phoenix demo site.

It can be addressed if/when the pages go modular...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

When the shop allows free shipping above certain order value, the question asking customer to select a shipping method still crops up during checkout. This happens when there are more than one shipping modules installed. This question is redundant and should be able to be eliminated by rewriting the program logic.

Share this post


Link to post
Share on other sites

Also navbar may need looking at still as again on mobile phone in landscape mode navbar items overflow out of navbar and cause site to scroll, Android 6" screen with Chrome browser.

image.thumb.png.2864a04702a0b476263201929c6dc028.png


 

Share this post


Link to post
Share on other sites
44 minutes ago, JcMagpie said:

Also navbar may need looking at still as again on mobile phone in landscape mode navbar items overflow out of navbar and cause site to scroll, Android 6" screen with Chrome browser.

image.thumb.png.2864a04702a0b476263201929c6dc028.png

in tpl_cm_navbar.php  line 10

<div class="collapse navbar-collapse" id="collapseCoreNav">

i added flex-wrap

which gets it like

image.png.cbbb81978596ff21ad4e09268145eb94.png

https://getbootstrap.com/docs/4.3/utilities/flex/#wrap 

Share this post


Link to post
Share on other sites

E.g. find the language file for the navbar module in admin->define languages e.g. modules/navbar_modules/nb_special_offers.php

add the span class to the following line so it looks like this

define('MODULE_NAVBAR_SPECIAL_OFFERS_PUBLIC_TEXT', '<a class="nav-link" href="' . tep_href_link('specials.php') . '"><i class="fas fa-fire"></i><span class="d-inline d-sm-none d-md-inline"> Bargains</span></a>');

We have a number of navbar modules in our shop, too much text caused display issues on ipad views so we changed <span class="d-inline d-sm-none d-md-inline"> to <span class="d-inline d-sm-none d-lg-inline"> so the text only shows on the hamburger list and on large and extra large views (desktop monitors).

Share this post


Link to post
Share on other sites

Problems with the code can be raised at Github as an issue please for a chit chat and steps to best resolution. 

The beauty of an open codebase is such that anyone who cares to can push fixes (after chatting to decide what path to take etc).


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
25 minutes ago, puddlec said:

i added flex-wrap

which gets it like 

Yes worked for me too. Thanks.

Edited by JcMagpie

 

Share this post


Link to post
Share on other sites

From this point forward, please only talk about;

http://template.me.uk/phoenix/

If you find a bug in your own installation, please recreate it on the Demo site (if you can, you might not be able to). 

Then post up screenshots / explanation of the Demo site, so that I know precisely what to and where to go to find it.

Thanks.

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Bugs that have been;

  • fixed

And bugs that are;

  • bogus

I have temporarily removed from this thread to try to keep the thread clean and easy to follow.

If you find a bug in your own installation of Phoenix, please try to recreate in the official Demo.  

After which please post screenshots etc.  This thread is Non-Technical so for code discussion, please use Github Issues.

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Please be aware that if you've made a post that you see as a bug..it may just disappear (temporarily) once it's been fixed in core.
If you want to have more chat about something that has disappeared...it's a Github Issue as that means it has gone "technical".

I do things this way to maximise the time I can give (remember that I do 99% of the heavy lifting) to making Phoenix better, moving forward day by day.

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Should anyone wish to see the proposed new layout for the checkout pages;

https://template.me.uk/phoenix/checkout_shipping.php

You'll obviously need an account and something in your cart to get there!

Please feel free to give constructive feedback. 

Do be aware that only the shipping and confirmation pages show the proposed new style, the rest are not yet converted.

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Much better Gary! Very compact and fewer colours.

My eyes should see as less of these bootstrap colours as possible.

Share this post


Link to post
Share on other sites
On 9/6/2019 at 8:39 AM, kgtee said:

When the shop allows free shipping above certain order value, the question asking customer to select a shipping method still crops up during checkout. This happens when there are more than one shipping modules installed. This question is redundant and should be able to be eliminated by rewriting the program logic.

I believe I have fixed this as a by-product of the checkout_shipping.php "prettification".  Could you check ? 

In the demo site I have 2 shipping methods, with the order_total "free shipping" if greater than $20 in cart.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
6 hours ago, burt said:

I believe I have fixed this as a by-product of the checkout_shipping.php "prettification".  Could you check ? 

In the demo site I have 2 shipping methods, with the order_total "free shipping" if greater than $20 in cart.

I just tried placing two orders; one below $20 and another greater than $20. Yes, it is fixed. Great job! @burt

Share this post


Link to post
Share on other sites
16 hours ago, kgtee said:

I just tried placing two orders; one below $20 and another greater than $20. Yes, it is fixed. Great job! @burt

Great, thank you for testing.  The improved checkout is likely to go into the next update (depends if I get it finished by the next scheduled update).


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

I believe all checkout pages are now running under the new "minimal" style;

https://template.me.uk/phoenix/index.php

To check out the checkout changes, you will obviously need to be logged in with something in cart...so that you can complete an order.

Feel free to offer constructive criticism, ask questions, point out broken things etc.

 

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
1 minute ago, azpro said:

Clean enough! Make it Modular?

It's not modular, it's just a rejig of the existing HTML.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×