Jump to content
burt

Phoenix, constructive feedback + bug hunting

Recommended Posts

46 minutes ago, rebelsheep said:

I have a copy of Frozen installed - can I just FTP the Phoenix files up and just overwrite the Fozen files (I'll just remod any files I modded in Frozen, in Phoenix).

Or do I have to wipe and do a complete reinstall (sigh)?

If you just FTP, you'll end up with orphan files (files in Frozen that are not in Phoenix). 
I suggest to (sigh) install a new Phoenix elsewhere and have a play with it before doing anything else.  


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
Just now, rebelsheep said:

Thank you, as always Burt - I'll do a fresh install.

Just to have a little play with.  Note that 1.0.1.0 will be out imminently, just waiting on finalised testing of one new feature, so may be worth waiting a short while.

Once you have had a play, start to replicate your changes from Frozen, and then when happy just import your products/categories & customers/orders etc.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Has any of the database fields / structure changed?

My existing Frozen site was in test stage anyway - so will remove existing site and copy the files to the same server / folder.

Just wanting to know if I do a fresh install, what will happen to the existing database?

Share this post


Link to post
Share on other sites

Which version of PHP will Phoenix run on stably?

I had Frozen running on PHP 7.1 as I understand that this was the max version of PHP that it was compatible with....  are we ok to move to PHP 7.3 yet?

Share this post


Link to post
Share on other sites

I've just upgraded to PHP 7.3. So far the latest version ( v1.0.1.0 ) of Phoenix works fine.

Is it possible to put in the 'read me' for the site code in GitHub exactly which versions of PHP Phoneix works with - as we go along and corrobate what works?

At the moment the read me specifys as Maximum of PHP 7.1.x.

More specific would be helpful... if this is practical.

What do others think?

Share this post


Link to post
Share on other sites
20 minutes ago, rebelsheep said:

What do others think?

I guess when enough people report it's OK an xyz version, that's the time to do that...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

I agree. At the moment 7.3 is ok for me.

This is from a fresh install of 1.0.0.4, then with v 1.0.1.0 added. I will let the community know if I run in to any problems.

Thank you for everyone's hard work in making this happen. As I learn more, I will try and contribute more.

Share this post


Link to post
Share on other sites

I'm doing all addon updates and development on a local PHP 7.3.2 installation with Phoenix 1.0.0.4 and since today 1.0.1.0  and no problems until now.

Share this post


Link to post
Share on other sites
19 minutes ago, rebelsheep said:

??

Of course, I didn't went through absolute all possible actions (but most), neither used all payment modules etc. Because of this until now.. impossible to give 100% guaranty for all theorical situations from my part....

Edited by raiwa

Share this post


Link to post
Share on other sites

I guess it might be useful to update the max version to 7.3, then if anyone on 7.3 finds issues they will probably report it.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
Quote

I guess it might be useful to update the max version to 7.3, then if anyone on 7.3 finds issues they will probably report it.

Good idea, the more current and relevant Phoenix can be, the better.

Share this post


Link to post
Share on other sites

Checking 1.0.1.0 you will find that most of the new shiopping_cart files contain bad characters probably due to cut and paste issue. All so far look to be in the copyright text so should not cause issues, but probably best to remove them.

image.png.d6218aa4cc64e49fe412627267956c8c.png

Edited by JcMagpie

 

Share this post


Link to post
Share on other sites

Thank You.

On 7/18/2019 at 2:15 PM, JcMagpie said:

Checking 1.0.1.0 you will find that most of the new shiopping_cart files contain bad characters probably due to cut and paste issue. All so far look to be in the copyright text so should not cause issues, but probably best to remove them.

image.png.d6218aa4cc64e49fe412627267956c8c.png

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Phoenix 1.0.1.0  Still has issues with tablet view. Only checked on 2 tabets but it looks like the old issue of display problems is still present. Would be helpfull is others can check also to confirm, tested on 10.5'' and 8" only andriod and mac os.

Issue is in portrait mode, As you can see PayPal image is bleading out side box. This looks to be an error in the coding as if you inspect the html genrated you see this.

<img src="images/card_acceptance/paypal_horizontal_large.png" alt="" class="" width="130" height="40">

As you can see the class is not populated! it should be using class="img-fluid" which would resize the images as the screen size changes.

Also side box's get so didtorted that text layot is broken. Would probably be better to introduce a new brake point to force portrait mode to act as a mobile device and show boxes as on phone's, landscape mode looks to be fine.

image.png.b99660215c8b0a185e1d8af3a9425943.png

image.png.403c11034ad7d7a0498488af0a7dfd9c.png


 

Share this post


Link to post
Share on other sites

This will need to be checked but a quick look at the /public_html/includes/functions/html_output.php  and adding the class to line 83 fixed the image issue

 $image = '<img class="img-fluid" src="' . tep_output_string($src) . '" alt="' . tep_output_string($alt) . '"';

html output  now is....

<img class="img-fluid" src="images/card_acceptance/paypal_horizontal_large.png" alt="" width="130" height="40">

As you can see the img-fluid class has been added and screeen display is now ok.

The alt is still unpopulated which is not good!, Not sure if this is the correct fix so use with caution or wait for an official fix.

image.png.25f345191a52db7a567875bcf97fa590.png

image.png

Edited by JcMagpie

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×