Jump to content
Latest News: (loading..)

Recommended Posts

Received the review request.  Awesome.  The data is correct too...name, date purchased, and item purchased....all good.

Dan

Share this post


Link to post
Share on other sites

Excellent thank you Guys - *much* appreciated. 

I'll clean up one piece of code and write a readme, and then get it out for you guys to have a play with...by end of tomorrow you'll have it.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
23 hours ago, burt said:

I believe this is now ready to test, if you are able to spend 5 minutes to create an account and perform a checkout I would greatly appreciate it:

 

Just ran a test order


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

@burt will this send the emails to who's accept  to get newsletters ? If yes then I think there is no problem with guest account (PWA) add-on because when you create account as guest there is no click box to accept the newsletters.. 

Share this post


Link to post
Share on other sites
23 minutes ago, Omar_one said:

@burt will this send the emails to who's accept  to get newsletters ? If yes then I think there is no problem with guest account (PWA) add-on because when you create account as guest there is no click box to accept the newsletters.. 

It sends to whoever the shopowner is targeting with the individual modules.  In the example modules I've come up with, that's all customers...

I am certain this system is the acorn that will grow into what CE will use for emails in the future.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
2 hours ago, altoid said:

Just ran a test order

The next activation (or perhaps the one after), you'll get;

  • testing123 (inserted via admin)
  • review_request (date changed from 60 days to 1 day)

Report back how they look?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
1 hour ago, Omar_one said:

@burt will this send the emails to who's accept  to get newsletters ? If yes then I think there is no problem with guest account (PWA) add-on because when you create account as guest there is no click box to accept the newsletters.. 

 

58 minutes ago, burt said:

It sends to whoever the shopowner is targeting with the individual modules.  In the example modules I've come up with, that's all customers...

PWA uses an additional column in the customers table to flagg guest accounts (the ones which didn't have been auto deleted because the customer didn't finish correct on checkout_success.php).

So to avoid sending e-mails to guest customers, shopowners can just add to the queries the condition:

AND c.customers_guest != '1'

or this could be used generic for all shops:

AND (EXISTS (SELECT c.customers_guest FROM customers c) AND c.customers_guest != '1')

I didn't check the code, but it should do it.

Edited by raiwa

Share this post


Link to post
Share on other sites
2 hours ago, burt said:

The next activation (or perhaps the one after), you'll get;

  • testing123 (inserted via admin)
  • review_request (date changed from 60 days to 1 day)

Report back how they look?

Received 4 and all's looking very nice.  


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

Code has gone out to two testers.  Depending on feedback given over the next week or two, should see this system into the wild.

It's close...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Gary I ran into an issue with the sql lines....

date_added datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,

that ran okay on one of my databases but not on another. 

The error given was...

#1067 - Invalid default value for 'date_added'

I googled that and it suggested that I needed to change the datetime to TIMESTAMP.  I tried that and it created the tables but I haven't gone any further yet.  I'll do that but in the meantime I thought I'd post my experience with the sql query while I remembered what happened and what I did.

Okay I'm off to check out the admin area.

Dan 

 

 

Share this post


Link to post
Share on other sites
41 minutes ago, Dan Cole said:

Okay I'm off to check out the admin area.

Great, thanks - please email me any feedback ...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
5 hours ago, Dan Cole said:

Why 4?

Dan

Looks like a welcome, order process, review request and a "test email"


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

Yes - the system does not yet replace the usual outgoing emails - but I am certain, in the near
future, something like this system has to be put in place for all emails.   

Template-able Emails - it has to be the future!


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Whilst I have not seen what you are doing I have been following this thread with anticipation for anything better than is originally available. It sound like you are getting somewhere Gary. Well done.

I would love to see a system where order status update emails could be written specifically for the update status replacing the standard 'your order has been upgraded to' emails. And the same with the 'new customer' or other emails. They are all a bit plain and do nothing for future sales.

Like I say, cant wait to see where this leads as it sounds good.


REMEMBER BACKUP, BACKUP AND BACKUP

Before installing the official version of oscommerce first look at a responsive version here

It's very easy to over complicate what are simple things in life

Share this post


Link to post
Share on other sites
17 hours ago, Dan Cole said:

Gary I ran into an issue with the sql lines....

date_added datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,

that ran okay on one of my databases but not on another. 

The error given was...

#1067 - Invalid default value for 'date_added'

I googled that and it suggested that I needed to change the datetime to TIMESTAMP.  I tried that and it created the tables but I haven't gone any further yet.

Do you mean "the DEFAULT change to TIMESTAMP"? datetime should still be a valid field type, shouldn't it? CURRENT_TIMESTAMP appears to be a more recent addition to MySQL -- is the failing database a much older version? I think the intent is that it acts like INSERT INTO with a now() value, but it can now be defaulted to do that. For older MySQL versions, it won't work, and you may have to explicitly give a now() in the VALUES list. That, or declare a minimum MySQL version number.


If you are running the "official" osC 2.3.4 or 2.3.4.1 download, your installation is obsolete! Get (stable) Frozen or (unstable) Edge. See also the naming convention and the latest community-supported responsive "Edge" release

Share this post


Link to post
Share on other sites
1 hour ago, MrPhil said:

Do you mean "the DEFAULT change to TIMESTAMP"? datetime should still be a valid field type, shouldn't it? CURRENT_TIMESTAMP appears to be a more recent addition to MySQL -- is the failing database a much older version? I think the intent is that it acts like INSERT INTO with a now() value, but it can now be defaulted to do that. For older MySQL versions, it won't work, and you may have to explicitly give a now() in the VALUES list. That, or declare a minimum MySQL version number.

It failed on the older database.  Versions as follows:

Database it failed on:
MySQL 5.5.52-MariaDB

Database where it work.
MySQL 10.2.22-MariaDB

Changing...

date_added datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,

to

date_added TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,

seems to have sorted it and the subsequent data seems identical.

Dan

 

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×