Jump to content

Recommended Posts

Are you checking what you are uploading?

I'm not sure taking your last one as an example

function execute() {
      global $oscTemplate, $product_info, $products, $manufacturer, $languages_id;
      
      $content_width = (int)MODULE_CONTENT_PI_STOCK_CONTENT_WIDTH;
      
      if (isset($_GET['products_id'])) {
        $manufacturer_query = tep_db_query("select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image, mi.manufacturers_url from " . TABLE_MANUFACTURERS . " m left join " . TABLE_MANUFACTURERS_INFO . " mi on (m.manufacturers_id = mi.manufacturers_id and mi.languages_id = '" . (int)$languages_id . "'), " . TABLE_PRODUCTS . " p  where p.products_id = '" . (int)$_GET['products_id'] . "' and p.manufacturers_id = m.manufacturers_id");
        if (tep_db_num_rows($manufacturer_query)) {
          $manufacturer = tep_db_fetch_array($manufacturer_query);
      
       if (tep_not_null($product_info['products_model'])) {
        $products_model = $product_info['products_model'];
      
      
      $product_description = stripslashes($product_info['products_description']);
      $products_quantity = stripslashes($product_info['products_quantity']);
      $products_name = stripslashes($product_info['products_name']);
      $products_url = stripslashes($product_info['products_url']);
      $products_gtin = stripslashes($product_info['products_gtin']);
      $products_seo_description = stripslashes($product_info['products_seo_description']);
      $products_seo_keywords = stripslashes($product_info['products_seo_keywords']);
      $manufacturers_image = stripslashes($manufacturer['manufacturers_image']);
       
      
        ob_start();
        include('includes/modules/content/' . $this->group . '/templates/tpl_' . basename(__FILE__));
        $template = ob_get_clean();

        $oscTemplate->addContent($template, $this->group);
      
    }
        }}}

What has all that stuff to to with the products model display ?

Please put at least some basic attention to what you are uploading

Share this post


Link to post
Share on other sites
    function execute() {
      global $oscTemplate, $product_info;

      $content_width = (int)MODULE_CONTENT_PI_STOCK_CONTENT_WIDTH;

      if (isset($_GET['products_id'])) {
        if (tep_not_null($product_info['products_model'])) {
          $products_model = $product_info['products_model'];

          ob_start();
          include('includes/modules/content/' . $this->group . '/templates/tpl_' . basename(__FILE__));
          $template = ob_get_clean();

          $oscTemplate->addContent($template, $this->group);
        }
      }
    }

 

Share this post


Link to post
Share on other sites

Sure thanks for pointing it out! I just used another module i had and changed the template file to do what I needed that's all. Feel free to upload an update or beter alternative.


 

Share this post


Link to post
Share on other sites

Its not the point about a "better alternative", its about your responsibility

If you like what you are producing, then you can keep doing and use it for your self.

Uploading for others to use, require at least some basic responsibility and attention

There is already more than enough crap in the addons area, lets try not to make it more, its in your hand

Share this post


Link to post
Share on other sites

You are not the first one here trying to promote your self as a "great contributor" and "active community member" while fishing for clients - trash talking at the same time other peoples work

Quote

Ουδέν κρυπτόν υπό τον ήλιον

Please correct the bad piece of code you uploaded. You are responsible for that
 

Share this post


Link to post
Share on other sites

As I said I'm not wasting my time with your nonsense HDLP is aware of what is happaning and has asked that behavior like this simply be ignored and reported. Which what i will be doing.


 

Share this post


Link to post
Share on other sites

I have enough proof for what I say.

What you do is a very bad business practice, however not relevant for the most

Only relevant point here and request fro my side is: Please correct the code you uploaded because it is simply not correct

Edited by multimixer

Share this post


Link to post
Share on other sites
26 minutes ago, valquiria23 said:

to move forward oscommere.

This kind of technical bad  quality uploads dont move Oscommerce forward,  it should be rejected.


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites

We can all make mistakes, the important thing is to warn in a friendly way and contribute to do the right thing without offending people who with their ideas and contributions try to move osommerce forward.

Share this post


Link to post
Share on other sites
18 minutes ago, Rwe said:

This kind of technical bad  quality uploads dont move Oscommerce forward,

The person it was made for was very happy with it! so if nothing else one person was happy.


 

Share this post


Link to post
Share on other sites
24 minutes ago, Rwe said:

This kind of technical bad  quality uploads dont move Oscommerce forward,  it should be rejected.

NONE OF US (me included) have the right to upload addons for "CE" to the "apps marketplace" (what used to be called addons area or contributions area) - we never have had that right, we (likely) never will have that right.   Only official osC is allowed...so it's extremely likely addons that are not directly for official osc...will be removed in the near future. 

Let the OP make his addons.  Hopefully when he gets advice to make them better...he'll listen.  We were all n00b-coders once upon a time.

 

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Unlike most of the contributors of this site who are here for commercial reasons (which is not bad) Zahid @JcMagpie does it for the love of Oscommerce and not for Sterling Pounds or Euros ...

He is not a professional programmer and he does it for the love of ocommerce ... and that is very important in differentiating.
It is easy to criticize, but much more difficult to give solutions.

I wish you all love and peace

Kiss

Valqui

Share this post


Link to post
Share on other sites
3 minutes ago, burt said:

Hopefully when he gets advice to make them better...he'll listen.  We were all n00b-coders once upon a time

Will allways listen to advice from people who know better than me, allways have and allways will. Hence update posted. It's the "you must go do it now" that I object to!

Also the add-on was done for someone who wanted fexability to add other bits into it at a later date! My mistake was uploading it in the same format, Oh well never mind.

As to uploading add-on, I have already spoken with HDLP and have his full support to keep producing and uploading my add-on's. If , no when I make mistakes and there will be many! I will do my best to rectify them as and when I have time, that is all I can offer.

And please I'll say it one more time I do NO paid work whatsoever ! Anyone stating otherwise is simply misleading people.


 

Share this post


Link to post
Share on other sites
56 minutes ago, Rwe said:

This kind of technical bad  quality uploads dont move Oscommerce forward,  it should be rejected.

The addon and its idea YES moves oscommerce forward. If there is an error or incorrect code, you can notify the author in a friendly way to solve it.

Share this post


Link to post
Share on other sites
19 minutes ago, JcMagpie said:

The person it was made for was very happy with it! so if nothing else one person was happy.

 If he knows about the quality of the addon, i dont think he is still happy.

maybe its a good idea to do a quality check on all of your uploads and make them better in case.

anyway when i see the recent addon section it starts to look for 99%  like a kindergarten of commercial useless  addons.

or is it just my opinion?


:heart: osCommerce

I am using osCommerce version 2.3.4.1 CE  Frozen

Get the latest Responsive osCommerce CE (community edition) here

 

Share this post


Link to post
Share on other sites
14 minutes ago, Rwe said:

maybe its a good idea to do a quality check on all of your uploads and make them better in case.

Thank you for your feedback as allways. You will see it has been updated.


 

Share this post


Link to post
Share on other sites
2 hours ago, burt said:

NONE OF US (me included) have the right to upload addons for "CE" to the "apps marketplace" (what used to be called addons area or contributions area) - we never have had that right, we (likely) never will have that right.   Only official osC is allowed...so it's extremely likely addons that are not directly for official osc...will be removed in the near future. 

Let the OP make his addons.  Hopefully when he gets advice to make them better...he'll listen.  We were all n00b-coders once upon a time. 

 

Sorry if I don't understand fully. Please, I only try to understand:

1.- Are the CE compatible  addons  banned here? I see a lot of good, usefull, interesting ones in the addoms area being the 'blood' of this almost catatonic project. With good people trying 'go forward' this project.

2.- Doing only addons for the  official 2.3.4.1 is as usefull as make  adons for a Spectrum... or for 2.2...

4.- You, with your HUGE work (with a few colleages) make a 'fresh' update with CE. You said in another places here, that is not official but 'allowed'. Why cut the few people that try to help with addons for 'your' CE version? If someone delete the addons for CE may be he will be correct in the terms but also it will killing the few energy remaining here of people like you, like waiwa, like Jack_cms, etc. etc.

5.- Bad coding: I learned PHP and, I''m sure,  the same of a lot of the rest, reading the  oscommerce code. I see good and usefull addons uploaded. Others so so good and/or interesting according my point of view. The autors need to take care of their 'sons' and the rest of us may ask for issues, new features, technical questions, etc. I think that it's not good to create factions and war againts one to others. Can someone of us confirm us that, when uploading, he discover that there are a mistake and he was forced to re-upload this. A lot of cases with gentle people that in a constructive way inform to the developer or someone that detect a bug in the code.. I'm wrong?!?

6.- I agree with Rwe that the adoms area need a 'rebuild'... but I KNOW that Burt and NONE OF US here can do it... This is the IMPORTANT THING, the sad thing, the impotent thing....

Me, as the rest of you, LOVE oscommerce.

We are less and less people remaining here every day...

Can we be at least to be polite? Can we be constructive?

+1 peace, love, PATIENCE.


Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

No pierdas el tiempo. Si quieres usar la versión más estable de osCommerce (la realizada por la comunidad, que además es 'responsive', la 2.3.4.1BS Edge) pincha aquí y aquí para descargarte el idioma Español.

Share this post


Link to post
Share on other sites
12 minutes ago, Antonio Garcia said:

Are the CE compatible  addons  banned here?

I had response from HDLP only a few days ago saying he is happy for add-on to be uploded and is happy to see new ones being added.

 

 


 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×