Feedback please

wvmlt · May 27, 2003

I've optomized my images to cut down on load time plus I keep the featured products and specials to a minimum. All feedback and any suggestions are appreciated. I especially need feedback on loading time from dial-up users.

Ajeh · May 27, 2003

Speeds nice ... DSL and just 1/2 mile away from the switching station ... 8)

Need to widen your columns just a bit or shrink the font. Shopping Cart is wrapping and distorts the box header.

daithi · May 27, 2003

well done.

would love a copy of your allprods.php.

wvmlt · May 27, 2003

Thanks for the feedback.

Linda, which columns and fonts are you speaking of?

The allprods came from this thread http://www.oscommerce.com/forums/viewtopic.php...hlight=allprods

read through the entire thread, as it gets changed about in the middle.

May 27, 2003

Linda means the infobox width, it is currently set @ 145 wide you need to look in the thema_boxes file for dezina_dove.

At the bottom of the file you will see

define('BOX_WIDTH', 145); // how wide the boxes should be in pixels (default: 125)

Set it to 165.

Also you can try this allprods file to go with the theme if you want, it uses the same look :?

<?php

/*

 $Id: allprods.php,v 1.7 2002/12/02



 osCommerce, Open Source E-Commerce Solutions

 http://www.oscommerce.com



 Copyright (c) 2002 osCommerce

 Copyright (c) 2002 HMCservices



 Released under the GNU General Public License

*/



 require('includes/application_top.php');

?>

<!doctype html public "-//W3C//DTD HTML 4.01 Transitional//EN">

<html <?php echo HTML_PARAMS; ?>>

<head>

<meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> 

<?php

// BOF: WebMakers.com Changed: Header Tag Controller v1.0

// Replaced by header_tags.php

if ( file_exists(DIR_WS_INCLUDES . 'header_tags.php') ) {

 require(DIR_WS_INCLUDES . 'header_tags.php');

} else {

?> 

 <title><?php echo TITLE ?></title>

<?php

}

// EOF: WebMakers.com Changed: Header Tag Controller v1.0

?>

<base href="<?php echo (getenv('HTTPS') == 'on' ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>">

<link rel="stylesheet" type="text/css" href="<? echo THEMA_STYLE;?>">

</head>

<body marginwidth="0" marginheight="0" topmargin="0" bottommargin="0" leftmargin="0" rightmargin="0">

<!-- header //-->

<?php require(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/thema_header.php'); ?>

<!-- header_eof //-->



<!-- body //-->

<center>

<table border="0" width="<?php echo SITE_WIDTH; ?>" cellspacing="3" cellpadding= "3" class="centerTable">

 <tr>

<?php require(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/thema_column_left.php'); ?>

<!-- body_text //-->

   <td width="100%" valign="top"><table border="0" width="100%" cellspacing="0" cellpadding="2">

     <tr>

       <td width="100%"><table border="0" width="100%" cellspacing="0" cellpadding="0">

         <tr>

           <td class="pageHeading">All Products</td>

           <td align="right"></td>

         </tr>

       </table></td>

     </tr>



     <tr>

       <td><table border="0" width="100%" cellspacing="0" cellpadding="2">



            <?php

   $languages_query = tep_db_query("select name, code, image, directory from " . TABLE_LANGUAGES . " WHERE languages_id = $languages_id order by sort_order");

   while ($languages = tep_db_fetch_array($languages_query)) {

   $languages_array[] = array('id' 	 => $languages['languages_id'],

        'name'  => $languages['name'],

                                     'code'  => $languages['code'],

                                     'image'  => $languages['image'],

                                          'directory'	=> $languages['directory']);

   }

           for ($i=0; $i<sizeof($languages_array); $i++) {    

             $this_language_id = $languages_array[$i]['id'];

   $this_language_name = $languages_array[$i]['name'];

   $this_language_code = $languages_array[$i]['code'];

   $this_language_image = $languages_array[$i]['image'];

   $this_language_directory = $languages_array[$i]['directory'];

?>



     <!--**************************-->

       <tr>

         <td>

<?PHP

$info_box_contents = array();

 $info_box_contents[] = array('align' => 'left', 'text' => '<b>' . HEADING_TITLE . '</b>');

 new infoBoxHeading($info_box_contents, true, true);

?>

<table border="0" width="100%" cellspacing="0" cellpadding="0" class="infoBox">

           <tr>

             <td align="left" width="<?php echo SIDE_BOX_LEFT_WIDTH; ?>" background="includes/classes/thema/<?php echo SITE_THEMA; ?>/infobox/box_bg_l.gif">

             <?php echo tep_image(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/infobox/box_bg_l.gif', 'box_bg_l.gif.'); ?>

             </td>

             <td>

             <table border="0" width="100%" cellspacing="0" cellpadding="3" class="infoBoxContents">

               <tr>

                 <td class="main">

                 <table border="0" cellspacing="0" cellpadding="2" align="right" width="100%" style="border-collapse: collapse" bordercolor="#111111">

<!--**************************-->



<?php

   echo tep_draw_form('search', 'allprods.php', '', 'get') . " <tr>n";

   echo "   <td class=main colspan="1">n";

   echo "     " . tep_image(DIR_WS_LANGUAGES . $this_language_directory . '/images/' . $this_language_image, $this_language_name);

   echo "   </td>n";

   echo "   <td class=main>n";

   echo "     " . tep_draw_pull_down_menu('categories_id', tep_get_categories(array(array('id' => '', 'text' => 'All Categories')))) . " <input type="submit" value="go">n";

   echo "   </td></form>n";

   echo tep_draw_form('search', 'allprods.php', '', 'get');



   echo "   <td class=main colspan='2'>n";

   echo "     " . tep_draw_pull_down_menu('manufacturers_id', tep_get_manufacturers(array(array('id' => '', 'text' => 'All Manufacturers')))) . " <input type="submit" value="go">n";

   echo "   </td></form>n";

   echo " </tr>n";

   echo " <tr>n";

?>

      <tr class="productListing-heading"> 

       <td align="left" class="productListing-heading" colspan="2">Product Name</td> 

      <td align="left" class="productListing-heading">Model</td> 

      <td align="right" class="productListing-heading">Price  </td> 

      </tr>

<?php

            if ($HTTP_GET_VARS['categories_id'])  // Categories Filter 

           { 

                     $products_query = tep_db_query("SELECT s.specials_new_products_price, p.products_id, p.products_model, p.products_price, pd.products_name FROM " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " pc LEFT JOIN " . TABLE_SPECIALS . " s ON p.products_id=s.products_id WHERE p.products_id = pd.products_id AND p.products_status = 1 AND p.products_id = pc.products_id AND pc.categories_id = '" . $HTTP_GET_VARS['categories_id'] . "' AND pd.language_id = $languages_id ORDER BY pd.products_name"); 

           } 

           elseif 



($HTTP_GET_VARS['manufacturers_id']) { 

$products_query = tep_db_query("SELECT m.manufacturers_id, p.manufacturers_id, s.specials_new_products_price, p.products_id, p.products_model, p.products_price, pd.products_name FROM " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd LEFT JOIN " . TABLE_SPECIALS . " s ON p.products_id=s.products_id, " . TABLE_MANUFACTURERS . " m WHERE p.products_id = pd.products_id AND p.products_status = 1 and p.manufacturers_id = m.manufacturers_id and m.manufacturers_id = '" . $HTTP_GET_VARS['manufacturers_id'] . "'  AND pd.language_id = $languages_id ORDER BY pd.products_name");



} else { 

           $products_query = tep_db_query("SELECT s.specials_new_products_price, p.products_id, p.products_model, p.products_price, pd.products_name FROM " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd LEFT JOIN " . TABLE_SPECIALS . " s ON p.products_id=s.products_id WHERE p.products_id = pd.products_id AND p.products_status = 1 AND pd.language_id = $languages_id ORDER BY pd.products_name"); 

}

                         

                     //$products_query = tep_db_query("SELECT p.products_id, p.products_model, p.products_price, pd.products_name FROM " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd WHERE p.products_id = pd.products_id AND p.products_status = 1 AND pd.language_id = $languages_id ORDER BY pd.products_name"); 

           $products_array = array(); 

           while($products = tep_db_fetch_array($products_query)) 

           { 

              $products_array[] = array('id'      => $products['products_id'], 

                            'name'    => $products['products_name'], 

                            'model'   => $products['products_model'], 

                            'price'   => $products['products_price'], 

                            'tax'     => $products['products_tax_class_id'], 

                            'special' => $products['specials_new_products_price']); 

           } 

             

           $num_prods = sizeof($products_array);  // This optimizes that slow FOR loop... 

             

           for ($i = 0; $i < $num_prods; $i++)    // Traverse Rows 

           { 

              // Rotate Row Colors 

              if ($i % 2)  // Odd Row 

              { 

                 $row_col = 'class="productListing-odd"'; 

              } 

              else   // Guess... 

              { 

                 $row_col = 'class="productListing-even"'; 

              } 

               

              $this_id = $products_array[$i]['id']; 

              $this_name = $products_array[$i]['name']; 

              $this_model = $products_array[$i]['model']; 

              $this_price = $products_array[$i]['price']; 

              $this_special = $products_array[$i]['special']; 

              $this_tax = $products_array[$i]['tax']; 

    $this_url = tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $this_id . '&language=' . $this_language_code . '&kill_sid=true', 'NONSSL', false);

               

              echo "<tr $row_col>"; 

              echo "<td class='productListing-data' align='left' colspan='2'><a href='$this_url'>$this_name</a></td>"; 

              echo "<td class='productListing-data' align='left'>$this_model</td>"; 

              if (tep_not_null($this_special)) 

              { 

                 echo "<td class='productListing-data' align='right'><span class='productSpecialPrice'>".$currencies->display_price($this_special, tep_get_tax_rate($this_tax))."</span></td>"; 

              } 

              else 

              { 

                 echo "<td class='productListing-data' align='right'>".$currencies->display_price($this_price, tep_get_tax_rate($this_tax))."</td>"; 

              } 

              echo "</tr>n"; 

           } 

        } 

       

?>                     <!--**************************-->

                 </table>

                 </td>

               </tr>

             </table>

             </td>

             <td align="right" width="<?php echo SIDE_BOX_RIGHT_WIDTH; ?>" background="includes/classes/thema/<?php echo SITE_THEMA; ?>/infobox/box_bg_r.gif">

             <?php echo tep_image(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/infobox/box_bg_r.gif', 'box_bg_r.gif.'); ?>

             </td>

           </tr>

         </table>

<?PHP

$info_box_contents = array();

 $info_box_contents[] = array('align' => 'left',

                               'text'  => ' '

                             );

 new infoBoxFooter($info_box_contents, true, true);

?>

         <!--**************************--></td>

       </tr>



           </td>

         </tr>

       </table></td>

     </tr>

     <tr>

   <td align="right" class="main"><br><?php echo '<a href="' . tep_href_link(FILENAME_DEFAULT, '', 'NONSSL') . '">' . tep_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE) . '</a>'; ?></td>

     </tr>

   </table></td>

<!-- body_text_eof //-->

   <td width="<?php echo BOX_WIDTH; ?>" valign="top" class="rightColumn"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2">

<!-- right_navigation //-->

<?php require(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/thema_column_right.php'); ?>

<!-- right_navigation_eof //-->

   </table></td>

 </tr>

</table>

<!-- body_eof //-->

<!-- footer //-->

<?php require(DIR_WS_CLASSES . 'thema/' . SITE_THEMA . '/thema_footer.php'); ?>

<!-- footer_eof //-->

</body>

</html>

<?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?

?>

Feedback please

Recommended Posts

wvmlt

Link to comment

Share on other sites

Ajeh

Link to comment

Share on other sites

daithi

Link to comment

Share on other sites

wvmlt

Link to comment

Share on other sites

Guest

Link to comment

Share on other sites

Archived

Browse

Activity