Simple Carousel header for Edge

[valquiria23 225]

Dear Zahid @JcMagpie

How can I hide the 3 circles of the carousel in this addon?

Simple Carousel header for Edge

https://apps.oscommerce.com/xa3f9&simple-carousel-header-for-edge

I need to hide them because if I put on the image text in that area those 3 horizintales circles get in the way....

Best regards
Valqui

 

[♥JcMagpie 1,689]

10 hours ago, valquiria23 said:

Dear Zahid @JcMagpie

How can I hide the 3 circles of the carousel in this addon?

Simple Carousel header for Edge

https://apps.oscommerce.com/xa3f9&simple-carousel-header-for-edge

I need to hide them because if I put on the image text in that area those 3 horizintales circles get in the way....

Best regards
Valqui

 

Simply edit------- public_html/includes/modules/content/header/templates/jccarousel.php

and comment out the following code.

<!--<ol class="carousel-indicators">
    <li data-target="#myCarousel" data-slide-to="0" class="active"></li>
    <li data-target="#myCarousel" data-slide-to="1"></li>
    <li data-target="#myCarousel" data-slide-to="2"></li>
  </ol>-->

 

tested on my site and works fine. They do look better without them.

https://tbyb.co.uk/

Edited June 24, 2018 by JcMagpie

[valquiria23 225]

thank you very much for your attention Zahid !!

I made the changes and it worked correctly. Thank you very much for your contributions to the community!

Greeting

Valqui

[♥raiwa 1,271]

Hello Zahid @JcMagpie,

It would be better to use tep_image functions for the image calls.

[♥JcMagpie 1,689]

Thank you @raiwa for your advice .

As others will maybe need more info on this perhaps you could explain the advantage of this over the simple html that I used?

I simply used this which most people will understand if they need to make changes.

<img src="images/<?php echo MODULE_CONTENT_HEADER_JCCAROUSEL_IMAGE1?>" alt="Image one">

The temp function is also quite simple.

tep_image(path_of_image, alt_tag_of_image, width_of_image, height_of_image);

which would change the code to somthing like this,

<?php

require('includes/application_top.php');

echo tep_image('images/' . 'MODULE_CONTENT_HEADER_JCCAROUSEL_IMAGE1', "Image one");

?>

Would be interesting to know the benefits gained on a simple 3 line add-on like this?

As always happy to learn and improve.

Edited December 14, 2018 by JcMagpie

[♥raiwa 1,271]

- compatibility with add-ons using the tep_image function to auto generate thumbnails like KissIt image thumbnailer

- ensure images are responsive (responsive image class is auto added)

- following oscommerce coding guidelines

- auto include title and alt from the second parameter

- shows nothing instead of broken image pic if image is not available

 

Another big improvement would be to use the built in banner functionality for the images.

 

[♥JcMagpie 1,689]

I'm sure you are correct. Thank you.