ArtcoInc Posted June 1, 2018 Share Posted June 1, 2018 Since Frozen is just that ... 'frozen', and any new development is being done on 'Edge', I propose posting any bugs and/or fixes for Frozen here. This will allow shop owners that are using Frozen to patch their shop as bugs are identified and fixed. I'll start: In the Also Purchased module ... There is a tiny mistake in cm_pi_also_purchased.php. Line 62 has "Enable Reviews Module" instead of "Enable Also Purchased Module". Link to comment Share on other sites More sharing options...
PiLLaO Posted June 1, 2018 Share Posted June 1, 2018 Yesterday I was thinking about this :) Link to comment Share on other sites More sharing options...
Jack_mcs Posted June 2, 2018 Share Posted June 2, 2018 I've been thinking of doing the same. Here are some changes that should be made (not all are mistakes): 1 - In includes/modules/content/product_info\templates/tpl_cm_pi_price.php, the variables in sprintf are in the wrong order. Change <h2 class="h3 text-right-not-xs"><?php echo (tep_not_null($specials_price)) ? sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY_SPECIAL, $specials_price, $products_price) : sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY, $products_price); ?></h2> to <h2 class="h3 text-right-not-xs"><?php echo (tep_not_null($specials_price)) ? sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY_SPECIAL, $products_price, $specials_price) : sprintf(MODULE_CONTENT_PI_PRICE_DISPLAY, $products_price); ?></h2> 2 - In languages/create_account_success.php change priviledges to privileges. 3 - In languages/shopping_cart.php change two instances of "don't" to "don\'t". 4 - In languages/shopping_cart.php change "immediate deliver" to "immediate delivery". 5 - In includes/application_top, add the deprecated flag to prevent future warnings and disable display errors since it is a security hole by changing error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT); to error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_DEPRECATED); ini_set('display_errors','0'); 6 - In includes/template_top.php, change the version number to the current one because some icons being used won't work in V 5.0.6. <script defer src="https://use.fontawesome.com/releases/v5.0.6/js/all.js"></script> to <script defer src="https://use.fontawesome.com/releases/v5.0.9/js/all.js"></script> Support Links: For Hire: Contact me for anything you need help with for your shop: upgrading, hosting, repairs, code written, etc. All of My Addons Get the latest versions of my addons Recommended SEO Addons Link to comment Share on other sites More sharing options...
♥raiwa Posted June 2, 2018 Share Posted June 2, 2018 13 minutes ago, wHiTeHaT said: if switch to php 7.X many undefined constants. This doesn't help too much. You should tell us which and the fixes. About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted June 2, 2018 Share Posted June 2, 2018 This is not a fix for a coding bug, but a good praxis improvement: customer creates account customer fills in a wrong state name which doesn't match any database state name error is thrown "please select a state from the drop down menu" the first alphabetic state is selected by default customer doesn't pay attention and the first default state is submitted solution: add "Please select" as default to the menu create_account.php, address_book_details.php, checkout_new_address.php: change: if ($entry_state_has_zones == true) { $zones_array = array(); to: if ($entry_state_has_zones == true) { $zones_array = array(array('id' => '', 'text' => PULL_DOWN_DEFAULT)); About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted June 2, 2018 Share Posted June 2, 2018 all others post the fixes, but ok, you are right in the strict sense About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 2, 2018 Share Posted June 2, 2018 10 hours ago, wHiTeHaT said: Here we go, continued project:https://github.com/osc2nuke/oscommerce-2.3.4.1-CE issues:https://github.com/osc2nuke/oscommerce-2.3.4.1-CE/issues excellent that saves me the bother! ...but I think it's going to mess up people's github projects with merge issues if it's not another fork of the same ancestor. I'll have a go and we'll see what happens Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 2, 2018 Share Posted June 2, 2018 I guess there's going to be a bit of self-moderating going on then Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
ArtcoInc Posted June 2, 2018 Author Share Posted June 2, 2018 As a store owner, I don't want to have to visit Github (or wherever) to see if there are any patches I need to apply to my live store(s). For me, I was very happy when Edge/Final/Frozen was 'finished'. That's not to say that there aren't any bugs still in it. That's the reason for this thread ... a place to document bugs, and hopefully fixes. I am also pleased that development is still happening. Keep it up, guys. Use this thread as a source of information to improve your forks. But please, for this thread, let's keep it just for Edge/Final/Frozen, ok? Link to comment Share on other sites More sharing options...
CGhoST Posted June 4, 2018 Share Posted June 4, 2018 With the latest final/frozen anyone else having problems with the site jerking on refresh? Does for a second but on every refresh the site jumps to the right and back. Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 4, 2018 Share Posted June 4, 2018 5 hours ago, CGhoST said: With the latest final/frozen anyone else having problems with the site jerking on refresh? Does for a second but on every refresh the site jumps to the right and back. @CGhoST On all pages? What modules do you have enabled? Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 I belive its always done this, you get what looks like a jerk but its just the switch from text to images on refresh. This (link) is fresh install of frozen with no addons ot tinkering. On refresh the logo is replaced with text for a micro second before returning to logo which gives a jerking effect. Unless you are seeing somethig diferent? http://www.justfastfood.com/ Link to comment Share on other sites More sharing options...
CGhoST Posted June 4, 2018 Share Posted June 4, 2018 @JcMagpie Thats exactly what happens. I installed a previous one from september or so last year and that does not do it. Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 4, 2018 Share Posted June 4, 2018 What Zahid described, every website does. @CGhoST pm me your url Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 Hmmm.. I just checked an old site I have which was built on Gold a very early BS and it behaves the same way. Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 Sorry your in good hands with John. Link to comment Share on other sites More sharing options...
CGhoST Posted June 4, 2018 Share Posted June 4, 2018 @BrockleyJohn On this link provided by JcMagpie http://www.justfastfood.com/ when you click on oscommerce image and the page refreshes you can see the breadcrumb jerking and the navbar jerking. In my older edge site it doesnt do that. There is no jerkiness. Edit: I dont have a link as its on localhost Link to comment Share on other sites More sharing options...
♥raiwa Posted June 4, 2018 Share Posted June 4, 2018 I would say thats normal. You see the image's alt text until the images are loaded. It may be more or less noticeable depending if you have the images already in cache or not, if they are bigger or smaller and the speed of your connection and server response. About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 4, 2018 Share Posted June 4, 2018 If you're experiencing jerking in the navbar, it's going to be the fontawsome icon causing it. There is a different version of fontawesome in CE since last September, and they are now vector graphics. Perhaps it's the speed with which your browser handles vector graphics; I don't have a noticeable flicker. If you fix a width for .fa-home in your user.css, the rest of the navbar won't move. Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 This is happening on most images in CE, look at any product info page and on refresh parts jumps about on image refresh. http://www.justfastfood.com/product_info.php?products_id=28 Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 Would these methods make it better? http://aspiringwebdev.com/stop-your-web-pages-from-jumping-around-while-images-load/ Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 4, 2018 Share Posted June 4, 2018 The navbar movement is likely to be visible on mobile; the rest probably not. I'd stick with fixing that if it bothers you. If you want to eliminate content moving altogether, you'll need site-specific solutions and lots of core changes. IMO CE does it very little and your time would be better spent investing in good content and SEO. As far as user experience is concerned, loading in a fraction of the time of a wordpress site is much more significant. However, if you want to set the minimum height of the gallery container to stop the buttons at the bottom of the product page moving, you can do it in user.css with media queries for the various layouts. Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 John, Setting .fa-home to a fixed width in user.css made no change, breadcrumb still jerks around. I used 50px 100px and 150px Link to comment Share on other sites More sharing options...
BrockleyJohn Posted June 4, 2018 Share Posted June 4, 2018 Ok needs something a bit cleverer ol.breadcrumb:first-child a { display: inline-block; width: 16px; } Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥JcMagpie Posted June 4, 2018 Share Posted June 4, 2018 5 minutes ago, BrockleyJohn said: Ok needs something a bit cleverer ol.breadcrumb:first-child a { display: inline-block; width: 16px; } Yes that defiantly stops the jerking on breadcrumb. But look what its done to it. Or have I missed somthing? Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.