Dan Cole Posted April 10, 2018 Share Posted April 10, 2018 @Moxamint Eddy at this point we are just taking what is and modularizing it but once it is finalized it will be very easy to duplicate and rename the wizards so you can add them to both the top and bottom of the checkout pages. Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 10, 2018 Author Share Posted April 10, 2018 5 hours ago, Moxamint said: Step Wizard - maybe should be allowed to show on BOTH top and bottom of the page like the pagnation numbers? 5 hours ago, Dan Cole said: once it is finalized it will be very easy to duplicate and rename the wizards so you can add them to both the top and bottom of the checkout pages. This is an example where 2 modules could use one and the same template file. See discussion: Can two modules use the same template? About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted April 10, 2018 Author Share Posted April 10, 2018 9 hours ago, ArtcoInc said: 4) Again, I may be missing something, but didn't you say you were going to add a Back button? Is this supposed to be on ALL of the pages? The back button has been added only to checkout_shipping/payment_address. It shows if the form submission for new address doesn't validate. it is like this until now in core and we just replicated. About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
BrockleyJohn Posted April 10, 2018 Share Posted April 10, 2018 In whose fork is the checkout development? Couldn't find it in @raiwa Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥raiwa Posted April 10, 2018 Author Share Posted April 10, 2018 2 minutes ago, BrockleyJohn said: In whose fork is the checkout development? Couldn't find it in @raiwa It's a separate repository for now: https://github.com/raiwa/Modular-Checkout About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
BrockleyJohn Posted April 10, 2018 Share Posted April 10, 2018 ok, ta! Contact me for work on updating existing stores - whether to Phoenix or the new osC when it's released. Looking for a payment or shipping module? Maybe I've already done it. Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x Link to comment Share on other sites More sharing options...
♥raiwa Posted April 10, 2018 Author Share Posted April 10, 2018 @burt, @Dan Cole, module/class names in checkout success and checkout shipping are the same. This breaks the installation. checkout_success/cm_cs_title checkout_shipping/cm_cs_title I suggest to change all checkout shipping modules/classes to "cm_csh_..." checkout_shipping/cm_csh_title About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
Dan Cole Posted April 11, 2018 Share Posted April 11, 2018 Makes sense to me. One of them needs to change. Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 @wHiTeHaT, Thank you for your suggestions and appreciations. But I believe they are off topic and should be posted in the developer proposals or main forum for 2.3.4 BS. In this project we just take and apply what is already defined and done in core. We do not pretend to change general architecture and naming conventions. I also do not understand the relation of my module control add-on whith this modular checkout project. Module control and slim checkout affects all module groups EXCEPT the main page content modules. About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 17 minutes ago, raiwa said: @wHiTeHaT, In this project we just take and apply what is already defined and done in core. We do not pretend to change general architecture and naming conventions. existing naming convention is abbreviation of main page name, not full name About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
burt Posted April 11, 2018 Share Posted April 11, 2018 12 hours ago, raiwa said: change all checkout shipping modules/classes to "cm_csh_..." Hmm, that's annoying. We could go with Henrys suggestion, and change up all the content stuff appropriately. account.php already does this;https://github.com/gburton/Responsive-osCommerce/tree/master/includes/modules/content/account Other pages do not. It should be a simple grep to find (eg) _i_ > _index_ I will try that and see if it changes everything approriately. Link to comment Share on other sites More sharing options...
azpro Posted April 11, 2018 Share Posted April 11, 2018 I favour Henrys suggestion because the naming of the modules allready gets harder to understand as more modules are introduced. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 filenames may get quite long: tpl_cm_checkout_shipping_address_new_shipping_address.php About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
burt Posted April 11, 2018 Share Posted April 11, 2018 4 minutes ago, raiwa said: filenames may get quite long: tpl_cm_checkout_shipping_address_new_shipping_address.php Yeah, I don't like that. Are we (or do we) bothered by thinking about the future ? This latest round of changes is for a final release. Bear in mind that no more pages after modular checkout are going to be modularised , other than potentially "shopping_cart.php". Thoughts (anyone)? Link to comment Share on other sites More sharing options...
azpro Posted April 11, 2018 Share Posted April 11, 2018 3 minutes ago, burt said: Are we (or do we) bothered by thinking about the future ? Yes - off course ... As a shopowner I would think some sort of upgrade outline / roadmap (even of it does not really exists) is very important. What is the way forward even if Official releases don't exist ... The community can keep development up as long as we agree on certain Defenitions / Guidelines. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 8 minutes ago, wHiTeHaT said: Assuming checkout_shipping.php cm_checkout_shipping_*.php in case of new address: cm_checkout_shipping_new_address.php for template would be tpl_checkout_shipping_new_address.php I think that makes sense Talking about checkout_shipping_address.php not checkout_shipping.php There are more module names and I believe we have to arrive to a general rule. tpl_cm_checkout_shipping_address_continue_button.php tpl_cm_checkout_shipping_address_address_book_entries.php tpl_cm_checkout_shipping_address_stepwizard.php About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
burt Posted April 11, 2018 Share Posted April 11, 2018 1 minute ago, azpro said: Yes - off course ... As a shopowner I would think some sort of upgrade outline / roadmap (even of it does not really exists) is very important. What is the way forward even if Official releases don't exist ... The community can keep development up as long as we agree on certain Defenitions / Guidelines. There won't be a way forward after Final is completed. That will be it. That's how I see it anyway. Link to comment Share on other sites More sharing options...
burt Posted April 11, 2018 Share Posted April 11, 2018 13 hours ago, raiwa said: I suggest to change all checkout shipping modules/classes to "cm_csh_..." How about cm_checkout_shipping_* I suppose it doesn't really matter as we have a mix anyway; i => index p_i => product_info account => account Link to comment Share on other sites More sharing options...
azpro Posted April 11, 2018 Share Posted April 11, 2018 1 minute ago, burt said: There won't be a way forward after Final is completed. That will be it. Well - I can's say that to my customers ... And I think / hope / believe that in one way or another development will go on! Off course I fully understand your position (that you want to finalize) .. So for your branch it is closingtime on Github .. But others might carry on developing! Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 2 minutes ago, burt said: How about cm_checkout_shipping_* I suppose it doesn't really matter as we have a mix anyway; i => index p_i => product_info account => account Chnging only checkout shipping and leave all others as they are? Not sure if this will be confusing: cm_checkout_shipping_continue_button.php but cm_csa_continue_button.php About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
burt Posted April 11, 2018 Share Posted April 11, 2018 Yeah, just go with cm_checkout_shipping_* and stop thinking so much What can hurt? Modules can be called anything... EG: take the navigation module and drop it into header. Turn it on, still works. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 ok less work , and it is nicer than cm_csh_.... ? About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 It will be: cm_csh_* - even adding one letter more, it is still an abbreviation and will not be confusing like a full name inside the same checkout page group - filenames will be shorter - it will work the same About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
♥Tsimi Posted April 11, 2018 Share Posted April 11, 2018 A bit late to the party but better late then never, right? Just installed this into the latest version of Edge from github. Everything works like a charm, well done. There is a small conflict however. The current Edge version uses already 2 checkout_shipping modules. One is a continue button and one is a Page header module. Not sure why those 2 modules are called checkout_shipping since they are only for the checkout success page. My guess is if this modularized checkout stuff makes it into the "final path" version then Gary will have to rename those 2 modules to avoid conflict. Link to comment Share on other sites More sharing options...
♥raiwa Posted April 11, 2018 Author Share Posted April 11, 2018 @Tsimi, Thank you, the last maybe 10 messages are about this subject and I just pushed the fix. About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.