Jump to content
Latest News: (loading..)

Recommended Posts

15 minutes ago, wHiTeHaT said:

@burt first pull request send, no core changes. It will already be an eye-opener for future code.

by just 2 lines.... not even lines lol!!!!!!!!!!!!!!!!!!!

Merged.  


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Loads of recent changes to index.php, so will this impact those ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@BrockleyJohn don't forget the install/oscommerce.sql changes for the index_products...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

The mayor impact for that content module is the usage of a new introduced class called "Products.php".

The purpose of this class is to get the corresponding data out of the other introduced classes.

(manufacturer, category) ....
Upcomming Specials class and Product class

(not mixup Product/Products classes ;) )

Another advantage is that, even that it looks complicated... feature improvements for "filtering" will be easier.
 

Share this post


Link to post
Share on other sites
5 minutes ago, wHiTeHaT said:

Keep in mind, pull-request #3 is putted on stage.

But i and many other will going ot be very happy...

It paves the way to url's like:
-index.php?Specials
-index.php?ContactUs
-index.php?ProductsNew
 

Oh.
I dont want to go down that road.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
Posted (edited)

You not have to, but other dev could if they want it.

There is no change to the default functionality.

What i try to say is.....
Because of the modularity, someone could make a module for the index (infact it could have already been done, just no one did it).

Don't get confused, nothing of the pull-request is anticipating on that.

But it just came to my mind it could.

 

Edited by wHiTeHaT

Share this post


Link to post
Share on other sites

What I want to do is get the Community Version to a "final" place.  I'm thinking; 

index (99% done), product_info (40% done) go modular 
php7.2 shop and admin (100% done, I think)

I've already nuked the bs4 idea, and will leave it at bs3.

After that, it's time for something new.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
3 hours ago, wHiTeHaT said:

$request ...............
Admin error-log page?
What do you think @burt @BrockleyJohn ... i would like to work on the class usage in the mean time?

I think we need to come to a consensus regarding the point at which we declare Final.  I don't want to be here 4 years from now...working on Edge. 
Or 4 months, or even 4 weeks...

What are your thoughts for a Final?  Also same question @BrockleyJohn 

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Consistency  - explain more ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

That future codes and add-ons are synchronously written.

Current requests to the database is in my point of view abnormal.
There are to much bm_'s , cm_'s and ht_'s that use same resources, but each of them make their own db request.
Template files of the  bm_'s , cm_'s and ht_'s should be only using vars, foreach and true/false and the html itself.
The constructors should not contain any html.

Introduction of classes and improved cache system can prevent that.

I also want to mention the languages. These ones are sometimes hurting.
They are a pain in the ass when it comes to maintain a website.
I personally hate it when i need to open several files and then these several files X the installed languages.
A site owner should be able to edit these within the back-end.

But that is perhaps something for later.

 

A final for me is a decent placeholder that takes out burdens and break-off walls preventing moving forward.

Share this post


Link to post
Share on other sites

For Final, my focus is stuff that is easy and further enables addons without changing core code (although if it's Final, what actually matters on this is ease of installation) ie.

- modularity as already proposed

- extra getContents etc

Plus the techy stuff that's largely covered. Is BS4 too big - or pointless without a considerable rewrite to use it?

I haven't looked at Henry's class stuff yet. On the whole classes are a good thing and lend themselves to adapting but it sounds more like opening a can rather than closing the lid on one. I'd like more time to think that through rather than try and do it in a rush.


For a new install or if your store isn't mobile-friendly, get the community-supported responsive osCommerce (2.3.4.1 CE) here: https://github.com/gburton/osCommerce-234-bootstrap/archive/master.zip

Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x

Share this post


Link to post
Share on other sites
5 minutes ago, BrockleyJohn said:

but it sounds more like opening a can rather than closing the lid on one

Never should have started then the community version and let have Harald do the work.
No one is getting hurt using :
 

			if (isset($_GET['manufacturers_id']) && !empty($_GET['manufacturers_id'])) {		
		        $osC_Manufacturer = new osC_Manufacturer(($_GET['manufacturers_id']));
				
				$heading = $osC_Manufacturer->getTitle();
				$description = $osC_Manufacturer->getDescription();
			} elseif ($current_category_id) {
				
				$heading = $osC_Category->getTitle();
				$description = $osC_Category->getDescription();
			}

in contrary to:
 

			if (isset($_GET['manufacturers_id']) && !empty($_GET['manufacturers_id'])) {
				$focusq = tep_db_query("select m.manufacturers_image, m.manufacturers_name as name, mi.manufacturers_description as description from manufacturers m, manufacturers_info mi where m.manufacturers_id = '" . (int)$_GET['manufacturers_id'] . "' and m.manufacturers_id = mi.manufacturers_id and mi.languages_id = '" . (int)$languages_id . "'");
				$focus = tep_db_fetch_array($focusq);
				$heading = $focus['name'];
				$description = $focus['description'];
			} elseif ($current_category_id) {
				$focusq = tep_db_query("select c.categories_image, cd.categories_name as name, cd.categories_description as description from " . TABLE_CATEGORIES . " c, " . TABLE_CATEGORIES_DESCRIPTION . " cd where c.categories_id = '" . (int)$current_category_id . "' and c.categories_id = cd.categories_id and cd.language_id = '" . (int)$languages_id . "'");
				$focus = tep_db_fetch_array($focusq);
				$heading = $focus['name'];
				$description = $focus['description'];
			}

If all future content modules keep going that way, no hosting provider would even allow to host a osCommerce anymore.

Share this post


Link to post
Share on other sites

Bootstrap v4

is not going to happen.  Too much work, not enough Community interest.  

Modularity:

Started on this from Day 1 of the Community Build. 
It's time to get it finished on the pages on which it's been started.
It's not a massive amount of work to get this done.

Classes:

Great, but opens up more work, eg changing coded modules to use classes. 

Personal Viewpoint:

I don't want to be doing any more coding after the end of April.  I really want to close the Community Version and just let people do what they want with it.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@wHiTeHaT Henry, I'm not saying I'm against classes now (yet!) and I share your concern over database hits.

I do take the general point. Modular implementation needs global thinking.


For a new install or if your store isn't mobile-friendly, get the community-supported responsive osCommerce (2.3.4.1 CE) here: https://github.com/gburton/osCommerce-234-bootstrap/archive/master.zip

Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x

Share this post


Link to post
Share on other sites
11 minutes ago, wHiTeHaT said:

You not have to code.
You only have to accept/deny the pull request.

:thumbsup:Sounds good.

The best way forward is, I think, to get the module bits done for the rest of index and product_info. 

After this:

Move the calls from db to class.

That way, the modules can be coded up, and all you/I/John will need to do is implement classes in them.

I'm not bothered about any "other stuff" at this point, as I just want to put a lid on this idea of "Edge".
If things are wrong...they can stay wrong.

Thoughts ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
1 hour ago, wHiTeHaT said:

Gary... all the schema stuff can be taken out?
Assuming all go be covered by ht_'s (i really hope that)

Almost impossible to do when it is a list of products...
Can you see a way to do it other than in the module output ?

For product_info...I moved it into a HT module already, but for pages where there is more than 1 product...I have not yet looked at.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×