Jump to content

Recommended Posts

Got another good one;

Just created a new box (copy of the information box) and a new page (copy of privacy page). If I hide all boxes for a page except my new one, as I may be doing for the new page, no boxes show on the site at all.

This is my boxes config

image.thumb.png.23b82cc9391d09991441a3745ade46d8.png

Uninstalled my box to see if that was the problem

image.thumb.png.8b97174825d4ded54a63a5cc2dbaf8ca.png

Also tested a combination of different boxes being on and off 

image.thumb.png.938b6d12381ddc495f514110cc82ce7e.png

It appears that if all boxes are off over a combination of pages then they are off for the entire site.

Share this post


Link to post
Share on other sites

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

Share this post


Link to post
Share on other sites
8 minutes ago, raiwa said:

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

I thought it was my changes at first but as I was testing to write the message I realised it wasn't. Happy to test when you find a fix.

Share this post


Link to post
Share on other sites

To add more confusion to this if you have 2 pages that between them hide all boxes but a 3rd page that hides non they show on the 3rd page.

Share this post


Link to post
Share on other sites

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.

// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

Share this post


Link to post
Share on other sites
On 10/17/2019 at 12:59 PM, LeeFoster said:

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.


// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

Share this post


Link to post
Share on other sites
4 minutes ago, raiwa said:

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

Just tested and seems to work.

Share this post


Link to post
Share on other sites

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×