Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.


raiwa

Recommended Posts

Got another good one;

Just created a new box (copy of the information box) and a new page (copy of privacy page). If I hide all boxes for a page except my new one, as I may be doing for the new page, no boxes show on the site at all.

This is my boxes config

image.thumb.png.23b82cc9391d09991441a3745ade46d8.png

Uninstalled my box to see if that was the problem

image.thumb.png.8b97174825d4ded54a63a5cc2dbaf8ca.png

Also tested a combination of different boxes being on and off 

image.thumb.png.938b6d12381ddc495f514110cc82ce7e.png

It appears that if all boxes are off over a combination of pages then they are off for the entire site.

Link to comment
Share on other sites

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

Link to comment
Share on other sites

8 minutes ago, raiwa said:

Yep, I could reproduce some glitch like this. I'll have a deeper look when I find some time.

I thought it was my changes at first but as I was testing to write the message I realised it wasn't. Happy to test when you find a fix.

Link to comment
Share on other sites

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.

// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

Link to comment
Share on other sites

On 10/17/2019 at 12:59 PM, LeeFoster said:

Removing this bit of code from osc_template.php fixes the issue but wanted to check it wasn't doing anything vital before making it a permanent fix.


// check if side columns are empty
      if (in_array(basename($PHP_SELF), $modules_exclude_array[$class])) {
        $this->_hide_column = count(array_intersect(array_keys($modules_exclude_array), str_replace('.php', '', explode(';', MODULE_BOXES_INSTALLED)))) == count(explode(';', MODULE_BOXES_INSTALLED));
      }

 

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

Link to comment
Share on other sites

4 minutes ago, raiwa said:

Hello Lee @LeeFoster,

I had a look and yes, all the side column control is not needed any more. Seems this is due to the BS4 column/layout dynamic behaviour.

I cleaned up the whole osc_template-php class file and it seems to work fine.

Please try and let me know. I'll then update also the admin page and upload the update with the fixes.

osc_template.php

Just tested and seems to work.

Link to comment
Share on other sites

Link to comment
Share on other sites

  • 7 months later...
26 minutes ago, LeeFoster said:

Doesn't appear to work on Phoenix 1.0.6.0

Not updated yet. It's on my list, but not on the top.

Link to comment
Share on other sites

28 minutes ago, LeeFoster said:

Any thing I can do to help?

Thanks. You could do the beta testing.

Link to comment
Share on other sites

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...