tmcca Posted September 3, 2017 Share Posted September 3, 2017 I am installing important add-ons that I feel should be part of the core. Any suggestions or fixes welcome Link to comment Share on other sites More sharing options...
Omar_one Posted September 3, 2017 Share Posted September 3, 2017 @tmcca I have this addon Credit Class, Gift Vouchers & Discount C installed with some modification on last osc 2.3 Edge and working well. Omar Get the latest Responsive osCommerce CE (community edition) here . Link to comment Share on other sites More sharing options...
burt Posted September 3, 2017 Share Posted September 3, 2017 The idea is not to add these ancient old addons... but instead to create a clean core suitable for drop in modules. Link to comment Share on other sites More sharing options...
burt Posted September 3, 2017 Share Posted September 3, 2017 I have also moved your topic into the correct Channel. And removed your Fork URL as it is unhelpful to further fragment the community. Link to comment Share on other sites More sharing options...
♥14steve14 Posted September 4, 2017 Share Posted September 4, 2017 On 9/3/2017 at 4:53 PM, tmcca said: I am installing important add-ons that I feel should be part of the core. Any suggestions or fixes welcome The whole trouble with adding code that you want to the core, means that it may be something that I dont want. I may need something different and it wont all get added. The whole idea is to keep the core code clean and simple and let people add easy to install one click addons for the functionality required by each store. When you think about it it makes more sense this way. Forget the old way of doing things, its in the past. REMEMBER BACKUP, BACKUP AND BACKUP Link to comment Share on other sites More sharing options...
tmcca Posted September 4, 2017 Author Share Posted September 4, 2017 true to that; Yeah I was looking into creating CCGV as a Module instead of editing core not sure how would do that; I am guessing to add a require to pages that need it. Link to comment Share on other sites More sharing options...
tmcca Posted September 4, 2017 Author Share Posted September 4, 2017 @omar_one do you have what you did for bootstrap? I am confused on checkout_payment as there is a javascript function do you keep that or remove it? Link to comment Share on other sites More sharing options...
Omar_one Posted September 4, 2017 Share Posted September 4, 2017 @tmcca The javascript function removed Get the latest Responsive osCommerce CE (community edition) here . Link to comment Share on other sites More sharing options...
tmcca Posted September 4, 2017 Author Share Posted September 4, 2017 @Omar_one anyway you can send me your checkout_payment? on your site is gift vouchers working? Link to comment Share on other sites More sharing options...
Omar_one Posted September 5, 2017 Share Posted September 5, 2017 @burt I think it had been rewritten for BS version but it have not pushed as addon.. but it still not a drop in modules.. and its true that the coders have to focus on creating a clean core suitable modules for drop in modules. Omar Get the latest Responsive osCommerce CE (community edition) here . Link to comment Share on other sites More sharing options...
Omar_one Posted September 5, 2017 Share Posted September 5, 2017 @tmcca here is the checkout_paymen.php file , I hope you or someone else will create CCGV as a Module instead of editing core. Omar checkout_payment.php Get the latest Responsive osCommerce CE (community edition) here . Link to comment Share on other sites More sharing options...
tmcca Posted September 5, 2017 Author Share Posted September 5, 2017 @Omar_one Yes I am looking into that like how Paypal is as an app. Some changes to core would be to require the actual app thats it. Also looking to add Store Credit option to use with RMA add on. As of now only Gift Vouchers or Store Credit can be used not both. Link to comment Share on other sites More sharing options...
burt Posted September 6, 2017 Share Posted September 6, 2017 23 hours ago, Omar_one said: @burt I think it had been rewritten for BS version but it have not pushed as addon.. but it still not a drop in modules.. and its true that the coders have to focus on creating a clean core suitable modules for drop in modules. Omar Any module that requires a core change...is OK to use, so long as the shopowner makes a note of what was changed and why it was changed. No problem. A potential problem comes when modules like these are inserted into a fork (where the fork is made by someone who cannot code)...and the fork is then advertised here in this forum. Link to comment Share on other sites More sharing options...
tmcca Posted September 6, 2017 Author Share Posted September 6, 2017 @burtTrue Burt how is bootstrap different on making Apps I see no OSC folder or is that coming? Link to comment Share on other sites More sharing options...
tmcca Posted September 6, 2017 Author Share Posted September 6, 2017 Also I made a pull request to update paypal did u see it? Link to comment Share on other sites More sharing options...
burt Posted September 6, 2017 Share Posted September 6, 2017 I did see it, thank you for the push. The Community Edition is at a "sleeping" phase until we see what is happening with the official release of 2.3.5 [last in the line of outdated 960] & 2.3.6 [first in the line of bootstrap] Link to comment Share on other sites More sharing options...
tmcca Posted September 6, 2017 Author Share Posted September 6, 2017 Actually I dropped it have to fix some things on it. Curious what would be better to download? 2.3.4.1? or bootstrap? I see the oscommerce2 github has OSC folder your don't. I am guessing this is the one in development. Link to comment Share on other sites More sharing options...
burt Posted September 7, 2017 Share Posted September 7, 2017 15 hours ago, tmcca said: Actually I dropped it have to fix some things on it. Curious what would be better to download? 2.3.4.1? or bootstrap? I see the oscommerce2 github has OSC folder your don't. I am guessing this is the one in development. You are looking at 2.4. 2.3 will never have an "OSC" folder (or put technically: namespaces). Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.