Jump to content
BrockleyJohn

[Addon] Store Times BS

Recommended Posts

11 minutes ago, YePix said:

that's how you do it

No, not really.
you could report an issue on the github repository, even could offer the bug fix.
Regardless if the repository owner accept your fix or not.... a link to your issue would have done the job.

( i encourage you to experiment , i know you have the potential............ i checked your work on the german CLUB, i speak and read ( mwa.... not really) fluent german..... i am 50% german).

Good Luck!!!!!!
PS:  i made the concept for the takeaway (pizzapizza) concept in laravel......... for multi-stores.
( if you are serious and have a range of potential cliënts......... we might can set up something in that area).

Edited by fridgebox

- ICECAT specialist.
(Icecat: open feed with product information, data-sheets for oscommerce.)
- CSV IMPORT specialist.
(manage your suppliers via supplier manager)
Contact me via PM.

Share this post


Link to post
Share on other sites

open the file "ht_store_times.php" in: catalog/includes/modules/header_tags/ folder

and search for the following code:

      if (defined('MOD_CON_HDR_STORE_TIMES_DIVERT_PAGES') && MOD_CON_HDR_STORE_TIMES_DIVERT_PAGES == 'True') {
        if (tep_not_null(MOD_CON_HDR_STORE_TIMES_CLOSE_PAGES)) {
          $pages_array = array();

          foreach (explode(';', MOD_CON_HDR_STORE_TIMES_CLOSE_PAGES) as $page) {
            $page = trim($page);

            if (!empty($page)) {
              $pages_array[] = $page;
            }
          }
        
          if (in_array(basename($PHP_SELF), $pages_array)) {
		        $store_status = sew_is_store_open();
            if ($store_status <> 'open' && $store_status <> 'open-override') tep_redirect('store_times.php');
          }
        }
      }
		}

replace this code with:

if (MODULE_CONTENT_HEADER_STORE_TIMES_STATUS == 'True') {  // new code for close the header_tags redirect
      if (defined('MOD_CON_HDR_STORE_TIMES_DIVERT_PAGES') && MOD_CON_HDR_STORE_TIMES_DIVERT_PAGES == 'True') {
        if (tep_not_null(MOD_CON_HDR_STORE_TIMES_CLOSE_PAGES)) {
          $pages_array = array();

          foreach (explode(';', MOD_CON_HDR_STORE_TIMES_CLOSE_PAGES) as $page) {
            $page = trim($page);

            if (!empty($page)) {
              $pages_array[] = $page;
            }
          }
        
          if (in_array(basename($PHP_SELF), $pages_array)) {
		        $store_status = sew_is_store_open();
            if ($store_status <> 'open' && $store_status <> 'open-override') tep_redirect('store_times.php');
          }
        }
      }
		}
} // new code for close the header_tags redirect

 

Edited by YePix

Share this post


Link to post
Share on other sites
19 minutes ago, YePix said:

what is so difficult to understand? did you install the addon "store times"?

not matter if i install it or not.

The module creator ( even that he does it wrong on github), took the effort to commit his code , with the option for YOU and ME and OTHERS to correct HIS code on GITHUB.
You ( as i assume you take yourself serious), should learn to use the correct channels for that.
you could have created an issue for it on there, when you made the issue, a link to the issue would be sufficient to know and understand and find out what the issue is, now it is just a fix in the dark. it only is here on the forum, yet your fix MUST be in the original code, for that GITHUB is a good place. ( do not be offended, i just try to learn you):
screenshot-github.com-2019_09.11-01_46_22.thumb.png.2aff5f674076d564a3b0ae1efeccb414.png


- ICECAT specialist.
(Icecat: open feed with product information, data-sheets for oscommerce.)
- CSV IMPORT specialist.
(manage your suppliers via supplier manager)
Contact me via PM.

Share this post


Link to post
Share on other sites

let it be good. Here is the forum and the corresponding posting to the addon. Everyone interested in this post has read and decides for yourself whether it will be used or not. here is oscommerce and not github. end of this discussion.

Share this post


Link to post
Share on other sites
3 minutes ago, YePix said:

et it be good. Here is the forum and the corresponding posting to the addon. Everyone interested in this post has read and decides for yourself whether it will be used or not. here is oscommerce and not github. end of this discussion.

NOPE not so EASY my friend , here you have the option to show your commitment, it's not that easy to paste a fix here in the forum if you are so RIGHT about it......... put it here 🙂 i told you i teach you.......... now do it the right way....... show your commitment........... your words............. not github............. oscommerce.............. here it is)
image.thumb.png.f553110e1ecb37bcd427c8a9bc14024f.png


- ICECAT specialist.
(Icecat: open feed with product information, data-sheets for oscommerce.)
- CSV IMPORT specialist.
(manage your suppliers via supplier manager)
Contact me via PM.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×