Latest News: (loading..)
mcmannehan

PayPal App v5.000

106 posts in this topic

The update today not working with PHP7. There still used the old class style. I did change to the new class style (__construct), now working with PHP7.

If some one need help for that, PM me. Thanks.

Edited by mcmannehan

Share this post


Link to post
Share on other sites

For those upgrading, if v4.039 worked, then v5.000 will also work fine.

 

For new installations that are getting deprecated notices, use the following error reporting level in includes/application_top.php and admin/includes/application_top.php:

 

 

// set the level of error reporting
  error_reporting(E_ALL & ~E_NOTICE);
 
  if (defined('E_DEPRECATED')) {
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED);
  }

 

The error reporting is set at the top of those files. The code block above will be present in v2.3.5 onwards.

Share this post


Link to post
Share on other sites

For those upgrading, if v4.039 worked, then v5.000 will also work fine.

 

For new installations that are getting deprecated notices, use the following error reporting level in includes/application_top.php and admin/includes/application_top.php:

// set the level of error reporting
  error_reporting(E_ALL & ~E_NOTICE);
 
  if (defined('E_DEPRECATED')) {
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED);
  }

The error reporting is set at the top of those files. The code block above will be present in v2.3.5 onwards.

 

i know, but i like to have clean PHP7 code. Thats why i change and it's working fine with PHP7.0 and PHP7.1.1

Share this post


Link to post
Share on other sites

:thumbsup:  Another update to the PayPal App will be pushed out soon that adds an option to force TLS v1.2 connections.

mcmannehan likes this

Share this post


Link to post
Share on other sites

:thumbsup:  Another update to the PayPal App will be pushed out soon that adds an option to force TLS v1.2 connections.

 

Cool, than i change the class files again and will check it's work or not.

Share this post


Link to post
Share on other sites

Harald, does the auto update change anything with regards to the Street2 part of the address being captured? It's just that I vaguely remember Jack altering our installation to make sure we got the second line in the address (often when Aussies put their town/suburb name).

 

Also, I wonder if you are able to comment on my recent post in the PayPal forum re: a customer being fed the incorrect shipping rates?

Share this post


Link to post
Share on other sites

Harald, does the auto update change anything with regards to the Street2 part of the address being captured? It's just that I vaguely remember Jack altering our installation to make sure we got the second line in the address (often when Aussies put their town/suburb name).

 

It will overwrite files that have been modified. Here is a list of changes that will be performed:

 

https://github.com/haraldpdl/oscom2_app_paypal/compare/23-4.039...23-5.000

 

Click on the Files Changed tab and then the "40 changed files" link to view the file listing.

 

I'll look at adding the suburb into SHIPTOSTREET2 in the upcoming update - this won't break existing installations. Could you get Jack to email me so we can go over the changes?

Share this post


Link to post
Share on other sites

Hi Harald, I think he may be busy as I'm waiting to hear back from him myself, hehe

 

Ty Greasemonkey!

Share this post


Link to post
Share on other sites

Incidentally, I think some customers put apartment numbers and all sorts of things in that slot, so it's worth adding in.

Share this post


Link to post
Share on other sites

It's a one click procedure. The App checks once every 24 hours if an update is available and displays a notice. A check is always performed on the Help/Info page.

 

The update procedure makes sure the file and directory permissions are sufficient for all files being updated before the files are overwritten.

 

Feel free to try on a backup beforehand.

vampirehunter likes this

Share this post


Link to post
Share on other sites

/catalog///includes/modules/payment/paypal_standard.php

 

Fatal error: Uncaught Error: Call to undefined method OSCOM_PayPal::getIdentifier() in catalog/includes/modules/payment/paypal_standard.php:363 Stack trace: #0 catalog/includes/classes/payment.php(173): paypal_standard->process_button() #1 /catalog/checkout_confirmation.php(292): payment->process_button() #2 {main} thrown in catalog/includes/modules/payment/paypal_standard.php on line 363

function paypal_standard() {
      global $PHP_SELF, $payment, $order;

      $this->_app = new OSCOM_PayPal(); <--- HERE
.................

and about line 363

      $parameters = array('cmd' => '_cart',
                          'upload' => '1',
                          'item_name_1' => STORE_NAME,
                          'shipping_1' => $this->_app->formatCurrencyRaw($order->info['shipping_cost']),
                          'business' => $this->_app->getCredentials('PS', 'email'),
                          'amount_1' => $this->_app->formatCurrencyRaw($order->info['total'] - $order->info['shipping_cost'] - $total_tax),
                          'currency_code' => $currency,
                          'invoice' => substr($cart_PayPal_Standard_ID, strpos($cart_PayPal_Standard_ID, '-')+1),
                          'custom' => $customer_id,
                          'no_note' => '1',
                          'notify_url' => tep_href_link('ext/modules/payment/paypal/standard_ipn.php', (isset($ipn_language) ? 'language=' . $ipn_language : ''), 'SSL', false, false),
                          'rm' => '2',
                          'return' => tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL'),
                          'cancel_return' => tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'),
                          'bn' => $OSCOM_PayPal->getIdentifier(), <--- ????
                          'paymentaction' => (OSCOM_APP_PAYPAL_PS_TRANSACTION_METHOD == '1') ? 'sale' : 'authorization');

Any ideas?

Edited by mcmannehan

Share this post


Link to post
Share on other sites

For me, the PayPal express checkout is not returning the correct shipping rates which have already been selected by the customer (I'm using the ship in cart module).  Where is this module pulling the shipping rates from?

Share this post


Link to post
Share on other sites

i did change back to PayPal App v4.039 because this work very well under php5.6 and php 7.0 and php 7.1.1 in sandbox mode

the PayPal App v5.000 is not working well in php5.6 and php 7.0 and php 7.1.1 in sandbox mode

 

i use flat shipping and the shipping rates are okay, but it's in sandbox mode

Edited by mcmannehan

Share this post


Link to post
Share on other sites

i did check again at my test shop with the flat shiping all is working well in sandbox mode

where you get the "ship in cart modul"? I think this modul is the problem.

Share this post


Link to post
Share on other sites

I try the follow resolution for the Paypal Api 5.000

 

find in /catalog//includes/modules/payment/paypal_standard.php

      $parameters = array('cmd' => '_cart',
                          'upload' => '1',
                          'item_name_1' => STORE_NAME,
                          'shipping_1' => $this->_app->formatCurrencyRaw($order->info['shipping_cost']),
                          'business' => $this->_app->getCredentials('PS', 'email'),
                          'amount_1' => $this->_app->formatCurrencyRaw($order->info['total'] - $order->info['shipping_cost'] - $total_tax),
                          'currency_code' => $currency,
                          'invoice' => substr($cart_PayPal_Standard_ID, strpos($cart_PayPal_Standard_ID, '-')+1),
                          'custom' => $customer_id,
                          'no_note' => '1',
                          'notify_url' => tep_href_link('ext/modules/payment/paypal/standard_ipn.php', (isset($ipn_language) ? 'language=' . $ipn_language : ''), 'SSL', false, false),
                          'rm' => '2',
                          'return' => tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL'),
                          'cancel_return' => tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'),
                          'bn' => $OSCOM_PayPal->getIdentifier(),
                          'paymentaction' => (OSCOM_APP_PAYPAL_PS_TRANSACTION_METHOD == '1') ? 'sale' : 'authorization');

and change to

      $parameters = array('cmd' => '_cart',
                          'upload' => '1',
                          'item_name_1' => STORE_NAME,
                          'shipping_1' => $this->_app->formatCurrencyRaw($order->info['shipping_cost']),
                          'business' => $this->_app->getCredentials('PS', 'email'),
                          'amount_1' => $this->_app->formatCurrencyRaw($order->info['total'] - $order->info['shipping_cost'] - $total_tax),
                          'currency_code' => $currency,
                          'invoice' => substr($cart_PayPal_Standard_ID, strpos($cart_PayPal_Standard_ID, '-')+1),
                          'custom' => $customer_id,
                          'no_note' => '1',
                          'notify_url' => tep_href_link('ext/modules/payment/paypal/standard_ipn.php', (isset($ipn_language) ? 'language=' . $ipn_language : ''), 'SSL', false, false),
                          'rm' => '2',
                          'return' => tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL'),
                          'cancel_return' => tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'),
                          //'bn' => $OSCOM_PayPal->getIdentifier(),
                          'bn' => 'osCommerce_PPapp_v5',
                          'paymentaction' => (OSCOM_APP_PAYPAL_PS_TRANSACTION_METHOD == '1') ? 'sale' : 'authorization');

I did test with PHP5.6 and PHP7.1.1 and it's not working in sandbox mode

Paypaly said you paid already and if i go back to the shop, the shop show a message:

 

Could not verify the PayPal transaction. Please try again.

 

The /catalog/includes/apps/paypal/OSCOM_PayPal.php isn't included and if you check the path, than there show you

/catalog/includes/modules/payment/OSCOM_PayPal.php

 

There is some issue to load the OSCOM_PayPal.php from the correct path.

 

I think the Paypal Api 5.000 isn't ready for production shop, so i still use the v4.039 because its working very well

 

Devlopment of osC please check it and fix it. Thank you!

Edited by mcmannehan

Share this post


Link to post
Share on other sites

@@Harald Ponce de Leon sorry to put this here but all my Pay Pal EC transactions are starting to log callbackresponses in the log immediately after them. This was never happening before, just started happening and some customers are abandoning carts. I haven't updated to this latest version as I'm waiting for the street2 thing to happen.

Share this post


Link to post
Share on other sites

While all product costs, taxes, shipping etc. are displayed correctly in OSC, the VAT is missing (sales tax: 0.00€) on the Paypal site (order details). Both in the customer's and seller's Paypal account !!?? The total paid and received is correct..

Share this post


Link to post
Share on other sites

I noticed that the ability to delete an order through the admin is no longer there after installing this PayPal app. Any plan to add that back?

Share this post


Link to post
Share on other sites

/catalog///includes/modules/payment/paypal_standard.php

 

Fatal error: Uncaught Error: Call to undefined method OSCOM_PayPal::getIdentifier() in catalog/includes/modules/payment/paypal_standard.php:363 Stack trace: #0 catalog/includes/classes/payment.php(173): paypal_standard->process_button() #1 /catalog/checkout_confirmation.php(292): payment->process_button() #2 {main} thrown in catalog/includes/modules/payment/paypal_standard.php on line 363

Thanks for pointing this out! This has been fixed in v5.0.1 - to apply it, visit the Info/Help page and the update notice should appear.

mcmannehan likes this

Share this post


Link to post
Share on other sites

Thanks for pointing this out! This has been fixed in v5.0.1 - to apply it, visit the Info/Help page and the update notice should appear.

 

Harald, you are very welcome!!! I hope the other issue will fixed too.

Share this post


Link to post
Share on other sites

While all product costs, taxes, shipping etc. are displayed correctly in OSC, the VAT is missing (sales tax: 0.00€) on the Paypal site (order details). Both in the customer's and seller's Paypal account !!?? The total paid and received is correct..

 

your "ship in cart modul" is the problem.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now