rudolfl Posted December 24, 2016 Share Posted December 24, 2016 Hi, Some cleanup is required as W3C validation fails. Yes, I know it is minor, but I hate errors and warnings -- sometime they can hide deeper underlying issues. 1. Header Tags "noscript" module adds html code inside <head>. This module should be separated from generic header tags as generic tags loaded inside <head> in template_top.php May new set of similar modules ("body_tags") is required to allow modues to be included in the body? noscript should be part of that. I can imagine other functionality that can be part of it. Or, perhaps, modify header tags mechanism to allow for more precise placement? 2. Missing "itemscope" in "New Products" module. Two files: /includes/modules/content/index/templates/new_products.php Line 44 should be changed from: <div class="row" itemtype="http://schema.org/ItemList">to <div class="row" itemscope itemtype="http://schema.org/ItemList"> /includes/modules/new_products.php Line 54 should be changed from: <div class="row" itemtype="http://schema.org/ItemList">to <div class="row" itemscope itemtype="http://schema.org/ItemList"> 3. /include/modules/boxes/bm_shopping_cart.php Line 97 should be changed from: $cart_contents_string .= '<p>' . MODULE_BOXES_SHOPPING_CART_BOX_CART_EMPTY . '</p>'; to: $cart_contents_string .= '<li><p>' . MODULE_BOXES_SHOPPING_CART_BOX_CART_EMPTY . '</p></li>'; Rudolf I am sorry, I am new to Git (used to use SVN) and, at the moment, I find it a major pain to use GitHub to apply changes. Link to comment Share on other sites More sharing options...
MrPhil Posted December 25, 2016 Share Posted December 25, 2016 The first two items sound good -- no "body" HTML in the <head>, and use "itemscope" if you have "itemtype" (other item* too?). On the third item, I haven't looked at the code, but if that was a paragraph mistakenly given for a list item, you should probably be changing <p> to <li>, rather than embedded a paragraph inside a list item. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.