Jump to content
Patty

Diferent levels of discount for payment type

Recommended Posts

Hi, everybody.

 

I'm trying to merge these two addons so I can configure several discount levels based on the order amount and the payment type:

 

Apply Payment Type Discount (http://addons.oscommerce.com/info/9058)

Price Sensitive Discount (http://addons.oscommerce.com/info/204)

 

It works perfect for one payment type, but if I add another one, the second one doesn't work, just the first one.

 

Here's the code. I'm not a programmer, so can someone help me fixing that so it will work for several payment types?

 

TIA for any clues! :)

<?php
/*
<<<<<<< ot_lev_discount.php
  $Id: ot_lev_discount.php,v 1.0 2002/04/08 01:13:43 hpdl Exp $
=======
  $Id: ot_lev_discount.php,v 1.3 2002/09/04 22:49:11 wilt Exp $
  $Id: ot_lev_discount.php,v 2.4 2006/02/28 12:10:01 maniac101 Exp $
modified to calc discount correctly when tax is included in discount
>>>>>>> 2.4

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2002 osCommerce

  Released under the GNU General Public License
*/

  class ot_lev_discount {
    var $title, $output;

    function ot_lev_discount() {
      $this->code = 'ot_lev_discount';
      $this->title = MODULE_LEV_DISCOUNT_TITLE;
      $this->description = MODULE_LEV_DISCOUNT_DESCRIPTION;
      $this->enabled = MODULE_LEV_DISCOUNT_STATUS;
      $this->sort_order = MODULE_LEV_DISCOUNT_SORT_ORDER;
      $this->include_shipping = MODULE_LEV_DISCOUNT_INC_SHIPPING;
      $this->include_tax = MODULE_LEV_DISCOUNT_INC_TAX;
      $this->calculate_tax = MODULE_LEV_DISCOUNT_CALC_TAX;
      $this->table = MODULE_LEV_DISCOUNT_TABLE;
//      $this->credit_class = true;
      $this->output = array();
    }

    function process() {
      global $order, $ot_subtotal, $currencies;
      $od_amount = $this->calculate_credit($this->get_order_total());
      if ($od_amount>0) {
      $this->deduction = $od_amount;
      $this->output[] = array('title' => $this->title . ':',
                              'text' => '<b>- ' . $currencies->format($od_amount) . '</b>',
                              'value' => $od_amount);
    $order->info['total'] = $order->info['total'] - $od_amount;
    if ($this->sort_order < $ot_subtotal->sort_order) {
      $order->info['subtotal'] = $order->info['subtotal'] - $od_amount;
    }
}
    }
     
   
  function calculate_credit($amount) {
    global $order, $customer_id, $payment;
    $od_amount=0;
   $table_pay = preg_split("/[,]/" , MODULE_LEV_DISCOUNT_TYPE);
   $table_cost = preg_split("/[:,]/" , MODULE_LEV_DISCOUNT_TABLE);		
    for ($i = 0; $i < count($table_cost); $i+=2) {
          if (($amount >= $table_cost[$i]) && ($payment == $table_pay[$i])) {
            $od_pc = $table_cost[$i+1];
          }
        }
// Calculate tax reduction if necessary
    if($this->calculate_tax == 'true') {
// Calculate main tax reduction
      $tod_amount = round($order->info['tax']*10)/10*$od_pc/100;
      $order->info['tax'] = $order->info['tax'] - $tod_amount;
// Calculate tax group deductions
      reset($order->info['tax_groups']);
      while (list($key, $value) = each($order->info['tax_groups'])) {
        $god_amount = round($value*10)/10*$od_pc/100;
        $order->info['tax_groups'][$key] = $order->info['tax_groups'][$key] - $god_amount;
      }  
    }
    $od_amount = round($amount*10)/10*$od_pc/100;
//    $od_amount = $od_amount + $tod_amount;
// maniac101 above line was adding tax back into discount incorrectly for me
    return $od_amount;
  }


  function get_order_total() {
    global  $order, $cart;
    $order_total = $order->info['total'];
// Check if gift voucher is in cart and adjust total
    $products = $cart->get_products();
    for ($i=0; $i<sizeof($products); $i++) {
      $t_prid = tep_get_prid($products[$i]['id']);
      $gv_query = tep_db_query("select products_price, products_tax_class_id, products_model from " . TABLE_PRODUCTS . " where products_id = '" . $t_prid . "'");
      $gv_result = tep_db_fetch_array($gv_query);
     // if (ereg('^GIFT', addslashes($gv_result['products_model']))) { 
	  if (preg_match('/^GIFT/', addslashes($gv_result['products_model']))) { 
        $qty = $cart->get_quantity($t_prid);
        $products_tax = tep_get_tax_rate($gv_result['products_tax_class_id']);
        if ($this->include_tax =='false') {
           $gv_amount = $gv_result['products_price'] * $qty;
        } else {
          $gv_amount = ($gv_result['products_price'] + tep_calculate_tax($gv_result['products_price'],$products_tax)) * $qty;
        }
        $order_total=$order_total - $gv_amount;
      }
    }
    if ($this->include_tax == 'false') $order_total=$order_total-$order->info['tax'];
    if ($this->include_shipping == 'false') $order_total=$order_total-$order->info['shipping_cost'];
    return $order_total;
  }   
    
    
    
    function check() {
      if (!isset($this->check)) {
        $check_query = tep_db_query("select configuration_value from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_LEV_DISCOUNT_STATUS'");
        $this->check = tep_db_num_rows($check_query);
      }

      return $this->check;
    }

    function keys() {
      return array('MODULE_LEV_DISCOUNT_STATUS', 'MODULE_LEV_DISCOUNT_SORT_ORDER','MODULE_LEV_DISCOUNT_TABLE', 'MODULE_LEV_DISCOUNT_TYPE', 'MODULE_LEV_DISCOUNT_INC_SHIPPING', 'MODULE_LEV_DISCOUNT_INC_TAX','MODULE_LEV_DISCOUNT_CALC_TAX');
    }

    function install() {
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Display Total', 'MODULE_LEV_DISCOUNT_STATUS', 'true', 'Do you want to enable the Order Discount?', '6', '1','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_LEV_DISCOUNT_SORT_ORDER', '999', 'Sort order of display.', '6', '2', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Include Shipping', 'MODULE_LEV_DISCOUNT_INC_SHIPPING', 'true', 'Include Shipping in calculation', '6', '3', 'tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Include Tax', 'MODULE_LEV_DISCOUNT_INC_TAX', 'true', 'Include Tax in calculation.', '6', '4','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Calculate Tax', 'MODULE_LEV_DISCOUNT_CALC_TAX', 'false', 'Re-calculate Tax on discounted amount.', '6', '5','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Discount Percentage', 'MODULE_LEV_DISCOUNT_TABLE', '100:7.5,250:10,500:12.5,1000:15', 'Set the price breaks and discount percentages', '6', '6', now())");
      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Formas de pagamento com desconto', 'MODULE_LEV_DISCOUNT_TYPE', 'transferencia', 'Digite as formas de pagamento que qualificam para o desconto (separar por vírgula): cc, cheque, cop, pagamentodigital, pagseguro, paypal_direct, paypal_express, paypal_standart, transferencia, transfer_cef, transfer_bb, transfer_bradesco, transfer_itau, transfer_unibanco, transfer_real, transfer_santander, transfer_hsbc, west', '6', '7', now())");
    }

    function remove() {
      $keys = '';
      $keys_array = $this->keys();
      for ($i=0; $i<sizeof($keys_array); $i++) {
        $keys .= "'" . $keys_array[$i] . "',";
      }
      $keys = substr($keys, 0, -1);

      tep_db_query("delete from " . TABLE_CONFIGURATION . " where configuration_key in (" . $keys . ")");
    }
  }
?>
Edited by Patty

Patty

Share this post


Link to post
Share on other sites

Never mind. Fixed!

I just changed the line
 

if ($amount >= $table_cost[$i]) && ($payment == $table_pay[$i])) {

to

if ($amount >= $table_cost[$i]) {

Voilá! :)


Patty

Share this post


Link to post
Share on other sites

Actually, this is not working as it should.

After applying the fix mentioned above, now ALL payment types are showing the discount!

 

Can somebody please help me fix this??

 

TIA! :)


Patty

Share this post


Link to post
Share on other sites

OK, I paid someone to fix this for me, since I couldn't get any help here.

 

Anyway, here's the file that corrects not only this, but also a bug that will show the discount even if the addon was deactivated in the admin.

I hope it can help someone.

<?php
/*
  <<<<<<< ot_lev_discount.php
  $Id: ot_lev_discount.php,v 1.0 2002/04/08 01:13:43 hpdl Exp $
  =======
  $Id: ot_lev_discount.php,v 1.3 2002/09/04 22:49:11 wilt Exp $
  $Id: ot_lev_discount.php,v 2.4 2006/02/28 12:10:01 maniac101 Exp $
  modified to calc discount correctly when tax is included in discount
  >>>>>>> 2.4

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2002 osCommerce

  Released under the GNU General Public License
 */

class ot_lev_discount
{

    var $title, $output;

    function ot_lev_discount()
    {
        $this->code = 'ot_lev_discount';
        $this->title = MODULE_LEV_DISCOUNT_TITLE;
        $this->description = MODULE_LEV_DISCOUNT_DESCRIPTION;
        $this->enabled = MODULE_LEV_DISCOUNT_STATUS;
        $this->sort_order = MODULE_LEV_DISCOUNT_SORT_ORDER;
        $this->include_shipping = MODULE_LEV_DISCOUNT_INC_SHIPPING;
        $this->include_tax = MODULE_LEV_DISCOUNT_INC_TAX;
        $this->calculate_tax = MODULE_LEV_DISCOUNT_CALC_TAX;
        $this->table = MODULE_LEV_DISCOUNT_TABLE;
//        $this->credit_class = true;
        $this->output = array();
    }

    function process()
    {
        global $order, $ot_subtotal, $currencies;
        $od_amount = $this->calculate_credit($this->get_order_total());
        if ($od_amount > 0) {
            $this->deduction = $od_amount;
            $this->output[] = array('title' => $this->title . ':',
                'text' => '<b>- ' . $currencies->format($od_amount) . '</b>',
                'value' => $od_amount);
            $order->info['total'] = $order->info['total'] - $od_amount;
            if ($this->sort_order < $ot_subtotal->sort_order) {
                $order->info['subtotal'] = $order->info['subtotal'] - $od_amount;
            }
        }
    }

    function calculate_credit($amount)
    {
        global $order, $customer_id, $payment;
        $od_amount = 0;
        $table_pay = preg_split("/[,]/", MODULE_LEV_DISCOUNT_TYPE);
        $table_cost = preg_split("/[:,]/", MODULE_LEV_DISCOUNT_TABLE);

        if (MODULE_LEV_DISCOUNT_STATUS == "true" && (in_array($payment, $table_pay))) {

            for ($i = 0; $i < count($table_cost); $i+=2) {
                if ($amount >= $table_cost[$i]) {
                    $od_pc = $table_cost[$i + 1];
                }
            }
            // Calculate tax reduction if necessary
            if ($this->calculate_tax == 'true') {
                // Calculate main tax reduction
                $tod_amount = round($order->info['tax'] * 10) / 10 * $od_pc / 100;
                $order->info['tax'] = $order->info['tax'] - $tod_amount;
                // Calculate tax group deductions
                reset($order->info['tax_groups']);
                while (list($key, $value) = each($order->info['tax_groups'])) {
                    $god_amount = round($value * 10) / 10 * $od_pc / 100;
                    $order->info['tax_groups'][$key] = $order->info['tax_groups'][$key] - $god_amount;
                }
            }
            $od_amount = round($amount * 10) / 10 * $od_pc / 100;
            //$od_amount = $od_amount + $tod_amount;
            // maniac101 above line was adding tax back into discount incorrectly for me
        }
        return $od_amount;
    }

    function get_order_total()
    {
        global $order, $cart;
        $order_total = $order->info['total'];
        // Check if gift voucher is in cart and adjust total
        $products = $cart->get_products();
        for ($i = 0; $i < sizeof($products); $i++) {
            $t_prid = tep_get_prid($products[$i]['id']);
            $gv_query = tep_db_query("select products_price, products_tax_class_id, products_model from " . TABLE_PRODUCTS . " where products_id = '" . $t_prid . "'");
            $gv_result = tep_db_fetch_array($gv_query);
            // if (ereg('^GIFT', addslashes($gv_result['products_model']))) {
            if (preg_match('/^GIFT/', addslashes($gv_result['products_model']))) {
                $qty = $cart->get_quantity($t_prid);
                $products_tax = tep_get_tax_rate($gv_result['products_tax_class_id']);
                if ($this->include_tax == 'false') {
                    $gv_amount = $gv_result['products_price'] * $qty;
                } else {
                    $gv_amount = ($gv_result['products_price'] + tep_calculate_tax($gv_result['products_price'], $products_tax)) * $qty;
                }
                $order_total = $order_total - $gv_amount;
            }
        }
        if ($this->include_tax == 'false')
            $order_total = $order_total - $order->info['tax'];
        if ($this->include_shipping == 'false')
            $order_total = $order_total - $order->info['shipping_cost'];
        return $order_total;
    }

    function check()
    {
        if (!isset($this->check)) {
            $check_query = tep_db_query("select configuration_value from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_LEV_DISCOUNT_STATUS'");
            $this->check = tep_db_num_rows($check_query);
        }

        return $this->check;
    }

    function keys()
    {
        return array('MODULE_LEV_DISCOUNT_STATUS', 'MODULE_LEV_DISCOUNT_SORT_ORDER', 'MODULE_LEV_DISCOUNT_TABLE', 'MODULE_LEV_DISCOUNT_TYPE', 'MODULE_LEV_DISCOUNT_INC_SHIPPING', 'MODULE_LEV_DISCOUNT_INC_TAX', 'MODULE_LEV_DISCOUNT_CALC_TAX');
    }

    function install()
    {
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Display Total', 'MODULE_LEV_DISCOUNT_STATUS', 'true', 'Do you want to enable the Order Discount?', '6', '1','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort Order', 'MODULE_LEV_DISCOUNT_SORT_ORDER', '999', 'Sort order of display.', '6', '2', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Include Shipping', 'MODULE_LEV_DISCOUNT_INC_SHIPPING', 'true', 'Include Shipping in calculation', '6', '3', 'tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Include Tax', 'MODULE_LEV_DISCOUNT_INC_TAX', 'true', 'Include Tax in calculation.', '6', '4','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function ,date_added) values ('Calculate Tax', 'MODULE_LEV_DISCOUNT_CALC_TAX', 'false', 'Re-calculate Tax on discounted amount.', '6', '5','tep_cfg_select_option(array(\'true\', \'false\'), ', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Discount Percentage', 'MODULE_LEV_DISCOUNT_TABLE', '100:7.5,250:10,500:12.5,1000:15', 'Set the price breaks and discount percentages', '6', '6', now())");
        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Formas de pagamento com desconto', 'MODULE_LEV_DISCOUNT_TYPE', 'transferencia', 'Digite as formas de pagamento que qualificam para o desconto (separar por vírgula): cc, cheque, cop, pagamentodigital, pagseguro, paypal_direct, paypal_express, paypal_standart, transferencia, transfer_cef, transfer_bb, transfer_bradesco, transfer_itau, transfer_unibanco, transfer_real, transfer_santander, transfer_hsbc, west', '6', '7', now())");
    }

    function remove()
    {
        $keys = '';
        $keys_array = $this->keys();
        for ($i = 0; $i < sizeof($keys_array); $i++) {
            $keys .= "'" . $keys_array[$i] . "',";
        }
        $keys = substr($keys, 0, -1);

        tep_db_query("delete from " . TABLE_CONFIGURATION . " where configuration_key in (" . $keys . ")");
    }

}
?>

Patty

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×