Jump to content
ArtcoInc

Purchase without account for 2.3.4 and BS2334

Recommended Posts

@rupruprup Ralph,

Can you please give it a try with this version:

PWA_Phoenix_4.2.0_beta_03.zip

Only replace the hooks:

/includes/hooks/admin/customers/cPwa.php

/includes/hooks/admin/siteWide/swPwa.php

 

the delete button/edit conflict should be fixed.

if the customer listing layout is still messed up, please try the following alternative hook in:hooks/admin/siteWide:

swPwa.php

If this still doesn't help, please post your html source code of admin/customers.php

 

Thanks
Rainer

Share this post


Link to post
Share on other sites
Posted (edited)

@raiwa the edit button is fixed but the two swPwa.php hook files do not help

as I said it is the stock customers.php file that came with 1.6.1

I " fixed " the guest <th> in the second table with

$('table .thead-dark tr th:nth-child(1)').after('<th class="text-center">{$header_title_guest}</th>');

the active row displays correct with your code

$('table tbody .table-active td:eq(1)').before('<td class="text-center">{$customer_guest}</td>');

the problem seems to be here :

$('table tbody tr:has([href*="cID={$customers_id}"]) td:eq(1)').before('<td class="text-center">{$customer_guest}</td>');

 

 

Edited by rupruprup

Share this post


Link to post
Share on other sites
Posted (edited)
17 minutes ago, rupruprup said:

@raiwa the edit button is fixed but the two swPwa.php hook files do not help

as I said it is the stock customers.php file that came with 1.6.1

I " fixed " the guest <th> in the second table with

$('table .thead-dark tr th:nth-child(1)').after('<th class="text-center">{$header_title_guest}</th>');

the active row displays correct with your code

$('table tbody .table-active td:eq(1)').before('<td class="text-center">{$customer_guest}</td>');

the problem seems to be here :

$('table tbody tr:has([href*="cID={$customers_id}"]) td:eq(1)').before('<td class="text-center">{$customer_guest}</td>');

 

 

It would be interesting to see if others have the same problem.

I can't reproduce it

Can you please post your html source code (Browser Ctrl U)

Edited by raiwa

Share this post


Link to post
Share on other sites

can you try this in the swPwa hook line 96:

        $customer_guest = $customers['customers_guest'] == '1' ? '<i class="fas fa-check"></i>' : '&nbsp;';

 

Share this post


Link to post
Share on other sites
26 minutes ago, rupruprup said:

I " fixed " the guest <th> in the second table with

$('table .thead-dark tr th:nth-child(1)').after('<th class="text-center">{$header_title_guest}</th>');

Why? This shows correct in your screenshot.

Share this post


Link to post
Share on other sites
Posted (edited)

the second "Gast" in the right table heading was not too much ?

the sourcecode is in your PM

Edited by rupruprup

Share this post


Link to post
Share on other sites
Posted (edited)

What I see in your html is that your URLs are setup without http:// (relative links)

My Urls:

onclick="document.location.href='http://localhost/

yours:

onclick="document.location.href='catalog/

is your config file correct setup?

Edited by raiwa

Share this post


Link to post
Share on other sites

yes it is correct I replaced the admin url with 'catalog/admin' in the html source

Share this post


Link to post
Share on other sites

another issue with this page

if you choose to edit a normal customer, it gets flagged as guest is deleted instantly when you click "save"

Share this post


Link to post
Share on other sites
Posted (edited)

which jquery are you loading? I have this:

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.5.1/jquery.min.js"

you have this:

<script src="catalog/ext/core/jquery.min.js"</script>

and Phoenix 1.0.6.0 had this and worked too:

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.4.1/jquery.min.js

 

Edited by raiwa

Share this post


Link to post
Share on other sites
Posted (edited)

the complete shop works without issues, it's just this single hook

Edited by rupruprup

Share this post


Link to post
Share on other sites
Posted (edited)

I think it's clear that the problem is the href selector.

I'll do some more testing and maybe try to rewrite the script in native javascript.

Let's also see what other testers report.

Thanks so far

Ah, just to be sure, on the orders and reviews page it shows correct?

Edited by raiwa

Share this post


Link to post
Share on other sites

The orders page was perfect, the reviews page looked ok too, but I had only 1 review in this shop

A bigger problem is the new issue

46 minutes ago, rupruprup said:

another issue with this page

if you choose to edit a normal customer, it gets flagged as guest is deleted instantly when you click "save"

 

Share this post


Link to post
Share on other sites

@rupruprup,

Can you please give this a try in swPwa hook line 103:

$('table tbody tr:has([href*="cID={$customers_id}"]) td:eq(2)').before('<td class="text-center">{$customer_guest}</td>');

 

Share this post


Link to post
Share on other sites

it did not work, it moves the guest mark in this row just 1 column further

and I found another issue:

users that register new with the stock "create_account.php" are now flagged as guest in the database customers_guest field ....

Share this post


Link to post
Share on other sites

btw I don't think that it is important to mark users in the table with a flag, my live shop has a few thousand customers now and I'd never look at such a feature. A simple row in the right table that writes something like "is guest" would be the easier and better solution. The delete guests button is a good idea, perhaps you should add a count that shows how many guest accounts are currently inside the database.

Share this post


Link to post
Share on other sites

@raiwa @rupruprup

If you want, you could try the alternative version of Phoenix at https://github.com/ecartz/CE-Phoenix/tree/guest

On a live store, you might want to run

UPDATE configuration SET configuration_value = CONCAT(configuration_value, ';create_account;customers') WHERE configuration_key LIKE 'MODULE_CUSTOMER_DATA%PAGES'

Although you could get the same effect by uninstalling and reinstalling or simply editing the configuration of those modules. 

Note that after running that SQL, you might have to edit the guest module to remove those two pages. 

I have done no testing of that version at the moment.  Use at your own risk, only on test stores. 


Always back up before making changes.

Share this post


Link to post
Share on other sites

a stand alone of the module is not compatible with standard Phoenix ?

German shop owners need to have guest checkout to match all laws ..

Share this post


Link to post
Share on other sites
1 hour ago, rupruprup said:

a stand alone of the module is not compatible with standard Phoenix ?

German shop owners need to have guest checkout to match all laws ..

Sorry I do not understand. Can you please explain.

 

Beta_04 with the following fixes:

- standard create_account.php flagged guests

- edit customer in admin/customers.php deleted guest accounts

- added guest account count info in admin/customers.php

not fixed: incorrect table layout in admin/customers in @rupruprup 's test store => I sent you a PM

 

Please replace all files:

PWA_Phoenix_4.2.0_beta_04.zip

Share this post


Link to post
Share on other sites
3 hours ago, raiwa said:

Beta_04 with the following fixes:

- standard create_account.php flagged guests - confirmed ✔️

- edit customer in admin/customers.php deleted guest accounts  - confirmed ✔️

- added guest account count info in admin/customers.php - confirmed ✔️

not fixed: incorrect table layout in admin/customers in @rupruprup 's test store => I sent you a PM  - also confirmed ✔️

 

thank you @raiwa I installed it and it works as it should ....

the table layout is also fixed, perhaps it had to do with the not correct working delete button ? 

Edited by rupruprup

Share this post


Link to post
Share on other sites

the delete guests button does not work anymore

pressing it results in a screen output above the header " $delete_actiondelete_guests "

the called url is correct ... customers.php?action=delete_guests

image.png.e8b26b5a0d4abeb7ed3f701fd6792221.png

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×