Jump to content
burt

Responsive osCommerce - Bootstrap

Recommended Posts

@burt

Hi Burt,

Thank you for that explanation and it certainly make it easier, however, I seem to be missing one piece here. This is likely a dumb question,.. but ordering the sort-order of these loaded elements is performed in the admin section, so how do you add a new module to that?

I was thinking of possibly adding a couple of new elements and the only way to do that without having it managed as a module in the admin area, is to code it into one of the existing module templates.

Because BS-Edge strives to be a modular design where developers can add their own modules as contributions, is there any documentation on requirements/guidelines for structuring new modules that would abide by the osC design and code integrity?

 

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce

Share this post


Link to post
Share on other sites

You would make a module.  You would then install it.

If you are a developer...this should be straightforward.

If you are not a developer...it won't be.

From the very start I advised that making things simple in the admin area would make things much harder to code.  
Shop-owners are not expected to code anything, so why are you doing that?  You just need to click click...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Anyone have a clean brand new version of responsive they could quickly test for a bug?

From the admin just try and upload/save a NEW logo.... brow

When I do so I'm being returned to: admin/FILENAME_STORE_LOGO?action=save

obviously not a good URL since filename has been removed.

Looking at the code in admin/store_logo.php I do see a reference to filename

 

        if ($store_logo->parse()) {
          if ($store_logo->save()) {
            $messageStack->add_session(SUCCESS_LOGO_UPDATED, 'success');
            tep_db_query("update configuration set configuration_value = '" . tep_db_input($store_logo->filename) . "' where configuration_value = '" . STORE_LOGO . "'");
          } else {
            $error = true;
          }
        } else {
          $error = true;
        }

 

Share this post


Link to post
Share on other sites

I don't see that in my copy. Maybe something you have added has introduced it. In that case, the easiest solution is to install the Compatibility Addon. Install it in the Admin as well as the Catalog side.

Regards

Jim


See my profile for a list of my addons and ways to get support.

Share this post


Link to post
Share on other sites
42 minutes ago, kymation said:

I don't see that in my copy. Maybe something you have added has introduced it. In that case, the easiest solution is to install the Compatibility Addon. Install it in the Admin as well as the Catalog side.

Regards

Jim

the code is copied off github

https://github.com/gburton/Responsive-osCommerce/blob/master/admin/store_logo.php

Or do you mean you don't experience the problem in your fresh copy?

Edited by greasemonkey

Share this post


Link to post
Share on other sites

I don't see FILENAME_STORE_LOGO anywhere in my copy or in the code for store_logo.php on Github. The redirect link in that file is:

tep_redirect(tep_href_link('store_logo.php'));

which has the filename spelled out, not the older constant value. So either you've changed something or something really odd is happening. Maybe your server is haunted with the spirit of v1.3.4?

Regards

Jim


See my profile for a list of my addons and ways to get support.

Share this post


Link to post
Share on other sites

@burt,

What's the status of this project? Will you continue with it or will it just became 2.3.6 and finish your community version effort?

I'f love to see the admin side integrated with bootstrap like 2.4 is.

Share this post


Link to post
Share on other sites

No plans.  Project is at the end of the road.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Any particular reason for this css:

@media only screen and (max-width: 768px)
custom.min.css:6
.row.list-group {
    -webkit-flex-direction: column;
    flex-direction: column;
}

which results in this on portrait iPad?

Just checking before I remove it on my installation :-)

ipad_css.PNG


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

@frankl that code has to do with the new approach to the perceived equal height problem.  I hated the .js approach to it, so changed it to a .css solution.  See 

The particular piece of code you posted appears to be code I added to force the layout into one column in small devices.  Instead of fully removing, try change 768 to a lower number (ie works on mobile phone, but won't work on portrait ipad)...

Report back if you can ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

@burt

Replacing it with

@media only screen and (min-width: 320px) and (max-width: 479px) { .row.list-group{-webkit-flex-direction:column;flex-direction:column;}}

fixes iPad portrait, but iPhone 6 landscape looks a little different. I'm not concerned, I wouldn't think many people would browse websites in landscape mode on their smart phones :)

 

 

ipadportrait.PNG

6slandscape.PNG


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

@frankl

 

Hi Frank,

What software are those screenshots from (to test a site in different type of mobile browsers)? I use Opera Mobile Emulator, but the mobile versions available for testing are outdated. Thanks.

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce

Share this post


Link to post
Share on other sites

@frankl

that's just the Chrome browser, right? I use their development tools console, but I've never seen a place to test for different mobile devices.

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce

Share this post


Link to post
Share on other sites

Just click the 'Device' icon in the developer console. You can also add other devices by clicking 'Edit' in the device selection dropdown.

 

chrome_device.PNG


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

@frankl see https://github.com/gburton/Responsive-osCommerce/pull/538

If I remember right there were some quite big differences between actual device behaviour and what the emulations show. Of course it's a moving feast anyway and you pretty much have to decide where to draw the line.

 

Maybe you need an equal widths module for the iphone!

Edited by BrockleyJohn

For a new install or if your store isn't mobile-friendly, get the community-supported responsive osCommerce (Phoenix).

here: on the official osc download page

Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x

Share this post


Link to post
Share on other sites

@BrockleyJohn

I know emulators aren't quite "real", so my workflow is to do all the dev using emulators and then for final tweaks check on the actual devices themselves. The emulators come quite close but you need the real device with the actual browser and OS to do a final check. Even the responsive design mode on Safari doesn't always match up to what you get on various iPads and iPhones.


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

is there a simple way to nest a module inside another?

I installed the Horizontal Categories Menu and want to use the header buttons module inside of it, but nothing seems to work. I tried including the template, and then added the code inside that menu module template, but this is just kicking back errors.

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce

Share this post


Link to post
Share on other sites


Ok, so I solved the issue of placing the header buttons module in the Horizontal Categories Menu module (for tablet screen size) ..by setting the sort-order higher for the header buttons module and then setting its margin-bottom to -34px (height of the button group) and bottom to -10px. See attached screenshot.

I did not nest the modules, but just applied a CSS fix. However, I’d still like to hear from one of the experts, if there is a simple way to nest a module inside another?  

My new challenge is with including some of the sub-modules from the navigation bar in the Horizontal Categories Menu module as part of the menu.

 

header-menu-screenshot.png


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce

Share this post


Link to post
Share on other sites

I am no expert but I think it depends on the module contents some might work together others might not.
I personally think your css fix is good and should cause no problems. As long it looks and works as you like keep it as is now with the css fix. Just make sure you cover all viewports XS, SM and so on...

Share this post


Link to post
Share on other sites
Hi, This is a slight divergence to the “Emails in 2.4” question raised by  @frankl - 
I am currently trying to make changes to 2.3.4bs without tampering with core code - using jQuery (until pages are fully modularised) in new footer content scripts it is possible to make significant changes to page content/layout (is this OK or unwise?). Is it also possible using a header_tag script to add code that would otherwise be in application_top (is there a better way?).
 
However, I have not yet found a suitable way to externally change functions. I would like to make minor changes to tep_href_link, tep_address_format, and tep_mail without meddling with core. Apparently there is no PHP facility to delete/replace (system/user) functions.
 
Is there a suitable solution?

Share this post


Link to post
Share on other sites

There is nothing wrong with changing core code so long as you know what you are doing and you remember what you have done.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
58 minutes ago, trier said:
Hi, This is a slight divergence to the “Emails in 2.4” question raised by  @frankl - 
I am currently trying to make changes to 2.3.4bs without tampering with core code - using jQuery (until pages are fully modularised) in new footer content scripts it is possible to make significant changes to page content/layout (is this OK or unwise?). Is it also possible using a header_tag script to add code that would otherwise be in application_top (is there a better way?).
 
However, I have not yet found a suitable way to externally change functions. I would like to make minor changes to tep_href_link, tep_address_format, and tep_mail without meddling with core. Apparently there is no PHP facility to delete/replace (system/user) functions.
 
Is there a suitable solution?

Avoid changing core code when there's a sensible alternative, but if the most straightforward way of doing something is to change the core, do it that way and make sure you keep track of what you have done.

It's only really going to matter in the future if and when you're working on a live shop that can be updated automatically. Then core updates will be dangerous. For now, they're not a sin if they're the best way of doing it. In my view it's more important for addon developers than for capable people working on their own store not to change core code.


For a new install or if your store isn't mobile-friendly, get the community-supported responsive osCommerce (Phoenix).

here: on the official osc download page

Working on generalising bespoke solutions for Quickbooks integration, Easify integration and pay4later (DEKO) integration at 2.3.x

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×