Jump to content
burt

Responsive osCommerce - Bootstrap

Recommended Posts

@@irishguy9

The project is not dead. It is just golden.

Not much happens to it except for bug fixes.

If you want changes, you will have to make a fork and change things for yourself, but everything in this repo is for basic osc bootstrap. No addons.

Share this post


Link to post
Share on other sites

I get a 404 trying to reach the site:

http://template.me.uk/2334bs3/

 

Is the URL deprecated?

Moved to http://www.template.me.uk/234bs3/

 

and forgot to place a redirect.  :blush:

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Yes I've read that. My concern is that since the last GOLD release, Responsive-OScommerce:master has become a mixture of some Bootstrap-related fixes, and a lot of random stuff that seems like it belongs in the mainline OSC repo instead. But maybe that doesn't matter if the plan is for OSC[r] to be merged back to OSC soon anyway?

 

I'd like to start contributing (to OSC and OSC[r]) via github, but the lack of clear separation is confusing me as to where I should be punting my PR.

 

I have what should be a simple thing to contribute to start with: Category names aren't currently escaped when sent to the screen in some places, and they should be. The difficulty is there's a difference between the mainline and BS versions - the BS version appears to be worse.

 

So do I have to do two PRs, or can I just roll it up into one and send it to Responsive because that will feed it into mainline OSC in due course anyway?

 

 

Edited by Ben23

Share this post


Link to post
Share on other sites

@@Ben23

 

Hi Ben...I think this is the right way to proceed but things are a bit uncertain at the moment.

 

just roll it up into one and send it to Responsive because that will feed it into mainline OSC in due course anyway?

 

If you do that, I think you'll find out soon enough...

 

Dan

Share this post


Link to post
Share on other sites

@@Ben23

 

Hi Ben...I think this is the right way to proceed but things are a bit uncertain at the moment.

 

 

If you do that, I think you'll find out soon enough...

 

Dan

I would do the same ...

KEEP CALM AND CARRY ON

I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support).

So if you are still here ? What are you waiting for ?!

 

Find the most frequent unique errors to fix:

grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt

Share this post


Link to post
Share on other sites

I saw a message in Github from Gary to a person to a person submitting a PR to the osC responsive repo that commits are no longer are being accepted for that particular repo.

 

https://github.com/gburton/Responsive-osCommerce/pull/170#event-266167792

 

@@Ben23


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

@@altoid

 

Steve...I don't know my way around GitHub well enough to tell but was that for the GOLD, EDGE or both responsive versions?

 

Dan

Share this post


Link to post
Share on other sites

@@Dan Cole

 

Hi Dan,  both Gold and Edge are in one repository.  With Gold being a "release", a benchmark so to speak, where Gary thought it good to go as is at that point in time.

 

Then further development has been done, on top of gold's release.  That further development is known as Edge.  It looks to me like Edge has 92 commits, or updates after the release of Gold.  I am using Edge by the way as it is more current.  I trust it even though it's not an official release because Gary is the gatekeeper and pretty particular about what goes in it.

 

For now, it appears that the repository responsive-oscommerce is dormant.  Resulting from what went on recently.

 

But then I see Gary has been doing a lot lately on the osCommerce2 repo, which is the historically recognized osCommerce that we all know.  It appears Gary is, among other things, melding a bunch of the stuff he did with responsive-oscommerce, into osCommerce2. 

 

So while I can't say for sure, it appears the goal is to get osCommerce2 moving along, including responsiveness.  

 

If I am correct,  then in due time, all's good.  I'm just not sure the implications of a Gold or Edge based shop over to the next osCommerce2 release.  So I'm staying tuned...


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

@@altoid

 

That's interesting Steve...I wonder why it's necessary to go back and update 2.3.4 in effect...I was thinking that GOLD responsive would just replace 2.3.4 to become 2.3.5 or 2.3.4 Responsive or whatever it might be called. The versions must have taken different tracks some where along the way.   Anyway it is good to know that work continues.  

 

Thanks for the explanation.  I must spend some time learning GitHub one of these days...

 

Dan

Share this post


Link to post
Share on other sites

quick question I see tep_session is changed, I was wondering with this line:

 

if (!tep_session_is_registered($post_var)) tep_session_register($post_var);

 

to:

 

if (!isset($_SESSION['post_var'])) set($_SESSION['post_var');

Share this post


Link to post
Share on other sites

Started making the admin side Mobile Responsive last night, and have a few pics to share... I will try to get the code into a github repo and create a pull request soon :)

 

http://grabilla.com/05401-9555d702-b88a-4503-9477-e4e987a7ea2c.png

 

http://grabilla.com/05401-b913e3d8-a187-4023-b16b-606e9d79d14e.png

 

http://grabilla.com/05401-a8e7db07-d8ef-487d-b0ec-2bd45aced4e4.png

 

http://grabilla.com/05401-46906c35-535c-4ca6-8568-b47806990b02.png

Thanks to everyone who has put the hard work into the store side :)


-------------------------------------------------

Best Regards,

 

ggbig (maestro)

Share this post


Link to post
Share on other sites

quick question I see tep_session is changed, I was wondering with this line:

 

if (!tep_session_is_registered($post_var)) tep_session_register($post_var);

 

to:

 

if (!isset($_SESSION['post_var'])) set($_SESSION['post_var');

Correct, that is the future way of doing things for sessions.

Asof PHP 4.1 superglobal _SESSION can be used

see below for more info

http://php.net/manual/en/reserved.variables.session.php


KEEP CALM AND CARRY ON

I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support).

So if you are still here ? What are you waiting for ?!

 

Find the most frequent unique errors to fix:

grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt

Share this post


Link to post
Share on other sites

Just a tidbit that folks will LOVE!!!
 
The Layout Problem:
http://grabilla.com/05401-159e0fdd-200f-45c4-b153-53ef5f153bef.png
 
The Desired Layout:
http://grabilla.com/05401-cf761074-d2a3-4061-a3b6-1361583ef6cf.png

The Solution:

 

< script >
/*
  Thanks to CSS Tricks for pointing out this bit of jQuery
  http://css-tricks.com/equal-height-blocks-in-rows/
  It's been modified into a function called at page load and then each time the page is resized.
  One large modification was to remove the set height before each new calculation.
 */

equalheight = function(container) {
  var currentTallest = 0,
      currentRowStart = 0,
      rowDivs = new Array(),
      $el,
      topPosition = 0;
  $(container).each(function() {
    $el = $(this);
    $($el).height('auto')
    topPostion = $el.position().top;
    if (currentRowStart != topPostion) {
      for (currentDiv = 0 ; currentDiv < rowDivs.length ; currentDiv++) {
        rowDivs[currentDiv].height(currentTallest);
      }
      rowDivs.length = 0; // empty the array
      currentRowStart = topPostion;
      currentTallest = $el.height();
      rowDivs.push($el);
    } else {
      rowDivs.push($el);
      currentTallest = (currentTallest < $el.height()) ? ($el.height()) : (currentTallest);
    }
    for (currentDiv = 0 ; currentDiv < rowDivs.length ; currentDiv++) {
      rowDivs[currentDiv].height(currentTallest);
    }
  });
}
 
$(window).load(function() {
  equalheight('.thumbnail');
});

$(window).resize(function(){
  equalheight('.thumbnail');
});
< /script >


-------------------------------------------------

Best Regards,

 

ggbig (maestro)

Share this post


Link to post
Share on other sites

@@ggbig

The above layout problem has been identified and solutions posted earlier.

They also discussed the issue when you change layout styles from grids to rows that the equal height should not affect the row height


KEEP CALM AND CARRY ON

I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support).

So if you are still here ? What are you waiting for ?!

 

Find the most frequent unique errors to fix:

grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt

Share this post


Link to post
Share on other sites

Hmm, ok @@bruyndoncx if it was fixed, I might have a slightly different version of the GOLD zip possibly... I saw the equalheight classname but still saw the non equal height listings... Either way thanks for the update, and possibly I have added a second solution if the first deems not 100% successful :)

 

Look for much more admin work from me very soon. I have just completed the Administrators section of the admin:

Full: http://grabilla.com/05402-bf30a71b-5f4f-47cb-9016-16fb9542518c.png

 

MED: http://grabilla.com/05402-3c61f896-fb0f-4f80-8f89-25325fa97fbd.png

SM: http://grabilla.com/05402-b547517b-9ba0-492a-a000-2768d62f2dec.png

 

XS: http://grabilla.com/05402-622ba2df-b9ba-4675-a938-2448a1872939.png

hopefully MANY of you will enjoy this work :) Peace!


-------------------------------------------------

Best Regards,

 

ggbig (maestro)

Share this post


Link to post
Share on other sites

@@irishguy9 no yet yet, I will create a public repo very soon and post the work I have done so far for anyone who would like a copy... It is not complete by any means, as per the pages in the admin being all converted to this layout, but there is certainly enough of the bulk of the work done for most any programmer to further it to completion. I will post the github link and possibly create a pull request to the GOLD release if the fine folks keeping that one updated are interested :)

 

Thanks for asking too!


-------------------------------------------------

Best Regards,

 

ggbig (maestro)

Share this post


Link to post
Share on other sites

Hello,

i'd like to know if there's a guide or instruction to update my 2.3.4 to 2.3.4 bootstrap or i need to install the a new ?

The 2.3.4 Bootstrap Gold is a stable version to use in live store?

 

Thanks for you replay

Marco

Share this post


Link to post
Share on other sites

@@marcochiana

 

There is no guide to do such update/upgrade. At least none that I know of.

It would take too much time to do that. Some people do such work but that is not for free. If you are interested though you can start a topic in the commercial enquire section.

Otherwise you have to start from scratch and install a fresh version of osC 2.3.4 BS GOLD

2.3.4 BS GOLD is a stable version and can be used as a live store.

Edited by Tsimi

Share this post


Link to post
Share on other sites

Just remember that 2.3.4 BS GOLD is a community version of oscommerce and not an official version. When oscomerce developers eventually get a responsive version coded it may, or may not, be compatible with the 2.3.4 BS GOLD community version. It is still the best of the available options available today, so I would use it and hope, rather than wait for an official version.


REMEMBER BACKUP, BACKUP AND BACKUP

Get the latest Responsive osCommerce CE (community edition) here

It's very easy to over complicate what are simple things in life

Share this post


Link to post
Share on other sites

Work on the community version has not stopped, it has just taken a back seat whilst I deal with other things.  Pretty soon I'll be coding again.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×