Dan Cole Posted December 24, 2014 Share Posted December 24, 2014 I'm wondering if someone who is using the account content module in their footer could check the "Existing Customer" button. For some reason the introduction of btn-block seems to cause the text to extend beyond the button in larger or maybe medium size screens. Just wondering if this is something I've done. Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
burt Posted December 24, 2014 Author Share Posted December 24, 2014 Is how that button looks in mine... Link to comment Share on other sites More sharing options...
Dan Cole Posted December 24, 2014 Share Posted December 24, 2014 Unfortunately I'm away from my computer at the moment but I'll try moving its' position in the footer when I get a chance. I have mine positioned in the right column and maybe that's making a difference....I'll report back with an image as soon as I can. Thanks for taking the time to have a look @@burt and Merry Christmas to you. Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
burt Posted December 24, 2014 Author Share Posted December 24, 2014 @@Dan Cole PM me the link if you wish and I can take a look. Link to comment Share on other sites More sharing options...
clustersolutions Posted December 25, 2014 Share Posted December 25, 2014 Just writing to wish everyone a very Merry Christmas and a Happy Holiday! :) Tim Link to comment Share on other sites More sharing options...
Dan Cole Posted December 25, 2014 Share Posted December 25, 2014 @@burt the coffee finally kicked in today and it occurred to me to have a look at the GABLEHAUSER demo that you have online and sure enough it's a problem there too...here is a screen shot... Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
burt Posted December 25, 2014 Author Share Posted December 25, 2014 @@Dan Cole looks like button text doesn't wrap, which is desired as it would make the button funky. For these circumstances (which would be rare, probably only seen in sm maybe md view) it would be best to make the text shorter "log in".. You can force the button text to wrap; http://stackoverflow.com/questions/18996202/twitter-bootstrap-button-text-word-wrap Link to comment Share on other sites More sharing options...
Dan Cole Posted December 25, 2014 Share Posted December 25, 2014 Thanks @@burt. I kinda like your solution...often the simplest answer is the best. :thumbsup: Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
auzStar Posted December 26, 2014 Share Posted December 26, 2014 If anyone wants to test; https://github.com/gburton/osCommerce-234-bootstrap/commit/40fe1c4851606107f710a9030030038f89a9d8e0 This is very basic and the new options once installed can be found in admin at configuration > bootstrap setup 1/ allows shopowner to decide between "container" or "container-fluid" ( see http://getbootstrap.com/css/#overview-container ) 2/ allows shopowner to no longer have to manually change /includes/classes/osc_template.php when wanting to set a different column width Feedback is welcome, note that this is in my FilthyHobbitsesBootstrap Branch, and is not committed to Master (yet), in case you want to pull it @ github no probs :thumbsup: My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
Dan Cole Posted December 26, 2014 Share Posted December 26, 2014 Thought I'd try to help out and installed this. If anyone wants to test; https://github.com/gburton/osCommerce-234-bootstrap/commit/40fe1c4851606107f710a9030030038f89a9d8e0 This is very basic and the new options once installed can be found in admin at configuration > bootstrap setup 1/ allows shopowner to decide between "container" or "container-fluid" ( see http://getbootstrap.com/css/#overview-container ) 2/ allows shopowner to no longer have to manually change /includes/classes/osc_template.php when wanting to set a different column width Feedback is welcome, note that this is in my FilthyHobbitsesBootstrap Branch, and is not committed to Master (yet), in case you want to pull it @ github Unfortunately my setup pukes on this line...var $_grid_column_width = (12 - BOOTSTRAP_CONTENT) / 2; in osc_template.php.This message received...Parse error: syntax error, unexpected '(' in xxxxxxxxxxxxxxxxxxxx/bootstrap/includes/classes/osc_template.php on line 20I tried changing the code in osc_template.php to...var $_grid_column_width = (12 - 8) / 2; just to rule out any problems that might be associated with BOOTSTRAP_CONTENT being defined or related to my database and I still get that same message.I'm wondering if this has to do with the version of php that I'm running....I don't recall the exact version but I know it's pre 5.3.Any ideas...Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
PupStar Posted December 26, 2014 Share Posted December 26, 2014 same here on wamp running php 5.5.12 Link to comment Share on other sites More sharing options...
auzStar Posted December 27, 2014 Share Posted December 27, 2014 Confirmed problem is with PHP version. My initial test was PHP v5.6.1 which worked. Tested with older version 5.3.13 and same error as Dan Cole. My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
♥kymation Posted December 27, 2014 Share Posted December 27, 2014 That code is invalid in any version of PHP that I can remember. Some versions are better at error checking. I'm surprised that PHP 5.6.1 passed it -- you should report that as a bug. Variable declarations can be set to any type, but they must have a constant value. No calculations are allowed. so var $_grid_content_width = 8; var $_grid_column_width = 2; are valid, but var $_grid_column_width = (12 - BOOTSTRAP_CONTENT) / 2; is not. Solution: Revert line 19 to var $_grid_column_width = 2; and add this to the class constructor $this->_grid_column_width = (12 - BOOTSTRAP_CONTENT) / 2; Regards Jim See my profile for a list of my addons and ways to get support. Link to comment Share on other sites More sharing options...
♥altoid Posted December 27, 2014 Share Posted December 27, 2014 using code provided by @@kymation my includes/classes/osc_template.php now shows in part: class oscTemplate { var $_title; var $_blocks = array(); var $_content = array(); var $_grid_container_width = 12; var $_grid_content_width = BOOTSTRAP_CONTENT; var $_grid_column_width = 2; var $_data = array(); function oscTemplate() { $this->_title = TITLE; $this->_grid_column_width = (12 - BOOTSTRAP_CONTENT) / 2; } test 234 bootstrap shop in uniserver looks to be working. I'll post some screen shots I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
♥altoid Posted December 27, 2014 Share Posted December 27, 2014 container fluid container I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
♥altoid Posted December 27, 2014 Share Posted December 27, 2014 following are fluid container content 8 content 6 content 4 I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
burt Posted December 27, 2014 Author Share Posted December 27, 2014 Thanks for testing chaps :thumbsup: Link to comment Share on other sites More sharing options...
burt Posted December 27, 2014 Author Share Posted December 27, 2014 @@altoid all of those screenshots look exactly correct, as you have no right column, what would be the width of the right column is added to the content column. All appears well. Thanks for testing. Link to comment Share on other sites More sharing options...
auzStar Posted December 28, 2014 Share Posted December 28, 2014 @@kymation That code is invalid in any version of PHP that I can remember. Some versions are better at error checking. I'm surprised that PHP 5.6.1 passed it -- you should report that as a bug. Nice pickup. (must have still been suffering xmas after-affects, since I hadn't realised on was still on 5.6.1 when initially testing) But it seems this is a new feature in 5.6: http://php.net/manual/en/migration56.new-features.php http://phplobby.com/tag/constant-scalar-expressions-supported-operands/ cheers My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted December 28, 2014 Author Share Posted December 28, 2014 https://github.com/gburton/osCommerce-234-bootstrap/commit/85225ccae51621c5e98390e5bb361b74611e6f66 Does this commit cure the problems ? Link to comment Share on other sites More sharing options...
Dan Cole Posted December 28, 2014 Share Posted December 28, 2014 Works for me @@burt. Dan Need help? See this thread and provide the information requested. Is your version of osC up to date? You'll find the latest osC community version (CE Phoenix) here. Link to comment Share on other sites More sharing options...
♥kymation Posted December 28, 2014 Share Posted December 28, 2014 @@auzStar Thanks, I didn't know that they had changed that. Yet another way to write code that isn't backwards compatible. Sigh. Regards Jim See my profile for a list of my addons and ways to get support. Link to comment Share on other sites More sharing options...
♥altoid Posted December 28, 2014 Share Posted December 28, 2014 https://github.com/gburton/osCommerce-234-bootstrap/commit/85225ccae51621c5e98390e5bb361b74611e6f66 Does this commit cure the problems ? Appears so, trying all three size options all's good. Here's a screenshot with setting of 6 with left and right columns. I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
burt Posted December 28, 2014 Author Share Posted December 28, 2014 Thanks @@Dan Cole - appreciated :) Thanks @@altoid - appreciated :) Looks good as the content is set to 6 (half), which gives the side columns 3 (quarter) each. Thanks for testing guys, I'll commit this to 234bs and 2.4 :thumbsup: Link to comment Share on other sites More sharing options...
burt Posted December 30, 2014 Author Share Posted December 30, 2014 https://github.com/gburton/osCommerce-234-bootstrap/milestones You can click on each Milestone to see individual tasks. When these Milestones are complete, I am going to declare 2.3.4(responsive) "gold", and there will then be no further changes (other than bug fixes). Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.