Jump to content
burt

Responsive osCommerce - Bootstrap

Recommended Posts

We definitely need to look at the two functions;

 

tep_draw_button

tep_image

 

both of these are useable, but not quite right - they need recoding. General idea is to pass individual arguments into the params (parameters) argument of these two functions. This allows the developer to do exactly as you want.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

I'm not sure what are Henry's plans for it. Please note that I am also updating 1 file later on today to solve an insignificant issue of display of buttons.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Yeah that's correct.

 

Users now have to explicitly pass the css to the button, if nothing is passed it "defaults" to btn-default (which is white with a grey hover effect).


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

I liked them in Green

 

So it now needs to be

 

tep_draw_button(IMAGE_BUTTON_IN_CART, 'glyphicon-shopping-cart', null, 'primary', null, 'btn-success');

 

Regards

 

Ken

Share this post


Link to post
Share on other sites

Correct. Or any of the button styles as found http://getbootstrap.com/css/#buttons


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Note that the previous commit was reverted and re-committed. Thanks to @@wHiTeHaT for spotting the extra unneeded line of code


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

I have recently installed KissER on my test site, and am receiving the following error:

E_NOTICE Error Count: 1

Error: Undefined variable: prod_list_contents

File: includes/modules/product_listing.php

Line: 105

 

 

This happens then I display a category that does *not* have any sub-categories, but does not happen when I display a category that *does* have a sub-category.

 

Malcolm

 

(2334bs3, with SEO Header Tags - Reloaded, and Better Checkout)


Get the latest Responsive osCommerce CE (community edition) here .

Share this post


Link to post
Share on other sites

I have recently installed KissER on my test site, and am receiving the following error:

 

E_NOTICE Error Count: 1

Error: Undefined variable: prod_list_contents

File: includes/modules/product_listing.php

Line: 105

 

 

This happens then I display a category that does *not* have any sub-categories, but does not happen when I display a category that *does* have a sub-category.

 

Malcolm

 

(2334bs3, with SEO Header Tags - Reloaded, and Better Checkout)

 

To corect this error on line 105 add

   $prod_list_contents = false;

or

   $prod_list_contents = null;

 

It's best for variables to be set with a default setting. I found this very helpful also in understanding comparisons.

http://docs.php.net/manual/en/types.comparisons.php


I'm not really a dog.

Share this post


Link to post
Share on other sites

To correct this error on line 105 add

$prod_list_contents = false;

or

$prod_list_contents = null;

 

It's best for variables to be set with a default setting. I found this very helpful also in understanding comparisons.

http://docs.php.net/manual/en/types.comparisons.php

 

That line currently is:

 

$prod_list_contents .= '<div id="product-listing">';

 

And, as I mentioned, if there is a sub-category, there is no error.

 

Malcolm


Get the latest Responsive osCommerce CE (community edition) here .

Share this post


Link to post
Share on other sites

Sorry, put it on line 104, not 105. Basically, the variable needs to be set and the reason you don't have that error when there is a sub category is the variable is then set. So, your lines will look like this

  $prod_list_contents = false;
  $prod_list_contents .= '<div id="product-listing">';
  $prod_list_contents .= '  <ul class="inline-span">';


I'm not really a dog.

Share this post


Link to post
Share on other sites

Sorry, put it on line 104, not 105. Basically, the variable needs to be set and the reason you don't have that error when there is a sub category is the variable is then set. So, your lines will look like this

 $prod_list_contents = false;
 $prod_list_contents .= '<div id="product-listing">';
 $prod_list_contents .= ' <ul class="inline-span">';

 

Thanks!

 

Malcolm


Get the latest Responsive osCommerce CE (community edition) here .

Share this post


Link to post
Share on other sites

@@ArtcoInc @@John W

Thanks for spotting this and providing the fix. Master updated.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Again: for debate about this and that, that have nothing to do with 2334BS, start a new thread.

 

Here is your discussion:

http://forums.oscommerce.com/topic/396834-commercial-aspect-of-gpl-open-source/

 

 

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Why do you want it reduced to one ? I personnally find the 2 buttons solution more clear


KEEP CALM AND CARRY ON

I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support).

So if you are still here ? What are you waiting for ?!

 

Find the most frequent unique errors to fix:

grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt

Share this post


Link to post
Share on other sites

Potential Bug found, need more testing please...

 

I had a report from a user who says that when using an iPad to view this:

 

http://www.template.me.uk/2334bs3/product_info.php?products_id=5

 

in landscape mode, the links in the breadcrumb do not work - however in portrait mode they do work.

 

Please could someone with an iPad (or in fact any tablet) take a look in both Hori and Vert modes and report back. Thank You.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Potential Bug found, need more testing please...

 

I had a report from a user who says that when using an iPad to view this:

 

http://www.template.me.uk/2334bs3/product_info.php?products_id=5

 

in landscape mode, the links in the breadcrumb do not work - however in portrait mode they do work.

 

Please could someone with an iPad (or in fact any tablet) take a look in both Hori and Vert modes and report back. Thank You.

 

samsung galaxy android version:

 

contrary to the above...portrait breadcrumb links don't respond, but rotated to landscape. they do work


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

Steve, I made a small change, would you be kind enough to test again? Thanks!


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Steve, I made a small change, would you be kind enough to test again? Thanks!

 

Working now Gary in both landscape and portrait on the samsung tablet. :thumbsup:


I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can.

I remember what it was like when I first started with osC. It can be overwhelming.

However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc.

There are several good pros here on osCommerce. Look around, you'll figure out who they are.

Share this post


Link to post
Share on other sites

Hi

 

Working OK now in landscape and portrait on a iPad.

 

Regards

 

Ken

Share this post


Link to post
Share on other sites

Thank You @@altoid @@Ken44

 

Commit

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

Confirmed. I can see the problem, and we could do an easy hardcoded fix like so: data-imgcount="15555555"

 

1 big, a row of 5 small, row of 5 small etc etc.

 

It seems overkill to try to do this by logic (grab the number of products in the DB for the product, remove 1, divide by some number, show those, iterate thru and come up with another row and so on.

 

Thoughts ?

 

We could even have the system ask the shopowner how they want to display their image in the header_tag module. Eg: 512 would show this;

 

 


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest Responsive osCommerce CE (community edition) here

Share this post


Link to post
Share on other sites

..

We could even have the system ask the shopowner how they want to display their image in the header_tag module. Eg: 512 would show this..

Much better than hardcoding a value and very versatile: I like!

Edited by ejsolutions

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×