auzStar Posted November 17, 2014 Share Posted November 17, 2014 @@burt It's code that I wrote. Why do you ask? My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted November 17, 2014 Author Share Posted November 17, 2014 I can take it, rework it, and place into the core? With no future problems? Link to comment Share on other sites More sharing options...
auzStar Posted November 17, 2014 Share Posted November 17, 2014 No problem. Just trying to help. cheers My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted November 17, 2014 Author Share Posted November 17, 2014 :thumbsup: Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted November 17, 2014 Share Posted November 17, 2014 I had saved this code that was linked to earlier function equalHeight(group) { tallest = 0; group.each(function() { thisHeight = $(this).height(); if(thisHeight > tallest) { tallest = thisHeight; } }); group.each(function() { $(this).height(tallest); }); } $(document).ready(function() { equalHeight($(".thumbnail")); }); this looks more generic, I'm not sure what the difference is between the two KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
auzStar Posted November 17, 2014 Share Posted November 17, 2014 Even better. The boxes are all the same height. :thumbsup: My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
auzStar Posted November 17, 2014 Share Posted November 17, 2014 I've combined both scripts above because I like how using the thumbnail class makes the all boxes a consistent size, but I'm concerned that the thumbnail class could be found elsewhere so better to still restrict it to the parent container that holds the grid. Using just the col-md-4 class creates a uniform grid but doesn't size the boxes consistently, so using with thumbnail class works well. All this relies on the fact that these classes will remain in the code, for the script to work, but a simple search and replace would find all occurrences for any alterations. cheers <script><!-- $(document).ready(function() { tallest = 0; $('.col-md-4:first').parent().each(function() { $(this).children('.col-md-4').each(function() { thisHeight = $(this).children('.thumbnail').height(); if (thisHeight > tallest) { tallest = thisHeight; } }); }); $('.col-md-4:first').parent().each(function() { $(this).children('.col-md-4').each(function() { $(this).children('.thumbnail').height(tallest); }); }); }); //--></script> My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 Could someone try this: /includes/modules/new_products.php From: $new_prods_content .= ' <div class="thumbnail">'; To: $new_prods_content .= ' <div class="thumbnail equal-height">'; And add at the bottom of the same file: <script><!-- function equalHeight(group) { var tallest = 0; group.each(function() { var thisHeight = $(this).height(); if(thisHeight > tallest) { tallest = thisHeight; } }); group.height(tallest); } $(document).ready(function(){ equalHeight($(".equal-height")); }); //--></script> Link to comment Share on other sites More sharing options...
auzStar Posted November 18, 2014 Share Posted November 18, 2014 @@burt Yes all good. Works for me. thanks burt My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 @@auzStar - it doesn't work for me in Chrome, but does in everything else. Could you check Chrome? Thanks Link to comment Share on other sites More sharing options...
auzStar Posted November 18, 2014 Share Posted November 18, 2014 @@burt It didn't appear to work when I first loaded it but after clearing cache and then reloading and refreshing to make sure it now appears to be OK. screen shot attached My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
auzStar Posted November 18, 2014 Share Posted November 18, 2014 oops! now attached My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 D'oh. I should have cleared my cache. OK, I'm going to make a couple more code changes, put the equal-heights into a HT module and commit it. Thanks to you @@auzStar and @@bruyndoncx Link to comment Share on other sites More sharing options...
♥mattjt83 Posted November 18, 2014 Share Posted November 18, 2014 @@burt I have used similar scripts quite a bit and one issue that can happen is that on the initial page load sometimes the dom is ready before the images have loaded so it will make all the boxes have a very tiny height. Reloading the page fixes it but it still can be a problem. It mostly happened when using Chrome. I ended up using basically the same function but waiting until dom loaded instead of dom ready. Matt Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 Matt can you paste the snippet u used ? Link to comment Share on other sites More sharing options...
♥mattjt83 Posted November 18, 2014 Share Posted November 18, 2014 $(window).load(function() { var maxHeight = 0; $(".your-class").each(function() { if ($(this).height() > maxHeight) { maxHeight = $(this).height(); } }); $(".your-class").height(maxHeight); }); Essentialy doing the same thing but waiting a bit longer. This of course does not go inside the normal document.ready functions. Matt Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 Team work for the community, I hope that @@bruyndoncx @@auzStar and @@mattjt83 get some thank you's.Equal Heights module now ships with Core - doesn't need to be turned on if you don't need it, as the core code only gets screwy for those with odd shaped images or long product names. https://github.com/gburton/osCommerce-234-bootstrap/commit/60701bef1b0dd150cfe666e62d2159006bea7b67 Please note that if you want to have this in your shop and just want to do this change, there are in fact TWO new files, and TWO updated files. Once done, go admin > modules > header tags > install > "equal heights divs (jquery)" Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted November 18, 2014 Share Posted November 18, 2014 I don't deserve the credit - someone, but I can't find who has posted this code a few weeks/months ago, and I was so smart to save it thinking this is going to come in handy sometime ... KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
newburns Posted November 18, 2014 Share Posted November 18, 2014 How can I change the default sort order? I managed to change the default sort listing, but I need it to sort descending. ../catalog/index.php if ( (!isset($HTTP_GET_VARS['sort'])) || (!preg_match('/^[1-8][ad]$/', $HTTP_GET_VARS['sort'])) || (substr($HTTP_GET_VARS['sort'], 0, 1) > sizeof($column_list)) ) { for ($i=0, $n=sizeof($column_list); $i<$n; $i++) { if ($column_list[$i] == 'PRODUCT_LIST_MODEL') { $HTTP_GET_VARS['sort'] = $i+1 . 'a'; $listing_sql .= " order by p.products_model"; break; } } } else { Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 @@newburns this is not a thread for advice. This thread is solely for discussion about bootstrap, bugs in our implementation, ideas and so on. Link to comment Share on other sites More sharing options...
newburns Posted November 18, 2014 Share Posted November 18, 2014 Alright. Sorry about that. Just an idea... Not sure it's possible, Allow the end user to select how the products are listed and sorted by default... Defaults to grid|list defaults to model|name|price|etc. Link to comment Share on other sites More sharing options...
burt Posted November 18, 2014 Author Share Posted November 18, 2014 @@newburns - probably not. But good way to rephrase your question :D :thumbsup: Ask in a new thread and see if one of the other users can help you. Link to comment Share on other sites More sharing options...
newburns Posted November 18, 2014 Share Posted November 18, 2014 :D I'm going to keep at it, and hopefully be able to make a suggestion to how other users can change it. The way I understand coding, if it's a value, then it is something that can be put into the mysql database. Therefore, an option can be listed under configuration or the header_tags modules to change that value. Which is reflected in the code for what happens by default. I like making suggestions more than asking questions. It's kinda fun on this side of the fence. Link to comment Share on other sites More sharing options...
auzStar Posted November 19, 2014 Share Posted November 19, 2014 Team work for the community, I hope that @@bruyndoncx @@auzStar and @@mattjt83 get some thank you's. Equal Heights module now ships with Core - doesn't need to be turned on if you don't need it, as the core code only gets screwy for those with odd shaped images or long product names. https://github.com/gburton/osCommerce-234-bootstrap/commit/1f0cac5890b4e215f5a21fdea7f4ff7efeeb42a6 Please note that if you want to have this in your shop and just want to do this change, there are in fact TWO new files, and TWO updated files. Once done, go admin > modules > header tags > install > "equal heights divs (jquery)" @@burt Works a treat :thumbsup: Just one small error though: :( in "catalog\includes\modules\header_tags\ht_div_equal_heights.php" inside the "install function()" for the "configuration_title" you have "Enable Clickable Table Rows Module" instead of "Enable Equal Height Divs Module" Too many chardonnays :D My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
auzStar Posted November 19, 2014 Share Posted November 19, 2014 @@burt :( Sorry! When I checked this I only viewed in grid views to check there were no holes. But discovered that when you switch from grid to list or vice versa the maxHeight is applied to both. So if you're in list view then refresh the page and then switch back to grid view the boxes are too small. This is because we've applied the "equal-height" class to the product_listing module. It's not an issue with the new_products module (no grid or list option), which is what my initial report was based on when I reported there were holes in the "New Products" display. We either remove the "equal-height" class from the product_listing module or change the script to one that addresses this problem. I came up with something that will reset the height when ever the "Grid" or "List" options are clicked and on window resize. Works quite well. Just need some else to test please. <script> <!-- var equal_height = $(".equal-height"); function equalHeight(group) { var maxHeight = 0; clearTimeout(timer); var timer = setTimeout(function() { // needed to set a slight delay to wait for grid to to appear before adjusting height group.height('auto'); // needed this for window resize group.each(function() { if ($(this).height() > maxHeight) { maxHeight = $(this).height(); } }); group.height(maxHeight); }, 10); } function autoHeight(group) { group.height('auto'); } $(document).ready(function() { $("#list").click(function() { autoHeight(equal_height); // reset heights to auto for list view }); $("#grid").click(function() { equalHeight(equal_height); // adjust heights in grid view }); }); $(window).resize(function() { // corrects each box size when resizing window otherwise boxes will be too small or too large if (!$('#product-listing .inline-span').hasClass('one-across fluid-one-across')) { // don't adjust when in list view equalHeight(equal_height); } }); $(window).load(function() { if (!$('#product-listing .inline-span').hasClass('one-across fluid-one-across')) { // don't adjust when in list view equalHeight(equal_height); } }); //--> </script> cheers My Add-onsAdvanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download SupportAjax Product Listing for osC 2.3.4 (bootstrap) Download SupportCategory New Products Carousel for osC 2.3.4 (bootstrap) Download SupportCategory Popular Products Carousel for osC 2.3.4 (bootstrap) Download SupportCustomer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportFront Page New Products Carousel for osC 2.3.4 (bootstrap) Download SupportIndex Nested - Product Listing for osC 2.3.4 (bootstrap) Download SupportMatch Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download SupportModular Category Page for osC 2.3.4 (bootstrap) Download SupportNEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download SupportNEW Equal Height Module for osC 2.3.4 (bootstrap) Download SupportProducts Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download SupportTwitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download SupportUpcoming Products Modules for osC 2.3.4 (bootstrap) Download Support Assisted Add-onsScroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support Bootstrap Add-ons created by other membersosCommerce Bootstrap Addons and Code Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.