burt Posted April 27, 2014 Author Share Posted April 27, 2014 We definitely need to look at the two functions; tep_draw_button tep_image both of these are useable, but not quite right - they need recoding. General idea is to pass individual arguments into the params (parameters) argument of these two functions. This allows the developer to do exactly as you want. Link to comment Share on other sites More sharing options...
♥Tsimi Posted April 29, 2014 Share Posted April 29, 2014 Where is the download link to @@wHiTeHaT s better menu? Link to comment Share on other sites More sharing options...
burt Posted April 29, 2014 Author Share Posted April 29, 2014 I'm not sure what are Henry's plans for it. Please note that I am also updating 1 file later on today to solve an insignificant issue of display of buttons. Link to comment Share on other sites More sharing options...
Ken44 Posted April 29, 2014 Share Posted April 29, 2014 @@burt The last bugfix to remove extra button class has changed the ‘Add to Cart’ buttons from Green to White in Product Info. Is this Correct? Regards Ken Link to comment Share on other sites More sharing options...
burt Posted April 29, 2014 Author Share Posted April 29, 2014 Yeah that's correct. Users now have to explicitly pass the css to the button, if nothing is passed it "defaults" to btn-default (which is white with a grey hover effect). Link to comment Share on other sites More sharing options...
Ken44 Posted April 29, 2014 Share Posted April 29, 2014 I liked them in Green So it now needs to be tep_draw_button(IMAGE_BUTTON_IN_CART, 'glyphicon-shopping-cart', null, 'primary', null, 'btn-success'); Regards Ken Link to comment Share on other sites More sharing options...
burt Posted April 29, 2014 Author Share Posted April 29, 2014 Correct. Or any of the button styles as found http://getbootstrap.com/css/#buttons Link to comment Share on other sites More sharing options...
burt Posted April 29, 2014 Author Share Posted April 29, 2014 Note that the previous commit was reverted and re-committed. Thanks to @@wHiTeHaT for spotting the extra unneeded line of code Link to comment Share on other sites More sharing options...
ArtcoInc Posted April 30, 2014 Share Posted April 30, 2014 I have recently installed KissER on my test site, and am receiving the following error: E_NOTICE Error Count: 1 Error: Undefined variable: prod_list_contents File: includes/modules/product_listing.php Line: 105 This happens then I display a category that does *not* have any sub-categories, but does not happen when I display a category that *does* have a sub-category. Malcolm (2334bs3, with SEO Header Tags - Reloaded, and Better Checkout) Link to comment Share on other sites More sharing options...
♥John W Posted April 30, 2014 Share Posted April 30, 2014 I have recently installed KissER on my test site, and am receiving the following error: E_NOTICE Error Count: 1 Error: Undefined variable: prod_list_contents File: includes/modules/product_listing.php Line: 105 This happens then I display a category that does *not* have any sub-categories, but does not happen when I display a category that *does* have a sub-category. Malcolm (2334bs3, with SEO Header Tags - Reloaded, and Better Checkout) To corect this error on line 105 add $prod_list_contents = false; or $prod_list_contents = null; It's best for variables to be set with a default setting. I found this very helpful also in understanding comparisons. http://docs.php.net/manual/en/types.comparisons.php I'm not really a dog. Link to comment Share on other sites More sharing options...
ArtcoInc Posted April 30, 2014 Share Posted April 30, 2014 To correct this error on line 105 add $prod_list_contents = false; or $prod_list_contents = null; It's best for variables to be set with a default setting. I found this very helpful also in understanding comparisons. http://docs.php.net/manual/en/types.comparisons.php That line currently is: $prod_list_contents .= '<div id="product-listing">'; And, as I mentioned, if there is a sub-category, there is no error. Malcolm Link to comment Share on other sites More sharing options...
♥John W Posted April 30, 2014 Share Posted April 30, 2014 Sorry, put it on line 104, not 105. Basically, the variable needs to be set and the reason you don't have that error when there is a sub category is the variable is then set. So, your lines will look like this $prod_list_contents = false; $prod_list_contents .= '<div id="product-listing">'; $prod_list_contents .= ' <ul class="inline-span">'; I'm not really a dog. Link to comment Share on other sites More sharing options...
ArtcoInc Posted May 1, 2014 Share Posted May 1, 2014 Sorry, put it on line 104, not 105. Basically, the variable needs to be set and the reason you don't have that error when there is a sub category is the variable is then set. So, your lines will look like this $prod_list_contents = false; $prod_list_contents .= '<div id="product-listing">'; $prod_list_contents .= ' <ul class="inline-span">'; Thanks! Malcolm Link to comment Share on other sites More sharing options...
burt Posted May 1, 2014 Author Share Posted May 1, 2014 @@ArtcoInc @@John W Thanks for spotting this and providing the fix. Master updated. Link to comment Share on other sites More sharing options...
burt Posted May 1, 2014 Author Share Posted May 1, 2014 Again: for debate about this and that, that have nothing to do with 2334BS, start a new thread. Here is your discussion: http://www.oscommerce.com/forums/topic/396834-commercial-aspect-of-gpl-open-source/ Link to comment Share on other sites More sharing options...
♥Tsimi Posted May 1, 2014 Share Posted May 1, 2014 @@burt sorry and thanks for moving the postings to the appropriate place. Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted May 5, 2014 Share Posted May 5, 2014 Why do you want it reduced to one ? I personnally find the 2 buttons solution more clear KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
burt Posted May 13, 2014 Author Share Posted May 13, 2014 Potential Bug found, need more testing please... I had a report from a user who says that when using an iPad to view this: http://www.template.me.uk/2334bs3/product_info.php?products_id=5 in landscape mode, the links in the breadcrumb do not work - however in portrait mode they do work. Please could someone with an iPad (or in fact any tablet) take a look in both Hori and Vert modes and report back. Thank You. Link to comment Share on other sites More sharing options...
♥altoid Posted May 13, 2014 Share Posted May 13, 2014 Potential Bug found, need more testing please... I had a report from a user who says that when using an iPad to view this: http://www.template.me.uk/2334bs3/product_info.php?products_id=5 in landscape mode, the links in the breadcrumb do not work - however in portrait mode they do work. Please could someone with an iPad (or in fact any tablet) take a look in both Hori and Vert modes and report back. Thank You. samsung galaxy android version: contrary to the above...portrait breadcrumb links don't respond, but rotated to landscape. they do work I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
burt Posted May 13, 2014 Author Share Posted May 13, 2014 Steve, I made a small change, would you be kind enough to test again? Thanks! Link to comment Share on other sites More sharing options...
♥altoid Posted May 13, 2014 Share Posted May 13, 2014 Steve, I made a small change, would you be kind enough to test again? Thanks! Working now Gary in both landscape and portrait on the samsung tablet. :thumbsup: I am not a professional webmaster or PHP coder by background or training but I will try to help as best I can. I remember what it was like when I first started with osC. It can be overwhelming. However, I strongly recommend considering hiring a professional for extensive site modifications, site cleaning, etc. There are several good pros here on osCommerce. Look around, you'll figure out who they are. Link to comment Share on other sites More sharing options...
Ken44 Posted May 13, 2014 Share Posted May 13, 2014 Hi Working OK now in landscape and portrait on a iPad. Regards Ken Link to comment Share on other sites More sharing options...
burt Posted May 14, 2014 Author Share Posted May 14, 2014 Thank You @@altoid @@Ken44 Commit Link to comment Share on other sites More sharing options...
burt Posted May 19, 2014 Author Share Posted May 19, 2014 Confirmed. I can see the problem, and we could do an easy hardcoded fix like so: data-imgcount="15555555" 1 big, a row of 5 small, row of 5 small etc etc. It seems overkill to try to do this by logic (grab the number of products in the DB for the product, remove 1, divide by some number, show those, iterate thru and come up with another row and so on. Thoughts ? We could even have the system ask the shopowner how they want to display their image in the header_tag module. Eg: 512 would show this; Link to comment Share on other sites More sharing options...
ejsolutions Posted May 19, 2014 Share Posted May 19, 2014 .. We could even have the system ask the shopowner how they want to display their image in the header_tag module. Eg: 512 would show this.. Much better than hardcoding a value and very versatile: I like! Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.