Jump to content
Latest News: (loading..)
burt

Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Recommended Posts

Just saw the video above...nice trick with the "switching the base" link. Saves me the dropdown selecting procedure.

Why didn't i see that.... :x

Edited by Tsimi

Share this post


Link to post
Share on other sites

@@greasemonkey

 

So, what you have now is a fork of my master, which is your master copy. You should never ever make changes to your master, the only changes to it come from pull requests from my master. If you did make changes to your master, you would introduce conflicts between your changes and my changes that you are attempting to pull. And that's a pain in the ass to solve.

 

What's next? On the next rainy afternoon, download sourcetree and have a play with it, there are many tutorials - basics is that you need to create a "branch" for your changes, and only ever work on that branch. You can then pull from my master to your master, and if necessary (to solve conflicts) manually apply the conflicted changes into your branch. That sounds complicated but is not really once you get to grips with it.

 

In summary

 

- make a master copy of my master - aka "fork".

- never make any direct changes to that master other than to pull from my master

- make a branch (or new fork of your fork) and work on that


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

The missing piece of the puzzle understand now

 

Thanks

Joli


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

@@Tsimi thank you kindly for the hints...

 

@@joli1811 lol yes.... It seems as I was looking for step 3.

 

@@burt thank you very kindly - I'm starting to get it. And just for the record (I need to correct myself) I'm in Toronto... It doesn't often "rain" in late November :( :( :(  so I will have to wait until the next "snowy" afternoon.

 

Just a thought, maybe a new thread just for basic github help would be appropriate? As I'm sure to be asking more questions and I didn't want this thread to get too far off topic.

Share this post


Link to post
Share on other sites

I wanted to test out the new content system to see if I could make a decent looking site, I came up with this;

 

 

 

Which you might be surprised to know that this touches NO core files at all.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Header Content Modules:

 

When header content module 'buttons' is enabled, it throws a PHP error on my system.

 

PHP Fatal error:  Call to a member function count_contents() on a non-object in /var/www/html/includes/modules/content/header/templates/buttons.php on line 4

 

Additionally, while it displays correctly on all browsers I tested, as a normal user, if the user agent is googlebot it will throw up a 500 page error and display only the nav bar.

 

Line 4 is

  echo tep_draw_button(HEADER_TITLE_CART_CONTENTS . ($_SESSION['cart']->count_contents() > 0 ? ' (' . $_SESSION['cart']->count_contents() . ')' : ''), 'glyphicon glyphicon-shopping-cart', tep_href_link('shopping_cart.php')) .

Cheers

 


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

@@frankl - I don't get an error like that...can you try this:

 

open up /includes/modules/content/header/cm_header_buttons.php

 

Find this:

 

global $oscTemplate;

 

Change to:

 

global $oscTemplate, $cart;

 

See if that fixes it?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Just tested working fine by me as regards the PHP error

 

Joli


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Just tested working fine by me as regards the PHP error

 

Joli

John is this working before the fix, or with my fix included?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@frankl - I don't get an error like that...can you try this:

 

open up /includes/modules/content/header/cm_header_buttons.php

 

Find this:

 

global $oscTemplate;

 

Change to:

 

global $oscTemplate, $cart;

 

See if that fixes it?

 

No, still the same. PHP version is 5.2.17


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

John is this working before the fix, or with my fix included?

@@burt

 

Without  fix working out of the box  just tested when I read the post the only thing is the site has a themeswitcher installed 

 

The options site I was talking about a few days back.

 

I think you have log in details it is an upgrade site from older bootstrap but most of the stuff was overwritten take a look if you want

 

and feel free to install uninstall etc...

 

demo  

 

php 5.3.28

 

PS: tested with nav bar in and out no problems either way just took it has far as shopping cart could not repeat the error

Edited by joli1811

To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

@@burt

 

Without  fix working out of the box  just tested when I read the post the only thing is the site has a themeswitcher installed 

 

The options site I was talking about a few days back.

 

I think you have log in details it is an upgrade site from older bootstrap but most of the stuff was overwritten take a look if you want

 

and feel free to install uninstall etc...

 

demo  

 

php 5.3.28

 

PS: tested with nav bar in and out no problems either way just took it has far as shopping cart could not repeat the error

 

When I view this page with googlebot as user agent page is black, no content, with an error

 

Fatal error: Call to a member function count_contents() on a non-object in /xxxx/xxxxx/public_html/penny/includes/modules/content/header/templates/buttons.php on line 4


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

Turned on strict error reporting few undefined constant is all I see


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

how do you view as google bot through webmaster tools??


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Fetch as google in Webmaster Tools, or fetch the page using aw-snap.info/file-viewer/ (using Googlebot as user agent).

 

I have a user agent spoofer addon for my browser, very handy.


Let's make things easier for new osCommerce users http://forums.oscommerce.com/topic/402638-discussion-about-hard-coded-database-tables/?p=1718900  Getting there with osCommerce 2.4! :thumbsup:

Share this post


Link to post
Share on other sites

Bit wierd this what browser are you using 

 

I am using firefox and the first website I came across shows ok

 

http://www.evolvedwebsites.com.au/googlebot/

 

just those undefined constant  but they are not so important

 

PS:

 

ok going to test with webmaster

post-185951-0-24689900-1417140260_thumb.png

Edited by joli1811

To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Ok confirmed  by big boss google webmaster

[28-Nov-2014 02:20:46 Europe/London] PHP Fatal error:  Call to a member function count_contents() on a non-object in /home/xxx/public_html/xxxx/includes/modules/content/header/templates/buttons.php on line 4

Strange by me no errors in log

 

the buttons appear fine

 

but I see a blank page and the error Frank mentioned from google webmaster fetch and render

 

The fix does not seem to work still testing a bit though


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Try global the $_SESSION as well.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt

function execute() {
     // global $oscTemplate;  
//  global $oscTemplate,  $_SESSION, $cart;
      global $oscTemplate, $cart, $_SESSION;
      $content_width = (int)MODULE_CONTENT_HEADER_BUTTONS_CONTENT_WIDTH;
 
complete blanko with buttons but error message is gone  without buttons it is  good
 
link


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Henrys the man of the moment :thumbsup:

 

Looks good the buttons I give x 4 columns so guess they need a bit more space especially with the log of .

 

wonder if google uses the same snapshot  thing as screenshot cache used to have not sure now.

 

Regards

John

post-185951-0-37255200-1417169981_thumb.png

Edited by joli1811

To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Excellent, I'll commit those changes in a moment. :thumbsup: @ @@wHiTeHaT


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

https://github.com/gburton/osCommerce-234-bootstrap/commit/b133ee05804fcdfcb338ea8c38171e17248e4ee8

 

this commit introduces the concept of templatable boxes, for anyone who wants to try them, let me know your thoughts.

 

Note that this is not committed to Master, only in a branch (for testing purposes).

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt

 

May I ask is the sort field in the navbar module supposed to work as no matter what sort order I use it is always at the top of the page.

 

Thanks

 

Mark


Bootstrap 3 ROCKS!

(or it will if I ever get my head around it lol)

(and I think I have now (w00t) )

Share this post


Link to post
Share on other sites

@@PupStar sort order is useless in that module unless there is another module in the navigation folder as well...make sense ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×