Jump to content
Latest News: (loading..)
burt

Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Recommended Posts

Hi

 

Just did an install of the latest

 

/github.com/gburton/osCommerce-234-bootstrap

 

to have a look and get the following message.

 

post-276414-0-58741100-1416796120_thumb.jpg

 

What have I done. I thought I was being so careful.

 

Cheers

 

Grandpa

 

SOLVED: Just kept "playing" with modules etc and allcame good.

Edited by grandpaj

Share this post


Link to post
Share on other sites

@@burt
 
In the screenshot attached you'll see that there are empty brackets after Flat Rate in the "Shipping Method" box (checkout confirmation page). This is due to the shipping module language files: flat, item & table having empty define('MODULE_SHIPPING_******_TEXT_WAY', ''); and therefore in checkout_ shipping.php line 129 (' . $quote[0]['methods'][0]['title'] . ') will still display with an empty title

                                'title' => (($free_shipping == true) ?  $quote[0]['methods'][0]['title'] : $quote[0]['module'] . ' (' . $quote[0]['methods'][0]['title'] . ')'),

 
This line also appears in a couple of the paypal payment ext modules.  Probably easier to fill the defines than check for null values in  $quote[0]['methods'][0]['title'] in all these files. As far as I can tell in previous versions of osCommerce these language files definitions for  define('MODULE_SHIPPING_******_TEXT_WAY', ''); were always populated.
 
cheers

post-290729-0-81059600-1416803717_thumb.jpg


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

@@auzStar

 

In the screenshot attached you'll see that there are empty brackets after Flat Rate

This is not a BS topic. This is in normal osC as well..


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Couple of minor errors in the footer suffix content modules.

Thanks for spotting. Fixed and committed.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

SOLVED: Just kept "playing" with modules etc and allcame good.

This took some investigation and seems to be caused by errant ; in SQL file.

 

THis commit fixes it, if you could find time to confirm by re-installing from scratch that would be excellent, thanks.

 

https://github.com/gburton/osCommerce-234-bootstrap/commit/68d37201945b9509b0aaef692c3bac75b96ca3db


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt

 

re: the mysterious MODULE_CONTENT_CREATE_ACCOUNT_LINK_SORT_ORDER issue

 

That is something that appears to (sometimes) not being loaded from the oscommerce.sql, for unknown reason, can anyone see why:
https://github.com/gburton/osCommerce-234-bootstrap/blob/master/install/oscommerce.sql#L1630

 

I did a test install of the latest 234bs and the issue still appeared.

The only thing I could see different in the bs version of the oscommerce.sql install file to other osc versions is that there are no comments or blank lines after the last sql statement. So I tried another clean install (new database table etc.) without the comments at the end of oscommerce.sql and this time it worked. The "Create Account Link" sort order was populated correctly. 

 

Can anyone else confirm?

 

cheers


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

i just did 2 test runs.

 

1 Run:

 

deleted the last 3 lines 1631, 1632 and 1633 and did an install

problem is still there. i still see the MODULE_CONTENT_CREATE_ACCOUNT_LINK_SORT_ORDER in the contents

 

2 Run:

 

deleted the last 2 lines 1632 and 1633 left one empty line 1631

problem seems to be solved as @@auzStar mentioned above.

Share this post


Link to post
Share on other sites

I also did another test and left 1 blank line at 1631 like @@Tsimi did, whereas in my previous successful test I had no blank lines (nothing after last sql statement).

 

Success again. So that's 2 successful with a blank line at 1631 and nothing else after.

 

Conclude that it's possibly an issue with the comments at the end.


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

I left one line because in the regular osC 2.3.4 oscommerce.sql file there is an empty line after the last statement, so i thought why not try to do the same thing.

Still i would have never guessed that THAT is the reason for not inserting the last statement correctly and therefore missing the text.

Edited by Tsimi

Share this post


Link to post
Share on other sites

Couple more minor issues in the latest 234bs:

 

Module box reviews defaults to "Product Page" on install.

      tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Content Placement', 'MODULE_BOXES_REVIEWS_CONTENT_PLACEMENT', 'Product Page', 'Should the module be loaded in the left or right column?', '6', '1', 'tep_cfg_select_option(array(\'Left Column\', \'Right Column\'), ', now())");

Also should bm_information.php module (and language) files exist since it was removed here?

https://github.com/gburton/osCommerce-234-bootstrap/commit/910b80fcb16060932faa7f82f019333b0366fb38

 

cheers


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

Then it would be wise to update the sql file in the github.

Maybe you can't add a pull request but i think burt should be able to change/edit the file.

I saw that you mentioned it but it wasn't changed.

Share this post


Link to post
Share on other sites

@@wHiTeHaT

Yes I can see that there was a commit here https://github.com/gburton/osCommerce-234-bootstrap/commit/9eb98b6b671e7d856e3f0b808b661cb21336bea2 to "add blank line in end of file" but there must have been some misunderstanding because there are comments after the last sql statement. But as @@Tsimi and I discovered it works without these comments at the end. I notice burt recently made some changes to remove the comments https://github.com/gburton/osCommerce-234-bootstrap/commit/18fb046622c474806d6db48194445765166d48ad

 

cheers


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

Also should bm_information.php module (and language) files exist since it was removed here?

https://github.com/gburton/osCommerce-234-bootstrap/commit/910b80fcb16060932faa7f82f019333b0366fb38

 

Sorry. I see now. Some modules are being included but not installed by default. :x


My Add-ons
Advanced Cache Control Tool for osCommerce 2.3.x (non-bootstrap) Download Support
Ajax Product Listing for osC 2.3.4 (bootstrap) Download Support
Category New Products Carousel for osC 2.3.4 (bootstrap) Download Support
Category Popular Products Carousel for osC 2.3.4 (bootstrap) Download Support
Customer Testimonials for osCommerce 2.3.4 (bootstrap and non-bootstrap) Download Support
Front Page New Products Carousel for osC 2.3.4 (bootstrap) Download Support

Index Nested - Product Listing for osC 2.3.4 (bootstrapDownload Support
Match Categories in Search Results for osCommerce versions 2.3.x (non-bootstrap) Download Support
Modular Category Page for osC 2.3.4 (bootstrap)
Download Support

NEW Australia Post Shipping Modules for osCommerce 2.3.x (non-bootstrap) Download Support
NEW Equal Height Module for osC 2.3.4 (bootstrapDownload Support
Products Low Stock Report for osC 2.3.x (bootstrap and non-bootstrap) Download Support
Twitter Typeahead Autocomplete Search for osCommerce 2.3.4 (bootstrap and non-bootstrap)
Download Support

Upcoming Products Modules for osC 2.3.4 (bootstrap) Download Support

 
Assisted Add-ons
Scroll Boxes for osCommerce 2.3.x (bootstrap and non-bootstrap) Download Support
 
Bootstrap Add-ons created by other members
osCommerce Bootstrap Addons and Code

Share this post


Link to post
Share on other sites

They are the same.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Not sure if these needs another thread - however, I'm wondering what the best way to keep 2.3.4bs up to date is? I have no clue how to use github - however, I can clearly see there have been lots of additions/changes since I downloaded a month or so ago by looking here https://github.com/gburton/osCommerce-234-bootstrap/commits/master

 

Should I just follow each commit and make the changes as you/the community makes improvements/changes?

 

In particular I was looking for the equalhights changes on index for new products on Nov 19th.

Share this post


Link to post
Share on other sites

@@greasemonkey you have at least two options;

 

1. create a github account and fork my master.

 

Now you have the ability to download a master zip from your fork. You also hve the ability to press a button to get any commits I have made to MY master into YOUR master - make sense ? So far so good. Now to find that button, read this: http://www.hpique.com/2013/09/updating-a-fork-directly-from-github/

 

OR

 

2. Download my master, and keep that .zip file somewhere at your desktop. Make a note of the date you download (should possibly be in the properties of the downloaded .zip file??). Or make a note of the last commit made, this is shown in my github near to the top of the file list. Or you can press the commit button and see a list of them as you pointed out. Now you can work thru each commit adding to your master zip

 

#1 is the simpler way by far. Try it, post back if you need more help with doing it...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

thank you kindly @@burt

 

Option 1 sounds like a bit of a rainy day project - but something I would like to do.

 

So, I will grab the equalheight stuff for now - and maybe over the holidays when we are less busy get going on the github "thing"

Share this post


Link to post
Share on other sites

It would take you not more than 10 minutes start to finish ... ;)

 

Once you got that 10 minutes done, then 30 seconds (1 button press) each time you want to update.

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

How to set up a new Github and Fork an existing project so that you have a master copy:

 

 

This shows the process takes less than 2 minutes.

I am sorry there is no sound, I could not find my headset.

 

Next video will show how to check that your new master is up-to-date with my master.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Pre-step to this video: I changed the README document in my master so that the burtyblotto fork would pull it in. I could just as easily have changed index.php or any other files, or 20 files or 100 files, or added new files or whatever...had I not changed at least 1 file, I could not have shown the new Pull Request system that Github recently introduced. Hope this makes sense ?

 

 

Again, no sound - sorry. It's easy to follow though.

 

Important Note: Once you have a master fork, it's important that you NEVER manually change it (as you might then get a conflict between a file you have updated and a file that I have changed at my master). I suspect that might lead to more questions (from those who not only want to keep a master, but also want to try their hand at coding) - I'll try my best to answer those questions as they arise, but those questions really don't affect those who simply want to keep a clean master copy. Only ever change your Master by pulling in any commits from my Master.

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt ok step one is done... yes 2 mins.

 

I'm having trouble wrapping my brain around Step 2.

 

How do I compare the changes I've already made to your fork? Do I need to start a new repository and upload my files?

Share this post


Link to post
Share on other sites

Hi Scott

 

I asked burt the same question few days ago. How can i keep my fork up to date with his new commits.

What i found to be the easiest way for me is.

 

Go to your fork and click on the the green button left (compare, review, create pull request)

It will probably show you this message

 

There isn't anything to compare

 

ignore that and click on the edit button right side. Now you should see a "base fork" and a "head fork" dropdown. Now switch those two. Make your fork the base one and gary's one the head fork.

The moment you change one of the dropdowns the view will change and you should see this

 

We’re showing branches in this repository, but you can also compare across forks.

 

click on the "compare across forks" link to setup the second dropdown.

Now it should show you the different commits and you should see a big "create pull request" button, click on that.

Now name it what ever you like and click on the "create pull request" button.

Now you should see this message somewhere

 

This pull request can be automatically merged.

 

with a "merge pull request" button on the right.

click on that button.

again rename it if you want or just click "confirm merge"

DONE!

Now you should see some sort of confirmation and a revert button on the right just in case you want to undo the merge/commit.

 

the only thing confusing about this is now that you are one commit ahead of burts, because of the merging. ignore that and keep that memorized in your head.

 

This is how I did it.

Edited by Tsimi

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×