Jump to content
Latest News: (loading..)
burt

Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Recommended Posts

I'm thinking to re-introduce tables into the checkout_shipping and checkout_payment for the module output. Any got any reasons why this should not happen ?


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

I always thought that BS doesn't allow table structures, only div classes, until I started to work with BS myself and now I use mostly tables for the admin area.

They look good in BS and they are responsive. So it is OK to use tables i guess.

 

What is the reason for your change of mind??

Edited by Tsimi

Share this post


Link to post
Share on other sites

I'm thinking to re-introduce tables into the checkout_shipping and checkout_payment for the module output. Any got any reasons why this should not happen ?

Personally, I find tables considerably easier to work with (especially as I hand code - no GUI/IDE) but is this not a retrograde step, in terms of modern coding style?

Share this post


Link to post
Share on other sites

Reverting to the tables based layout is a sideways step - I made the wrong decision to try to break the output out of a table (as it tabular data)...

 

I'll have a play with the code.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Testers Required Please:

 

Please make a backup copy of your existing checkout_shipping.php and then use this instead;

 

http://pastebin.com/KSCUhMw3

 

Please report back (with screenshot if possible) of how it acts/looks etc.

 

All being well, it should look like this (for example):

 

 

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

at first i didn't realise the difference because there was only one shipping method. If you offer many different shipping methods then it looks good and easy to see because of the striped class of BS. the only thing that would be great is if you click the row <tr> the radio button should be checked/filled. same as I did in my japanese shop.

there is no problem when resizing. looks fine so far to me.

Edited by Tsimi

Share this post


Link to post
Share on other sites

@@Tsimi I can click the radio buttons on your site but couldn't click on a row and have the button selected as you mentioned.

Share this post


Link to post
Share on other sites

@@Dan Cole

That is because it is not in that shop. That is just a BS test shop. My other shop is not BS but i can click the whole row and the radio button gets checked.

I don't know how difficult it would be to do that for a BS shop.

Edited by Tsimi

Share this post


Link to post
Share on other sites

Adding a clickable row is easy enough and is something that can be added when this thread is complete and @@wHiTeHaT has decided which code is best for the purpose...


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt Re post #839

 

Did this, downloaded from the link provided, checkout-shipping.php and got this

 

post-276414-0-50118600-1401224343_thumb.jpg

 

and the rest of the page was the same as the "standard" page.

 

I think I must be stupid as Ive obviously done something wrong guess its all about learning.

 

Cheers

Grandpa

Edited by grandpaj

Share this post


Link to post
Share on other sites

You most likely have whitespace or new lines before the start <?php or after the end ?>

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt

 

Tested on local, looks as your screenshot does, performs as expected. Just need the whole row to select the radio when when clicked.

 

I think I pasted some code for the shipping and payment method tables somewhere a zillion pages back in this thread. I'll have to see if I can find it.

 

I think that's about the time you said we were not going back to tables, though we are dealing with tabular data. (w00t)


Follow the community build:

BS3 to osCommerce Responsive from the Get Go!

Check out the new construction:

Admin Gone to Total BS!

Share this post


Link to post
Share on other sites

@@grandpaj @ - thanks for testing :)

 

@ - http://pastebin.com/tyQ663Yf


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Hi @@burt

 

I downloaded the latest version of checkout_shipping.php.

I had to test locally as I only have one shipping method on live site.

The clickable row appears to work great.

 

On my monitor there is virtually no difference between the highlight grey colour and the grey on the striped table alternate lines, however it is not a problem.

 

I’ve attached a screen capture

 

http://tinyurl.com/msvj4xa

 

 

Regards

 

Ken

Edited by Ken44

Share this post


Link to post
Share on other sites

Great thanks @@Ken44 :thumbsup:

 

All; I'll change the payment page in a bit and upload the changes for testing.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt with the release of 2.3.4 is the intention to now release a 2.3.4 BS version and if so any idea on the timeline? I'm wanting to update to 2.3.4 and looking for a BS version but I really don't want to have to tackle it twice.

Share this post


Link to post
Share on other sites

@@Dan Cole.

Maybe you could tackle it once (on a base 2334BS), then make a zip of all the changed / new files.

That would help a lot.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@burt I'm willing to help in any way I can Gary....I have a copy of Beyond Compare and I can walk through it file by file and produce a zip file of the changed files. Maybe we can get a few folks involved and walk through it fairly quickly. Just so we're on the same page here is a comparison report on the catalog directory...as I understand the task you'd like me to merge the individual changes/differences between the files (2.3.3.4BS to 2.3.4) into a new combined file and then zip them up for you. Is that what you'd like?

 

http://www.aquarist.info/osc_project/Catalog_Directory_Compare_Report.html

Share this post


Link to post
Share on other sites

@@Dan Cole = easier to take a 2334bs and work through the "file changes" on

http://library.oscommerce.com/Online&en&oscom_2_3&release_notes&v2_3_4

 

Then zip up the result and send to me.

 

I have already done this, but would like at least one other person to do the same, so that I can compare my changes agsinst the other persons. Even better would be for someone else as well as you to volunteer to do the same and also send me the result, so that I can compare the three.

 

Thanks.

 

Taking a new 234 and working it, to make the same changes we made in 2334 > 2334bs would be far too much work. Easier as above to go 2334bs > file changes walkthru = 234bs


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
Hi Burt

 

I have emailed my updates to v234BS for you to compare. I have not touched the content modules so they may need adjustment.

 

Regards

 

Ken

Share this post


Link to post
Share on other sites

@@Dan Cole = easier to take a 2334bs and work through the "file changes" on

http://library.oscommerce.com/Online&en&oscom_2_3&release_notes&v2_3_4

 

Taking a new 234 and working it, to make the same changes we made in 2334 > 2334bs would be far too much work. Easier as above to go 2334bs > file changes walkthru = 234bs

I wondered about that...will do Gary, unless someone else in addition to Ken beats me to it.

 

Dan

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×