Jump to content
burt

Bootstrap 3 in 2.3.4 - Responsive from the Get Go

Recommended Posts

Do what you like, whatever you think can be made better or is missing. I can then cherry-pick and commit to master.

 

I would particularly like to see;

 

1. horizontal / drop down menu, based on existing menu class file.

2. full addon for information pages, coded well, not the awful thing in the addons area.

3. Guest checkout, non invasive to the existing core code

4. Login with Facebook / Paypal

5. Get SEO built in

6. Update Banners Manager to allow addition of carousel style images in front page

7. Addition of "js turned off" module [ https://github.com/gburton/osCommerce-2334-bootstrap/commit/2c99f35e759d960f7d2cf2460384fdd82afbccbc ]

8. Addition of "back to top" module

9. Start of a plan for a template system

 

Also, these need doing ASAP;

 

a. Clean up of any tables in the shop side (there are 3 or 4 tables left)

b. Make the two external files change to being called internally + source the files Thanks @@mattjt83

c. Update other infoBoxes to be able to be called in footer / product page

d. social icons (made by someone here, or available for use MIT or GPL)

 

So, which developers are volunteering to do what ? Quote this post, with the bit you want to take on...

Edited by burt

This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

And for those who are not developers but want to help;

 

visit (in your phone, tablet, computer) http://template.me.uk/2334bs3/ and report any bugs or display problems.

 

Thanks


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

just saw the header navi bar. looks awesome! :thumbsup:

love the fire icon next to the "special offers" and the menu button? when you go into XS view.

all in all it looks really, really nice. header area, footer area = KILLER! that is how it should look.

run the store through gtmetrix; page speed: 94% A and y-slow: 90% A !! (w00t) i don't know how much value this gtmetrix data has......but it makes you feel good to see such numbers right? :shifty:

i really enjoy to browse through this BS store, there is nothing that makes me feel uncomfortable or stressed.

 

BRAVO! @@burt

Edited by Tsimi

Share this post


Link to post
Share on other sites

Thanks @@Tsimi

 

Should now be a nanosecond faster as I removed all the un-needed boxes (those which now exist as links in the header area for example). Only boxes left are categories and manufacturers.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Thanks @@Tsimi

 

Should now be a nanosecond faster as I removed all the un-needed boxes (those which now exist as links in the header area for example). Only boxes left are categories and manufacturers.

 

@@burt

 

awesome, left column and main only. that increased the speed a little bit. you know i like that layout. ;)

please don't make such changes if i see this i loose my will and motivation to continue working on my current store. :P

Edited by Tsimi

Share this post


Link to post
Share on other sites

@@burt

 

When will you push the latest changes you have made to your git? I was going to have a look at the header area but I wanted to work with the latest changes you have made.


Matt

Share this post


Link to post
Share on other sites

@@mattjt83 - thanks, it's still being worked on. You can fork then cherry commit the upcoming changes back into yours.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

One small point. On wider resolutions, when the footer spreads itself out, the Mastercard and part of the Paypal icons are hidden by the floating return to top device


OsC 2.3.4.1 CE Frozen   PHP 7.2   MySQL 10.1.36-MariaDB-cll-lve

Share this post


Link to post
Share on other sites

And for those who are not developers but want to help;

 

visit (in your phone, tablet, computer) http://template.me.uk/2334bs3/ and report any bugs or display problems.

 

Thanks

 

Hi Gary,

 

First time I have seen this problem maybe caused by some recent changes on first page load the glyphicon icons are not appearing after first click all is ok

 

Using firefox normal laptop

 

John

post-185951-0-44539400-1395860675_thumb.jpg


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

Hi Gary,

 

First time I have seen this problem maybe caused by some recent changes on first page load the glyphicon icons are not appearing after first click all is ok

 

Using firefox normal laptop

 

John

 

that sometimes happens to me but is ok after couple of refreshes.


Bootstrap 3 ROCKS!

(or it will if I ever get my head around it lol)

(and I think I have now (w00t) )

Share this post


Link to post
Share on other sites

One small point. On wider resolutions, when the footer spreads itself out, the Mastercard and part of the Paypal icons are hidden by the floating return to top device

 

The return to top thing is not going to make it into Core as it stands as it does not work on mobile devices :(


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

First time I have seen this problem maybe caused by some recent changes on first page load the glyphicon icons are not appearing after first click all is ok

 

I don't know why that is.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

@@joli1811@@PupStar

 

That happens if the URL doesn't have the www first.

 

@mattj83 but not on yours ;)


Bootstrap 3 ROCKS!

(or it will if I ever get my head around it lol)

(and I think I have now (w00t) )

Share this post


Link to post
Share on other sites

I don't know why that is.

 

:D :P yes confirmed it is Burts lazy link

 

 

That happens if the URL doesn't have the www first.

 

@@mattjt83


To improve is to change; to be perfect is to change often.

 

Share this post


Link to post
Share on other sites

That's strange. Oh well ;)


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

Online demo of some header and footer changes: http://bettercheckout.com/demo/2334_BS3/

In the small view when the top navigation is collapsed, selecting one of the dropdowns (settings or account) gives a scrollbar on the right, I personally feel it would be better if the area just expanded as needed, so you only keep one (browser) scrollbar.


KEEP CALM AND CARRY ON

I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support).

So if you are still here ? What are you waiting for ?!

 

Find the most frequent unique errors to fix:

grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt

Share this post


Link to post
Share on other sites

Good. Remember always; because something is not in the core does not mean it is not valuable. That is why there will be a marketplace for addons commercial and free.


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

The return to top thing is not going to make it into Core as it stands as it does not work on mobile devices :(

 

On my mobile it works like a charm.

Tested in vertical and horizontal view.

Share this post


Link to post
Share on other sites

@@joli1811@@PupStar

 

That happens if the URL doesn't have the www first.

 

We have already see this bug while using fontawesome + bootstrap. To solve it we had this in htaccess

 

<FilesMatch "\.(ttf|otf|eot|woff)$">
<IfModule mod_headers.c>
Header set Access-Control-Allow-Origin "*"
</IfModule>
</FilesMatch>

Share this post


Link to post
Share on other sites

@@burt

 

Tested the search on your test site: Searched for "Microsoft" - 4 items found - displayed in a list: 1. item displayed in a full width box, 2. item in a 2/3 box, 3. has an undefined width and 4. nearly half width.

Now I click on the grid button, but it doesn't switch to the grid view, but I will headed back to the default site.

Share this post


Link to post
Share on other sites

@@De Dokta - the answer to that is pretty obvious if you think about it ;)


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites

 

 

We have already see this bug while using fontawesome + bootstrap. To solve it we had this in htaccess

 

<FilesMatch "\.(ttf|otf|eot|woff)$">
<IfModule mod_headers.c>
Header set Access-Control-Allow-Origin "*"
</IfModule>
</FilesMatch>

 

I added this to the test shop .htaccess, could those who were getting a problem, test it again;

 

http://template.me.uk/2334bs3/index.php

 

and report if it is now OK (or still broken).


This is a signature that appears on all my posts.  
IF YOU MAKE A POST REQUESTING HELP...please state the exact version
of osCommerce that you are using. THANKS

 
Get the latest current code (community-supported responsive 2.3.4.1BS Edge) here

 

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×