mpotvin Posted June 21, 2013 Share Posted June 21, 2013 Hello Brouillard, I have installed Newsletters Subscribers Manager - Oscommerce 2.3 & 2.2 but the email is still being sent only to customers. Anybody have a solution. http://antiquerb.ca/gabaritcommerce/t9816/www/ The newsletter manager is still showing in the tools options menu... I would appreciate any solution idea. Michèle Quote Link to comment Share on other sites More sharing options...
sembrouille Posted June 23, 2013 Author Share Posted June 23, 2013 Hi Michèle (ma belle) ! You forgot something in the install, Table (newsletter_abonnement), or update file maybe (admin/includes/modules/newsletters/newsletter.php) ... Quote Link to comment Share on other sites More sharing options...
Shazam_Brazil Posted June 25, 2013 Share Posted June 25, 2013 Hello, I'm from Brazil, I installed this contribution and really liked it, everything works fine, but has a problem I can not solve. If you click the subscribe button to accept it anyway, even if they put the wrong email or write with space or @, this is bad. NB: And I have installed the file catalog / includes / language / português.php and all is right. My version is 2.2 my store: www.shazammagicas.com This contribution is in the box to the left below, can be tested and see that just click and not showing an error message. I really appreciate if someone can help me! Oscar Rocha São Paulo - Brazil www.shazammagicas.com.br Quote Link to comment Share on other sites More sharing options...
Shazam_Brazil Posted June 29, 2013 Share Posted June 29, 2013 Hello Brouillard, The file "newsleter_boxe.php" in its contribution is wrong, I managed to work well with this file below, but it still has an error, if not put anything in the field of e-mail it works fine and the correct phrase appears in the pop-up, but if you put comma or space does not report the correct phrase but the "BOX_NEWSLETTER_ERREUR_VIRGULE" to comma and "BOX_NEWSLETTER_ERREUR_ESPACES" for spaces. I do not know what's wrong but the file below works best: Oscar Rocha São Paulo - Brazil <?php /* $Id: boxe newsletter.php le 05 Avril 2012 Auteur : Brouillard s'embrouille ([email protected]) osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright © 2012 osCommerce Released under the GNU General Public License */ ?> <!-- boxe newsletter //--> <script type="text/javascript"> function VerifierMail(form) { if (form.emailabonnement.value == "" ) { alert("<?php echo BOX_NEWSLETTER_ERREUR_CHAMP_VIDE; ?>") form.emailabonnement.focus(); return false; } else if (form.emailabonnement.value.indexOf(",") > 0) { alert("' . BOX_NEWSLETTER_ERREUR_VIRGULE . '") form.emailabonnement.focus(); return false; } else if (form.emailabonnement.value.indexOf(" ") > 0) { alert("' . BOX_NEWSLETTER_ERREUR_ESPACES . '") form.emailabonnement.focus(); return false; } else if (form.emailabonnement.value.indexOf("@") < 0) { alert("' . BOX_NEWSLETTER_ERREUR_AROBASE . '") form.emailabonnement.focus(); return false; } else if (form.emailabonnement.value.lastIndexOf(".") < 0) { alert("' . BOX_NEWSLETTER_ERREUR . '") form.emailabonnement.focus(); return false; } else if ((form.emailabonnement.value.length - 1) - form.emailabonnement.value.lastIndexOf(".") < 2) { alert("' . BOX_NEWSLETTER_ERREUR . '") form.emailabonnement.focus(); return false; } else { // form.submit() return true; } } </script> <tr> <td> <?php $info_box_contents = array(); $info_box_contents[] = array('align' => 'left', 'text' => BOX_HEADING_NEWSLETTER ); new infoBoxHeading($info_box_contents, false, false); $info_box_contents = array(); $info_box_contents[] = array('align' => 'center', 'text' => BOX_NEWSLETTER_TEXT_ABONNEMENT . '<br><br>' . tep_draw_form('newsletterabonnement', tep_href_link(FILENAME_NEWSLETTER_ABONNEMENT, '', 'NONSSL'), 'post', 'onsubmit="return VerifierMail(this);"') . BOX_NEWSLETTER_TEXT_EMAIL . '<br>' . tep_draw_input_field('emailabonnement', '', 'size="20" maxlength="50"') . '<br>' . tep_image_submit('sinscrire_newsletter.gif', IMAGE_BUTTON_CONTINUE, 'SSL') . '</form>'); new infoBox($info_box_contents); ?> </td> </tr> <!-- boxe newsletter eof //--> Quote Link to comment Share on other sites More sharing options...
sembrouille Posted June 29, 2013 Author Share Posted June 29, 2013 Hi oscar ! I saw that you have a lot of "javascript" on your website and I think your problem is one of this mixture. Regards BS. Quote Link to comment Share on other sites More sharing options...
sembrouille Posted June 29, 2013 Author Share Posted June 29, 2013 You don't translated all files ! ?? Quote Link to comment Share on other sites More sharing options...
Shazam_Brazil Posted June 29, 2013 Share Posted June 29, 2013 Hello brouillard, I think I found the problem that was happening, realized I file "newsletter.boxe.php" extract the block "arobase" all others works well. Then I noticed that the file "/ catalog / includes / languages / english.php" in line arobase had backslashes "\" in the text ('Incorrect email address, lacks an at sign \ "@ \".');) then pulled out and just let @, why not accept slashes and quotes. So now put the block in the file arobase "newsletter.boxe.php" and everything works fine. Just do not know how to work the two blocks after arobase because I never see any error message appears, but everything now works fine. NB: I'm not the only one who had problems with this, see the post above Michelle, I went there and saw it in the store that has the same error there too, if she read my post here can fix your store. Thank you and sorry for my poor translation. Oscar Rocha São Paulo - Brazil www.shazammagicas.com.br Quote Link to comment Share on other sites More sharing options...
mpotvin Posted July 10, 2013 Share Posted July 10, 2013 Hi Michèle (ma belle) ! You forgot something in the install, Table (newsletter_abonnement), or update file maybe (admin/includes/modules/newsletters/newsletter.php) ... Thank you, finally got it to work. Hourra!!!!!!! Quote Link to comment Share on other sites More sharing options...
ken0306 Posted July 19, 2013 Share Posted July 19, 2013 Hi, I got a question relate to the duplications on subscriber issues. So, if a customer sign up newsletter before they create an account, it will insert as a new record in the database. So, if they create an account and click on the newsletter subscription under the account section again, it will insert as a second record. However, when customer unsubscribe your newsletter from subscribing link, it only deleted one record from the database. I need to login to customer account to uncheck the box again. So, how do you guys deal with this kind of issues. Thank you ken Quote Link to comment Share on other sites More sharing options...
Comesticage Posted July 23, 2013 Share Posted July 23, 2013 Hello, My site is www,oxytarm-ap.com Great add-on! I even put it at the header level. However, there are 2 things i ll like to modify a) i wish to change the words "Subscribe to the newsletter" - how to do so? B) The "Subscribe" word on the button i would also like to change it to "Get it NOW!" - any idea how to do this edit? Thanks in advance! Great Add-on again! Regards, Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 24, 2013 Author Share Posted July 24, 2013 a) you can change it in : /includes/languages/english/newsletter_abonnement.php B) you can change the button in : /includes/languages/french/images/buttons/sinscrire_newsletter.gif Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 24, 2013 Author Share Posted July 24, 2013 Hi Eugene Gan ! Quote Link to comment Share on other sites More sharing options...
Comesticage Posted July 24, 2013 Share Posted July 24, 2013 a) you can change it in : /includes/languages/english/newsletter_abonnement.php B) you can change the button in : /includes/languages/french/images/buttons/sinscrire_newsletter.gif <?php /* $Id: newsletter_abonnement.php le 05 Avril 2012 Auteur : Brouillard s'embrouille ([email protected]) osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2012 osCommerce Released under the GNU General Public License */ define('NAVBAR_TITLE', 'Newsletters'); define('HEADING_TITLE', 'XXXXXXXXXXXXXXX'); define('TEXT_INFORMATION', '<strong>Thank you for your newsletter subscription.</strong><br />A confirmation email has been sent.'); define('EMAIL_WELCOME_SUBJECT', 'Welcome to ' . STORE_NAME); define('EMAIL_WELCOME', 'Thank you for your ' . STORE_NAME . ' Newsletter subscription<br /><br />This message informs you that your registration was successfully processed and you are now registered for our newsletter. <br /><br />If you did not register to receive our Newsletter, you can unsubscribe by clicking the unsubscribe link at the bottom of this email.'); define('TEXT_PRIVACY_EMAIL', '<br /><br />Your information is confidential and will never be retransmitted, please visit our privacy policy : ' . '<a href="' . tep_href_link(FILENAME_PRIVACY, '', 'NONSSL') . '">' . tep_href_link(FILENAME_PRIVACY, '', 'NONSSL') . '</a>'); define('NL_DESABONNEMENT_LINK', '<br /><br />To unsubscribe:<br /><a href="' . tep_href_link(FILENAME_NEWSLETTER_DESABONNEMENT, '%s', 'NONSSL') . '">' . tep_href_link(FILENAME_NEWSLETTER_DESABONNEMENT, '%s', 'NONSSL') . '</a>'); define('TEXT_EMAIL_HTML', 'HTML'); define('TEXT_EMAIL_TXT', 'Text'); define('PREVENIR_EMAIL_NEW_INSCRIT_NL', 'oui'); define('EMAIL_NEW_INSCRIT_NL', 'A new subscribe to the Newsletter'); //mis en page html----------------------------------------------- define('EMAIL_START_HTML', '<html><head> </head><body>'); define('EMAIL_STOP_HTML', '<br /></body></html>'); define('EMAIL_SPAN_START_STYLE', '<span style="font-family:Verdana, Arial, sans-serif; font-size:12px;">'); define('EMAIL_SPAN_STOP_STYLE', '</span>'); //fin mis en page html----------------------------------------------- ?> I looked for the "Subscribe to the newsletter" can't find it... where is it? My website is www.oxytarm-ap.com Thanks! Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 25, 2013 Author Share Posted July 25, 2013 and here --> /includes/languages/english/modules/boxes/bm_newsletter_boxe.php Quote Link to comment Share on other sites More sharing options...
Comesticage Posted July 25, 2013 Share Posted July 25, 2013 @@sembrouille Nope, can't find the place to edit "Subscribe to the newsletter" It is not inside /includes/languages/english/modules/boxes/bm_newsletter_boxe.php Are you the creator of this add-on? Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 26, 2013 Author Share Posted July 26, 2013 You can change this text /includes/modules/newsletter_footer.php BOX_NEWSLETTER_TEXT_ABONNEMENT by 'I want you' Or somthing like this, don't forget quotes Quote Link to comment Share on other sites More sharing options...
Comesticage Posted July 26, 2013 Share Posted July 26, 2013 (edited) @@sembrouille Hi thanks a lot. I manage to change the wordings. like to ask you, if i choose to remove this wordings 'subscribe to our newsletter' so that i can make my header more compact. too much empty spaces (see the ||) How do i do so? Can i also try to change the wordings of the Subscribe button to Subscribe newsletter..Hope it's not too much trouble for you to guide me. Edited July 26, 2013 by Comesticage Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 26, 2013 Author Share Posted July 26, 2013 You can find all defines in step (8) ---> /catalog/includes/languages/english.php File install.html step (8) : // ################# Contribution Newsletter by brouillard s'embrouille ########### define('IMAGE_BUTTON_NEWSLETTER_ABONNEMENT', 'Subscribe'); define('IMAGE_BUTTON_NEWSLETTER_DESABONNEMENT', 'Unsubscribe newsletter'); define('BOX_HEADING_NEWSLETTER', 'Newsletter'); define('BOX_NEWSLETTER_TEXT_ABONNEMENT', 'Subscribe to the newsletter'); define('BOX_NEWSLETTER_TEXT_EMAIL','Email: '); define('BOX_NEWSLETTER_ERREUR', 'Incorrect email address.\n" + form.emailabonnement.value + " is not a valid email address.'); define('BOX_NEWSLETTER_ERREUR_CHAMP_VIDE', 'Error, the email address field is empty.'); define('BOX_NEWSLETTER_ERREUR_VIRGULE', 'Incorrect email address, it must not contain comma.'); define('BOX_NEWSLETTER_ERREUR_ESPACES', 'Incorrect email address, it must not contain spaces.'); define('BOX_NEWSLETTER_ERREUR_AROBASE', 'Incorrect email address, lacks an at sign \"@\".'); // ################# Fin Contribution Newsletter by brouillard s'embrouille ########### ?> Quote Link to comment Share on other sites More sharing options...
sembrouille Posted July 28, 2013 Author Share Posted July 28, 2013 @@Comesticage Yes, I am Quote Link to comment Share on other sites More sharing options...
Comesticage Posted July 30, 2013 Share Posted July 30, 2013 @@sembrouille www.oxytarm-ap.com I did it! thanks for the great add on! Quote Link to comment Share on other sites More sharing options...
Comesticage Posted August 2, 2013 Share Posted August 2, 2013 @@sembrouille Hi, i found another place i need to edit. Where i click on my privacy notice, http://oxytarm-ap.com/shop/catalog/privacy.php It writes the below Privacy Notice Put here your Privacy Notice information. Went into the privacy.php file, and got this <?php /* $Id$ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright (c) 2010 osCommerce Released under the GNU General Public License */ require('includes/application_top.php'); require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRIVACY); $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_PRIVACY)); require(DIR_WS_INCLUDES . 'template_top.php'); ?> <h1><?php echo HEADING_TITLE; ?></h1> <div class="contentContainer"> <div class="contentText"> <?php echo TEXT_INFORMATION; ?> </div> <div class="buttonSet"> <span class="buttonAction"><?php echo tep_draw_button(IMAGE_BUTTON_CONTINUE, 'triangle-1-e', tep_href_link(FILENAME_DEFAULT)); ?></span> </div> </div> <?php require(DIR_WS_INCLUDES . 'template_bottom.php'); require(DIR_WS_INCLUDES . 'application_bottom.php'); ?> I believe changes should be done @ <?php echo TEXT_INFORMATION; ?> Where is this TEXT_INFORMATION? Many thanks for your help! Regards, Quote Link to comment Share on other sites More sharing options...
♥joli1811 Posted August 2, 2013 Share Posted August 2, 2013 Hi /includes/languages/english/privacy.php Regards Joli Quote To improve is to change; to be perfect is to change often. Link to comment Share on other sites More sharing options...
Comesticage Posted August 2, 2013 Share Posted August 2, 2013 @@joli1811 Thanks! Quote Link to comment Share on other sites More sharing options...
vampirehunter Posted August 21, 2013 Share Posted August 21, 2013 i'm surprised the glaring error of no php validation hasn't been fixed on this yet. if you turn off javascript, and enter anything into the text field, it will always come up with success message. Quote Link to comment Share on other sites More sharing options...
sembrouille Posted August 22, 2013 Author Share Posted August 22, 2013 Hi vempire ! 1) Javascript is enabled by default in all browsers 2) If you turn off javascript all "moderns" websites, including osc2.3.x, will be turn off 3) in which case and why customers turn off javascript ?!! Conclusion: no bug! Best Regards Brouillard s'embrouille. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.