Jump to content
JuanIgnacio

Credit Class & Gift Vouchers (CCGV) for 2.3.1

Recommended Posts

I recently installed this great contribution and have been informed by a couple of customers that this fault occurs when returning to the site from paypal. It is returning exactly the same fault. Is it possible to post the fix that you found worked?

I just ran into this.

 

In paypal_standard.php, find this:

function before_process() {
     global $customer_id, $order, $order_totals, $sendto, $billto, $languages_id, $payment, $currencies, $cart, $cart_PayPal_Standard_ID;
     global $$payment;

 

and change it to this:

function before_process() {
     global $customer_id, $order, $order_totals, $sendto, $billto, $languages_id, $payment, $currencies, $cart, $order_total_modules, $cart_PayPal_Standard_ID;
     global $$payment;

 

That eliminated the errors when returning to the site from paypal.

Share this post


Link to post
Share on other sites

Regarding checkbox not showing up:

 

Go to your admin panel, modules, order totals. First, click on "gift vouchers" and check your "recalculate tax" setting.

 

Per the instructions:

 

 

 

 

No tax recalculation

 

Sub-total - Sort order = 1

Shipping - Sort order = 2

Tax - Sort order = 3

Gift Voucher - Sort order = 4

Discount Coupons - Sort Order =5

Total - Sort Order = 6

 

Tax recalculation

 

Sub-total - Sort order = 1

Shipping - Sort order = 2

Gift Voucher - Sort order = 3

Discount Coupons - Sort Order =4

Tax - Sort order = 5

Total - Sort Order = 6

 

Obviously, if you don't charge sales tax, you would check false for re-calculate tax, and use the first sort order option, leaving out taxes altogether.

Share this post


Link to post
Share on other sites

Hello,

i recently installed the contribution on a mod 2.3.1 version but obviously I don't have the GV tick box in the checkout_payment.

The input field and redeem button appear but no GV tick though there is a balance on the account.

 

 

Admin and Shopping cart section is working fine.

 

Settings for the GV modul are

 

Display Total

true

Sort Order

4

Queue Purchases

true

Include Shipping

true

Include Tax

true

Re-calculate Tax

None

Tax Class

--None--

Credit including Tax

false

 

checkout_payment code

 

<?php

/*

$Id$

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

Copyright © 2010 osCommerce

Released under the GNU General Public License

*/

require('includes/application_top.php');

if (!tep_session_is_registered('customer_id'))

{

$navigation->set_snapshot();

tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL'));

}

if ($cart->count_contents() < 1)

{

tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));

}

if (!tep_session_is_registered('shipping'))

{

tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

}

if (isset($cart->cartID) && tep_session_is_registered('cartID'))

{

if ($cart->cartID != $cartID)

{

tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

}

}

/* CCGV - BEGIN */

if(tep_session_is_registered('credit_covers')) tep_session_unregister('credit_covers');

if(tep_session_is_registered('cot_gv')) tep_session_unregister('cot_gv');

/* CCGV - END */

if ( (STOCK_CHECK == 'true') && (STOCK_ALLOW_CHECKOUT != 'true') )

{

$products = $cart->get_products();

for ($i=0, $n=sizeof($products); $i<$n; $i++)

{

if (tep_check_stock($products[$i]['id'], $products[$i]['quantity']))

{

tep_redirect(tep_href_link(FILENAME_SHOPPING_CART));

break;

}

}

}

/* CCGV - BEGIN ## OPTIONAL! ## */

require(DIR_WS_CLASSES . 'shipping.php');

$shipping_modules = new shipping($shipping);

/* CCGV - END ## OPTIONAL! ## */

if (!tep_session_is_registered('billto'))

{

tep_session_register('billto');

$billto = $customer_default_address_id;

}

else

{

if ( (is_array($billto) && empty($billto)) || is_numeric($billto) )

{

$check_address_query = tep_db_query("select count(*) as total from " . TABLE_ADDRESS_BOOK . " where customers_id = '" . (int)$customer_id . "' and address_book_id = '" . (int)$billto . "'");

$check_address = tep_db_fetch_array($check_address_query);

if ($check_address['total'] != '1')

{

$billto = $customer_default_address_id;

if (tep_session_is_registered('payment')) tep_session_unregister('payment');

}

}

}

require(DIR_WS_CLASSES . 'order.php');

$order = new order;

/* CCGV - BEGIN */

require(DIR_WS_CLASSES . 'order_total.php');

$order_total_modules = new order_total;

$order_total_modules->clear_posts();

/* CCGV - END */

if (!tep_session_is_registered('comments')) tep_session_register('comments');

if (isset($HTTP_POST_VARS['comments']) && tep_not_null($HTTP_POST_VARS['comments']))

{

$comments = tep_db_prepare_input($HTTP_POST_VARS['comments']);

}

$total_weight = $cart->show_weight();

$total_count = $cart->count_contents();

/* CCGV - BEGIN */

$total_count = $cart->count_contents_virtual();

/* CCGV - END */

require(DIR_WS_CLASSES . 'payment.php');

$payment_modules = new payment;

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CHECKOUT_PAYMENT);

$breadcrumb->add(NAVBAR_TITLE_1, tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'));

$breadcrumb->add(NAVBAR_TITLE_2, tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL'));

$tab_sel = tep_href_link(FILENAME_CHECKOUT_PAYMENT);

$current_page = FILENAME_CHECKOUT_PAYMENT;

require(DIR_WS_INCLUDES . 'template_top.php');

?>

<script type="text/javascript"><!--

var selected;

<!-- CCGV - BEGIN -->

var submitter = null;

function submitFunction()

{

submitter = 1;

}

<!-- CCGV - END -->

function selectRowEffect(object, buttonSelect)

{

/* CCGV - BEGIN */

if (!document.checkout_payment.payment[0].disabled)

{

/* CCGV - END */

if (!selected)

{

if (document.getElementById)

{

selected = document.getElementById('defaultSelected');

}

else

{

selected = document.all['defaultSelected'];

}

}

if (selected) selected.className = 'moduleRow';

object.className = 'moduleRowSelected';

selected = object;

if (document.checkout_payment.payment[0])

{

document.checkout_payment.payment[buttonSelect].checked=true;

}

else

{

document.checkout_payment.payment.checked=true;

}

/* CCGV - BEGIN */

}

/* CCGV - END */

}

function rowOverEffect(object)

{

if (object.className == 'moduleRow') object.className = 'moduleRowOver';

}

function rowOutEffect(object)

{

if (object.className == 'moduleRowOver') object.className = 'moduleRow';

}

<?php

/* CCGV - BEGIN */

if (MODULE_ORDER_TOTAL_INSTALLED) $temp=$order_total_modules->process();

$temp=$temp[count($temp)-1];

$temp=$temp['value'];

$gv_query = tep_db_query("select amount from " . TABLE_COUPON_GV_CUSTOMER . " where customer_id = '" . $customer_id . "'");

$gv_result = tep_db_fetch_array($gv_query);

if ($gv_result['amount']>=$temp)

{

$coversAll=true;

?>

function clearRadeos()

{

document.checkout_payment.cot_gv.checked=!document.checkout_payment.cot_gv.checked;

for (counter = 0; counter < document.checkout_payment.payment.length; counter++)

{

if (document.checkout_payment.cot_gv.checked)

{

document.checkout_payment.payment[counter].checked = false;

document.checkout_payment.payment[counter].disabled=true;

}

else

{

document.checkout_payment.payment[counter].disabled=false;

}

}

}

<?php

}

else

{

$coversAll=false;?>

function clearRadeos()

{

document.checkout_payment.cot_gv.checked=!document.checkout_payment.cot_gv.checked;

}

<?php

}

?>

//--></script>

<?php echo $payment_modules->javascript_validation($coversAll); ?>

<!-- CCGV - END -->

<?php echo tep_draw_content_top();?>

<?php echo tep_draw_title_top();?>

<h1><?php echo HEADING_TITLE; ?></h1>

<?php

//osc-support-edition BOF

if ($messageStack->size('terms_agree') > 0) {

echo $messageStack->output('terms_agree');

}

//osc-support-edition EOF

?>

<?php echo tep_draw_title_bottom();?>

<?php //echo tep_draw_form('checkout_payment', tep_href_link(FILENAME_CHECKOUT_CONFIRMATION, '', 'SSL'), 'post', 'onsubmit="return check_form();"', true); ?>

<!-- Start - CREDIT CLASS Gift Voucher Contribution -->

<?php echo tep_draw_form('checkout_payment', tep_href_link(FILENAME_CHECKOUT_CONFIRMATION, '', 'SSL'), 'post', 'onsubmit="return check_form();"'); ?>

<!-- End - CREDIT CLASS Gift Voucher Contribution -->

<div class="contentContainer">

<div class="contentPadd">

<?php

if (isset($HTTP_GET_VARS['payment_error']) && is_object(${$HTTP_GET_VARS['payment_error']}) && ($error = ${$HTTP_GET_VARS['payment_error']}->get_error()))

{

?>

<div class="contentInfoText">

<?php echo '<strong>' . tep_output_string_protected($error['title']) . '</strong>'; ?>

<p class="messageStackError"><?php echo tep_output_string_protected($error['error']); ?></p>

</div>

 

<?php

}

?>

<!-- CCGV - BEGIN ## OPTIONAL! ##-->

 

<h3><?php echo HEADING_PRODUCTS; ?></h3><div class="contentInfoText"><?php echo '<a href="' . tep_href_link(FILENAME_SHOPPING_CART) . '"><span class="orderEdit">(' . TEXT_EDIT . ')</span></a>'; ?>

<table border="0" width="100%" cellspacing="0" cellpadding="2">

<?php

for ($i=0, $n=sizeof($order->products); $i<$n; $i++)

{

echo '<tr>' . "\n" .

' <td width="10%" class="main" align="right" valign="top" width="10">' . $order->products[$i]['qty'] . ' x</td>' . "\n" .

' <td class="main" align="left" valign="top">' . $order->products[$i]['name'];

if (STOCK_CHECK == 'true')

{

echo tep_check_stock($order->products[$i]['id'], $order->products[$i]['qty']);

}

if ( (isset($order->products[$i]['attributes'])) && (sizeof($order->products[$i]['attributes']) > 0) )

{

for ($j=0, $n2=sizeof($order->products[$i]['attributes']); $j<$n2; $j++)

{

echo '<br><nobr><small> <i> - ' . $order->products[$i]['attributes'][$j]['option'] . ': ' . $order->products[$i]['attributes'][$j]['value'] . '</i></small></nobr>';

}

}

echo ' </td>' . "\n";

if (sizeof($order->info['tax_groups']) > 1) echo '<td width="12%" class="main" valign="top" align="right">' . tep_display_tax_value($order->products[$i]['tax']) . '% ' . TEXT_PAYM_STEUER . '</td>' . "\n";

echo ' <td width="35%"class="main" align="right" valign="top">' . $currencies->display_price_normal($order->products[$i]['final_price'], $order->products[$i]['tax'], $order->products[$i]['qty']) . ' </td>' . "\n" .

'</tr>' . "\n";

}

?>

<tr>

<?php if (sizeof($order->info['tax_groups']) > 1) { ?>

<td colspan="4" valign="top" align="right">

<?php } else { ?>

<td colspan="3" valign="top" align="right">

<?php } ?>

<table border="0" cellspacing="0" cellpadding="2">

<?php

if (MODULE_ORDER_TOTAL_INSTALLED)

{

echo $order_total_modules->output();

}

?>

</table>

</td>

</tr>

</table></div>

<!-- CCGV - END ## OPTIONAL! ##-->

<?php

/* CCGV - BEGIN */

echo '' . $order_total_modules->credit_selection() . '';

echo tep_draw_form('checkout_payment', tep_href_link(FILENAME_CHECKOUT_CONFIRMATION, '', 'SSL'), 'post', 'onsubmit="return check_form();"');

if (tep_session_is_registered('customer_id'))

{

echo '' . $order_total_modules->sub_credit_selection() . '';

if ($gv_result['amount'] > 0)

{

echo '' . $order_total_modules->sub_credit_selection() . '';

}

}

echo '<div>' . VOUCHER_BALANCE . ' ' . $currencies->format($gv_result['amount']) . '</div></div>';

/* CCGV - END */

?>

<h3><?php echo TABLE_HEADING_BILLING_ADDRESS; ?></h3>

<div class="contentInfoText">

<div class="" style="float:right; width:auto; margin-left:17px;">

<h3 class="first_h3"><?php echo TITLE_BILLING_ADDRESS; ?></h3>

<div class="contentInfoText marg-bottom" style="white-space:nowrap;">

<?php echo tep_address_label($customer_id, $billto, true, ' ', '<br />'); ?>

</div>

</div>

<?php echo TEXT_SELECTED_BILLING_DESTINATION; ?><br /><div class="buttonSet"><?php echo tep_draw_button2_top();?><?php echo tep_draw_button(IMAGE_BUTTON_CHANGE_ADDRESS, 'home', tep_href_link(FILENAME_CHECKOUT_PAYMENT_ADDRESS, '', 'SSL')); ?><?php echo tep_draw_button2_bottom();?></div>

</div>

<div style="clear: both;"></div>

<h3><?php echo TABLE_HEADING_PAYMENT_METHOD; ?></h3>

<?php

$selection = $payment_modules->selection();

if (sizeof($selection) > 1)

{

?>

<div class="contentInfoText">

<div style="float: right;"><?php echo '<strong>' . TITLE_PLEASE_SELECT . '</strong>'; ?>

</div>

<?php echo TEXT_SELECT_PAYMENT_METHOD; ?>

<?php

} elseif ($free_shipping == false) {

?>

<div class="contentInfoText">

<?php echo TEXT_ENTER_PAYMENT_INFORMATION; ?>

<?php

}

?>

<br /><br />

<?php

$radio_buttons = 0;

for ($i=0, $n=sizeof($selection); $i<$n; $i++)

{

?>

<table border="0" width="100%" cellspacing="0" cellpadding="5">

 

<?php

if ( ($selection[$i]['id'] == $payment) || ($n == 1) ) {

echo ' <tr id="defaultSelected" class="moduleRowSelected" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";

} else {

echo ' <tr class="moduleRow" onmouseover="rowOverEffect(this)" onmouseout="rowOutEffect(this)" onclick="selectRowEffect(this, ' . $radio_buttons . ')">' . "\n";

}

?>

<td width="100%"><strong><?php echo $selection[$i]['module']; ?></strong></td>

<td align="right">

 

<?php

if (sizeof($selection) > 1)

{

echo tep_draw_radio_field('payment', $selection[$i]['id'], ($selection[$i]['id'] == $payment));

//echo tep_draw_radio_field('payment', $selection[$i]['id'], (($selection[$i]['id'] == $payment) || (($payment == "") && ($radio_buttons == 0))));

}

else

{

echo tep_draw_hidden_field('payment', $selection[$i]['id']);

}

?>

</td>

</tr>

 

<?php

if (isset($selection[$i]['error']))

{

?>

<tr>

<td colspan="2"><?php echo $selection[$i]['error']; ?></td>

</tr>

 

<?php

}

elseif (isset($selection[$i]['fields']) && is_array($selection[$i]['fields']))

{

?>

<tr>

<td colspan="2">

<table border="0" cellspacing="0" cellpadding="2">

<?php

for ($j=0, $n2=sizeof($selection[$i]['fields']); $j<$n2; $j++)

{

?>

<tr>

<td><?php echo $selection[$i]['fields'][$j]['title']; ?></td>

<td><?php echo $selection[$i]['fields'][$j]['field']; ?></td>

</tr>

 

<?php

}

?>

</table>

</td>

</tr>

<?php

}

?>

</table>

 

<?php

$radio_buttons++;

}

?>

</div>

<h3><?php echo TABLE_HEADING_COMMENTS; ?></h3>

<div class="contentInfoText">

<?php echo tep_draw_textarea_field('comments', 'soft', '60', '5', $comments); ?>

</div>

<?php

// osc-support-edition BOF

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CONDITIONS);

?>

<?php

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_WIDERRUF);

?>

<h2><?php echo HEADING_WIDERRUF_INFORMATION; ?></h2>

<div class="contentText">

<div class="termsContainer"><?php echo TEXT_WIDERRUF_CHECKOUT; ?></div>

</div>

 

<div class="contentText">

<div style="float:left;"><?php echo tep_draw_checkbox_field('terms', 'true'); ?></div>

<div style="float:left; margin-left:10px;"><?php echo TERMS_ACCEPT_TEXT; ?></div><br style="clear: both;" />

</div>

<?php

// osc-support-edition EOF

?>

<div class="buttonSet">

<div class="coProgressBar">

<div id="coProgressBar"></div>

<table border="0" width="100%" cellspacing="7" cellpadding="0">

<tr>

<td align="center" width="33%" class="checkoutBarFrom"><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL') . '" class="checkoutBarFrom">' . CHECKOUT_BAR_DELIVERY . '</a>'; ?></td>

<td align="center" width="33%" class="checkoutBarCurrent"><?php echo CHECKOUT_BAR_PAYMENT; ?></td>

<td align="center" width="33%" class="checkoutBarTo"><?php echo CHECKOUT_BAR_CONFIRMATION; ?></td>

</tr>

</table>

</div>

 

<div class="fl_right" align="right"><?php echo tep_draw_button_top();?><?php echo tep_draw_button(IMAGE_BUTTON_CONTINUE, 'triangle-1-e', null, 'primary'); ?><?php echo tep_draw_button_bottom();?></div>

</div>

 

</div>

</div>

<script type="text/javascript">

$('#coProgressBar').progressbar(

{

value: 66

});

</script>

</form>

<?php echo tep_draw_content_bottom();?>

<?php

require(DIR_WS_INCLUDES . 'template_bottom.php');

require(DIR_WS_INCLUDES . 'application_bottom.php');

?>

 

Any help?

Share this post


Link to post
Share on other sites

fixed the problem with the missing checkbox. Changed the settings in modules - order totals to

 

No tax recalculation

 

ot_subtotal - Sort order = 1

ot_shipping - Sort order = 2

ot_tax - Sort order = 3

ot_coupon - Sort order = 4

ot_gv - Sort Order =5

ot_total - Sort Order = 6

Share this post


Link to post
Share on other sites

Hi i installed the ccgv 6.0 on a clean install of oscommerce 2.3.1. And at first it looks like everything works fine no errors or anything. But when I set a coupon code up and tried to use it. I noticed that there is no field to put the code in the ceckout process als I canot ad it in the admin menu because I only got the 4 choices:

 

shpping,sub total, tax and total

 

but I have uploaded al the files to the directorys like includes/modules/order_total/

 

there are the files ot_coupon.php and ot_gv.php but don't appear in the admin modules order total page.

 

I hope you understand my problem mine englisch isn't verry good.

 

Thanks for the help in advance

Share this post


Link to post
Share on other sites

Hi,

 

I got it working I mist the install button at the top of the order total modules. But now when I try to redeem the coupon code it sends me back to the customer login screen and then I can't login any more although I have the inlog code's right.

Share this post


Link to post
Share on other sites

I hope someone can help me out, I've installed CCGV 6.0 for 2.3.1 everything seems to work fine, however..when you check use gift voucher balance, hit continue and then confirm order, it says say "please select a payment method for your order", even when the amount in the gift voucher account is more than the total of the order. I installed this modification on a fresh copy of 2.3.1. Anyone have an idea?

Share this post


Link to post
Share on other sites

Figured it out. So in catalog/checkout_process.php go to line 53ish and change this:

 

if ($credit_covers) $payment='';

 

To This:

 

if ($credit_covers) $payment='credit_covers';

Share this post


Link to post
Share on other sites

Hi,

thx for this contribution.

 

...As a customer, if you purchase something, then when you get to checkout, there will be a check box giving you the option of using the voucher balance. You can also email the gift voucher to someone else as a gift to them and they can use it. ...

 

I put right gift product - relase the voucher, on checkout_payment.php I have Enter Redeem Code field but dont have any check box

Somebody could help me what mistake I did?

Share this post


Link to post
Share on other sites

Hi, is there anywhere that actually states the full instructions on how to install this to my site? I have downloaded the file and extracted it.... what next? I'm using 2.3.1

Share this post


Link to post
Share on other sites

hello,

 

could you tell me which file are modified for :

" Fixed an issue where a discount coupon is restricted to product but does not calculate price with tax."

 

i have installed the 10.2 version and i want to try to resolve my probleme with the tax in the checkout files :

when i use coupon the total is ok but not the tax (always the same if i didnt use cupon)

 

my order total :

1 sub total

2 shipping

3 discoutn coupon

4 voucher

5 tax

6 total

 

my price are always with tax

 

thanks for help

Share this post


Link to post
Share on other sites

hello. i'm new to oscommerce and e-commerce in general.

 

i have a clean 2.3.1 install and now have this module installed. i can purchase a gift voucher and pay for it via the paypal sandbox, but i never see anything appear in the gift voucher queue. it appears as though the order has been processed, with order status processing.

 

also if i email a gift certificate from the admin console, i can redeem it and apply the credit to a subsequent purchase, so i think the module is functioning correctly apart from the gv queue.

 

I have run the script order_total_gv.sql

 

Store Credit

Display Total

true

Sort Order

8

Queue Purchases

true

Include Shipping

false

Include Tax

true

Re-calculate Tax

Credit Note

Tax Class

--none--

Credit including Tax

true

 

Modules Sort Order Action Discount Coupons 9

StoreCredit 8

Shipping 2

Sub-Total 1 Tax 3

Total 10

 

 

is there some specific order tracing I can look at?

 

any help appreciated as i'm now completely stuck.

Edited by paulwarwicker

Share this post


Link to post
Share on other sites

to nicerico.

 

I believe it was around line 150 in includes\modules\order_total\ot_coupon.php

 

replace:

 

$pr_c = ($order->products[$i]['final_price'] * $order->products[$i]['qty']);

with:

 

$pr_c = $this->product_price(tep_get_prid($order->products[$i]['id']));

$pr_c = $this->product_price($order->products[$i]['id']);

Share this post


Link to post
Share on other sites

to paulwarwicker.

 

Check that your gift voucher product has the Model prefixed with 'GIFT' otherwise it will not be recognised as a gift voucher. For example you could call it GIFT_Voucher or GIFT_10, etc.

Share this post


Link to post
Share on other sites

@@fnzb

 

thanks for the reply. the vouchers are already defined with both a product name and product model that are prefixed with "GIFT" (ie GIFT50, GIFT25, etc).

 

I have diffed all the files between the module source files (NEW_FILES and FILES_TO_MODIFY) and those installed and both are indentical.

 

I have turned on database queries in the logging but there is nothing that goes near the coupon_gv_table. I can see the order inserted and the product stock quantity is decremented. I have also manually checked the value of the configuration key 'MODULE_ORDER_TOTAL_GV_QUEUE' which is set to true.

 

I tried adding some debug to ot_gv.php but this method did not look like it was being called, or i was not looking at the right place for output in the browser

 

function update_credit_account($i, $order_id=0) {

global $order, $customer_id, $insert_id, $REMOTE_ADDR;

print ("in update_credit_account");

if (!$order_id) $order_id = $insert_id;

print ("100");

if (preg_match('/^GIFT/', addslashes($order->products[$i]['model']))) {

print ("101");

$gv_order_amount = ($order->products[$i]['final_price'] * $order->products[$i]['qty']);

if ($this->credit_tax=='true') $gv_order_amount = $gv_order_amount * (100 + $order->products[$i]['tax']) / 100;

$gv_order_amount = $gv_order_amount * 100 / 100;

print ("102");

if (MODULE_ORDER_TOTAL_GV_QUEUE == 'false') {

print ("103");

...

} else {

print ("104");

$gv_insert=tep_db_query("insert into " . TABLE_COUPON_GV_QUEUE . " (customer_id, order_id, amount, date_created, ipaddr) values ('" . $customer_id . "', '" . $insert_id . "', '" . $gv_order_amount . "', NOW(), '" . $REMOTE_ADDR . "')");

 

Is there some configuration to check that the module is correctly installed?

 

I have also noticed that if I have manually sent a store credit and redeemed it, it is available at checkout and can be correctly applied to a purchase, but the store credit isn't removed once used. It's available for subsequent purchases!

 

??

 

thanks

paul

Edited by paulwarwicker

Share this post


Link to post
Share on other sites

@fnzb

 

I have found the problem. After some extensive debugging I have found that the call to $payment_modules->before_process() in checkout_process.php never returns so the gv queue code in checkout_process.php is never run.

 

I am using the paypal standard payment module. In the file includes/modules/payment/paypal_standard.php the last line of the method before_process() is to redirect the browser session. If I comment out the redirect, I get the gift voucher added to the queue and it resolves the problem about the credit remaining after use. Ultimately I appear to be redirected to checkout_success.php so everything appears to be normal.

 

includes/modules/payment/paypal_standard.php::before_process()

 

tep_session_unregister('cart_PayPal_Standard_ID');

 

//tep_redirect(tep_href_link(FILENAME_CHECKOUT_SUCCESS, '', 'SSL'));

}

 

Hope this helps someone in future

paul

Share this post


Link to post
Share on other sites

cant edit my previous reply, but i have just noticed that removing the redirect causes two orders to appear so is not a solution.

 

anyway it seems less a problem with ccgv and more a problem integrating with paypal standard.

 

Unless anyone else has experienced this before, I guess I'm going to have to duplicate a chunk of code.

 

paul

Share this post


Link to post
Share on other sites

@@paulwarwicker

 

Sorry I couldnt help. It must be an issue with paypal module. I did have this installed once, before I installed CCGV but removed it when paypal did the dirty on us, will never use them for business again.

 

I hope you manage to figure it out, good luck.

Share this post


Link to post
Share on other sites

Hi

I have this module working lovely for the past few weeks but with Paypal playing up ive upgraded to paypal express and now the discounts dont work.

 

I have no errors showing and it still works with Sagepay, any idea on where i should look, i have a tiny idea it might be on the express page but not knowing what to look for i dont know where to start, ive combed the froums and found nothing that can help so far.

 

Any help would be fab as i realy dont want to uninstall it coz it rocks :-D

Edited by clippers

Share this post


Link to post
Share on other sites

Love the CCGV post - thank you! but a question about allowed payment methods... When I place only a GV in the cart, the only allowed payment method is via Paypal (currently, I only have COD and Paypal enabled), and when I place only hard goods in the cart, I see both payment methods allowed, but when I place BOTH a GV and some hard goods in the cart, I still see both payment methods allowed.

 

I'd like to close the gap and only allow credit (e.g., Paypal) payment methods when there's a GV in the cart (to prevent the fraud situation).

 

One option I see is to modify the payment class and, when there's a GV in the cart, exclude other payment methods. But i'm not seeing how this gets done (in the code). I see a "credit_class" in the order class, but i'm not clear on it's meaning - does this indicate whether the payment method is a credit card?

 

any ideas/options (or better, a place where this sort of exclusion is already occurring).

 

thanks very much for any insight!

 

-Peter

Share this post


Link to post
Share on other sites

Have an issue with the CCGV Credit Class Gift Voucher v6.0 for 2.3.1.

 

I installed it but during checkout there is no box to enter the coupon code.

 

Any suggestions how to resolve this?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×