More logic with linking after "big images" mod

[mazza]

Having a link that creates a pop-up window (without warning) and with the same picture, is kind a annoying. what you can do at product_info.php:

 

find

<?php

   if ($product_info_values['products_image'] != '') {

?>

         <tr>

           <td align="center" class="smallText">

<script language="javascript"><!--

document.write('<?php echo '<a href="javascript:popupWindow('' . tep_href_link(FILENAME_POPUP_IMAGE, 'pID=' . $product_info_values['products_id']) . '')">' . tep_image(DIR_WS_IMAGES . $product_info_values['products_image'], addslashes($product_info_values['products_name']), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br />' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>');

//--></script>

<noscript>

<?php echo '<a href="' . tep_href_link(DIR_WS_IMAGES . $product_info_values['products_image']) . '">' . tep_image(DIR_WS_IMAGES . $product_info_values['products_image'], $product_info_values['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br />' . TEXT_CLICK_TO_ENLARGE . '</a>'; ?>

</noscript>

           </td>

         </tr>

<?php

   }

?>

 

replace with

<?php

   if ($product_info_values['products_image'] == '') {

echo ''; 

}

   if ($product_info_values['products_bimage'] == '') {

    	 echo '<tr><td align="center" class="smallText">' . tep_image(DIR_WS_IMAGES . $product_info_values['products_image'], $product_info_values['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '</td></tr>'; 

}

else {

 echo '<tr><td align="center" class="smallText"><a href="' . tep_href_link(DIR_WS_IMAGES . $product_info_values['products_bimage']) . '" title="' . TEXT_OPENS_IN_NEW_WINDOW . '">' . tep_image(DIR_WS_IMAGES . $product_info_values['products_image'], $product_info_values['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, 'hspace="5" vspace="5"') . '<br />' . TEXT_CLICK_TO_ENLARGE . '</a> </td></tr>'; 

}

?>

find

          <?php

 $product_info = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, p.products_bimage, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.language_id = '" . $languages_id . "'");

 if (!tep_db_num_rows($product_info)) { // product not found in database

?>

replace with

<?php

 $product_info = tep_db_query("select p.products_id, pd.products_name, pd.products_description, p.products_model, p.products_quantity, p.products_image, p.products_bimage, pd.products_url, p.products_price, p.products_tax_class_id, p.products_date_added, p.products_date_available, p.manufacturers_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd where p.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.products_id = '" . $HTTP_GET_VARS['products_id'] . "' and pd.language_id = '" . $languages_id . "'");

 if (!tep_db_num_rows($product_info)) { // product not found in database

?>

 

also add this to english.php and other languages:

define('TEXT_OPENS_IN_NEW_WINDOW', 'Opens in new window');

 

You can also do search for all the target="_blank" links and add warning

 

title="' . TEXT_OPENS_IN_NEW_WINDOW . '

 

Now

 

No image for product = no image shown.

small image, no big one= show small image with no links or larger image text.

small and big are both found = show small image with link and larger image text.

 

and links to larger images have warning in title tag

 

Note: this takes the javascript stuff away from pop-up window. If you would like to keep it do not use this trick.

 

And if someone would like to add to this code, you are welcomed to do so.