Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Product Listing Enhancements, Thumbnails & Manufacturer Headings


spooks

Recommended Posts

hi Mr. Sam

i have installed last ver. and also product_extra_fileds add-on and also set the value to "true" in product_listing.php but nothing of the extra fields which i created is appearing in listing mode

y?

 

tnx alot

 

See my conversation with marker ealier for tests to find issue http://www.oscommerce.com/forums/index.php?showtopic=307010&pid=1464018&start=1200&st=1200#entry1464018

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

ok, really need the help of all you genuises.... I've got checkmarks --- tep_image_button('checkmark_sm.gif') --- which is almost working well. Problem is it shows on the first product, as it should, but then continues on every product there after. I need only a checkmark on the products from the sql query --- $orders['products_id'] --- Your help would be so greatly appreciated !! thanks liz.

 

// build thumb

$man_id = (tep_not_null($_GET['manufacturers_id']) ? $_GET['manufacturers_id'] : '');

$link = '<a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products['products_id'] . ($man_id ? '&manufacturers_id='.$man_id : ($cPath && $cat_path ? '&cPath=' . $cPath : ''))) . '"' . ($man_id || ($cat_path && $cat_path) ? ' rel="nofollow"' : '') . '>';

$image = $products['products_image'];

$udc_d = $products['UDC_design'];

$addimages = (file_exists(DIR_WS_CLASSES . 'displayimages.php')); // Additional Images Present

if ($addimages) {

$image_query = tep_db_query( "SELECT ai.medium_images, ai.images_description, ai.popup_images, p.products_image_med, p.products_image_description FROM " . TABLE_ADDITIONAL_IMAGES . " ai, " . TABLE_PRODUCTS . " p WHERE ai.products_id=p.products_id and ai.products_id = '".(int)$products['products_id']."'");

$selected_image = tep_db_fetch_array($image_query);

$image = ($selected_image['medium_images'] ? $selected_image['medium_images'] : ($selected_image['products_image_med'] ? $selected_image['products_image_med'] : ($selected_image['popup_images'] ? $selected_image['popup_images'] : $products['products_image'])));

}

$image = (!$grid && $column_list[0] == 'PRODUCT_LIST_IMAGE' ? '<br>' : '') . $link . tep_image(DIR_WS_IMAGES . $image, ($addimages ? (tep_not_null($selected_image['images_description']) ? $selected_image['images_description'] : (tep_not_null($selected_image['products_image_description']) ? $selected_image['products_image_description'] : $products['products_name'])) : $products['products_name']), PRODUCT_IMAGE_WIDTH, '') . '</a>' . '<br>';

$buypic = (LISTING_BUTTON == 'buy now' ? 'button_in_cart.gif' : 'button_buy_now.gif');

$button = (LISTING_BUTTON != 'none' && PRODUCT_LIST_BUY_NOW ? (LISTING_BUTTON == 'buy now & details' ? '<br><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $products['products_id']) . '">' . tep_image_button($buypic, IMAGE_BUTTON_BUY_NOW, 'class="thm_buy_now"') . '</a> <span class="buy_now">|</span> ' . $link . tep_image_button('button_details_small.gif', IMAGE_BUTTON_DETAILS, 'class="thm_buy_now"') . '</a><br><br>' : (strstr(LISTING_BUTTON, 'buy now') ? '<br><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $products['products_id']) . '">' . tep_image_button($buypic, IMAGE_BUTTON_BUY_NOW) . '</a><br><br>' : '<br>' . $link . tep_image_button('button_details.gif', IMAGE_BUTTON_DETAILS) . '</a><br><br>' )) : '  <span class="buy_now">|</span> ' . $link . tep_image_button('button_details_small.gif', IMAGE_BUTTON_DETAILS, 'class="thm_buy_now"') . '</a><br><br>' );

if ($products['products_price'] == 0) $button = (strstr(LISTING_BUTTON, 'details') ? '<br><span class="buy_now"> </span>'. $link . tep_image_button('button_details_small.gif', IMAGE_BUTTON_DETAILS, 'class="thm_buy_now"') . '</a> <br>' : '');

$name = $link . '<b>' . $products['products_name'] . '</b>' . '</a><br>'. ($products['short_desc'] && (PRODUCT_SHORT_DESC == 'true') ? '<br>' . $products['short_desc'] . '<br>' : '');

$price = (function_exists(display_short_price)) ? $currencies->display_short_price($products['products_price'], tep_get_tax_rate($products['products_tax_class_id'])) : $currencies->display_price($products['products_price'], tep_get_tax_rate($products['products_tax_class_id']));

if (tep_not_null($products['specials_new_products_price'])) {

$price = '<s>' . $currencies->display_price($products['products_price'], tep_get_tax_rate($products['products_tax_class_id'])) . '</s> <span class="productSpecialPrice">' . $currencies->display_price($products['specials_new_products_price'], tep_get_tax_rate($products['products_tax_class_id'])) . '</span>';

}

if (function_exists(tep_get_att_price)) $price .= (tep_get_att_price($products['products_id']) > 0 ? '+' : '') ;

if (isset($products['products_quantity']) && !$products['products_quantity']) $button = (strstr(LISTING_BUTTON, 'details') ? '<br><span class="buy_now"> </span>'. $link . tep_image_button('button_details_small.gif', IMAGE_BUTTON_DETAILS, 'class="thm_buy_now"') . '</a> <br>' : '');

$show_price = '<br><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br></font>';

$quantity = ($products['products_quantity'] ? 'Stock = '.$products['products_quantity'] : 'Out of Stock').'<br />';

$weight = 'Weight = '.$products['products_weight'].WEIGHT_ABRV.'<br />';

$model = $products['products_model'] . '<br>';

 

$orders_query = tep_db_query("select distinct op.products_id, op.orders_id, o.orders_id from " . TABLE_ORDERS_PRODUCTS . " op LEFT JOIN " . TABLE_ORDERS . " o on op.orders_id = o.orders_id where op.products_id = '".(int)$products['products_id']."' and o.customers_id = '" . (int)$customer_id . "'");

while ($orders = tep_db_fetch_array($orders_query)) {

if ($orders['products_id'] == $products['products_id']) {

//echo $products['products_id'];

$cust = tep_image_button('checkmark_sm.gif'). '<br>';

 

}

}

$udc = (tep_image_button($products['UDC_design'])) . '<br />';

 

 

$manfact = '<a href="' . tep_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $products['manufacturers_id']) . '">' . $products['manufacturers_name'] . '</a><br>';

$display = $border;

for ($disp=0, $n=sizeof($column_list); $disp<$n; $disp++) {

switch ($column_list[$disp]) {

case 'PRODUCT_LIST_IMAGE':

$display .= '<table summary="" width="100%" ><tr><td style="text-align:center;" valign="top" height="'.PRODUCT_IMAGE_VSPACE.'" >'.$image.'</td></tr></table>';

break;

case 'PRODUCT_LIST_NAME':

$display .= '<table summary="" width="100%" ><tr><td class="thumbcontent" height="'.PRODUCT_NAME_VSPACE.'" >'.$name.'</td></tr></table>';

break;

case 'PRODUCT_LIST_MODEL':

$display .= $model;

break;

case 'PRODUCT_LIST_UDC':

$display .= $udc;

break;

case 'PRODUCT_LIST_CUSTDESIGN':

$display .= $cust;

break;

case 'PRODUCT_LIST_MANUFACTURER':

$display .= $manfact;

break;

case 'PRODUCT_LIST_PRICE':

$display .= $show_price;

break;

case 'PRODUCT_LIST_QUANTITY':

$display .= $quantity;

break;

case 'PRODUCT_LIST_WEIGHT':

$display .= $weight;

break;

}

}

$display .= $borderend . $button;

// thumb built

Link to comment
Share on other sites

Removing the larger spacing gaps if desired in product listing.

Just wanted to post this as it might help others who had the same need. Perhaps it was posted already and I did not find it after exhaustion of trying to figure it out.

 

Here is what I am trying to change:ProductInfoPage.gif

 

Open /includes/modules/product_listing.php

 

Remove ALL the <br/> and it will be a tighter box.

 

 

Charles ;)

Edited by fan4chevy
Link to comment
Share on other sites

Hello (again!) ;)

 

I've got my grid set as thumbnails and it looks awesome with 9 products (3 on each row) BUT if there are an amount of products that isnt a multiple of 3... then the bottom set of images isn't laid out from left to right... it's sort of scattered across the page. (see image below for example)

 

screenshot2.jpg

 

Am I missing an option in the admin settings, or is there another way to configure this?

 

leelee2023

 

I like the displaying: 1-5 and the results:1 you have at the top of the listing. How did you do it?

 

Charles

Link to comment
Share on other sites

 

 

Select thumbnail grid mode, instead of just thumbnail, it is detailed. wink.gif

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

Display results pege

 

I like the displaying: 1-5 and the results:1 you have at the top of the listing. How did you do it?

 

 

 

 

Its in the code, that will be displa\yed whenever there is more than one page, otherwise considered pointless so its not.

 

Its position is as per admin setting.

 

the code is:

 if ( ($listing_split->number_of_rows > (int)$max_results) && $top_nav ) echo $page_nav;

(similar at bottom of page)

 

remove the

 ($listing_split->number_of_rows > (int)$max_results) &&  

part & it will always be there

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

With all the additions to this due to its continued development, I thought it time that I state its current capabilities, as the ealier list is outdated.

 

Product thumbnails (products in any number of columns) is only one small part.

 

This contribution provides many options for your product listing displays, you can have thumbnails (products in columns) in distributed display or a strict grid mode, or a number of list modes: a standard mode, like the osC default, a block mode (like new products display) or either of those modes but with manufacturer heading and if wished a manufacturer short description. Settings are in admin and the old admin controls apply along with some new ones.

 

 

Features

  • Products in columns with thumbnails in a distributed display or a strict grid mode, you can set how many columns in admin.
  • Products in a variety of list modes including a block mode (like new products display) where you control whats in what column.
  • The option of manufacturer headings and if wished a manufacturer short description.
  • Drop down boxes for display sorting.
  • Drop down boxes to set number of products to show per page.
  • Listing mode switch, allows you visitors to switch between two modes.
  • Quantity input boxes with incremental buttons.
  • Option of a drop down for the quantity box instead of a input box.
  • A multi buy option (with attribute support) to allow visitors to purchase multiple products from the listing in mutliple quantities at once.
  • List mode global headings, you can have the product name & or price on its own line above all other fields.
  • Tool tip images: Product images can have a tool tip mouseover zoom.
  • Tool tip info boxs: Any text field can have tool tip info box (set in your language file).
  • Set contents of center & rightmost columns in any list block mode.
  • Product attributes (options) can be included in the listing.
  • A truncated version of the product description can be included, you set how big.
  • A short decription can be included if you add the Short Description add-on (http://addons.oscommerce.com/info/3123)
  • Supports Additional Images (http://addons.oscommerce.com/info/1032)
  • Supports Easy Graphic Borders if you want pretty borders(http://addons.oscommerce.com/info/1702)
  • Supports Products Extra Fields (http://addons.oscommerce.com/info/2202)
  • CSS control of most aspects of any element displayed.
  • Control over the inclusion of category paths in product links.
  • Control of heading displays.

 

The thumbnails part displays products with thumbnail images in a grid layout, you define how many boxes per line plus image & box sizes. It shows the product image etc in a box, it will obey the set order & items set in admin, so you can set the position order (vertically) of everything in the thumbnail (buy now buttons always below though).

 

You can also apply the thumbnail display to the new_products module & products_new page. NOTE: These files have an exrta date function, original will just list product to set limit, this adds a max age for product (default is 60days) to change edit the commented line. These files display image, name, manufacturer & price only, they will not display any 'special price' as that may be illegal in your country.

 

As some of the listing styles remove the heading (you can select to remove in other modes too) where a user would select sort mode (if they realised, its not obvious) I`ve add a drop down to select sort order, that appears at the base of the product display, it will list according to what you have set in admin. Also added a drop down for user to select number of products shown per page.

 

The visitor can switch between thumbnails & list modes provided you give the option.

Edited by spooks

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

installed.jpg

 

hello i have installed it?

 

just questions? the installation steps says about the short description? but why it is not showing on me it is set true to my admin..

 

how can i make the product name go to top and the price bold?

 

and how can i make it rounded corners and the boxes the same size? am i missing something?

 

about the thumbnails its not nice im using before Automatic Thumbnail Creator v1.0 " then when i installed this its gone?

 

help

Link to comment
Share on other sites

Spooks,

 

What would it take to make the "The visitor can switch between thumbnails & list modes" option for a customer that has not signed in or created an account?

 

Charles

switching between thumbnails & list mode is already available (i think since 1.9)

you have to just set the last option to TRUE and then a switch option will be in bottom of the product listing page, no matter logged in or not :thumbsup:

Link to comment
Share on other sites

switching between thumbnails & list mode is already available (i think since 1.9)

you have to just set the last option to TRUE and then a switch option will be in bottom of the product listing page, no matter logged in or not :thumbsup:

 

Yep your right! :thumbsup: Do you know how to get it to show at the top of the listing instead or in addition to?

Link to comment
Share on other sites

My link

 

please check my site the "list in blocks" option works good for me but can i add some rounded borders on it.. the "thumbnails in grid" format looks awful the prices and buynow/details are not aligned so i cant use it. or can you suggest how to modify it i have been reading half of the forum till page 30 im still looking maybe you can help?..

Link to comment
Share on other sites

My link

 

please check my site the "list in blocks" option works good for me but can i add some rounded borders on it.. the "thumbnails in grid" format looks awful the prices and buynow/details are not aligned so i cant use it. or can you suggest how to modify it i have been reading half of the forum till page 30 im still looking maybe you can help?..

 

 

You have to play with the admin settings (spacing etc) and the css (use firefox and its web developer & firebug plugins to find/edit the css of any element on a page.

 

Default alignment is centered, your thumbnails look centered to me! huh.gif

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

HI,

 

Regarding switching of ThumbView and ListView.

 

In ThumbView my listing page will only show the link to change to listview at the bottom of the page ONLY. However, in ListView it will show the option at both the top or bottom to switch back to Thumbview.

 

What do I need to do to get the thumbview to also show the Listview link at the top as well when in thumbview?

 

Charles

Edited by fan4chevy
Link to comment
Share on other sites

HI,

 

Regarding switching of ThumbView and ListView.

 

In ThumbView my listing page will only show the link to change to listview at the bottom of the page ONLY. However, in ListView it will show the option at both the top or bottom to switch back to Thumbview.

 

What do I need to do to get the thumbview to also show the Listview link at the top as well when in thumbview?

 

Charles

 

To add the switch above the listing:

 

after:

$data_ok = ($listing_split->number_of_rows > 0);

add:

$thumbnail_view = (isset($_GET['list']) ? $_GET['list'] : PRODUCT_THUMBNAIL_VIEW);
if (LISTING_SWITCH != 'false' && $data_ok) echo '<br /><span class="smalltext"><a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('list')). 'list='.(strstr($thumbnail_view, 'thumbnails') ? 'manufacturer' : 'thumbnails')) . '">' . (strstr($thumbnail_view, 'thumbnails') ? LIST_VIEW : THUMB_VIEW).'</a></span><br />';

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

Hi Mr. Sam

 

i was searching that i ran into an oscommerce shop that had a nice effect while adding product to cart... i was wondering if you can manage to have sth like this (although i think you are as busy as a honey bee) or at least guide me how can i have this effect :thumbsup: :rolleyes:

demo

tnx alot

Edited by arash.najafi
Link to comment
Share on other sites

Removing the larger spacing gaps if desired in product listing.

Remove ALL the <br/> and it will be a tighter box.

 

 

Charles ;)

 

 

That’s a bit severe :rolleyes:

 

Using Version Product Listing Enhancements, Thumbnails & Manufacturer Headings V2.4.5

 

Product Listing Style > thumbnails in grid

 

To remove the space above the Images

 

\includes\modules\product_listing.php

 

Line 404

 

$border = (!$grid ? '<table class="infoBoxProducts" cellpadding="2" width="'.PRODUCT_LIST_WIDTH.'" height="'.PRODUCT_LIST_HEIGHT.'" ><tr><td valign="top">' : '<br />');

 

change to

 

$border = (!$grid ? '<table class="infoBoxProducts" cellpadding="2" width="'.PRODUCT_LIST_WIDTH.'" height="'.PRODUCT_LIST_HEIGHT.'" ><tr><td valign="top">' : '');

 

 

To remove the space above the Price

Line 405

 

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

Change to

 

$show_price = '<font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

 

To remove the space Below the Price

Line 405

 

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

change to

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '</font>';

 

 

Hope this helps

 

Regards

 

Ken

Link to comment
Share on other sites

That’s a bit severe :rolleyes:

 

Using Version Product Listing Enhancements, Thumbnails & Manufacturer Headings V2.4.5

 

Product Listing Style > thumbnails in grid

 

To remove the space above the Images

 

\includes\modules\product_listing.php

 

Line 404

 

$border = (!$grid ? '<table class="infoBoxProducts" cellpadding="2" width="'.PRODUCT_LIST_WIDTH.'" height="'.PRODUCT_LIST_HEIGHT.'" ><tr><td valign="top">' : '<br />');

 

change to

 

$border = (!$grid ? '<table class="infoBoxProducts" cellpadding="2" width="'.PRODUCT_LIST_WIDTH.'" height="'.PRODUCT_LIST_HEIGHT.'" ><tr><td valign="top">' : '');

 

 

To remove the space above the Price

Line 405

 

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

Change to

 

$show_price = '<font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

 

To remove the space Below the Price

Line 405

 

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '<br /></font>';

 

 

change to

 

$show_price = '<br /><font size="'.PRODUCT_PRICE_SIZE.'">' . ($products['products_price'] > 0 ? $price : TEXT_POA) . '</font>';

 

 

Hope this helps

 

Regards

 

Ken

 

 

Ken aren't you doing the same thing I posted which is to remove the breaks except your way takes a bit longer to do it? If you simply go Find and replace it is faster! I have to say the comment and the rolling eyes image was a bit offensive. I posted to help others who may have had the same issue after my many days of researching for the result.

 

Where were you when I posted 2x asking for assistance? I had tried to get help in this area and to no success so I figured out that it was the breaks making the spaces. So I simply went into Product_info.php searched the </br> and removed them and walla it was all nice and tight between lines.

 

Anyone looking to tighten the spacings is most likely wanting to do them all. Thanks Ken, except several days short!

Edited by fan4chevy
Link to comment
Share on other sites

You have to play with the admin settings (spacing etc) and the css (use firefox and its web developer & firebug plugins to find/edit the css of any element on a page.

 

Default alignment is centered, your thumbnails look centered to me! huh.gif

 

yes its center it your option "List in Block" (which dont have a border..) but when i select "Thumbnail in Grid"(with borders) its not aligned.

 

sir thats my problem now.. my site looks different on firefox and my web developer cant read my site but i can read the others..

Edited by halluzineyt
Link to comment
Share on other sites

Ken aren't you doing the same thing I posted which is to remove the breaks except your way takes a bit longer to do it? If you simply go Find and replace it is faster! I have to say the comment and the rolling eyes image was a bit offensive. I posted to help others who may have had the same issue after my many days of researching for the result.

 

Where were you when I posted 2x asking for assistance? I had tried to get help in this area and to no success so I figured out that it was the breaks making the spaces. So I simply went into Product_info.php searched the </br> and removed them and walla it was all nice and tight between lines.

 

Anyone looking to tighten the spacings is most likely wanting to do them all. Thanks Ken, except several days short!

 

 

I think ken was pointing out that some of the breaks you removed will have undesirable effects, that you hav'nt noticed as you are'nt using the mode that would be effected, simply removeing all <br /> is rather drastic. wink.gif

 

I admit that default layout may not work for all & I have used breaks where it will work for most, this contrib is not about providing an exact solution for all, but providing the code around a rough layout that people can mod to suite their site. smile.gif

 

 

PS I woulld advise against placing reactive posts too quickly, you never know whose help you will need tomorrow. wink.gif

Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Link to comment
Share on other sites

I think ken was pointing out that some of the breaks you removed will have undesirable effects, that you hav'nt noticed as you are'nt using the mode that would be effected, simply removeing all <br /> is rather drastic. wink.gif

 

I admit that default layout may not work for all & I have used breaks where it will work for most, this contrib is not about providing an exact solution for all, but providing the code around a rough layout that people can mod to suite their site. smile.gif

 

 

PS I woulld advise against placing reactive posts too quickly, you never know whose help you will need tomorrow. wink.gif

 

yeah that ones more cooler rather than deleting all the br without knowing what will it look like

Link to comment
Share on other sites

I think ken was pointing out that some of the breaks you removed will have undesirable effects, that you hav'nt noticed as you are'nt using the mode that would be effected, simply removeing all <br /> is rather drastic. wink.gif

 

I admit that default layout may not work for all & I have used breaks where it will work for most, this contrib is not about providing an exact solution for all, but providing the code around a rough layout that people can mod to suite their site. smile.gif

 

 

PS I woulld advise against placing reactive posts too quickly, you never know whose help you will need tomorrow. wink.gif

 

Spooks, I fully agree with you about making the contrib general for everybody. The contrib has been AWESOME! Just had a small change for personal preference. ;)

 

However, I was taken by the smiley and by the approach of stating 'Rather Drastic'. Perhaps it could have been stated differently and without the smiley rolling eyes.

 

For about two weeks I tried to figure out the spacing after I posted without finding a solution. Once I found that the breaks were the solution to my post, I tried to help the community with my findings. I can appreciate the additional "here is another way" but lets be a team and considerate.

 

I have contributed on OS as well. On fancy Box contrib I think you will find I sent up a few things that helped as well.

 

So my point, lets be considerate and a team. :thumbsup:

Edited by fan4chevy
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...