Jump to content
Sign in to follow this  
wallyboyjohn

All-in-one-FCKeditor

Recommended Posts

Hi all, I installed the contribution all-in-one fckeditor. It works perfect on Product descriptions. The FCKeditor works also with the newsletter addition, but I got extra blanc lines always before datatables added to the content of the newsletter.

This happened always after the preview and the preview before send, not within the FCKeditor! Also the mail that was send, contained the extra lines.

I found a solution for the preview and the preview before send, I removed the function nl2br in newsletters.php (catalog/admin/) and newsletter.php (catalog/admin/includes/modules/newsletters/). Unfortunately this solved not the addition of extra lines in de newsletter wich is send!

Who has a solution for this?

Share this post


Link to post
Share on other sites

Hi, you will find the solution within this package:

 

http://addons.oscommerce.com/info/5806

 

B)


Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Share this post


Link to post
Share on other sites
Thank you Spooks for your quick reply. I added the contribution you suggested. After that I've got the same results as written before. There must be something else thats wrong.

Any idea?

 

Here I have some details after hours testing.

Now I can type emails with FCKeditor. The message send has, the same as the newsletter, extra lines before a datatable added to the mail.

My newsletters have also the extra lines added. But now, after I have added the contribution for the email, the pictures are not shown. In the code I see, I guess, an "/>" on a position were it not belongs.

Example:<img height="150" alt="" width="600" src="/catalog/userfiles/image/picture.jpg" />

 

I hope someone can help.

:'(

Share this post


Link to post
Share on other sites

Have you followed the instal and done the change it mentiones:

 

if using FCK or extra line feeds are a problem, change 'false' below to 'true'

 

 

:huh:


Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Share this post


Link to post
Share on other sites
Have you followed the instal and done the change it mentiones:

 

if using FCK or extra line feeds are a problem, change 'false' below to 'true'

:huh:

 

Yes, I did everything mentioned in the contribution "Send Admin HTML e-mails V1.5", including the "true" frase. The result is that I can send a mail now made with FCKeditor but with the same problems as described earlier for the newsletter. That means extra lines before a table added to the mail and the newsletter.

As a result of implementing the contribution "Send Admin HTML e-mails V1.5" the pictures in the newsletter do not show anymore.

Thus I've got an extra problem.

:huh:

Share this post


Link to post
Share on other sites
Yes, I did everything mentioned in the contribution "Send Admin HTML e-mails V1.5", including the "true" frase. The result is that I can send a mail now made with FCKeditor but with the same problems as described earlier for the newsletter. That means extra lines before a table added to the mail and the newsletter.

As a result of implementing the contribution "Send Admin HTML e-mails V1.5" the pictures in the newsletter do not show anymore.

Thus I've got an extra problem.

:huh:

 

Your reply triggered me to check again my implementation of "Send Admin HTML e-mails V1.5".

It's stupid, but I made a mistake in email.php. Now the send mail function works as it belongs.

The problems I still have are with the newsletter. Extra lines and a wrong link for the pictures.

:blush:

Share this post


Link to post
Share on other sites

Hi, thats as I thought, clearly the newletter function has the same fault as did the mail function before I fixed it in the contribution, as we havent done any newsletters yet I hav`nt looked at that.

 

When I get time I`ll take a look and let you know the fix.

 

Cheers B)


Sam

 

Remember, What you think I ment may not be what I thought I ment when I said it.

 

Contributions:

 

Auto Backup your Database, Easy way

 

Multi Images with Fancy Pop-ups, Easy way

 

Products in columns with multi buy etc etc

 

Disable any Category or Product, Easy way

 

Secure & Improve your account pages et al.

Share this post


Link to post
Share on other sites
Hi, thats as I thought, clearly the newletter function has the same fault as did the mail function before I fixed it in the contribution, as we havent done any newsletters yet I hav`nt looked at that.

 

When I get time I`ll take a look and let you know the fix.

 

Cheers B)

 

Thank you very much for your expertise and time so far.

Noticed the content of your contribution, so far I can understand, I think the problem is in "admin/includes/modules/newsletters/newsletter.php".

Exactly the same problem within "admin/includes/modules/newsletters/product_notification.php".

 

The pictures have invalid links. At the start "http://www.our_site_name.xx" is missing in the "src=". Also the extra lines are generated before a table added to the mail.

I will go on, with my mini knowledge, to find a solution. I'am pleased that you will take a look also.

Thanks!

:lol:

Share this post


Link to post
Share on other sites

:rolleyes:

Thank you very much for your expertise and time so far.

Noticed the content of your contribution, so far I can understand, I think the problem is in "admin/includes/modules/newsletters/newsletter.php".

Exactly the same problem within "admin/includes/modules/newsletters/product_notification.php".

 

The pictures have invalid links. At the start "http://www.our_site_name.xx" is missing in the "src=". Also the extra lines are generated before a table added to the mail.

I will go on, with my mini knowledge, to find a solution. I'am pleased that you will take a look also.

Thanks!

:lol:

 

Now I'am a bit further. The extra lines are gone. On your suggestion, I replaced arond line 90 of "admin/includes/modules/newsletters/newsletter.php" this line:

$mimemessage->send(stripslashes($mail['customers_firstname']) . ' ' . stripslashes($mail['customers_lastname']), $mail['customers_email_address'], '', EMAIL_FROM, $this->title);

into:

tep_mail($mail['customers_firstname'] . ' ' . $mail['customers_lastname'], $mail['customers_email_address'], $this->title, $this->content, '', EMAIL_FROM, true);

 

Still the missing start in the "src=" for the reference to pictures and smileys is there.

Tanks so far again.

Your turn?

:rolleyes:

Share this post


Link to post
Share on other sites
Hi, thats as I thought, clearly the newletter function has the same fault as did the mail function before I fixed it in the contribution, as we havent done any newsletters yet I hav`nt looked at that.

 

When I get time I`ll take a look and let you know the fix.

 

Cheers B)

 

I found a solution for both, the exra lines and the wrong links for the pictures.

 

1. First of all I changes in "catalog/admin/mail.php" around line 37:

$message = tep_add_base_ref($messageraw);

into:

$message = $messageraw;

The functon "tep_add_base_ref" added to "general.php" is not used anymore.

 

2. In "admin/fckeditor/editor/filemanager/connectors/php/config.php", around line 34, I added the baseHref of the site:

Thus a change from:

$Config['UserFilesPath'] = "/catalog/userfiles/' ;

into:

$Config['UserFilesPath'] = 'http://www.yoursitename.xx/catalog/userfiles/' ;

 

3. In "admin/fckeditor/fckconfig.js", around line 35, I filled in the baseHref of my site:

Thus a change from:

FCKConfig.BaseHref = '' ;

into:

FCKConfig.BaseHref = 'http://www.yoursitename.xx' ; (witout "/" at the end)

 

further around line 309 change:

FCKConfig.SmileyPath = FCKConfig.BasePath + 'images/smiley/msn/' ;

into:

FCKConfig.SmileyPath = FCKConfig.BaseHref + FCKConfig.BasePath + 'images/smiley/msn/' ;

 

Thats it.

I'am glad about the result. Maybe an addition worth for to contribution.

Thanks for your companionship.

:lol:

Share this post


Link to post
Share on other sites
I found a solution for both, the exra lines and the wrong links for the pictures.

 

1. First of all I changes in "catalog/admin/mail.php" around line 37:

$message = tep_add_base_ref($messageraw);

into:

$message = $messageraw;

The functon "tep_add_base_ref" added to "general.php" is not used anymore.

 

2. In "admin/fckeditor/editor/filemanager/connectors/php/config.php", around line 34, I added the baseHref of the site:

Thus a change from:

$Config['UserFilesPath'] = "/catalog/userfiles/' ;

into:

$Config['UserFilesPath'] = 'http://www.yoursitename.xx/catalog/userfiles/' ;

 

3. In "admin/fckeditor/fckconfig.js", around line 35, I filled in the baseHref of my site:

Thus a change from:

FCKConfig.BaseHref = '' ;

into:

FCKConfig.BaseHref = 'http://www.yoursitename.xx' ; (witout "/" at the end)

 

further around line 309 change:

FCKConfig.SmileyPath = FCKConfig.BasePath + 'images/smiley/msn/' ;

into:

FCKConfig.SmileyPath = FCKConfig.BaseHref + FCKConfig.BasePath + 'images/smiley/msn/' ;

 

Thats it.

I'am glad about the result. Maybe an addition worth for to contribution.

Thanks for your companionship.

:lol:

 

Hi! If you want, you can write a guide were you write code modifications and effects after these code changes. I don't have enough time to checke them now, but if you are going to write this little guide for my contribution, I'm going to add it to a new full package. Thank you for your help!


I love oscommerce and OS software! I'm not a programmer, I'm only a learning boy and a translator :) I love full contribution packages!

Share this post


Link to post
Share on other sites

I found a solution for both, the exra lines and the wrong links for the pictures.

 

1. First of all I changes in "catalog/admin/mail.php" around line 37:

$message = tep_add_base_ref($messageraw);

into:

$message = $messageraw;

The functon "tep_add_base_ref" added to "general.php" is not used anymore.

 

2. In "admin/fckeditor/editor/filemanager/connectors/php/config.php", around line 34, I added the baseHref of the site:

Thus a change from:

$Config['UserFilesPath'] = "/catalog/userfiles/' ;

into:

$Config['UserFilesPath'] = 'http://www.yoursitename.xx/catalog/userfiles/' ;

 

3. In "admin/fckeditor/fckconfig.js", around line 35, I filled in the baseHref of my site:

Thus a change from:

FCKConfig.BaseHref = '' ;

into:

FCKConfig.BaseHref = 'http://www.yoursitename.xx' ; (witout "/" at the end)

 

further around line 309 change:

FCKConfig.SmileyPath = FCKConfig.BasePath + 'images/smiley/msn/' ;

into:

FCKConfig.SmileyPath = FCKConfig.BaseHref + FCKConfig.BasePath + 'images/smiley/msn/' ;

 

Thats it.

I'am glad about the result. Maybe an addition worth for to contribution.

Thanks for your companionship.

:lol:

 

 

 

 

Yeah, that is it, but...

 

In my case, I'm using tinyMCE, and I got the trouble with the image links, how do fix that in tinyMCE?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×