Jump to content
Sign in to follow this  
FWR Media

[Contribution] Independent SEO URL Validation

Recommended Posts

B)-->

QUOTE(Steven B @ Apr 6 2008, 10:36 AM) <{POST_SNAPBACK}>
die( include('MY404MESSAGE.php') ); // Product/category does not exist so die here with a 404

 

Here, with my own 404errorpage, i had the headers i sent earlyer.

 

Your 404 error page needs a 404 header then.

Share this post


Link to post
Share on other sites
albossum,

 

I'm assuming you asked permission from FWR Media to add something to the contribution page?

FWR Media wrote: "Please do not add packages here or I will cease support". That is the message on the contribution page that you seemed to have missed.

 

Your inability to set up your site correctly doesn't mean that you should change code and add contributions. The contribution already works the way it was intended to work. Your new addition needs to be taken off of the page before a newcomer has the mishap of believing it is actually needed.

 

No person in their right mind would have customers browse a whole site in https.

FWR Media and myself are not forum buddies nor does it matter to me whether we ever would be. All I know is that this would irritate to hell out of me if someone touched code that was already perfect the way it was and someone took it upon themselves to screw it up.

 

Thanks,

Google Junky

 

Hi Google junky,

 

It is not a reason to be rude!

 

I am sorry that I have skipped the line "Please do not add packages here or I will cease support". Unfortunately, I could not undo the upload. I hope you accept my excuse.

 

With my publishing, I just wanted to help others who may have the same problem that I had. It is the sense of each contribution, isn´t ist?

 

About my inability to set up my page: maybe you can help me? Why does a security warning appears when a site is partly loaded on http and https? (As is usual at oscommerce) How do I deal with this? I think that can only be bypassed if the whole site is loaded either via http or https, right?

 

I also thought it would be an open source project and each person can change and improve the code of other people? Sorry if I was wrong!

 

The fact, that the ssl problem was not included, says to me that the code was not "perfect", as you said. And Roberts recently released update of the function includes the ssl problem. (thanks to Robert by the way!). That means i wasn´t so wrong, right?

 

Also you have not read well, because our customers do not browse the whole site via https. This only happens when a customer decides to search for some products during the checkout. Once the user is logged on, he browses via https. Until he is off. Many customers are very concerned about their personal data and want to see the "padlock" when they are logged somewhere.

 

 

Sorry for my bad english!!!

 

Many greetings

 

Albossum

Share this post


Link to post
Share on other sites

That means i wasn´t so wrong, right?

 

I appreciate and welcome all comments in this thread related to the contribution whether good or bad.

 

The reason I don't want others adding to the contribution is that history has shown that contributions get "out of hand" with lots of "some good some aweful" changes being added leading to the point where new users just don't know which to download.

 

As you have seen I take notice of comments in this support forum and will do my best to meet the requirements of the majority and keep it updated.

 

BUT ..

 

If others add packages to the contribution I will cease support and stop updating.

 

Hope that makes sense.

Share this post


Link to post
Share on other sites

Hi Robert

 

The Mod works like a charm, well done!

 

However, if I remove the dash after either a p, c, m the correct URL is not rewritten as it should be, but gives me a 404 (not your 404 however, but my own one). Is it supposed behave like this?

 

see it in action at: www.thefrenchybee.com

Edited by pixclinic

Share this post


Link to post
Share on other sites
Hi Robert

 

The Mod works like a charm, well done!

 

However, if I remove the dash after either a p, c, m the correct URL is not rewritten as it should be, but gives me a 404 (not your 404 however, but my own one). Is it supposed behave like this?

 

see it in action at: www.thefrenchybee.com

 

Normal behaviour, .htaccess wont rewrite and the server will fail it as a bad url. It would never reach the SEO URLs contrib or validation.

Edited by FWR Media

Share this post


Link to post
Share on other sites
That means i wasn´t so wrong, right?

 

I appreciate and welcome all comments in this thread related to the contribution whether good or bad.

 

The reason I don't want others adding to the contribution is that history has shown that contributions get "out of hand" with lots of "some good some aweful" changes being added leading to the point where new users just don't know which to download.

 

As you have seen I take notice of comments in this support forum and will do my best to meet the requirements of the majority and keep it updated.

 

BUT ..

 

If others add packages to the contribution I will cease support and stop updating.

 

Hope that makes sense.

 

hi robert,

 

of course that makes sense! it just was a mistake of me. i unfortunately missed the line where you explained.

 

my last comment was addressed to "google junky" because he of his rude comment.

 

special thanks

 

greetings albossum

Share this post


Link to post
Share on other sites
Hmmm .. I've "doctored" a catalog/includes/classes/seo.class.php attached below .. please feed back.

 

 

Hi Robert,

 

I've installed Independent SEO URL Validation 1.0.2 according to the instructions and my categories are reported as http://mysite/-c-nn.html (n=number) and selecting any category redirects me to the index exactly as reported by charlie (post 82) and psq (post 91). I think you sent the fix to psq from post 91 but it's not clear for me which was. Could you please help me?

Share this post


Link to post
Share on other sites
Hi Robert,

 

I've installed Independent SEO URL Validation 1.0.2 according to the instructions and my categories are reported as http://mysite/-c-nn.html (n=number) and selecting any category redirects me to the index exactly as reported by charlie (post 82) and psq (post 91). I think you sent the fix to psq from post 91 but it's not clear for me which was. Could you please help me?

 

Install 2.1d updated. This is nothing to do with validation you probably have SEO URLs 2-2.2e installed.

Share this post


Link to post
Share on other sites

Hello, i install the 1.03 version, and i have much problems with, problems detected with previous versions too.

 

301 work correctly, but 404 not.

 

When i click to my product info page whitch have item with product_id 444. My link is like this -> http://www.mysite/xxx-p-444.html

Now i do manual modification of link in adress bar, i add for example "ghf7" AFTER the original number id, and i modify it like this-> http://www.mysite/xxx-p-444ghf7.html

Now the site and product info page continue to show the product number 444 :-( So with this bad link, header is still 200, AND full duplicate content on screen, BUT bigger problem here, my duplicate content info page show now different unique Model_id on page whitch CHANGE from 444 and show now this modified number "444ghf7".

Big security probleme here.

 

When i do same modification INSIDE or APEND the original number id like this -> http://www.mysite/xxx-p-44ghf74.html, http://www.mysite/xxx-p-4ghf744.html, http://www.mysite/xxx-p-ghf7444.html, then i do not have 404 not found, but just stock osc "Product not found!" page, with a normal 200 header, so not good.

 

ONLY when i suppress a part of " -p- " in link like this -> http://www.mysite/xxxp-444.html, and this -> http://www.mysite/xxx-p444.html, or i alter it like this -> http://www.mysite/xxx-pghf7-444.html i obtain 404 not found error page and Header, with my custom 404 page.

 

Tested with SEO 2.1d and 2.1d update 1.2

 

Link for check you headers

http://www.seoconsultants.com/tools/headers.asp

 

What do you think How we can rectify this problems ?

Edited by misillsam

Share this post


Link to post
Share on other sites
Hello, i install the 1.03 version, and i have much problems with, problems detected with previous versions too.

 

301 work correctly, but 404 not.

 

When i click to my product info page whitch have item with product_id 444. My link is like this -> http://www.mysite/xxx-p-444.html

Now i do manual modification of link in adress bar, i add for example "ghf7" AFTER the original number id, and i modify it like this-> http://www.mysite/xxx-p-444ghf7.html

Now the site and product info page continue to show the product number 444 :-( So with this bad link, header is still 200, AND full duplicate content on screen, BUT bigger problem here, my duplicate content info page show now different unique Model_id on page whitch CHANGE from 444 and show now this modified number "444ghf7".

Big security probleme here.

 

When i do same modification INSIDE or APEND the original number id like this -> http://www.mysite/xxx-p-44ghf74.html, http://www.mysite/xxx-p-4ghf744.html, http://www.mysite/xxx-p-ghf7444.html, then i do not have 404 not found, but just stock osc "Product not found!" page, with a normal 200 header, so not good.

 

ONLY when i suppress a part of " -p- " in link like this -> http://www.mysite/xxxp-444.html, and this -> http://www.mysite/xxx-p444.html, or i alter it like this -> http://www.mysite/xxx-pghf7-444.html i obtain 404 not found error page and Header, with my custom 404 page.

 

Tested with SEO 2.1d and 2.1d update 1.2

 

Link for check you headers

http://www.seoconsultants.com/tools/headers.asp

 

What do you think How we can rectify this problems ?

 

I do not see any problem. There is no instance where USU would append gh7 or any other alpha to products_id or cPath so the findings are irrelevant as the only time it could happen is if someone like you were hacking the querystring.

Edited by FWR Media

Share this post


Link to post
Share on other sites
I do not see any problem. There is no instance where USU would append gh7 or any other alpha to products_id or cPath so the findings are irrelevant as the only time it could happen is if someone like you were hacking the querystring.

 

 

I think Findings is very relevant.

This pointing another problem.

I explain.

We all needs to have a 404 error headers and page for our deleted products who are indexed on google.

example, If i have a product with id 4445, link will be http://www.mysite/xxx-p-4445.html

google index it, and after 2 months this product is no longer available and i delete it.

the product stay indexed on google.

visitor click on google link of deleted product http://www.mysite/xxx-p-4445.html, come on site, site display link -> http://www.mysite//-p-4445.html, and send header 200 OK.

Google verify indexed link of deleted product http://www.mysite/xxx-p-4445.html, and obtain 301 redirect to http://www.mysite//-p-4445.html with header 200 OK.

THIS is not good.

Edited by misillsam

Share this post


Link to post
Share on other sites

visitor click on google link of deleted product http://www.mysite/xxx-p-4445.html, come on site, site display link -> http://www.mysite//-p-4445.html, and send header 200 OK.

 

I can't replicate this, it dies with a 404 error message.

Share this post


Link to post
Share on other sites

Robert,

 

Thanks for the Contribution and keep up the excellent work.

 

I Installed the contribution and I am happy with the results. However, I decided to make the following change to suit my site, as I beleive the "four_o_four_die" function is a bit of a work around for a proper 404 redirect aand does not catch all incorrect URL's on a given domain. (i.e it would not catch www.mysite.co.uk/fgsd)

 

for people that are interested in doing a "proper" redirect simply replace line:

 

four_o_four_die(); // Product/category does not exist so die here with a 404

 

with:

 

die( include('404.html') ); // Product/category does not exist so die here with a 404

 

Delete the entire four_o_four_die() function. i.e delete this:

 

function four_o_four_die() { // 404 then redirect doesn't work as Google records a 302 so we need to die here with a 404
echo
header("HTTP/1.0 404 Not Found") .
'<p align="left" style="font-size: large;">  404 Page not found!</p>
<div align="center" style="width: 100%; margin-top: 70px;">
<div align="center" style="font-family: verdana; font-size: 0.8em; color: #818181; padding: 90px 10px 90px 10px; width: 60%; border: 1px solid #818181;">
This product/category does not exist it may have been deleted.<p />
To return to ' . STORE_NAME .
'. Please click here <a href="' . tep_href_link(FILENAME_DEFAULT) . '" title="' . STORE_NAME . '">back to ' . STORE_NAME . '</a>
</div></div>';
}

 

upload your custom 404 to the root of your site (there is plenty of advice on how to lay out your 404 page on the Net).

 

and add the following to your root .htaccess file

ErrorDocument 404 /404.html

 

hope this comes in use to someone.

 

Cheers

 

Joe

 

P.S. If you are doing a test page with less of less than 512 bytes and are using crappy IE make sure you turn off "Show friendly HTTP error messages" (Tools->Internest Options->Advanced->untick Show friendly HTTP error messages

Edited by jestore

Share this post


Link to post
Share on other sites
Robert,

 

Thanks for the Contribution and keep up the excellent work.

 

I Installed the contribution and I am happy with the results. However, I decided to make the following change to suit my site, as I beleive the "four_o_four_die" function is a bit of a work around for a proper 404 redirect aand does not catch all incorrect URL's on a given domain. (i.e it would not catch www.mysite.co.uk/fgsd)

 

for people that are interested in doing a "proper" redirect simply replace line:

 

four_o_four_die(); // Product/category does not exist so die here with a 404

 

with:

 

die( include('404.html') ); // Product/category does not exist so die here with a 404

 

Delete the entire four_o_four_die() function. i.e delete this:

 

function four_o_four_die() { // 404 then redirect doesn't work as Google records a 302 so we need to die here with a 404
echo
header("HTTP/1.0 404 Not Found") .
'<p align="left" style="font-size: large;">  404 Page not found!</p>
<div align="center" style="width: 100%; margin-top: 70px;">
<div align="center" style="font-family: verdana; font-size: 0.8em; color: #818181; padding: 90px 10px 90px 10px; width: 60%; border: 1px solid #818181;">
This product/category does not exist it may have been deleted.<p />
To return to ' . STORE_NAME .
'. Please click here <a href="' . tep_href_link(FILENAME_DEFAULT) . '" title="' . STORE_NAME . '">back to ' . STORE_NAME . '</a>
</div></div>';
}

 

upload your custom 404 to the root of your site (there is plenty of advice on how to lay out your 404 page on the Net).

 

and add the following to your root .htaccess file

ErrorDocument 404 /404.html

 

hope this comes in use to someone.

 

Cheers

 

Joe

 

P.S. If you are doing a test page with less of less than 512 bytes and are using crappy IE make sure you turn off "Show friendly HTTP error messages" (Tools->Internest Options->Advanced->untick Show friendly HTTP error messages

 

Joe this makes no sense at all.

 

My method dies and gives a 404 header .. your method dies and includes an html document. Other than that .. no difference whatsoever. You mention

 

the "four_o_four_die" function is  a bit of a work around for a proper 404 redirect aand does not catch all incorrect URL's on a given domain. (i.e it would not catch www.mysite.co.uk/fgsd)

 

Neither does yours, and neither was validation meant to, validation validates USU urls nothing else.

 

AND if your 404 doc does not have a valid 404 header then it wouldn't work at all. including a 404 file is a fine idea if you have one as long as it has a valid 404 header.

 

My method is only a workaround in as much as I could not assume that users would have a valid file to include.

Edited by FWR Media

Share this post


Link to post
Share on other sites
Joe this makes no sense at all.

 

My method dies and gives a 404 header .. your method dies and includes an html document. Other than that .. no difference whatsoever. You mention

 

the "four_o_four_die" function is  a bit of a work around for a proper 404 redirect aand does not catch all incorrect URL's on a given domain. (i.e it would not catch www.mysite.co.uk/fgsd)

 

Neither does yours, and neither was validation meant to, validation validates USU urls nothing else.

 

AND if your 404 doc does not have a valid 404 header then it wouldn't work at all. including a 404 file is a fine idea if you have one as long as it has a valid 404 header.

 

My method is only a workaround in as much as I could not assume that users would have a valid file to include.

 

 

Fair enough, I am not going to argue with you about it... apart from saying goto: http://www.amazon.co.uk/sdfsdf (catch all 404 page) and then goto http://www.babygurgles.co.uk/dfgfd (no catch all 404 page(as of this post))

Edited by jestore

Share this post


Link to post
Share on other sites

Problem with manufacturer and catergories split.

Installation was easy and urls redirect fine.

One little problem, when I go to a manufacturer(college team)on my site and I use drop down box to filter to a catergory the link will not go thru!!!

Visa Versa...

If I go to a catergory and us drop down to narrow to a college team the same thing happens,NOTHING...

I found that I can us my old seo.class.php file and everything works fine other than the Validation no longer works.

My old seo.class.php file is version 2.1 and the new one that is giving me problems is version 2.2

I have tried everything that I know and this one has got me tangled up...

 

HELP PLEASE!!!

Share this post


Link to post
Share on other sites

I also found that my links to the result next pages stopped functing as well.

So with this said I just uploaded my older version seo.class file for now...

 

Any help would be greatly appreciated.

Share this post


Link to post
Share on other sites
Fair enough, I am not going to argue with you about it... apart from saying goto: http://www.amazon.co.uk/sdfsdf (catch all 404 page) and then goto http://www.babygurgles.co.uk/dfgfd (no catch all 404 page(as of this post))

 

babygurgles doesn't have validation :)

Share this post


Link to post
Share on other sites
I also found that my links to the result next pages stopped functing as well.

So with this said I just uploaded my older version seo.class file for now...

 

Any help would be greatly appreciated.

 

I don't support 2-2.2e as it doesn't work. Try 2.1d updated.

Share this post


Link to post
Share on other sites

Ive got one for you FWR.

 

I found this by chance.

I was using information pages to create a page called about PR. So, the url looks like http://mysite.com/about-pr-i-18.html

Guess what happens?


Follow the community build:

BS3 to osCommerce Responsive from the Get Go!

Check out the new construction:

Admin Gone to Total BS!

Share this post


Link to post
Share on other sites
Ive got one for you FWR.

 

I found this by chance.

I was using information pages to create a page called about PR. So, the url looks like http://mysite.com/about-pr-i-18.html

Guess what happens?

 

Well it wouldn't work because -pr- is a seperator used by USU. Probably 404 die.

Share this post


Link to post
Share on other sites

I have trird 2.1 and when I installed your contribution with it my site locks up.

I could pull up index.php, but no other links would work.

So that is why I have been trying 2.2 version.

Share this post


Link to post
Share on other sites

Ultimate_SEO_URLSv21d_UPDATED

This is the version that I was originally using and I have reinstalled all the files.

I still have the same problem with your contribution, when I enable it in my admin area my links just go BLANK.

The only page that will pull up is the index page.

When I disable it everything works fine.

I have been working on this for 3 days now, about 20 or so hours of time in this project with no real success.

 

HELP PLEASE!!!

Share this post


Link to post
Share on other sites
Ultimate_SEO_URLSv21d_UPDATED

This is the version that I was originally using and I have reinstalled all the files.

I still have the same problem with your contribution, when I enable it in my admin area my links just go BLANK.

The only page that will pull up is the index page.

When I disable it everything works fine.

I have been working on this for 3 days now, about 20 or so hours of time in this project with no real success.

 

HELP PLEASE!!!

 

2.1d has no known issues other than the documented & issue and incompatibility with WinDoze servers. I presume you have the "Use Search-Engine Safe URLs (still in development)" turned off in admin.

 

Provide a link to your site.

Share this post


Link to post
Share on other sites

PM me when you want to see what it does when I set it to True in my admin panel.

 

www.yourcollegegear.com

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×