MSRP MRSP Savings with RC1 Missing code for INstallation

[bonzabuy 1]

Gday - did you get an answer for this?

I am getting a similar problem:

 

I think this Contrib is written for an older version of OSc?

 

INSTRUCTIONS:

12. In catalog/admin/categories.php around line 940 find the lines that read as follows:

 

if (isset($_GET['search'])) {
     $products_query = tep_db_query("select p.products_id, pd.products_name, p.products_quantity, p.products_image, p.products_price, p.products_date_added, p.products_last_modified, p.products_date_available, p.products_status, p2c.categories_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and p.products_id = p2c.products_id and pd.products_name like '%" . tep_db_input($search) . "%' order by pd.products_name");
   } else {
     $products_query = tep_db_query("select p.products_id, pd.products_name, p.products_quantity, p.products_image, p.products_price, p.products_date_added, p.products_last_modified, p.products_date_available, p.products_status from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and p.products_id = p2c.products_id and p2c.categories_id = '" . (int)$current_category_id . "' order by pd.products_name");
   }

 

But there is no

if (isset($_GET['search'])) {

in my file... I don't think it has been modified.

 

Here is the relevant section of my code

 $products_count = 0;
   if (isset($HTTP_GET_VARS['search'])) {
     $products_query = tep_db_query("select p.products_id, pd.products_name, p.products_quantity, p.products_image, p.products_price, p.products_date_added, p.products_last_modified, p.products_date_available, p.products_status, p2c.categories_id from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and p.products_id = p2c.products_id and pd.products_name like '%" . tep_db_input($search) . "%' order by pd.products_name");
   } else {
     $products_query = tep_db_query("select p.products_id, pd.products_name, p.products_quantity, p.products_image, p.products_price, p.products_date_added, p.products_last_modified, p.products_date_available, p.products_status from " . TABLE_PRODUCTS . " p, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where p.products_id = pd.products_id and pd.language_id = '" . (int)$languages_id . "' and p.products_id = p2c.products_id and p2c.categories_id = '" . (int)$current_category_id . "' order by pd.products_name");
   }

 

 

Can I just keep my original " if (isset($HTTP_GET_VARS['search']))" and use the rest of the code?

 

 

Also: my file doesn't have this code:

 if ($new_price = tep_get_products_special_price($pInfo->products_id)) {
     $products_price = '<s>' . $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</s> <span class="specialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</span>';
   } else {
     $products_price = $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id));
   };

[warrenerjm 1]

Gday - did you get an answer for this?

I am getting a similar problem:

 

I think this Contrib is written for an older version of OSc?

 

INSTRUCTIONS:

12. In catalog/admin/categories.php around line 940 find the lines that read as follows:

 

Can I just keep my original " if (isset($HTTP_GET_VARS['search']))" and use the rest of the code?

 

I just added the p.products_msrp, to the two following lines

 

Also: my file doesn't have this code:

 if ($new_price = tep_get_products_special_price($pInfo->products_id)) {
     $products_price = '<s>' . $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</s> <span class="specialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</span>';
   } else {
     $products_price = $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id));
   };

I was wondering about this one particularly, as I too cannot find it at all & I have the OSC 060817 version & not RC1

 

Does anyone know what this code is for please?

 

Can it just be ignored! or is there an alternative code to change?

 

Thanks

Julie

[adam777 0]

... also this code seems to be missing in osc version RC2a...

 

13. In catalog/admin/categories.php very near the end of the file find the lines that read as follows:

if ($new_price = tep_get_products_special_price($pInfo->products_id)) {
  $products_price = '<s>' . $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</s> <span class="specialPrice">' . $currencies->display_price($new_price, tep_get_tax_rate($pInfo->products_tax_class_id)) . '</span>';
} else {
  $products_price = $currencies->display_price($pInfo->products_price, tep_get_tax_rate($pInfo->products_tax_class_id));
};

 

 

Can someone please do a contribution update for this?