Jump to content
Jack_mcs

Links Manager II

Recommended Posts

Hi Jack!

 

 

I try on PHP5.3, but it looks like doesnt work. Maybe I missed something?


:blink:
osCommerce based shop owner with minimal design and focused on background works. When the less is more.
Email managment with tracking pixel, package managment for shipping, stock management, warehouse managment with bar code reader, parcel shops management on 3000 pickup points without local store.

Share this post


Link to post
Share on other sites

Hi Jack!

 

 

I try on PHP5.3, but it looks like doesnt work. Maybe I missed something?

Hmm, "it doesn't work." Does that mean 5.3, your server, your computer, the links page, the admin section...?

 

Assuming you are getting some error in Links Manager, it is probably related to the ereg code used in the current version of Links Manager. That has been replaced in the next version which will be released within a week.

Share this post


Link to post
Share on other sites

A new version has been uploaded with these changes:

 

- Added charset meta tag into links.php and links_submit.php

- Added option to display part of category description on the links page

- Added filtering for cross-scripting (thanks to member 32 Degrees)

- Added code to verify submitted links actually exist

- Added code to verify submitted links are all from the same domain name (thanks to member shpy)

- Added code to verify reciprocal links have a parent link on the home page

- Added column in links status in admin to show if the urls do not match (thanks to member shpy)

- Added a new class to the sytlesheet for descriptions

- Added a date column to the links listing in admin

- Added a no follow tag to the popup file

- Changed how titles are displayed on the links page

- Changed links check code to better check for errors

- Fixed a mistake in one of the css classes that caused the link count to be hidden

- Fixed search function on shop side (thanks to member shpy)

- Fixed several minor errors - missing classes, duplicate text, etc.

- Replaced ereg calls with preg type

 

Note regarding the two new options for link checking. In going through a number of sites that have link exchanges, I found that many of the links were from SEO companies. They would submit a link on behalf of their client. The reciprocal link would be on their site while the link from the shop owners site (your site) was to the others shop. This, in effect, gives that other site a one-way link since, in the cases I looked at, the link on the SEO companies web site was a stand-alone page with no links to it. Such a hidden page is useless to a site when exchanging links. I also found many regular sites doing something similar. They would have a links page but not a link to it from their home page. Those are dead pages with no PR and PR is the only reason for link exchanges so such links only help the other site, not yours. To fix that, I've added the Domain and Parent check options.

 

Domain Check: If enabled, this option will require that the reciprocal and main domain names (and the image url if that is used) to be from the same domain name.

 

Parent Check: If enabled, this option will check the home page to see if there is a link to the links page and refuse the link if not. This may not work in all cases since there are a number of possibilites as to how the reciprocal link can be added. But I think it will catch most of the missing ones.

 

If you don't want to use either of the above options, they can be turned off in admin. But given that the only reason to exchange links is to build PR, there isn't much reason to have exchanges that don't pass those checks. If you do you those options, you may want to add some text to the link exchange page explaining your policy.

Share this post


Link to post
Share on other sites

A new version has been uploaded with these changes:

 

- Added code to email results of the link_check script to the shop owner

- Changed javascript code on links edit page to consider the reciprocal override setting

- Fixed errors in the links_check.php file that prevented the new options from working correctly

- Switched the images on the Links Edit page so the domain and parent checks indicate correctly

Share this post


Link to post
Share on other sites

Hi there.

 

Thanks for the great Mod.

 

I just want to check one thing though.

 

I have the domain and parent check enabled.

 

The cron job I ran removed a link which I know for sure has a link from the main page, to the links page.


Craig Shaw

Linden Design

Share this post


Link to post
Share on other sites

Hi there.

 

Thanks for the great Mod.

 

I just want to check one thing though.

 

I have the domain and parent check enabled.

 

The cron job I ran removed a link which I know for sure has a link from the main page, to the links page.

Without the link all I can say is OK.

Share this post


Link to post
Share on other sites

Sorry, my bad.

 

The link was between two of my sites.

 

The store is located at http://www.thelittleboxofjewels.co.uk

 

And the site I linked to is http://www.lindendesign.co.uk

 

On the Linden Design site, down the left menu is a link to the Links page to which the little box of jewels link is present.

 

 

Thanks.


Craig Shaw

Linden Design

Share this post


Link to post
Share on other sites

The link was between two of my sites.

 

The store is located at http://www.thelittleboxofjewels.co.uk

 

And the site I linked to is http://www.lindendesign.co.uk

 

On the Linden Design site, down the left menu is a link to the Links page to which the little box of jewels link is present.

It appears to be correct and there may be a problem in the code casuing the problem but you need determine what the problem is before I can look into it. When you goto the links edit page in admin, how are the found, domain mismatch and parent mismatch items marked?

Share this post


Link to post
Share on other sites

It appears to be correct and there may be a problem in the code casuing the problem but you need determine what the problem is before I can look into it. When you goto the links edit page in admin, how are the found, domain mismatch and parent mismatch items marked?

 

For this domain, it says the following:

 

Site Located: Yes

 

Link Located: Yes

 

Domain Mismatch: No

 

Parent Mismatch: Yes


Craig Shaw

Linden Design

Share this post


Link to post
Share on other sites

A new version has been uploaded with these changes:

 

- Changed the code for figuring out the domain name

- Changed the code in the phase checking code

 

The above should allow the domain and parent checking to work correctly.

Share this post


Link to post
Share on other sites

Brill.

 

I'll give that a try over the weekend and let you know how I get on.

 

Thanks,

 

Craig


Craig Shaw

Linden Design

Share this post


Link to post
Share on other sites

Hi Jack,

Updated to the latest version and now I receive a google error "oops! This link appears to be broken" when selecting a category on my catalog/links page.

Any ideas?


If the only tool you have is a hammer, all your problems look like nails

Share this post


Link to post
Share on other sites

Hi Jack,

Updated to the latest version and now I receive a google error "oops! This link appears to be broken" when selecting a category on my catalog/links page.

Any ideas?

No ideas. Does it fail on every link? Do you have a url rewriter installed and, if so, does it fail if you turn the rewriter off? What version did you upgrade from? Are you sure you did all of the upgrades for each version?

Edited by Jack_mcs

Share this post


Link to post
Share on other sites

I don't know what you mean by url rewriter.

I do have seo url installed.

Yes it happens on all the links when clicking on them.

As for the upgrades I went through each upgrade doc and made sure all the changes were made.

If I shut off seo urls and then click a category link, the main page sits there waiting to load the next page.


If the only tool you have is a hammer, all your problems look like nails

Share this post


Link to post
Share on other sites

I don't know what you mean by url rewriter.

I do have seo url installed.

Yes it happens on all the links when clicking on them.

As for the upgrades I went through each upgrade doc and made sure all the changes were made.

If I shut off seo urls and then click a category link, the main page sits there waiting to load the next page.

Please provide a link to your site so I can see the problem.

Share this post


Link to post
Share on other sites

Hi Installed and got the following errors: when submitting a link

 

Warning: parse_url(http://) [function.parse-url]: Unable to parse URL in /home/blah/public_html/includes/functions/links.php on line 182

 

Warning: Cannot modify header information - headers already sent by (output started at /home/blah/public_html/includes/functions/links.php:182) in /home/blah/public_html/includes/functions/general.php on line 29

 

Any help appreciated

Andy

Share this post


Link to post
Share on other sites

Hi Installed and got the following errors: when submitting a link

 

Warning: parse_url(http://) [function.parse-url]: Unable to parse URL in /home/blah/public_html/includes/functions/links.php on line 182

The code is trying to check the url http://, which is invalid. You'll need to fix that.

Share this post


Link to post
Share on other sites

The code is trying to check the url http://, which is invalid. You'll need to fix that.

 

I tested links_submit.php again this time i deleted the http:// out of the image url field and it went through fine.

 

what im saying is if they dont enter an image url and they dont delete the http:// in the text box there is an error.

 

if they delete the http:// it goes through fine.

 

so i need to??? .... remove the http:// and have a note next to it saying (including the http:// ) or ..... :'(

Share this post


Link to post
Share on other sites

I tested links_submit.php again this time i deleted the http:// out of the image url field and it went through fine.

 

what im saying is if they dont enter an image url and they dont delete the http:// in the text box there is an error.

 

if they delete the http:// it goes through fine.

 

so i need to??? .... remove the http:// and have a note next to it saying (including the http:// ) or ..... :'(

That part of the code has been unchnaged for about six years. I suppose there could be something wrong with it that is causing it to fail on your just your site but it is more likley that something is either not installed correctly or something is being entered in that field.

Share this post


Link to post
Share on other sites

Hi Jack,

Sorry for the delay. My site can be found at www.lyonsperformance.com The link page is listed under cool links.


If the only tool you have is a hammer, all your problems look like nails

Share this post


Link to post
Share on other sites

Hi Jack,

Sorry for the delay. My site can be found at www.lyonsperformance.com The link page is listed under cool links.

The links look fine. My guess is that it is the url rewriter you are using but you said the same problem is there if that is turned off so I don't know what it might be.

Share this post


Link to post
Share on other sites

I have the latest Links manager installed and am having no major issues. But what I am noticing, what I am doing in links manager by entering data and clicking the buttons, it always take anywhere from 45 to 55 seconds before page refreshes. Now all of the other modules in admin, page refresh in withing a few seconds. So far I just entered only two so it's not like there numerous reciprocal links where it might take a little to load.

 

So me being curious, is this normal for links module to be somewhat slow? if not, is there something I might try to speed this up a bit.

 

Thanks.

 

Bennett

Share this post


Link to post
Share on other sites

I have the latest Links manager installed and am having no major issues. But what I am noticing, what I am doing in links manager by entering data and clicking the buttons, it always take anywhere from 45 to 55 seconds before page refreshes. Now all of the other modules in admin, page refresh in withing a few seconds. So far I just entered only two so it's not like there numerous reciprocal links where it might take a little to load.

 

So me being curious, is this normal for links module to be somewhat slow? if not, is there something I might try to speed this up a bit.

The number of links will have some effect but the main problem is probably the checking of the site. When the link listing and link edit pages are displayed, the links are checked to see if they are valid. If the other site takes a while to respond, so does the refresh.

Share this post


Link to post
Share on other sites

Thanks Jack. great plugin/addon

 

Would it be possible, if you find the time, to add and option so the person submitting has the option to add a picture or for our site to take a snapshot of there website as a image instead.

 

Either way great and I love it thanks again.

 

(oh also noticed that I got errors until I changed a setting in admin.. like the length of characters accepted - something like zero not accepted check mysql php version5 error.) all fine now

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×