Jump to content

Recommended Posts

this one from Sept 20th, 2015:
 

Hi tsimi,

I have installed get 1 free on oscommerce bootstrap master.
Now I have to do an adjustment in shoppingcart.php on line 102.


$products_name .= '<br>' . tep_draw_input_field('cart_quantity[]', $products[$i]['quantity'], 'style="width: 45px;"') . tep_draw_hidden_field('products_id[]', $products[$i]['id']) . tep_draw_hidden_field('free[]', $products[$i]['free']) . ' ' . tep_draw_button(NULL, 'glyphicon glyphicon-refresh', NULL, NULL, NULL, 'btn-info btn-xs') . ' ' . tep_draw_button(NULL, 'glyphicon glyphicon-remove', tep_href_link(FILENAME_SHOPPING_CART, 'products_id=' . $products[$i]['id'] . '&action=remove_product'), NULL, NULL, 'btn-danger btn-xs');


it comes to glyphicon. it is removed in master ????

should it be adjusted or not ???? because it works properly I think.

and there are also instructions for $HTTP_POST_VARS and $HTTP_GET_VARS, which don't exist in BS Edge. And another line that was re-coded for BS Edge, which does not match the instructions. I cannot remember what file it's in at the moment.

Like I said, not a big deal, but would be for someone less technical.

 

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&amp;geo=US&amp;q=oscommerce

Share this post


Link to post
Share on other sites

@Tsimi

hey Lambros,

If you do an update release, please don't forget to include that product_info.php page bug fix that you and David (Roaddoctor) worked on. I only found it on this forum after installing the addon. It's on page 17. Thanks.

Demitry

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&amp;geo=US&amp;q=oscommerce

Share this post


Link to post
Share on other sites

@Demitry

New version released.

Get 1 Free BS v1.7

https://apps.oscommerce.com/T3Bra&get-1-free-bs

I just did minor changes like automatic SQL install. Module for product info part. And some other minor changes.
I hope I got the expire date story right this time. That was the only bug left in the previous version.

Share this post


Link to post
Share on other sites

@Tsimi

Wow! That was fast man!

I uninstalled the other one and am installing this one. One thing,.. in the install.txt there is mention of a new file: catalog/includes/functions/get_1_free.php but it is not in the package.

 


osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&amp;geo=US&amp;q=oscommerce

Share this post


Link to post
Share on other sites

@Demitry

New package uploaded. It will be available in the next few minutes I guess.
Just use the functions/ file from that new package, no other changes.

Share this post


Link to post
Share on other sites

@Tsimi

Thank you Lambros.

One last thing,.. there was a conditional statement you added based on status ..a post from March 3rd and 4th of 2015 (page 17). This one:

if (($free_product['get_1_free_expires_date'] > date('Y-m-d H:i:s')) || ($free_product['status'] == 1)) {

I don't see it in /includes/modules/content/get_1_free/cm_pi_get_1_free.php You said prior that it fixed an issue, so should it be added?

Edited by Demitry

osCommerce: made for programmers, ...because store owners do not want to be programmers.

https://trends.google.com/trends/explore?date=all&amp;geo=US&amp;q=oscommerce

Share this post


Link to post
Share on other sites

Hmmm.... I have to check again.
I created a github repository so it is easier to test things before uploading a new addon version.

I have to leave the office now but I'll check it out later at home.
 

Edited by Tsimi

Share this post


Link to post
Share on other sites

@Demitry

So back at home now and just checked.

That status check is not needed. The code is good as it is at the moment.
The new functions file is taking care of the expire date issue now.

Share this post


Link to post
Share on other sites
10 minutes ago, Demitry said:

@Tsimi

Excellent! ..really great job on this addon! Thank you much.

Demitry

 

Thanks but credit for the addon goes to Jim aka. @kymation

I simply converted it for osC BS 

Share this post


Link to post
Share on other sites

Jim, Tsimi,

Hey there from way back... Yes, I still exist. Hope you are all well.

Came across a issue and hope you may have some insight... I'm still using non-BS shop...

I think PayPal changed something... When a customer tries to PP checkout with the get1free item in the cart, they are getting an error. In the log I am seeing:

L_ERRORCODE0 10003 
L_SHORTMESSAGE0 Missing argument 
L_LONGMESSAGE0 Item name, amount and quantity are required if item category is provided. 

The only thing I can think of is the $0.00 price is freaking out paypal…. ???

L_PAYMENTREQUEST_0_AMT1 0.00 

any ideas? I have no clue how to sort this one.

Thanks in advance

 


-Dave

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×