Demitry Posted November 1, 2017 Share Posted November 1, 2017 @Tsimi hey Lambros, If you do an update release, please don't forget to include that product_info.php page bug fix that you and David (Roaddoctor) worked on. I only found it on this forum after installing the addon. It's on page 17. Thanks. Demitry Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 1, 2017 Share Posted November 1, 2017 Roger that. Thanks. Quote Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 1, 2017 Share Posted November 1, 2017 @Demitry New version released. Get 1 Free BS v1.7 https://apps.oscommerce.com/T3Bra&get-1-free-bs I just did minor changes like automatic SQL install. Module for product info part. And some other minor changes. I hope I got the expire date story right this time. That was the only bug left in the previous version. Quote Link to comment Share on other sites More sharing options...
Demitry Posted November 2, 2017 Share Posted November 2, 2017 @Tsimi Wow! That was fast man! I uninstalled the other one and am installing this one. One thing,.. in the install.txt there is mention of a new file: catalog/includes/functions/get_1_free.php but it is not in the package. Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 2, 2017 Share Posted November 2, 2017 Ah crap! My bad. I'll upload it later today. Quote Link to comment Share on other sites More sharing options...
Demitry Posted November 2, 2017 Share Posted November 2, 2017 cool, thanks! Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 2, 2017 Share Posted November 2, 2017 @Demitry New package uploaded. It will be available in the next few minutes I guess. Just use the functions/ file from that new package, no other changes. Quote Link to comment Share on other sites More sharing options...
Demitry Posted November 2, 2017 Share Posted November 2, 2017 (edited) @Tsimi Thank you Lambros. One last thing,.. there was a conditional statement you added based on status ..a post from March 3rd and 4th of 2015 (page 17). This one: if (($free_product['get_1_free_expires_date'] > date('Y-m-d H:i:s')) || ($free_product['status'] == 1)) { I don't see it in /includes/modules/content/get_1_free/cm_pi_get_1_free.php You said prior that it fixed an issue, so should it be added? Edited November 2, 2017 by Demitry Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 2, 2017 Share Posted November 2, 2017 (edited) Hmmm.... I have to check again. I created a github repository so it is easier to test things before uploading a new addon version. I have to leave the office now but I'll check it out later at home. Edited November 2, 2017 by Tsimi Quote Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 2, 2017 Share Posted November 2, 2017 @Demitry So back at home now and just checked. That status check is not needed. The code is good as it is at the moment. The new functions file is taking care of the expire date issue now. Demitry 1 Quote Link to comment Share on other sites More sharing options...
Demitry Posted November 3, 2017 Share Posted November 3, 2017 (edited) @Tsimi Excellent! ..really great job on this addon! Thank you much. Demitry Edited November 3, 2017 by Demitry Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
♥Tsimi Posted November 3, 2017 Share Posted November 3, 2017 10 minutes ago, Demitry said: @Tsimi Excellent! ..really great job on this addon! Thank you much. Demitry Thanks but credit for the addon goes to Jim aka. @kymation I simply converted it for osC BS Quote Link to comment Share on other sites More sharing options...
Demitry Posted November 3, 2017 Share Posted November 3, 2017 Right,.. I saw that. Cheers to Jim as well. ...really great stuff! Quote osCommerce: made for programmers, ...because store owners do not want to be programmers. https://trends.google.com/trends/explore?date=all&geo=US&q=oscommerce Link to comment Share on other sites More sharing options...
Roaddoctor Posted March 22, 2019 Share Posted March 22, 2019 Jim, Tsimi, Hey there from way back... Yes, I still exist. Hope you are all well. Came across a issue and hope you may have some insight... I'm still using non-BS shop... I think PayPal changed something... When a customer tries to PP checkout with the get1free item in the cart, they are getting an error. In the log I am seeing: L_ERRORCODE0 10003 L_SHORTMESSAGE0 Missing argument L_LONGMESSAGE0 Item name, amount and quantity are required if item category is provided. The only thing I can think of is the $0.00 price is freaking out paypal…. ??? L_PAYMENTREQUEST_0_AMT1 0.00 any ideas? I have no clue how to sort this one. Thanks in advance Quote -Dave Link to comment Share on other sites More sharing options...
freakystreak Posted August 1, 2019 Share Posted August 1, 2019 Hey there @Tsimi how's things? I've just been adding this great add-on to my site but have come across an issue. I'm using OSC Frozen and when I add a free product to cart I'm getting this error: Uncaught Error: Call to undefined method shoppingCartMod::get1free() in shopping_cart.php line 203 Here is that line: if (is_array ($free_product = $this->get1free ($products_id))) { Any ideas? The admin side works fine and the front side works great until you add a BOGOF item to the cart then it complains... Quote Ah, the world wide web. What a wonderful place. Link to comment Share on other sites More sharing options...
♥raiwa Posted August 1, 2019 Share Posted August 1, 2019 (edited) 35 minutes ago, freakystreak said: Hey there @Tsimi how's things? I've just been adding this great add-on to my site but have come across an issue. I'm using OSC Frozen and when I add a free product to cart I'm getting this error: Uncaught Error: Call to undefined method shoppingCartMod::get1free() in shopping_cart.php line 203 Here is that line: if (is_array ($free_product = $this->get1free ($products_id))) { Any ideas? The admin side works fine and the front side works great until you add a BOGOF item to the cart then it complains... This is not related to get one free. shopping_cart_mod is part of wholesale. It seems you are using the wholesale product listing in shopping cart but do not have the wholesale main (store) module installed. The error says that something tries to use the shopping_cart_mod.php class, but it has not been initiated. I do not knoe the details of the get one fre addon, but it is possible that you need some code merging to get it to work together with wholesale. Edited August 1, 2019 by raiwa Quote About Me: http://www.oscommerce.com/forums/user/249059-raiwa/ Need help? How To Get The Help You Need Is your version of osC up to date? You'll find the latest osC community version CE Phoenix here. Public Phoenix Change Log Cheat Set on Google Sheets Link to comment Share on other sites More sharing options...
freakystreak Posted August 1, 2019 Share Posted August 1, 2019 1 minute ago, raiwa said: This is not related to get one free. shopping_cart_mod is part of wholesale. It seems you are using the wholesale product listing in shopping cart but do not have the wholesale main (store) module installed. The error says that something tries to use the shopping_cart_mod.php class, but it has not been initiated. @raiwa thank you for noticing that. If you remember I was having an issue with the products not stacking which I fixed by using just the default product_listing. This obviously is a connected issue with this add on. You've given me an idea as to what to look for now. Thanks again, sorry I confused things there. That's another drink I owe you.... Quote Ah, the world wide web. What a wonderful place. Link to comment Share on other sites More sharing options...
freakystreak Posted August 1, 2019 Share Posted August 1, 2019 @raiwa, @Tsimi problem sorted. Because Frozen is modular then I had to re-follow the install instructions as I had placed the main class in the wrong file. My bad... Thanks for the quick reply @raiwa. kymation and raiwa 2 Quote Ah, the world wide web. What a wonderful place. Link to comment Share on other sites More sharing options...
freakystreak Posted September 24, 2019 Share Posted September 24, 2019 On 3/22/2019 at 1:55 PM, Roaddoctor said: Jim, Tsimi, Hey there from way back... Yes, I still exist. Hope you are all well. Came across a issue and hope you may have some insight... I'm still using non-BS shop... I think PayPal changed something... When a customer tries to PP checkout with the get1free item in the cart, they are getting an error. In the log I am seeing: L_ERRORCODE0 10003 L_SHORTMESSAGE0 Missing argument L_LONGMESSAGE0 Item name, amount and quantity are required if item category is provided. The only thing I can think of is the $0.00 price is freaking out paypal…. ??? L_PAYMENTREQUEST_0_AMT1 0.00 any ideas? I have no clue how to sort this one. Thanks in advance I'm having the same issue. Is there a way to add a free product to Paypal Express? Quote Ah, the world wide web. What a wonderful place. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.