GemRock Posted January 28, 2007 Author Share Posted January 28, 2007 (edited) Hi Talle: 1. the h1 class only needs to apply to the heading title line, not the image line. 2. if you were talking about the category box at left column, then the h1 class wont have any effect on it. You need to make changes in the categories.php under includes/boxes/. No one does it by entering <b>etc html tags in the category names. That's why I do not put in function to take out the html tags in category names as I do to the product description. Ken Edited January 28, 2007 by GemRock Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
Talle Posted January 28, 2007 Share Posted January 28, 2007 Hi Talle: 1. the h1 class only needs to apply to the heading title line, not the image line. 2. if you were talking about the category box at left column, then the h1 class wont have any effect on it. You need to make changes in the categories.php under includes/boxes/. No one does it by entering <b>etc html tags in the category names. That's why I do not put in function to take out the html tags in category names as I do to the product description. Ken So that is why nothing affected the categories but only the title... :rolleyes: That brings me into my next question, and this is realy out of this subject, I do appologize to anyone that reads this since this is not why you are reading this thread (but I need to ask Ken..) Where in includes/boxes/categories.php do I make the changes (and what changes) to get the MAIN category to be bold and underlined as it where when I made the html tags in admin panel. I want the subcategories to be bold ONLY when activated but the MAIN categories to be bold and underlined all the time... I know I should know this but I´m sorry to say that I don´t!!! Once again I appologize for being out of topic!!! //Talle Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 28, 2007 Author Share Posted January 28, 2007 (edited) Hi Talle As you might know, the default for the cat box is that a cat only becomes bold when it is clicked. But of cource you'd change it whatever you like. As you said it is a bit off topic here, and it is not somehitng I have time for at the moment (sorry for that), so I am goign to leave it at another time. Meantime, while you are waiting for a solution, you could look at some other threads (eg, General or Installation sections) that someone may have posted a solution there. Ken Edited January 28, 2007 by GemRock Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
yos40 Posted January 29, 2007 Share Posted January 29, 2007 You 1st question: when you open the edit header tags page, there are three columns you can enter text. The 1st is the title tag, where you can enter the title wording for that product as shown at the left most column. 2nd question: Yes. You could show them in whatever way you like. Could you post your current <Title> </Title> tag in your product_info.php so that I can have a look, and see how it could be changed? Ken For the first answer: yea i got that from your info file but my qustion is there a way to contoll all the tags and stuff for pages that are not products? For example index.php, spacials.php exc... and here is my product info opening code hope you can help me <html <?php echo HTML_PARAMS; ?>> <head> <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> <title><?php echo TITLE; ?></title> <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>"> <link rel="stylesheet" type="text/css" href="style.css"> <script language="javascript"><!-- function popupWindow(url) { window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,res izable=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,le ft=150') } //--></script> </head> Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 29, 2007 Author Share Posted January 29, 2007 Hi yos40: None of the header tags contributions would make their focus on non-product pages, e.g., conditions, contact us etc. Specials is still a product-related page, so you can still control its title & meta tags as does to the product_info pages. What you need to do is open 'header tags edit.php', and enter the title tag, desc tag & keyword tag for each product. As you want the product name to show first, followed by category name and then title, you could enter the info in exactly that way, ie, product name for that product, then the cat that product belongs to, then the title you wnat to appear at the browser title bar for that product (all wihtin the title tag field). This way, you do not need to make any change to the Title tag (<Title> --- </Title>), but you do need to add the two meta tags below the title tag as per the instructions of the contribution. I hope this would clear the issue. Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 Installed the contribution Header Tags for novices and am having a problem. I am using STS v4.3.3 (plain without the Header Tag inclusion) with STS set to True HT4N does not work. If I set STS to False then HT4N works. So the problem has to have something to do with the fact that I am using STS. Has anyone else had this problem or does anyone know the fix? Thanks Allen Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 29, 2007 Author Share Posted January 29, 2007 Hi Allen More details please? In what way it didnt work? Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 Hi Allen More details please? In what way it didnt work? Ken Hi Ken, With STS active and using the template the title only shows the store name and there are no Meta tags for the description and Keywords. When not using the STS template and running the stock osc your contribution works as described. Here a part of the view source from a product page. <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html $htmlparams> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <title>Parts and Things</title><base href="http://www.partsanthings.com/catalog/"> <!-- start get_javascript(applicationtop2header) //--> <script language="javascript"><!-- function popupWindow(url) { window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,res izable=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,le ft=150') } //--></script> <!-- end get_javascript(applicationtop2header) //--> <link rel="stylesheet" media="screen" type="text/css" href="stylesheet.css"> <script type="text/javascript" src="column.js"></script> </head> <body> <!-- Header Start --> <div id="tmpheader"><img class="pos_right" src="../images/pnt-25790.gif" alt="Parts and Things" width="257" height="90" align="left"></img><div align="center"><h2>eStore</h2><h3>We'll sell your stuff</h3></div> Allen Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 29, 2007 Author Share Posted January 29, 2007 I just upload a new package that correct two typos, you could download the new package or make the correction here: For those who already downloaded the contrib, please correct the two typos in the included application_top.php: line 542 should read: $header_tags[keywords_tag]= trim(strip_tags($header_tags[keywords_tag])); That is, *keywords*, not *kewwords*. Sorry for the typo. Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
GemRock Posted January 29, 2007 Author Share Posted January 29, 2007 Hi Allen Ive never used STS so I do not know for sure what is the problem with it. But look at the source above, it would seem the two meta tags lines are missing: <meta name="description" content="<?php echo $header_tags[desc_tag]; ?>"> <meta name="keywords" content="<?php echo $header_tags[keywords_tag]; ?>"> Perhaps post your product_info.php (just the header tags) here? Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 Hi Allen Ive never used STS so I do not know for sure what is the problem with it. But look at the source above, it would seem the two meta tags lines are missing: <meta name="description" content="<?php echo $header_tags[desc_tag]; ?>"> <meta name="keywords" content="<?php echo $header_tags[keywords_tag]; ?>"> Perhaps post your product_info.php (just the header tags) here? Ken Hi Ken, Here's the header code from product_info.php <head> <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> <title><?php echo $header_tags[title_tag]; ?></title> <meta name="description" content="<?php echo $header_tags[desc_tag]; ?>"> <meta name="keywords" content="<?php echo $header_tags[keywords_tag]; ?>"> <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . DIR_WS_CATALOG; ?>"> <link rel="stylesheet" type="text/css" href="stylesheet.css"> <script language="javascript"><!-- function popupWindow(url) { window.open(url,'popupWindow','toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,res izable=yes,copyhistory=no,width=100,height=100,screenX=150,screenY=150,top=150,le ft=150') } //--></script> </head> Allen Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 29, 2007 Author Share Posted January 29, 2007 ...Here's the header code from product_info.php <head> <meta http-equiv="Content-Type" content="text/html; charset=<?php echo CHARSET; ?>"> <title><?php echo $header_tags[title_tag]; ?></title> <meta name="description" content="<?php echo $header_tags[desc_tag]; ?>"> <meta name="keywords" content="<?php echo $header_tags[keywords_tag]; ?>"> <base href="<?php echo (($request_type == 'SSL') ? HTTPS_SERVER : HTTP_SERVER) . ... </head> That doesnt make sense to me: you got the meta tags there, but they were completely ignored. What I can do is get a copy of STS and have a look at it to see if theres anything unusual. Will get back to you but do allow more time. Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 That doesnt make sense to me: you got the meta tags there, but they were completely ignored. What I can do is get a copy of STS and have a look at it to see if theres anything unusual. Will get back to you but do allow more time. Ken Hi Ken, Thanks!!!! Allen Quote Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 That doesnt make sense to me: you got the meta tags there, but they were completely ignored. What I can do is get a copy of STS and have a look at it to see if theres anything unusual. Will get back to you but do allow more time. Ken Ken, I figured out what is causing it, but not how to fix it. In the top of the template there is a line <!--Headcontent--> this puts the header information in the page. Now to figure out how to modify it so that it will include you contrib. Allen Quote Link to comment Share on other sites More sharing options...
bigal50 Posted January 29, 2007 Share Posted January 29, 2007 Ken,I figured out what is causing it, but not how to fix it. In the top of the template there is a line <!--Headcontent--> this puts the header information in the page. Now to figure out how to modify it so that it will include you contrib. Allen Hi Ken, Found out where it is happening at but my programing isn't good enough to know how to correct it. From what I can tell the problem is in catalog/includes/modules/sts_inc/general.php The line of code is towards the bottom at around line 69 $sts->template['headertags']= "<title>" . TITLE ."</title>"; Tried putting your coed from index.php in place of what was there and got parse errors. What ever I tried didn't work. Allen Quote Link to comment Share on other sites More sharing options...
GemRock Posted January 30, 2007 Author Share Posted January 30, 2007 Hi Allen Sorry to hear that the problem is still there and I think I understand. Ive been working on a site for the big valentine season the whole evening & 2morrow as well, so for give me not to have the time to look at it in details :( as I am not familiar with STS. ONce I get the time I will take a look as many people seem to use STS. Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
bigal50 Posted January 30, 2007 Share Posted January 30, 2007 Hi Ken, Found a post in Tips and Tricks with the answer As always BACKUP before making any changes In catalog/includes/modules/sts_inc/general.php Look for the following, around line 67 $sts->template['headertags']= "<title>" . TITLE ."</title>"; Replace with the following // Header Tags for novices w/STS BOF $sts->template['headertags']= "<title>"; $sts->template['headertags'] .= (strlen($breadcrumb_tags->trail_tags('')) > 0) ? TITLE . ' - ' . $breadcrumb_tags->trail_tags(' - ') : TITLE; $sts->template['headertags'] .= "</title>"; $sts->template['headertags'] .= "<meta name=\"description\" content=\""; $sts->template['headertags'] .= (strlen($product_info_tags['products_description']) > 10) ? strip_tags($product_info_tags['products_description']) : strip_tags($breadcrumb_tags->trail_tags(' ')); $sts->template['headertags'] .= "\"><meta name=\"keywords\" content=\""; $sts->template['headertags'] .= strip_tags($breadcrumb_tags->trail_tags(', ')); $sts->template['headertags'] .= "\">"; // Header Tags for novices w/STS Thanks to Egor for this code. I only copied it to this thread Thanks Ken for the great contrib and trying to help me with this. You might want to add this to your docs to make it easier for others with STS to use Header Tags for novices. Thanks Allen Quote Link to comment Share on other sites More sharing options...
bigal50 Posted January 30, 2007 Share Posted January 30, 2007 After a little testing it seems that there might be a flaw in the above code, at least on my site. It is only putting the Store Name - Catagory - Catagory in the title and just the catagory in Description and Keywords. Could be that I'm using a different version of STS that what Egor was using, I'm using STS v4.3.3 Here is part of the header from a product page <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <title>Parts and Things - DVD Movies</title><meta name="description" content="DVD Movies"><meta name="keywords" content="DVD Movies"><base href="http://www.partsanthings.com/catalog/"> Allen Quote Link to comment Share on other sites More sharing options...
bigal50 Posted January 30, 2007 Share Posted January 30, 2007 (edited) This may not be the best solution but it seems to work on my site, it's closer to Ken's original contrib in the way it places thing in the title, description & keywords. Don't forget BACKUP before editing files. In catalog/includes/modules/general.php around line 68 Find the following $sts->template['headertags']= "<title>" . TITLE ."</title>"; Replace with this // Header Tags for novices w/STS v4.3.3 BOF $sts->template['headertags']= "<title>"; // $sts->template['headertags'] .= (strlen($breadcrumb_tags->trail_tags('')) > 0) ? TITLE . ' - ' . $breadcrumb_tags->trail_tags(' - ') : TITLE; $sts->template['headertags'] .= $header_tags[title_tag]; $sts->template['headertags'] .= ' - ' . TITLE; $sts->template['headertags'] .= "</title>"; $sts->template['headertags'] .= "<meta name=\"description\" content=\""; $sts->template['headertags'] .= $header_tags[desc_tag]; $sts->template['headertags'] .= "\"><meta name=\"keywords\" content=\""; $sts->template['headertags'] .= $header_tags[keywords_tag]; $sts->template['headertags'] .= "\">"; // Header Tags for novices EOF This works with the catalog/admin/header_tags_edit.php too. Allen Edited January 30, 2007 by bigal50 Quote Link to comment Share on other sites More sharing options...
Patty Posted January 30, 2007 Share Posted January 30, 2007 Very nice contribution, thank you for making it available. :thumbsup: Someone has posted the same kind of error I'm getting, but there was no solution posted as of yet: 1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 select count(*) as total from products p, products_description pd where p.products_id = pd.products_id and pd.language_id = '4'order by [TEP STOP] This happens when I click the Update button or when I go to the next page. I have no other errors on my admin, everything seems to be working fine. Could you please shed a light? Although I'm no noobie to osCommerce and PHP and MySQL, I'm no programmer. TIA for your help. Quote Patty Link to comment Share on other sites More sharing options...
GemRock Posted January 30, 2007 Author Share Posted January 30, 2007 Hi Patty As far as I am concerned, this is a strange error and it seems it doesnt mean what it says as you'd notice there's no such query as 'select count as total' in the header tags edit php file. The first person who reported the problem was Toby but unfornately there's no further response from him. AS this problem seems only happen to some people and I my self cannot re-produce the problem whatsoever (php4, php 5, mysql 4, mysql 5), I guess although not comclusive it may be something to do with the setup of your osc shop. It'd be useful for future investigation if you'd state how you access this header tags edit, ie, is it via a link in the catalog box or directly key in the file name in the address bar? Good Luck! Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
Patty Posted January 30, 2007 Share Posted January 30, 2007 Hey, Ken. Tks for your reply. It turned out the problem seems to occur only on older versions of MySQL. I noticed the version on my local machine was 3, so I upgrade it and the error is gone. :) Tks for such a great and easy contribution. Everything is working great now. :thumbsup: Quote Patty Link to comment Share on other sites More sharing options...
GemRock Posted January 30, 2007 Author Share Posted January 30, 2007 (edited) ...occur only on older versions of MySQL. I noticed the version on my local machine was 3, so I upgrade it and the error is gone. .. Goodness me! I'd never ever thought there's still mysql 3 going around in this 21th century! Anyway, good to hear you got it work. Regards, Ken Edited January 30, 2007 by GemRock Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
Patty Posted January 30, 2007 Share Posted January 30, 2007 (edited) Actually, I still don't understand why my version was 3.23.49. I use xampp 1.5.5, latest version, and it says MySQL version is 5. So I just reinstalled it, and although it's still showing v3.23.49 for MySQL, the error didn't happen again. As a suggestion, it would be nice if the list of products on the edit page could link directly to each product on the store. ;) Edited January 30, 2007 by Patty Quote Patty Link to comment Share on other sites More sharing options...
GemRock Posted January 30, 2007 Author Share Posted January 30, 2007 ...it would be nice if the list of products on the edit page could link directly to each product on the store... Dont understand what you mean? Ken Quote commercial support - unProtected channel, not to be confused with the forum with same name - open to everyone who need some professional help: either PM/email me, or go to my website (URL can be found in my profile). over 20 years of computer programming experience. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.