Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

My wifes new store. Feedback please


Doc Holliday

Recommended Posts

it's not very clear if a product is added to the basket or not. especially since the contents are on the bottom left, which is of my screen. Consider putting the number of items in the header.

 

It doesn't load very fast, although it's not too slow either (am on 2 mbps)

 

too many cell borders in shopping_cart.php

 

nice colours and pics!

Link to comment
Share on other sites

Your Visa and Master Card icons are broken on your main page. Is there a reason why the shadow boarder is darker on the left as opposed to a lighter shade on the right (it seems pretty awkward to me)? Your search icon magnification glass should be put on a transparent background since the white is showing over the light blue background. In your categories, your category icons are broken. Finally, I do not recommend putting all your text on the main page into a image for SEO purposes.

Andrew Yuen

osCommerce, Community Team

Link to comment
Share on other sites

Thanks yet again. Looks like many of my problems are due to me not checking in IE often enough. It all works a lot better in FF and Opera.

 

The reason I've been sloppy about IE is when I am working on my local machine, IE doesn't like to work properly for whatever reason, so I generally only check it online. Any ideas why I might be having problems with IE and my testing server (I'm using WAMP)

Link to comment
Share on other sites

First thing that i noticed was that the text "quick find" is different from all the other box headings. It looks a bit out of place like that. Your advanced search page has a standard oscomerce button. It looks nothing like some of your other buttons. Your advanced search help page would be better if it related to items that you sell, not computer parts.

 

On this page it would appear that some of the product description is not shown. Part of it goes beyond the page width. It happens on most pages now that i look. On some of these pages your complete image is not shown. Itys almost like the center page is too narrow.

 

You are obviously a UK based company as your prices are only available in pounds sterling. My question is Why is your create account page not in the UK address and date format? There may be a good explanation.

 

I also keep getting a this page containd both secure and non secure items message. This will need looking at.

 

I also could not find a contact name, address and phone number where you could be contacted.

 

On a positive note i do like the colours, and layout of your site, but do think that in places there are too many black boxes around items, such as on your create account page.

REMEMBER BACKUP, BACKUP AND BACKUP

Link to comment
Share on other sites

Hi Doc,

 

 

 

I really like the idea for the shop and the design ... lovely site!

 

It helps that I'm a deep believer in Victoriana :-)

 

 

 

...there is a bunch of little things that I noticed for design and would really change. Not sure if you are interested in that kind of comment, if yes give me a holler!

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

The site is very nice.

What i don't like is that banner.

You alreay mentioned that is Powered by osCommerce and i think Harald Ponce de Leon will not be too upset if you remove the banner :), or, if you really want an oscommerce banner on your site, try to modify it a bit. Its design has nothing in common with your website.

Link to comment
Share on other sites

Hi Alan,

 

here my list of little things for finetuning ... no specified order, not complete either, just what stucks me first :-)

 

- osC banner ... bye bye ... ditto for the FF affiliate ...not the style of this site

- on the homepage, I'd change the footer paypal logo into a text link, takes up way too much space and doesn't seem to fit in. For all other pages, I'd add the paypal logo and the cc images to the column left, under the cart box

- atten footer, on some pages aligned to center, on some to center but only in the main part (not includig col left)

- I'd shift around the header ... would need to try a few option, but without trying I think this order would look best from left to right: family silver banner ... past to present banner ... monogram. ... or ... maybe the present thing on the left, as it seems to be same with as column, that alwys looks nice. would really have to try. Easyest for trying: create a variable for each cell content, then the 3 cells and only shift numbers (like col1, col2, col3). I didn't forget your links. I'd add them above the page - move everything a bit down, and at top right on plain light bg or add to bar while probably getting rid of the create account one and only keeping login - hardly anyone creates an account without stuff inthe cart and in that case the login page will be clear enough

- I see you have played woth the boxes,not bad, while I really likes the one with the borders and the bit of ... was it red?

here more box ideas:

the cat box has a line at the bottom, while the inrmation box doesn't. You need a counter so the last cat doesn't usethe sep line

the quick find box blue font doen't appeal to me, would use the purple from the buttons

- in general, your boxes on the left should match the center page box or it looks awkward if they are too similar but different. Alternatively, why not have a new look for the center page?

- main page and boxes do not align at top

- make shopping basket header a link

- cart page: if you want to keep the nice big images, consider adding product name below or above the image - longer words that cannot start a new line will break your design

- contact us page header looks a bit lost, add your full addy to this page

- cate gory image (on vintage cat etc) looks lost, I'd get rid of it and free up that space too

- subcat page looks nice, but adjust the smaller images so all are same height

- in product listing, remove the space before the product name ...

- I'd add the pice above the buy now button and free up more space for the product name, less lines needed

- did you try white for the product names?

- attention for the security alert, all images used must either use base of page (for SSL base) or be hardcoded with SSL url.

- Create account page doesn't align in any direction. Try the format movies use, create a 3 col layout, with a 20px empty center column, left col aligning to the right and right col aligning to the left

- you really ship everywhere? limit list to your real target countries, and have UK preselected

- get rid of options header

 

I'm sure this site will turn out great! Say hello to dw from me, and have her look at my cake site (old hobby, in my profile, look for hollywood link ... many Victorian cakes)

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

Wow, How can I go to work this week with so much to do (or even take a holiday a week later!!!!) :blink:

 

Thanks so much for your suggestions, which I am gradually digesting and attending to! I hope I can 'get my head round it' so to speak!!

 

Thanks all of you!

Link to comment
Share on other sites

Hello again.

 

I have a few questions. While I am able to attend to many of the suggestions, I am a little overstretched in some areas. I'd appreciate a little help if possible:-

 

 

cart page: if you want to keep the nice big images, consider adding product name below or above the image - longer words that cannot start a new line will break your design

 

How do I do this?? I suppose it's a coding job, I have found the 'zone' it's all in but am not sure where/how to move which buits of code.

 

- attention for the security alert, all images used must either use base of page (for SSL base) or be hardcoded with SSL url.

 

I don't fully understand. The security alert I presume is the 'secure/undsecure items'. These seem to have just been the visa/mastercard images and the 'paypal verified'. The Paypal has gone. how do you hardcode images? or how do I use the base of the page?

 

the cat box has a line at the bottom, while the inrmation box doesn't. You need a counter so the last cat doesn't usethe sep line

 

This, I think, is due to the fact that All Products should appear in the Cat box. (It does in FF and Opera, but not in IE). Please can you tell me what a 'counter' is?

 

 

So many questions. Thanks in advance.

Link to comment
Share on other sites

the last one is the easiest: when one browser doesn't behave, look at the source code generated by the page ... in this case I got

 

 

 

<tr>

<td class="boxText"><a href="http://familysilver.co.uk/all_products.php...69b8f623d10d5ba" ">All Products</a><br></td>

</tr>

 

see the orphan quote? Try to find in your php code, if not, post that part for me.

 

**********************************************************

 

cart page: if you want to keep the nice big images, consider adding product name below or above the image - longer words that cannot start a new line will break your design

 

this is done in the product listing file and admin. in admin you hide the products image column

 

in the file, you copy the code that is in products image column to your products name column, abouve or under it, using a <br> in between the both and cancatenating the rows. One possible way cound be this (name below pic, centered):

 

case 'PRODUCT_LIST_NAME':
 $lc_align = 'center';
 if (isset($HTTP_GET_VARS['manufacturers_id'])) {
$lc_text = ' <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a>';
$lc_text .= '<br> <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'manufacturers_id=' . $HTTP_GET_VARS['manufacturers_id'] . '&products_id=' . $listing['products_id']) . '">' . $listing['products_name'] . '</a>';
 } else {
$lc_text = ' <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . tep_image(DIR_WS_IMAGES . $listing['products_image'], $listing['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a> ';
$lc_text .= '<br> <a href="' . tep_href_link(FILENAME_PRODUCT_INFO, ($cPath ? 'cPath=' . $cPath . '&' : '') . 'products_id=' . $listing['products_id']) . '">' . $listing['products_name'] . '</a> ';
 }
 break;

 

************************************************************

 

hardcoded images: if you code an image like this: http://www.yoursite.com/images/... even on an SSL page the pic will be NON-SSL giving the alert. Yours is gone so it was the paypal image, right? Save the image to your own folder and call by relative paths (starting with the images folder), it will automatically use the base of the page. Personally, I add all onsite links and images only with the tep_image and tep_href_link functions respectively

 

*********************************************************

 

 

 

hmmmmmmmm wasn't too many questions :-) ... you're on your way!

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

<tr>

<td><?php

$info_box_contents = array();

$info_box_contents[0][] = array('align' => 'center',

'params' => 'class="productListing-heading"',

'text' => TABLE_HEADING_REMOVE);

 

$info_box_contents[0][] = array('params' => 'class="productListing-heading"',

'text' => TABLE_HEADING_PRODUCTS);

 

$info_box_contents[0][] = array('align' => 'center',

'params' => 'class="productListing-heading"',

'text' => TABLE_HEADING_QUANTITY);

 

$info_box_contents[0][] = array('align' => 'right',

'params' => 'class="productListing-heading"',

'text' => TABLE_HEADING_TOTAL);

$any_out_of_stock = 0;

$products = $cart->get_products();

for ($i=0, $n=sizeof($products); $i<$n; $i++) {

// Push all attributes information in an array

if (isset($products[$i]['attributes']) && is_array($products[$i]['attributes'])) {

while (list($option, $value) = each($products[$i]['attributes'])) {

echo tep_draw_hidden_field('id[' . $products[$i]['id'] . '][' . $option . ']', $value);

$attributes = tep_db_query("select popt.products_options_name, poval.products_options_values_name, pa.options_values_price, pa.price_prefix

from " . TABLE_PRODUCTS_OPTIONS . " popt, " . TABLE_PRODUCTS_OPTIONS_VALUES . " poval, " . TABLE_PRODUCTS_ATTRIBUTES . " pa

where pa.products_id = '" . $products[$i]['id'] . "'

and pa.options_id = '" . $option . "'

and pa.options_id = popt.products_options_id

and pa.options_values_id = '" . $value . "'

and pa.options_values_id = poval.products_options_values_id

and popt.language_id = '" . $languages_id . "'

and poval.language_id = '" . $languages_id . "'");

$attributes_values = tep_db_fetch_array($attributes);

 

$products[$i][$option]['products_options_name'] = $attributes_values['products_options_name'];

$products[$i][$option]['options_values_id'] = $value;

$products[$i][$option]['products_options_values_name'] = $attributes_values['products_options_values_name'];

$products[$i][$option]['options_values_price'] = $attributes_values['options_values_price'];

$products[$i][$option]['price_prefix'] = $attributes_values['price_prefix'];

}

}

}

 

for ($i=0, $n=sizeof($products); $i<$n; $i++) {

if (($i/2) == floor($i/2)) {

$info_box_contents[] = array('params' => 'class="productListing-even"');

} else {

$info_box_contents[] = array('params' => 'class="productListing-odd"');

}

 

$cur_row = sizeof($info_box_contents) - 1;

 

$info_box_contents[$cur_row][] = array('align' => 'center',

'params' => 'class="productListing-data" valign="top"',

'text' => tep_draw_checkbox_field('cart_delete[]', $products[$i]['id']));

 

 

 

$products_name = '<table border="0" cellspacing="2" cellpadding="2">' .

' <tr>' .

' <td class="productListing-data" align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">' . tep_image(DIR_WS_IMAGES . $products[$i]['image'], $products[$i]['name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></td>' .

' <td class="productListing-data" valign="bottom"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '"><b>' . $products[$i]['name'] . '</b></a>';

 

if (STOCK_CHECK == 'true') {

$stock_check = tep_check_stock($products[$i]['id'], $products[$i]['quantity']);

if (tep_not_null($stock_check)) {

$any_out_of_stock = 1;

 

$products_name .= $stock_check;

}

}

 

if (isset($products[$i]['attributes']) && is_array($products[$i]['attributes'])) {

reset($products[$i]['attributes']);

while (list($option, $value) = each($products[$i]['attributes'])) {

$products_name .= '<br><small><i> - ' . $products[$i][$option]['products_options_name'] . ' ' . $products[$i][$option]['products_options_values_name'] . '</i></small>';

}

}

 

$products_name .= ' </td>' .

' </tr>' .

'</table>';

 

$info_box_contents[$cur_row][] = array('params' => 'class="productListing-data"',

'text' => $products_name);

 

$info_box_contents[$cur_row][] = array('align' => 'center',

'params' => 'class="productListing-data" valign="top"',

'text' => tep_draw_input_field('cart_quantity[]', $products[$i]['quantity'], 'size="4"') . tep_draw_hidden_field('products_id[]', $products[$i]['id']));

 

$info_box_contents[$cur_row][] = array('align' => 'right',

'params' => 'class="productListing-data" valign="top"',

'text' => '<b>' . $currencies->display_price($products[$i]['final_price'], tep_get_tax_rate($products[$i]['tax_class_id']), $products[$i]['quantity']) . '</b>');

}

 

new productListingBox($info_box_contents);

?></td>

 

This is the code for the table in the shopping cart (I think:huh: ), I am very lost right now, if you could show where and how, I'd be very grateful.

 

My presumption is that I need to change this bit:

 

$products_name = '<table border="0" cellspacing="2" cellpadding="2">' .

' <tr>' .

' <td class="productListing-data" align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">' . tep_image(DIR_WS_IMAGES . $products[$i]['image'], $products[$i]['name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a></td>' .

' <td class="productListing-data" valign="bottom"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '"><b>' . $products[$i]['name'] . '</b></a>';

 

But can't work it out. Sorry, but I am very very fresh to all this coding malarky.

Link to comment
Share on other sites

ahhh bugger I can not see I gave you code how to put the product name below the image for the product listing in my last post - not the cart! Well I hope someone wants just that and can use it... Maybe I should really start sleeping more :lol:

 

 

 

ok here you go, yes you found the correct spot, change to this:

$products_name = '<table border="0" cellspacing="2" cellpadding="2">' .
' <tr>' .
' <td class="productListing-data" align="center"><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '">' . tep_image(DIR_WS_IMAGES . $products[$i]['image'], $products[$i]['name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</a><br><a href="' . tep_href_link(FILENAME_PRODUCT_INFO, 'products_id=' . $products[$i]['id']) . '"><b>' . $products[$i]['name'] . '</b>';

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

I gave you code how to put the product name below the image for the product listing in my last post - not the cart! Well I hope someone wants just that and can use it...

 

It's all useful for me. Steeeeeeeeep learning curve :thumbsup:

 

Alan

Link to comment
Share on other sites

Here's a howto contrib for box header links, well explained all around:http://www.oscommerce.com/community/contributions,3033/category,all/search,infobox+header+link

 

If you'd like to follow my suggestion on the buy now/price combo, you need to turn off the buy now button in admin for product listing (or you get 2 lol).

Then you open the products_listing.php and find this:

 

case 'PRODUCT_LIST_PRICE':

$lc_align = 'right';

if (tep_not_null($listing['specials_new_products_price'])) {

$lc_text = ' <s>' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</s>  <span class="productSpecialPrice">' . $currencies->display_price($listing['specials_new_products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</span> ';

} else {

$lc_text = ' ' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . ' ';

}

break;

 

replace by this

 

case 'PRODUCT_LIST_PRICE':

$lc_align = 'center';

if (tep_not_null($listing['specials_new_products_price'])) {

$lc_text = ' <s>' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</s>  <span class="productSpecialPrice">' . $currencies->display_price($listing['specials_new_products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . '</span> ';

} else {

$lc_text = ' ' . $currencies->display_price($listing['products_price'], tep_get_tax_rate($listing['products_tax_class_id'])) . ' ';

}

$lc_text .= '<p> <a href="' . tep_href_link(basename($PHP_SELF), tep_get_all_get_params(array('action')) . 'action=buy_now&products_id=' . $listing['products_id']) . '">' . tep_image_button('button_buy_now.gif', IMAGE_BUTTON_BUY_NOW) . '</a> ';

break;

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

Monika,

 

Thanks a bunch. That's all great. Except..... I used the contri for Box Header Links and it has a black line around the image which turns white on hover.. The code that I changed has class as "headernavigation".

 

<?php

$info_box_contents = array();

$info_box_contents[] = array('text' => '<a class="headerNavigation" href="' . tep_href_link(FILENAME_SHOPPING_CART) . '">' . BOX_HEADING_SHOPPING_CART . '</a>');

new infoBoxHeading($info_box_contents, false, true, tep_href_link(FILENAME_SHOPPING_CART));

 

I have mucked around, trying to find which style is causing it with no luck. Any thoughts?

 

Gillian, thanks for that, I will do asap.

Link to comment
Share on other sites

Alan, the box header isn't a link for me ... would need to see in action!

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

just what I thought ... when you defined the image for the cartheader, you didn't use the tep_image function which you really should! It adds the attribute border="0" automatically apart from other advantages.

 

for a quick fix add the border attribute in your define ... as default is a border in bright blue :-)

 

<img src="images/shoppingcarttitle.gif">

 

to

 

<img src="images/shoppingcarttitle.gif" border="0" >

:-)

Monika

 

addicted to writing code ... can't get enough of databases either, LOL!

 

my toolbox: Textpad - Compare and Merge - phpMyAdmin - WS_FTP - Photoshop - How to search the forum

 

Interactive Media Award July 2007 ~ category E-Commerce

my advice on the forum is for free, PMs where you send me work are considered consultation which I charge for ...

Link to comment
Share on other sites

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...