Jump to content
Sign in to follow this  
tomjmul

Support thread for the Image Magic contribution

Recommended Posts

I am also having an issue with the more pics contrib. I can increase the size of the main image in the product info page but the other images stay the same size as set in small image size rather than changing to the size set in the product info size. I would like to have the thumbnails in the product info be larger than in the rest of the site.

 

Answsering my own question here:

 

I changed the references to the small_image_width and small_image_height in product_info.php to PRODUCT_INFO_IMAGE_WIDTH and PRODUCT_INFO_IMAGE_HEIGHT and this fixed that problem.

Share this post


Link to post
Share on other sites
did not have a thumbnail file anywhere. So I created one (catalog/thumbnails) is this where it is supposed to be? I also added catalog/thumbnails/images and set them both to 777 an still have the issue where no photos are loading.

 

I think my problem was that I had imagmagic.php in the wrong folder, moved it to catalog/imagemagic.php and its working!

Share this post


Link to post
Share on other sites

New problem, the left right arrows in my popup are not showing and a button or two here or there is missing.

 

How do I fix this?

Share this post


Link to post
Share on other sites
New problem, the left right arrows in my popup are not showing and a button or two here or there is missing.

 

How do I fix this?

 

Wow, answering my own questions this evening! It seems to be that they arent showing up because they are gifs...now to figure out how toget image magic to ignore the gifs and let them show up.

Share this post


Link to post
Share on other sites
Wow, answering my own questions this evening! It seems to be that they arent showing up because they are gifs...now to figure out how toget image magic to ignore the gifs and let them show up.

You could try what I recommended a few posts ago by adding a line to catalog/includes/functions/html_output.php:

if (strstr($src, '.gif')) $calculate = false;

I think this will stop all your gifs being processed.

 

Rich

Share this post


Link to post
Share on other sites

Thanks Rich,

 

I did end up using that code, and finaly got it working.

 

I had hoped there was a way to just have it not process any gifs rather than doing each one individually.

 

I put the code in catalog/includes/functions/html_output.php starting about line 110

 

  //Prevent image magic from processing this file
 if (strstr($src, '1a45.gif')) $calculate = false;

Share this post


Link to post
Share on other sites

For those of you who have problem displaying images with this contribution, here is a tip: look the html code where the image should be generated. It should be something like this:

<img src="imagemagic.php?img=images/dvd/theres_something_about_mary.gif&w=75&h=60&page=" ...

 

Copy the URL that you can see in the src, and paste it in the address bar of your browser, for example

www.mystore.com/catalog/imagemagic.php?img=images/dvd/theres_something_about_mary.gif&w=75&h=60&page=

 

And maybe... you'll see some php errors that tells you why this is not working.

 

Note that the page= followed by nothing is not an error.

 

Just did like this today and found some php warnings in catalog/imagemagic.php, so I placed a new release on the contribution page and I hope it'll help some people out there.

 

 

- Rigadin


STS v4.5 SP5 is out, and check the STS Power Pack contribution too!

New thumbnailer using phpThumb: oscThumb. Works great.

Share this post


Link to post
Share on other sites

I was so happy to make this contribution working that I installed it on another project and got in trouble again. So... I made a new version 1.17 where all the php notes and warnings in imagemagic.php are ignored. It helps.

 

The second modification I made, in the same file, is to include configure.php in the same way as it is in application_top.php, otherwise you can have some problems if you use includes/local/configure.php to set some of the constants but not all. (Check that if you have some errors with DB connection for example).

 

This contribution works great and is easy to install.

 

- Rigadin


STS v4.5 SP5 is out, and check the STS Power Pack contribution too!

New thumbnailer using phpThumb: oscThumb. Works great.

Share this post


Link to post
Share on other sites

....and can it support more than one photo pr. item?

I can upload the images to sub folders of images/whateverfolder - right??

 

Helle *again*

Share this post


Link to post
Share on other sites
I was so happy to make this contribution working that I installed it on another project and got in trouble again. So... I made a new version 1.17 where all the php notes and warnings in imagemagic.php are ignored. It helps.

 

The second modification I made, in the same file, is to include configure.php in the same way as it is in application_top.php, otherwise you can have some problems if you use includes/local/configure.php to set some of the constants but not all. (Check that if you have some errors with DB connection for example).

 

This contribution works great and is easy to install.

 

- Rigadin

 

Please do read the reply that the original builder AND maintainer wrote when he updated this (his) great contribution today! <_<

 

@tomjmul, thanks for this great contribution! :thumbsup:

I've a small question for you, how do I upgrade from version V1.15 tomjmul 17 May 2006?

Just follow the install instructions and run the sql?

 

Thanks again and please do ignore those who do not respect.


Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Share this post


Link to post
Share on other sites
Which version should I download? There are almost too many fixes / updates etc.

 

Helle ???

 

Download the 1.16 version posted on 15 Dec 2006 by the original builder tomjmul.

 

Please ignore the updates or so called fixes posted by others!


Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Share this post


Link to post
Share on other sites
Please do read the reply that the original builder AND maintainer wrote when he updated this (his) great contribution today! <_<

 

@tomjmul, thanks for this great contribution! :thumbsup:

I've a small question for you, how do I upgrade from version V1.15 tomjmul 17 May 2006?

Just follow the install instructions and run the sql?

 

Thanks again and please do ignore those who do not respect.

 

No, just replace the imagemagic.php file - simple eh?

 

And thanks for your support.

 

Tom


OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites
....and can it support more than one photo pr. item?

I can upload the images to sub folders of images/whateverfolder - right??

 

Helle *again*

 

 

Yes, it can work quite well in combination with the mopics contribution to allow for multiple images per product. If my memory serves me correctly, there is one small change needed to mopics, to use the tep_image() function instead of writing the image tags directly.

 

Anyway, I know the complete solution is in this forum somewhere.

 

Tom


OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites
No, just replace the imagemagic.php file - simple eh?

 

And thanks for your support.

 

Tom

 

Thanks! :thumbsup:

 

But I see that your contribution is no longer found among the contributions? :'(


Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Share this post


Link to post
Share on other sites

Norman,

 

Yes, it would appear that they have removed it. :D

 

I guess they didn't like the comments in my update. You know, I'm kind of happy that they have. But the fact that my contribution has a very large user base in the oscommerce community and is helping out thousands of oscommerce store owners obviously means nothing to them.

 

From what I have seen in the past the whole oscommerce community thing is based upon bullyboy tactics. If you are ever bored, check into what they done with the guy who wrote the original paypal payment module.

 

The only reason why oscommerce is popular is because it was one of the first php-based carts out. The code-base itself is a complete mess and it must be one of the least developed open source projects that has such a high user-base.

 

I think the core team would rather fly off to the trade shows and conventions than work on the next version of oscommerce, or even tidy up the mess that is.

 

There are a lot of other contribution developers very unhappy about the contribution system they have in place which allows anyone who feels like it to hack a contribution to pieces and post a new version. No version control, peer review nothing. It is a joke.

 

Anyway, to anyone else who came here looking for image magic, it is no longer available because I dared ask that development and updates be kept as a team effort. It you are pissed off, the webmaster's email address is at the bottom of the page.

 

Tom

Edited by tomjmul

OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites

I will make image magic available for download from my website at www.celtware.com for the near future, until that is I decide what to do with it.

 

It is not to be packaged and re-uploaded to this site.


OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites

I tried this contribution more than 2 months ago and it did not work for me. I looked in this forum but could not find any solution, only other people with problems. I forgot this contribution until few days ago and found the solution. I was not the only one with this problem, so I posted a new version on the osCommerce website.

 

I'm sorry if I have disturbed the community by uploading a new version of this great contribution to the osCommerce website. I posted also the copyrighted install instructions because they were on my HD together with the other files, I apologize to the author for this mistake.

 

The contribution is not anymore on the osCommerce website and this is how it should be if the author does not want any disturbance in his code. I agree with him concerning the osC project in general.

 

Anyway, I propose to the author to look into my small modifications, even he supposed I introduced new bugs,

because even the last "official" version is not working, for me, without these small modifications.

 

- Rigadin


STS v4.5 SP5 is out, and check the STS Power Pack contribution too!

New thumbnailer using phpThumb: oscThumb. Works great.

Share this post


Link to post
Share on other sites

Hey Chris,

 

Don't sweat it, this wasn't you. It was the oscommerce "team", their arrogance and their dictatorial way of running this website. It is ok for them to control how their code is used and community run, but not for anyone else.

 

Now, notwithstanding your apology, which I accept, I do want to make some points.

 

Regards your modifications, I never once said that you introduced new bugs, or even refered to you. What I said was that the general actions of anyone uploading a new version without first checking with the person most experienced with the contribution and still actively working on it (In this case, the author) was no way for a project....any project to remain sustainable.

 

What I have found in the past is that because i/m uses the filesystem on the remote server it is operating on, something which probobly 99.5% of all other contribs do not do, the default configuration does not work for absolutely everyone without a slight tweak here or there. For example, some setups have a trailing slash for the store's root directory in their configure.php whilst the majority don't.

 

Now, I have also experienced in the past, that people will make this tweak, think that because it works for them it works for everyone and then upload a new 'fixed' version. Which of course causes a world of pain for most everyone else and fills up my pm box within a day.

 

Anyway, I propose to the author to look into my small modifications, even he supposed I introduced new bugs, because even the last "official" version is not working, for me, without these small modifications.

 

And what about over 3,000 stores it is working for? Is this not a slight "centre of universe" type mentality?

 

Can you tell me, how I am supposed to keep any sort of version control, introduce any new features into, or support code which I am no longer intimate with, and which people have hacked and reversioned of their own accord? It is impossible. I consider myself to be a programmer, not a hacker. Anything I do, I like to be done right. I think that people who use my contribution have benefited from this attitude.

 

Image magic wasn't going to be just another hack put out and to hell with it, it was going to be improved upon. There are many, many professional (as opposed to amateur oportunistic) e-shops, with a lot of investment in them using image magic, and every day people get in touch with positive feedback.

 

The contribution is not anymore on the osCommerce website and this is how it should be if the author does not want any disturbance in his code. I agree with him concerning the osC project in general.

 

That is a very selfish attitude and I do not agree. If an author spends as much time as I did writing a piece of software and keeping it current, their views as to the on-going management of the project should be taken into consideration. That my friend is the spirit of open source software. If it is your view that the thousands of existing users of image magic and the potential thousands more should be denied access to new versions and updates, just because I asked that my code not be hacked to pieces, then maybe you should reconsider.

 

I don't see the oscommerce code base put up like the contributions are, for anyone to hack and reupload for general release.

 

I think your views might be formed by the fact that your actions precipitated the removal of image magic, but they shouldn't and you should take another look at the issue from an unblinkered perspective.

 

Remember, I gave away this software for nothing - nada. Hours, and hours of my time and experience.

 

In summary: When I wanted to update it, like I did yesterday, am I meant to download your 1.17 (along with everyone alse's 1.165's etc etc, check what has changed, make the alterations to my own code. Test it on multiple setups, THEN integrate my own code and then upload a 1.18.

 

Seriously, what do you think? What does everyone else think?

 

Tom


OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites
Yes, it can work quite well in combination with the mopics contribution to allow for multiple images per product. If my memory serves me correctly, there is one small change needed to mopics, to use the tep_image() function instead of writing the image tags directly.

 

Anyway, I know the complete solution is in this forum somewhere.

 

Tom

 

Hi Tom - Great - I'll download it soon - I'm still "fighting" with SPPC *lol*

Helle :-)

Share this post


Link to post
Share on other sites
Download the 1.16 version posted on 15 Dec 2006 by the original builder tomjmul.

 

Please ignore the updates or so called fixes posted by others!

 

Well - it's gone?

*ev* Helle :-(

Share this post


Link to post
Share on other sites

Yes Helle, it is.

 

If you want to know the precise reasons, then this is the guy to ask hpdl


OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Share this post


Link to post
Share on other sites

I am trying to remove the program from my OScomm software but I'm not sure if I got everything. I tried to download the file to see if I got all the files off the server, but your link to download is broken. So far I have cleeared the html_output.php and general.php files of the image magic settings, i also removed the image magic folder in the catalogs/includes area. is there anything else I have to do? the image magic link is still in my configuration box in the admin CP...does that matter?

Share this post


Link to post
Share on other sites
Well - it's gone?

*ev* Helle :-(

 

If tomjmul will let me I can PM you a link so you can download this 1.16 version from my site. :thumbsup:

And now, it's not modified in any way.

 

:lol:


Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  

×