Jump to content
  • Checkout
  • Login
  • Get in touch

osCommerce

The e-commerce.

Support thread for the Image Magic contribution


tomjmul

Recommended Posts

OK guys,

 

I've been asked a noumerus of times via PM to provide a downloadspot for the download of the latest version of Image Magic (1.16).

Up until today it was still availlible at tomjul's website but as I just discoverred it is not anymore.

As this is not my contribution I'm reluctand to just put it up somewhere as I do not want to intervent with the intentions of tomjul.

I've send him a PM and hope he will reply as soon as he can.

 

All I'm asking you all is to have a little patiënt for now.

 

Regards, Norman

Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Link to comment
Share on other sites

  • Replies 1.3k
  • Created
  • Last Reply

Top Posters In This Topic

Norman, sorry for not replying to your pm's sooner, I have been quite busy.

 

Obviously I do not want to spite all of the users of image magic, just because the osc developers decided to. However, I am reviewing in what licence to distribute image magic under from my own site. As I included no GPL'ed or otherwise code and never officially distributed it under GPL, this is something that requires some thought. Again, the precipitating reason for this is so that I can keep development and version control of my own code.

 

As I've said, I am very busy and it will be after christmas before I finally decide. I would suggest either patience, the guaranteed install option or another thumbnailer in the meantime.

 

Also, you could try asking hpdl why he removed it. He didn't even have the decency to answer me when I asked. But then again, I wasn't overly surprised as this seems the the devs general way of dealing with ANY emails.

 

On a side-note, I have noticed that the install counter on my home page is still rising, so people must be getting it from somewhere :D

 

 

Tom

Edited by tomjmul

OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Link to comment
Share on other sites

Norman, sorry for not replying to your pm's sooner, I have been quite busy.

 

Obviously I do not want to spite all of the users of image magic, just because the osc developers decided to. However, I am reviewing in what licence to distribute image magic under from my own site. As I included no GPL'ed or otherwise code and never officially distributed it under GPL, this is something that requires some thought. Again, the precipitating reason for this is so that I can keep development and version control of my own code.

 

As I've said, I am very busy and it will be after christmas before I finally decide. I would suggest either patience, the guaranteed install option or another thumbnailer in the meantime.

 

Also, you could try asking hpdl why he removed it. He didn't even have the decency to answer me when I asked. But then again, I wasn't overly surprised as this seems the the devs general way of dealing with ANY emails.

 

On a side-note, I have noticed that the install counter on my home page is still rising, so people must be getting it from somewhere :D

Tom

 

Hi Tom,

 

Would it be possible that you could upload one of your "older" version for download on your website?

 

Thnaks in advence,

 

Thomas

Link to comment
Share on other sites

Have been using imagemagic for good 2 years also and recently move to new server. Come here to look for solution for the same problem as the above post. I'm suprised that they removed it from oscommerce site? Why? :'( I just can't believe it.. BTW, if anyone found the solution please post here.

 

EDIT: CHMOD thumbnail and it sub directory to 777 solved my problem but still why did they remove it.. Hope Tom can make it available for new user soon.

 

Thanks.

Edited by adx
Link to comment
Share on other sites

#3: In html_output.php,

- Find the following code:

if (strstr($_SERVER['PHP_SELF'],"product_info.php")) {

- Change it for

if (strstr($_SERVER['PHP_SELF'],"product_info.php") && isset($in_product_info_block) & $in_product_info_block) {

 

Alex

 

 

This did the trick - to get my pictures bigger on the product_info.php page - and no where else!

 

I also put this in the product_info.php page

 

SMALL_IMAGE_WIDTH*1.5, SMALL_IMAGE_HEIGHT*1.5

 

Seems to be ALL fine now

 

Thanks

Link to comment
Share on other sites

This did the trick - to get my pictures bigger on the product_info.php page - and no where else!

 

I also put this in the product_info.php page

 

SMALL_IMAGE_WIDTH*1.5, SMALL_IMAGE_HEIGHT*1.5

 

Seems to be ALL fine now

 

Thanks

 

 

Helle,

 

Did you try changing the product info image width and height in your admin panel? Image magic installs a new image size for the products page.

 

Tom

OSC Image Magic

On-the-fly thumbnails, watermarks and image processing

Link to comment
Share on other sites

Norman, sorry for not replying to your pm's sooner, I have been quite busy.

 

Obviously I do not want to spite all of the users of image magic, just because the osc developers decided to. However, I am reviewing in what licence to distribute image magic under from my own site. As I included no GPL'ed or otherwise code and never officially distributed it under GPL, this is something that requires some thought. Again, the precipitating reason for this is so that I can keep development and version control of my own code.

 

As I've said, I am very busy and it will be after christmas before I finally decide. I would suggest either patience, the guaranteed install option or another thumbnailer in the meantime.

 

Also, you could try asking hpdl why he removed it. He didn't even have the decency to answer me when I asked. But then again, I wasn't overly surprised as this seems the the devs general way of dealing with ANY emails.

 

A man could always ask :-"

But I think I will also be left without an answer as the Dutch osC support site and forum has the "unofficial" status

 

On a side-note, I have noticed that the install counter on my home page is still rising, so people must be getting it from somewhere :D

Tom

 

:-"

 

Seriously, I'm not redistributing it becaus I did not hear from you and no answer means to me that I'm not allowed to.

 

The question still remains that I get great demands from this forum and the Ducth forum for mailing the 1.16 zip I'm still having.

On the other hand, I did install 3 website's in the last 2 day's running your latest version.

Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Link to comment
Share on other sites

Great Contribution. I used it for about 5 months without problems. Now, after installing another contribution (Fancier Invoice & Packing Slip by PopTheTop) my images are all broken.

 

When I paste the image URL into my browser I get the following PhP errors:

Warning: chdir() [function.chdir]: No such file or directory (errno 2) in /home/shena7/public_html/catalog/imagemagic.php on line 21

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 492

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 493

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 494

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 495

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 496

 

Warning: Cannot modify header information - headers already sent by (output started at /home/shena7/public_html/catalog/imagemagic.php:21) in /home/shena7/public_html/catalog/imagemagic.php on line 497

 

Warning: imagecreate() [function.imagecreate]: Invalid image dimensions in /home/shena7/public_html/catalog/imagemagic.php on line 499

 

Warning: imagecolorallocate(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 500

 

Warning: imagecolorallocate(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 501

 

Warning: imagefilledrectangle(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 503

 

Warning: imagestring(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 505

 

Warning: imagestring(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 505

 

Warning: imagejpeg(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 508

 

Warning: imagedestroy(): supplied argument is not a valid Image resource in /home/shena7/public_html/catalog/imagemagic.php on line 509

 

I discovered the file that is causing this problem. I can get Image Magic working again by removing the configure.php file from my catalog/includes/local folder (this file was added for functionality of the Fancier Invoice & Packing Slip contribution).

 

However, removing that file causes the checkout process to fail.

 

Does anyone have any idea why this file would cause problems with ImageMagic, and any possible solutions? Here are the full contents of the configure.php in question:

 

<?php

/*

$Id: configure.php,v 6.1 2005/06/05 00:37:30 PopTheTop Exp $

 

osCommerce, Open Source E-Commerce Solutions

http://www.oscommerce.com

 

Copyright © 2003 osCommerce

 

Released under the GNU General Public License

*/

 

// Folder Definitions

define('DIR_FS_ADMIN', '/home/shena7/public_html/catalog/admin/'); // absolute path required

define('EMAIL_INVOICE_DIR', 'email_invoice/');

define('INVOICE_TEMPLATE_DIR', 'templates/');

 

// Email Invoice File Definitions

define('FILENAME_EMAIL_INVOICE', 'email_invoice.php');

define('FILENAME_EMAIL_CACHE_FILE', 'temp_cache.php');

define('FILENAME_ORDERS_INVOICE', 'invoice.php');

 

?>

 

Thank you! I very much appreciate any help.

Link to comment
Share on other sites

Helle,

 

Did you try changing the product info image width and height in your admin panel? Image magic installs a new image size for the products page.

 

Tom

 

Hi Tom - sorry for the late answer....

 

I tried that, but then the images in the colunm under reviews also were bigger....

 

Helle :-)

Link to comment
Share on other sites

About Fancier Invoice & Packing Slip and the configure.php file needed in the includes/local folder:

 

imagemagic.php is using a different logic than application_top.php to include the configure.php files(s), and that gives the problem. The proper code is:

 

// Set the local configuration parameters - mainly for developers
 if (file_exists('includes/local/configure.php')) include('includes/local/configure.php');

// include server parameters
 require('includes/configure.php');

 

- Rigadin

Link to comment
Share on other sites

About Fancier Invoice & Packing Slip and the configure.php file needed in the includes/local folder:

 

imagemagic.php is using a different logic than application_top.php to include the configure.php files(s), and that gives the problem. The proper code is:

 

// Set the local configuration parameters - mainly for developers
 if (file_exists('includes/local/configure.php')) include('includes/local/configure.php');

// include server parameters
 require('includes/configure.php');

 

- Rigadin

 

Thank you so much Rigadin!! I substituted the code you provided in imagemagic.php and that did the trick.

Link to comment
Share on other sites

Would it be possible to tweak imagemagic.php to only allow images be dynamically made if and only if its being asked by parent server? I tried making a link outside, and it succeeded. Eg:

<img src="http://www.yoursite.com/imagemagic.php?img=images/yourimage123.jpg&w=275&h=275&page=">
<img src="http://www.yoursite.com/imagemagic.php?img=images/yourimage123.jpg&w=123&h=123&page=">
<img src="http://www.yoursite.com/imagemagic.php?img=images/yourimage123.jpg&w=555&h=555&page=">

As you can imagine this would have dramatic impact on storage and especially server load.

Link to comment
Share on other sites

hI:

 

I need to knwo about the tep_image() in the html_output file. I just dont quite understand how much of this file I am to replace with the code given in the instructions.

 

any help would be great.

 

thanks,

shawn

If it was easy, anyone could do it!

Link to comment
Share on other sites

hI:

 

I need to knwo about the tep_image() in the html_output file. I just dont quite understand how much of this file I am to replace with the code given in the instructions.

 

any help would be great.

 

thanks,

shawn

 

 

on a fresh install the code to replace is the section below -

 

////
// The HTML image wrapper function
 function tep_image($src, $alt = '', $width = '', $height = '', $parameters = '') {
if ( (empty($src) || ($src == DIR_WS_IMAGES)) && (IMAGE_REQUIRED == 'false') ) {
  return false;
}

// alt is added to the img tag even if it is null to prevent browsers from outputting
// the image filename as default
$image = '<img src="' . tep_output_string($src) . '" border="0" alt="' . tep_output_string($alt) . '"';

if (tep_not_null($alt)) {
  $image .= ' title=" ' . tep_output_string($alt) . ' "';
}

if ( (CONFIG_CALCULATE_IMAGE_SIZE == 'true') && (empty($width) || empty($height)) ) {
  if ($image_size = @getimagesize($src)) {
	if (empty($width) && tep_not_null($height)) {
	  $ratio = $height / $image_size[1];
	  $width = intval($image_size[0] * $ratio);
	} elseif (tep_not_null($width) && empty($height)) {
	  $ratio = $width / $image_size[0];
	  $height = intval($image_size[1] * $ratio);
	} elseif (empty($width) && empty($height)) {
	  $width = $image_size[0];
	  $height = $image_size[1];
	}
  } elseif (IMAGE_REQUIRED == 'false') {
	return false;
  }
}

if (tep_not_null($width) && tep_not_null($height)) {
  $image .= ' width="' . tep_output_string($width) . '" height="' . tep_output_string($height) . '"';
}

if (tep_not_null($parameters)) $image .= ' ' . $parameters;

$image .= '>';

return $image;
 }

 

 

the current install instructions are not very clear for this bit. Which is a shame because the rest of the install file is very detailed...odd ?

Link to comment
Share on other sites

where can i download the contribution now.. it is not wvailable on www.celtware.com anymore either.. please help.. I want his :)

 

It is not there anymore. If you do a search at Google you will be able to find it in its cache. Please only use tomjuls versions.

 

I have not heard from tomjul and I'm not sure what's going to happen with his contribution.

Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Link to comment
Share on other sites

I haven't used this contrib, so can't comment on how good it is or not - but users seem to like it. However, all contributions listed on this forum have to be available as GPL licenced, that's a cardinal rule of the forums. That appears to be why it was removed.

 

However, just because it can't be in the Contributions section here without being GPL licenced it does not mean that the author cannot make it available elsewhere with a different licencing arrangement.

 

The Netherlands forum is 'independent' because the osCommerce project does not own the .nl domain.

 

Vger

Link to comment
Share on other sites

  • 2 weeks later...
I haven't used this contrib, so can't comment on how good it is or not - but users seem to like it. However, all contributions listed on this forum have to be available as GPL licenced, that's a cardinal rule of the forums. That appears to be why it was removed.

 

Strange that it took the moderators such a long time to came up with that "reason" for removing it.....

 

However, just because it can't be in the Contributions section here without being GPL licenced it does not mean that the author cannot make it available elsewhere with a different licencing arrangement.

 

It looks like this contribution is lost to the osCommerce community as tomjul has disapered, like many other contributors after beeing moderated :(

 

The Netherlands forum is 'independent' because the osCommerce project does not own the .nl domain.

 

Vger

 

Lucky for us ;)

Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Link to comment
Share on other sites

A "simple" question after these clarifications:

I took the code of this contribution when it was available on this site. The code was not GPL, and in fact it had no mention of any kind of copyright. Can I still use it to build new stores?

Link to comment
Share on other sites

A "simple" question after these clarifications:

I took the code of this contribution when it was available on this site. The code was not GPL, and in fact it had no mention of any kind of copyright. Can I still use it to build new stores?

 

I've build my shop when it was still available, I'm "giving" my shop-source (inlcuding Image Magic) to anyone who wants is. I think you can just use it to build your shops. I do not know how long the install-instrcutions well be available on the Internet...

Norman in 't Veldt

 

Moderator

osCommerce The Netherlands

Link to comment
Share on other sites

It helped! thanx alot! :D

 

 

Hi, I had that problem and read through most of the pages in this topic but found nothing to fix it and I don't want to spend hours just reading and not find anything so I decided to do some coding. I found a way do arrange that with some minors modifications.

 

I don't want to make an update to Tom's wonderful contrib so I post my code here to be discussed.

 

#1: In product_info.php,

- Find the following code:

if (tep_not_null($product_info['products_model'])) {

$products_name = $product_info['products_name'] . '<br><span class="smallText">[' . $product_info['products_model'] . ']</span>';

} else {

$products_name = $product_info['products_name'];

}

- Add after:

$in_product_info_block = true;

 

#2: In the same file

- Find the following code:

if ($product_info['products_date_available'] > date('Y-m-d H:i:s')) {

- Add before:

$in_product_info_block = false;

 

#3: In html_output.php,

- Find the following code:

if (strstr($_SERVER['PHP_SELF'],"product_info.php")) {

- Change it for

if (strstr($_SERVER['PHP_SELF'],"product_info.php") && isset($in_product_info_block) & $in_product_info_block) {

 

And that's about it. It was tested for 5 mins but seems to works fine. Should fit for most versions: mine is OSC2MS2.2.

 

I had some problems previously with that contrib related to the php.ini file so I needed to also install the Register Globals contrib.

 

Alex

Link to comment
Share on other sites

  • 2 weeks later...

I installed the 2.6 version of Anti Robot Registration Validation 1.0 + images http://www.oscommerce.com/community/contributions,1237, and got a blank black box , i checked on the database on the antirobot.. table i ca nsee my sessions then i test and i still see a blank balck rectangle .

 

My tep_image function has been changed for image magic , is there anyone that could check and see where i got to make a change , in the code you will see i tried something commented now but that didnt work

 

// BOF Image Magic 
function tep_image($src, $alt = '', $width = '', $height = '', $params = '') {  
 global $product_info;

 //Allow for a new intermediate sized thumbnail size to be set 
 //without any changes having to be made to the product_info page itself. 
 //(see the lengths I go to to make your life easier :-)
 if (strstr($_SERVER['PHP_SELF'],"product_info.php")) {

	if (isset($product_info['products_image']) 
			   && $src == DIR_WS_IMAGES . $product_info['products_image']
			   && $product_info[products_id]==$_GET['products_id'])  {   //final check just to make sure that we don't interfere with other contribs
		$width = PRODUCT_INFO_IMAGE_WIDTH == 0?'':PRODUCT_INFO_IMAGE_WIDTH;
		$height = PRODUCT_INFO_IMAGE_HEIGHT == 0?'':PRODUCT_INFO_IMAGE_HEIGHT;
		$product_info_image=true;
		$page="prod_info"; 
	}
 }

 //Detect whether this is a pop-up image
 if (strstr($_SERVER['PHP_SELF'],"popup_image.php")) $page="popup";

 //do we apply the IE PNG alpha transparency fix?
 if  (strstr(strtolower($src),".png") && CFG_PNG_BUG=="True") $fix_png = true;
 else $fix_png=false; // added by azer

 //send the image for processing unless told otherwise
 $image = '<img src="' . $src . '"'; //set up the image tag just in case we don't want to process
 if (CFG_MASTER_SWITCH=="On") $calculate = true;
 else $calculate=false;

 // Don't calculate if the image is set to a "%" width
 if (strstr($width,'%') == true || strstr($height,'%') == true) $calculate = false; 

 // Dont calculate if a pixel image is being passed (hope you dont have pixels for sale)
 if (strstr($image, 'pixel')) $calculate = false;


 $image_size = @getimagesize($src);


 // Decide whether or not we want to process this image
 if (($width == '' && $height == '' && $page != 'popup' ) || ($width == $image_size[0] && $height == $image_size[0] && $page != 'popup')) {  
	if (CFG_PROCESS_GRAPHICS=="False") $calculate = false; //looks like this is a store graphic rather than product image
 }	

 // Is this image good to go?
  if ( CONFIG_CALCULATE_IMAGE_SIZE && $calculate) { 
 // tested for antirobot doesnt work 
 // if ((substr($src,0,24)!='validation_png.php?rsid=') && CONFIG_CALCULATE_IMAGE_SIZE && $calculate) { 



 if ($image_size) { 

  $ratio = $image_size[1] / $image_size[0];

  // Set the width and height to the proper ratio
  if (!$width && $height) { 
	$ratio = $height / $image_size[1]; 
	$width = intval($image_size[0] * $ratio); 
  } elseif ($width && !$height) { 
	$ratio = $width / $image_size[0]; 
	$height = intval($image_size[1] * $ratio); 
  } elseif (!$width && !$height && !$over_ride) { 
	$width = $image_size[0]; 
	$height = $image_size[1]; 
  } 

  //Encrypt the image filename if switched on
	if (CFG_ENCRYPT_FILENAMES == "True" && CFG_ENCRYPTION_KEY !="") {
		  $result = '';
		  $key=CFG_ENCRYPTION_KEY;
		  for($i=0; $i<strlen($src); $i++) {
			  $char = substr($src, $i, 1);
			  $keychar = substr($key, ($i % strlen($key))-1, 1);
			  $char = chr(ord($char)+ord($keychar));
			  $result.=$char;
		  }
		  $src=urlencode(base64_encode($result));
	}

   //Return the html
	$image = '<img src="imagemagic.php?img='.$src.'&w='.
	tep_output_string($width).'&h='.tep_output_string($height).'&page='.$page.'"';

} elseif (IMAGE_REQUIRED == 'false') { 
  return false; 
} 
 }  

//If the size asked for is greater than the image itself, we check the configs to see if this is allowed and if not over-ride
 if ($width > $image_size[0] || $height > $image_size[1]) {
	if (CFG_ALLOW_LARGER  != 'True'){
		  $width=$image_size[0];
		  $height=$image_size[1];
		  $over_ride = true;
	}
 }
 // Add remaining image parameters if they exist
 if ($width) { 
$image .= ' width="' . tep_output_string($width) . '"'; 
 } 

 if ($height) { 
$image .= ' height="' . tep_output_string($height) . '"'; 
 }	 

 if (tep_not_null($params)) $image .= ' ' . $params;

 $image .= ' border="0" alt="' . tep_output_string($alt) . '"';

 if (tep_not_null($alt)) {
$image .= ' title="' . tep_output_string($alt) . '"';
 }

 if ($fix_png && CFG_MASTER_SWITCH=="On") {
	$image .= ' onload="fixPNG(this)"'; 
 }

 $image .= '>';   
 return $image; 
}
//EOF Image Magic

MS2

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...