PVK Posted July 14, 2004 Share Posted July 14, 2004 I have installed the Must agree to terms 2.2MS2v1.4 contribution but something seems not to be correct. When i click the checkbox or when i click the link which displays the conditions of use i get an irritating yellow triangle in the lower lefthandside of my browser pointing me to the fact that i have an error on the page on line [i translated it since my browser is dutch] Line 308 Symbol 1 Error Object expected Code 0 URL https://www.myshop.com/shop/checkout_confirmation.php en when i click previous it displays Line 310 Symbol 1 Error Object expected Code 0 URL https://www.myshop.com/shop/checkout_confirmation.php The contribution works as expected including popup etc, so as far as i know i have done everything correct as indicated in the contributions manual, but maybe i made a mistake somewhere causing the contribution to work but at the same time displaying this annoying error in the browser?? Could someone check my original checkout confirmation.php code below? The code of my page: <?php /* $Id: checkout_confirmation.php,v 1.139 2003/06/11 17:34:53 hpdl Exp $ osCommerce, Open Source E-Commerce Solutions http://www.oscommerce.com Copyright ? 2003 osCommerce Released under the GNU General Public License */ require('includes/application_top.php'); // if the customer is not logged on, redirect them to the login page if (!tep_session_is_registered('customer_id')) { $navigation->set_snapshot(array('mode' => 'SSL', 'page' => FILENAME_CHECKOUT_PAYMENT)); tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL')); } // if there is nothing in the customers cart, redirect them to the shopping cart page if ($cart->count_contents() < 1) { tep_redirect(tep_href_link(FILENAME_SHOPPING_CART)); } // avoid hack attempts during the checkout procedure by checking the internal cartID if (isset($cart->cartID) && tep_session_is_registered('cartID')) { if ($cart->cartID != $cartID) { tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')); } } // if no shipping method has been selected, redirect the customer to the shipping method selection page if (!tep_session_is_registered('shipping')) { tep_redirect(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL')); } if (!tep_session_is_registered('payment')) tep_session_register('payment'); if (isset($HTTP_POST_VARS['payment'])) $payment = $HTTP_POST_VARS['payment']; if (!tep_session_is_registered('comments')) tep_session_register('comments'); if (tep_not_null($HTTP_POST_VARS['comments'])) { $comments = tep_db_prepare_input($HTTP_POST_VARS['comments']); } // load the selected payment module require(DIR_WS_CLASSES . 'payment.php'); $payment_modules = new payment($payment); require(DIR_WS_CLASSES . 'order.php'); $order = new order; $payment_modules->update_status(); if ( ( is_array($payment_modules->modules) && (sizeof($payment_modules->modules) > 1) && !is_object($$payment) ) || (is_object($$payment) && ($$payment->enabled == false)) ) { tep_redirect(tep_href_link(FILENAME_CHECKOUT_PAYMENT, 'error_message=' . urlencode(ERROR_NO_PAYMENT_MODULE_SELECTED), 'SSL')); } if (is_array($payment_modules->modules)) { $payment_modules->pre_confirmation_check(); } // load the selected shipping module require(DIR_WS_CLASSES . 'shipping.php'); $shipping_modules = new shipping($shipping); require(DIR_WS_CLASSES . 'order_total.php'); $order_total_modules = new order_total; // Stock Check $any_out_of_stock = false; if (STOCK_CHECK == 'true') { for ($i=0, $n=sizeof($order->products); $i<$n; $i++) { if (tep_check_stock($order->products[$i]['id'], $order->products[$i]['qty'])) { $any_out_of_stock = true; } } // Out of Stock if ( (STOCK_ALLOW_CHECKOUT != 'true') && ($any_out_of_stock == true) ) { tep_redirect(tep_href_link(FILENAME_SHOPPING_CART)); } } require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_CHECKOUT_CONFIRMATION); $breadcrumb->add(NAvb script:void(0);" onclick="NewWindow('popup_conditions.php','tech','800','600','yes');return false"><u style="main"><?php echo CONDITIONS; ?></u></a> </td> </tr> </table></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <tr> <td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox"> <tr class="infoBoxContents"> <td align="right"><?php echo tep_image_submit('button_confirm_order.gif', IMAGE_BUTTON_CONFIRM_ORDER); ?></td> </tr> </table></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> </form></table></td> </tr> <tr> <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td> </tr> <tr> <td><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td width="50%" align="right"><?php echo tep_draw_separator('pixel_silver.gif', '1', '5'); ?></td> <td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td> </tr> </table></td> <td width="25%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td> <td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td> <td><?php echo tep_image(DIR_WS_IMAGES . 'checkout_bullet.gif'); ?></td> <td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td> </tr> </table></td> <td width="25%"><table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '100%', '1'); ?></td> <td width="50%"><?php echo tep_draw_separator('pixel_silver.gif', '1', '5'); ?></td> </tr> </table></td> </tr> <tr> <td align="center" width="25%" class="checkoutBarFrom"><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL') . '" class="checkoutBarFrom">' . CHECKOUT_BAR_DELIVERY . '</a>'; ?></td> <td align="center" width="25%" class="checkoutBarFrom"><?php echo '<a href="' . tep_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL') . '" class="checkoutBarFrom">' . CHECKOUT_BAR_PAYMENT . '</a>'; ?></td> <td align="center" width="25%" class="checkoutBarCurrent"><?php echo CHECKOUT_BAR_CONFIRMATION; ?></td> <td align="center" width="25%" class="checkoutBarTo"><?php echo CHECKOUT_BAR_FINISHED; ?></td> </tr> </table></td> </tr> </table></td> <!-- body_text_eof //--> <td width="<?php echo BOX_WIDTH; ?>" valign="top"><table border="0" width="<?php echo BOX_WIDTH; ?>" cellspacing="0" cellpadding="2"> <!-- right_navigation //--> <?php require(DIR_WS_INCLUDES . 'column_right.php'); ?> <!-- right_navigation_eof //--> </table></td> </tr> </table> <!-- body_eof //--> <!-- footer //--> <?php require(DIR_WS_INCLUDES . 'footer.php'); ?> <!-- footer_eof //--> <br> </body> </html> <?php require(DIR_WS_INCLUDES . 'application_bottom.php'); ?> Quote Link to comment Share on other sites More sharing options...
PVK Posted July 14, 2004 Author Share Posted July 14, 2004 Come on guys, this really shouldn't be so hard to solve for you php cracks out there. Please help Quote Link to comment Share on other sites More sharing options...
PVK Posted July 16, 2004 Author Share Posted July 16, 2004 hmm, it seems that nobody is able to solve this seemingly huge problem :( maybe time to deinstall it then... Quote Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted July 17, 2004 Share Posted July 17, 2004 (edited) The line being referred to is in the output in the browser. Can you redo this, and save the resulting html page and post it here as code. Then we can look at the offending lines, make sure to take note of which lines as they might be different based on what you put in the shopping cart. Edited July 17, 2004 by bruyndoncx Quote KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
PVK Posted July 17, 2004 Author Share Posted July 17, 2004 hello carine, i have sent you a pm ;) Quote Link to comment Share on other sites More sharing options...
The_ancient Posted July 17, 2004 Share Posted July 17, 2004 I had the same problem I went and used the ORGINAL contribution with no Errors... Quote Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted July 17, 2004 Share Posted July 17, 2004 When I remove the checkbox('agree') sections in the html, I no longer get the error and everything seems to work, so Change <tr class="infoBoxContents" onclick="checkbox('agree')"> <td class="main" align="right"><b><?php echo CONDITION_AGREEMENT; ?></b> <?php echo tep_draw_checkbox_field('agree','true', false, 'onclick="checkbox(\'agree\')"'); ?><br> To <tr class="infoBoxContents"> <td class="main" align="right"><b><?php echo CONDITION_AGREEMENT; ?></b> <?php echo tep_draw_checkbox_field('agree','true', false)"'); ?><br> Tested this in IE, now the question is if this piece of code was perhaps needed for other browsers ? Quote KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
PVK Posted July 17, 2004 Author Share Posted July 17, 2004 (edited) Thanks once again carine, it becomes a habit of you solving my problems :lol: So proper respect and thanks to you! However, when i did as you suggested i got some weird errors . When i changed a small bit in your solution everything seemed to work correctly. As you know i am not a program crack, could you take a look at my code and seen if it makes sense [as i wouldn't know if it wasn't] i always use the trial and error methode :rolleyes: Your suggestion [gives me a little error]: <tr class="infoBoxContents"> <td class="main" align="right"><b><?php echo CONDITION_AGREEMENT; ?></b> <?php echo tep_draw_checkbox_field('agree','true', false)"'); ?><br> My solution: <td class="main" align="right"><b><?php echo CONDITION_AGREEMENT; ?></b> <?php echo tep_draw_checkbox_field('agree','true'); ?><br> Is this a correct piece of code [it works as i expected to, but just to make sure i didn't do anything stupid] Edited July 17, 2004 by PVK Quote Link to comment Share on other sites More sharing options...
♥bruyndoncx Posted July 17, 2004 Share Posted July 17, 2004 yes, you are correct. That's the edit to make ... I had a few less ") in the html output that I edited :D to simulate the php solution anyhow, seems you are all set now. Have a good productive weekend ! Quote KEEP CALM AND CARRY ON I do not use the responsive bootstrap version since i coded my responsive version earlier, but i have bought every 28d of code package to support burts effort and keep this forum alive (albeit more like on life support). So if you are still here ? What are you waiting for ?! Find the most frequent unique errors to fix: grep "PHP" php_error_log.txt | sed "s/^.* PHP/PHP/g" |grep "line" |sort | uniq -c | sort -r > counterrors.txt Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.