Multi_Vendor_Shipping new thread

[trelyuw 0]

I don't see any way around presenting separate shipments to the customer, else they won't be able to select their shipping preference for those shipments that offer them an option. It's probably also advisable to show them which items are in which shipment.

[webwork 1]

Hi,

In the my oscommerce installation, v2.3.4.1 CE, there are  only four shipping modules, flat, table, per item and zone rates in includes/modules/. After I installed this addon and enable the vendor shipping with upsxml, I cannot see upsxml shipping with checkout. Do I miss some in installation? 

Thank you for your help in advance！

[cigarsforless 34]

Has anyone gotten MVS_BSv1.4.3 working on 2.3.4.1 BS Frozen? (as of 18/05/2018)
Can't for the life of me get it to give rates and here are the errors I am getting

Notice: Undefined variable: order_id in /includes/classes/order.php on line 287

Warning: reset() expects parameter 1 to be array, null given in /includes/classes/vendor_shipping.php on line 51

Notice: Undefined variable: vendors_id in /checkout_shipping.php on line 223

 

for what it is worth I have installed just flat rate and table shipping modules at this point

Edited March 1 by cigarsforless

[cigarsforless 34]

in regards to my post above, please see here

pulling my hair out trying to get MVS_BSv1.4.3 to work on 2.3.4.1 BS Frozen (THE "official" stable BS release)

[cigarsforless 34]

as Burt says

"Be aware that EDGE is basically my playground. 
It is subject to changes in all files and there is zero support for it.

If, as a shopowner, you want stable:  Go Frozen.
If, as a shopowner, you have a good developer or you are technically minded:  Go Edge."

 

SO... is there a working version of MVS for BS Frozen? or am I just an idiot who can no longer code?

[burt 3,736]

Warning: reset() expects parameter 1 to be array, null given in /includes/classes/vendor_shipping.php on line 51

Find L51 and cast the object to an array.  

reset( $whatever );

to

reset( (array)$whatever );

That is a MASK for that problem, not a fix.  That Mask may introduce other problems.

 

[cigarsforless 34]

@burt

thanks for the suggestion but now error is
Fatal error: Only variables can be passed by reference in /home/xxx/xx.xxx.com/includes/classes/vendor_shipping.php on line 51

[cigarsforless 34]

seems that for some reason the code is not detecting any of the installed vendor shipping modules and as a result returning an empty array

 

// Find all of the modules and instantiate the module classes
    public function __construct($module = '') {
      global $language, $PHP_SELF;

      $installed_modules_array = array();
			//Get the vendors_id for each vendor in the database
      $vendors_data_query = tep_db_query("select vendors_id from " . TABLE_VENDORS);
      while ($vendors_data = tep_db_fetch_array($vendors_data_query)) {
        $vendors_id = $vendors_data['vendors_id'];
        $installed_modules = @constant('MODULE_VENDOR_SHIPPING_INSTALLED_' . $vendors_id);

        if (isset ($installed_modules) && tep_not_null ($installed_modules)) {
          $modules_array = explode(';', $installed_modules);
          $this->modules[$vendors_id] = $modules_array;

          foreach ($modules_array as $module_name) {
            //if the module is not already in the array, add it in
            if (!in_array ($module_name, $installed_modules_array)) {
              $installed_modules_array[] = $module_name;
            }//if !in_array
          }//foreach
        }//if isset
      }//while

      $include_modules = array();
      if ( (is_string($module) && (tep_not_null($module)) && (in_array(substr($module['id'], 0, strpos($module['id'], '_')) . '.' . substr($PHP_SELF, (strrpos($PHP_SELF, '.')+1)), $modules_array))) ) {
          $include_modules[] = array('class' => substr($module['id'], 0, strpos($module['id'], '_')), 
                                     'file' => substr($module['id'], 0, strpos($module['id'], '_')) . '.' . substr($PHP_SELF, (strrpos($PHP_SELF, '.')+1)));

// X 2-20-10 ADDED PRINTOUT CODE
	  } else {
//  LINE 51 BELOW THAT IS THROWING THE ERROR
          reset($modules_array); 
	      foreach ($installed_modules_array as $value) {
	          $class = substr($value, 0, strrpos($value, '.'));
	          $include_modules[] = array('class' => $class, 
                                         'file' => $value);
	      } //foreach
	  } //if tep_not_null

as well, not a single shipping quote is being returned?
MVS_BSv1.4.3  on stock 2.3.4.1 BS Frozen

[♥JcMagpie 1,369]

First simple check would be your database config table to see if modules are indeed still in the config table. It could just be that the tabe has got messed up.

In admin run check tables an if needed run repair tables.

If still not seeing add-ons then uninstall them and try reinstalling.

 

[cigarsforless 34]

tables are good, config values are in vendor_configuration table correctly, uninstalling reinstalling shipping modules does nothing

I see $vendors_id='1' at the end of every function in the add on like below

//Find the cheapest shipping method for a specific vendor
    function cheapest($vendors_id='1') {
      if (is_array($this->modules[$vendors_id])) {
        $rates = array();

but I have no vendor with id 1

 

checkout shipping page throws out these errors at the top of the page

Notice: Undefined variable: order_id in /home/cigars/test.xxx.com/includes/classes/order.php on line 287

Warning: reset() expects parameter 1 to be array, null given in /home/cigars/test.xxx.com/includes/classes/vendor_shipping.php on line 52

Notice: Undefined variable: vendors_id in /home/cigars/test.xxx.com/checkout_shipping.php on line 223

 

what am I missing?

[cigarsforless 34]

turn off vendors shipping and it give the flat rate result, but still shows the 1st error above about Undefined variable: order_id

turn on vendors shipping and same result, no rates, just errors

for what it is worth, as this is a new install, orders_shipping table is empty

[cigarsforless 34]

hmmmmmm

 

where the quotes "should" be displayed I get these errors

Shipping Method

Notice: Undefined offset: 13 in /home/cigars/test.xxx.com/includes/classes/shopping_cart.php on line 377

Notice: Undefined index: weight in /home/cigars/test.xxx.com/includes/classes/shopping_cart.php on line 377

Notice: Undefined index: cost in /home/cigars/test.xxx.com/includes/classes/shopping_cart.php on line 378

Notice: Undefined index: qty in /home/cigars/test.xxx.com/includes/classes/shopping_cart.php on line 379

Notice: Undefined index: ship_cost in /home/cigars/test.xxx.com/includes/classes/shopping_cart.php on line 381

 

code referred to is

          // Add values to the output array
          $this->vendor_shipping[$vendors_id]['weight'] += ($quantity * $products_weight);
          $this->vendor_shipping[$vendors_id]['cost'] += tep_add_tax($products_price, $products_tax) * $quantity;
          $this->vendor_shipping[$vendors_id]['qty'] += $quantity;
// mod IndvShip
          $this->vendor_shipping[$vendors_id]['ship_cost'] += ($quantity * $products_ship_price);
          $this->vendor_shipping[$vendors_id]['products_id'][] = $products_id; //There can be more than one product
          $this->vendor_shipping[$vendors_id]['products_qty'][$products_id] = $quantity; // displays the number of each product being bought

1st error is referring to "Undefined offset: 13" but 13 is the $vendors_id value
perhaps I am wrong but all the issues seem to somehow come from the $vendors_id variable not being recognized correctly

getting close to pulling my hair out, time for a break and fresh eyes later.

for what it is worth, installed a fresh version of frozen, used a file compare program to find all changes in that and the MVS_BSv1.4.3 addon, installed limited shipping options and have never managed to get it to work as of yet

[♥kymation 629]

2 hours ago, cigarsforless said:

but I have no vendor with id 1

You must have a vendor with id=1. Fix that and try again

Regards

Jim

[cigarsforless 34]

thanks, will try that and let you know

[cigarsforless 34]

sigh, no change after running sql to add vendor 1 to vendors table

[♥kymation 629]

Did you patch the filed or just upload the new files from the MVS distro? There may be file version differences between the MVS base and the Frozen version.

Regards

Jim

[cigarsforless 34]

patched the frozen version

uploaded the new files, and did a file by file compare on files to be changed.

did see some changes in frozen vs mvs distro but they relate to php 7.2 compatibilities such as  

          reset($products[$i]['attributes']);
          while (list($option, $value) = each($products[$i]['attributes'])) {

changes to

foreach($products[$i]['attributes'] as $option => $value) {

but I am running php 7.1 and sql 5.7

Edited March 3 by cigarsforless

[cigarsforless 34]

Doh! turns out there was an edit in application_top.php that I missed somehow.
now works like a charm on frozen

[♥kymation 629]

Glad to hear you found the problem. I've been having computer problems and couldn't look at the files until now. You saved me another dive into that code.

Regards

Jim